chamilo / chamilo-lms

main/inc/lib/search/tool_processors/quiz_processor.class.php

Braces +2 added lines, -1 removed lines

@@ -81,7 +81,8 @@
                         );
                         if ($course_visible_for_user) {
                             $results[] = $result;
-                        } else { // course not visible for user
+                        } else {
+// course not visible for user
                             if ($search_show_unlinked_results) {
                                 $result['url'] = '';
                                 $results[] = $result;

Upper-Lower-Casing +2 added lines, -2 removed lines

@@ -26,7 +26,7 @@ 
             switch ($row_val['xapian_data'][SE_DATA]['type']) {
                 case SE_DOCTYPE_EXERCISE_EXERCISE:
                     $exercise_id = $se_data['exercise_id'];
-                    $question = NULL;
+                    $question = null;
                     $item = array(
                         'courseid' => $courseid,
                         'question' => $question,
@@ -60,7 +60,7 @@ 
         $results = array();
         foreach ($this->exercises as $courseid => $exercises) {
             $search_show_unlinked_results = (api_get_setting('search_show_unlinked_results') == 'true');
-            $course_visible_for_user = api_is_course_visible_for_user(NULL, $courseid);
+            $course_visible_for_user = api_is_course_visible_for_user(null, $courseid);
             // can view course?
             if ($course_visible_for_user || $search_show_unlinked_results) {
                 foreach ($exercises as $exercise_id => $exercise) {

main/inc/lib/search/tool_processors/document_processor.class.php

Braces +2 added lines, -1 removed lines

@@ -42,7 +42,8 @@
                     );
                     if ($course_visible_for_user) {
                         $results[] = $result;
-                    } else { // course not visible for user
+                    } else {
+// course not visible for user
                         if ($search_show_unlinked_results) {
                             $result['url'] = '';
                             $results[] = $result;

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -24,7 +24,7 @@
         $results = array();
         foreach ($this->rows as $row_val) {
             $search_show_unlinked_results = (api_get_setting('search_show_unlinked_results') == 'true');
-            $course_visible_for_user = api_is_course_visible_for_user(NULL, $row_val['courseid']);
+            $course_visible_for_user = api_is_course_visible_for_user(null, $row_val['courseid']);
             // can view course?
             if ($course_visible_for_user || $search_show_unlinked_results) {
                 // is visible?

main/inc/lib/search/tool_processors/learnpath_processor.class.php

Upper-Lower-Casing +2 added lines, -2 removed lines

@@ -108,7 +108,7 @@ 
             $lp_id = intval($lp_id);
 
             if ($has_document_id) {
-                $sql = "SELECT $lpi_table.id, $lp_table.name, $lp_table.author, $doc_table.path
+                $sql = "select $lpi_table.id, $lp_table.name, $lp_table.author, $doc_table.path
                     FROM       $lp_table, $lpi_table
                     INNER JOIN $doc_table ON $lpi_table.path = $doc_table.id  AND $lpi_table.c_id = $course_id
                     WHERE       $lpi_table.c_id = $course_id AND 
@@ -118,7 +118,7 @@ 
                                 $lp_table.id = $lpi_table.lp_id
                     LIMIT 1";
             } else {
-                $sql = "SELECT $lpi_table.id, $lp_table.name, $lp_table.author
+                $sql = "select $lpi_table.id, $lp_table.name, $lp_table.author
                     FROM       $lp_table, $lpi_table
                     WHERE      
                                 $lpi_table.c_id = $course_id AND 

Braces +2 added lines, -1 removed lines

@@ -81,7 +81,8 @@
                         );
                         if ($course_visible_for_user) {
                             $results[] = $result;
-                        } else { // course not visible for user
+                        } else {
+// course not visible for user
                             if ($search_show_unlinked_results) {
                                 $result['url'] = '';
                                 $results[] = $result;

main/inc/lib/text.lib.php

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -681,7 +681,7 @@
     $lastweek = sprintf("%02d", $lastweek);
     $arrdays = array();
     for ($i = 1; $i <= 7; $i++) {
-        $arrdays[] = strtotime("$year"."W$lastweek"."$i");
+        $arrdays[] = strtotime("$year"."w$lastweek"."$i");
     }
     return $arrdays;
 }

Doc Comments +9 added lines, -4 removed lines

@@ -54,6 +54,7 @@ 
  * Converts the text of a html-document to a given encoding, the meta-tag is changed accordingly.
  * @param string $string                The input full-html document.
  * @param string                        The new encoding value to be set.
+ * @param string $encoding
  */
 function api_set_encoding_html(&$string, $encoding)
 {
@@ -463,7 +464,7 @@ 
  * @since wordpress  2.8.1
  * @access private
  *
- * @param string|array $search The value being searched for, otherwise known as the needle. An array may be used to designate multiple needles.
+ * @param string[] $search The value being searched for, otherwise known as the needle. An array may be used to designate multiple needles.
  * @param string $subject The string being searched and replaced on, otherwise known as the haystack.
  * @return string The string with the replaced svalues.
  */
@@ -660,6 +661,7 @@ 
  * @param string    The text to "cut"
  * @param int       Count of chars
  * @param bool      Whether to embed in a <span title="...">...</span>
+ * @param integer $maxchar
  * @return string
  * */
 function cut($text, $maxchar, $embed = false)
@@ -678,7 +680,7 @@ 
  *
  * @param mixed     Number to convert
  * @param int       Decimal points 0=never, 1=if needed, 2=always
- * @return mixed    An integer or a float depends on the parameter
+ * @return string|null    An integer or a float depends on the parameter
  */
 function float_format($number, $flag = 1)
 {
@@ -723,7 +725,7 @@ 
 /**
  * Gets the week from a day
  * @param   string   Date in UTC (2010-01-01 12:12:12)
- * @return  int      Returns an integer with the week number of the year
+ * @return  string      Returns an integer with the week number of the year
  */
 function get_week_from_day($date)
 {
@@ -770,6 +772,9 @@ 
     return $output.$end;
 }
 
+/**
+ * @param string $glue
+ */
 function implode_with_key($glue, $array)
 {
     if (!empty($array)) {
@@ -849,7 +854,7 @@ 
 /**
  * @param string $string
  * @param bool $capitalizeFirstCharacter
- * @return mixed
+ * @return string
  */
 function underScoreToCamelCase($string, $capitalizeFirstCharacter = true)
 {

Braces +17 added lines, -7 removed lines

@@ -418,8 +418,9 @@ 
      * link starting with /, # or ? or a php file).
      */
     if (strpos($url, ':') === false && !in_array($url[0], array('/', '#', '?')) &&
-        !preg_match('/^[a-z0-9-]+?\.php/i', $url))
-        $url = 'http://'.$url;
+        !preg_match('/^[a-z0-9-]+?\.php/i', $url)) {
+            $url = 'http://'.$url;
+    }
 
     return Security::remove_XSS($url);
 
@@ -558,7 +559,8 @@ 
         // Long strings might contain expensive edge cases ...
         if (10000 < strlen($piece)) {
             // ... break it up
-            foreach (_split_str_by_whitespace($piece, 2100) as $chunk) { // 2100: Extra room for scheme and leading and trailing paretheses
+            foreach (_split_str_by_whitespace($piece, 2100) as $chunk) {
+// 2100: Extra room for scheme and leading and trailing paretheses
                 if (2101 < strlen($chunk)) {
                     $r .= $chunk; // Too big, no whitespace: bail.
                 } else {
@@ -814,13 +816,21 @@ 
     if (isset($array['Y']) && (isset($array['F']) || isset($array['M'])) && isset($array['d']) && isset($array['H']) && isset($array['i'])) {
         $year = $array['Y'];
         $month = isset($array['F']) ? $array['F'] : $array['M'];
-        if (intval($month) < 10) $month = '0'.$month;
+        if (intval($month) < 10) {
+            $month = '0'.$month;
+        }
         $day = $array['d'];
-        if (intval($day) < 10) $day = '0'.$day;
+        if (intval($day) < 10) {
+            $day = '0'.$day;
+        }
         $hours = $array['H'];
-        if (intval($hours) < 10) $hours = '0'.$hours;
+        if (intval($hours) < 10) {
+            $hours = '0'.$hours;
+        }
         $minutes = $array['i'];
-        if (intval($minutes) < 10) $minutes = '0'.$minutes;
+        if (intval($minutes) < 10) {
+            $minutes = '0'.$minutes;
+        }
     }
     if (checkdate($month, $day, $year)) {
         $datetime = $year.'-'.$month.'-'.$day.' '.$hours.':'.$minutes.':'.$seconds;

main/inc/lib/social.lib.php

Upper-Lower-Casing +2 added lines, -2 removed lines

@@ -454,7 +454,7 @@ 
         }
 
         $tbl_message = Database::get_main_table(TABLE_MESSAGE);
-        $sql = "UPDATE $tbl_message
+        $sql = "update $tbl_message
                 SET msg_status = ".MESSAGE_STATUS_INVITATION_ACCEPTED."
                 WHERE
                     user_sender_id = ".((int) $user_send_id)." AND
@@ -1779,7 +1779,7 @@ 
         $id = intval($id);
         $tblMessage = Database::get_main_table(TABLE_MESSAGE);
         $statusMessage = MESSAGE_STATUS_WALL_DELETE;
-        $sql = "UPDATE $tblMessage SET msg_status = '$statusMessage' WHERE id = '{$id}' ";
+        $sql = "update $tblMessage SET msg_status = '$statusMessage' WHERE id = '{$id}' ";
 
         return Database::query($sql);
     }

Indentation +5 added lines, -5 removed lines

@@ -1555,7 +1555,7 @@ 
             $media .= '<div class="col-md-2 col-xs-2 social-post-answers">';
             $media .= '<div class="user-image pull-right">';
             $media .= '<a href="'.$url.'" ><img src="'.$users[$userIdLoop]['avatar'].
-                       '" alt="'.$users[$userIdLoop]['complete_name'].'" class="avatar-thumb"></a>';
+                        '" alt="'.$users[$userIdLoop]['complete_name'].'" class="avatar-thumb"></a>';
             $media .= '</div>';
             $media .= '</div>';
             $media .= '<div class="col-md-9 col-xs-9 social-post-answers">';
@@ -1770,10 +1770,10 @@ 
     }
 
     /**
-    * Delete messages delete logic
-    * @param int $id id message to delete.
-    * @return bool status query
-    */
+     * Delete messages delete logic
+     * @param int $id id message to delete.
+     * @return bool status query
+     */
     public static function deleteMessage($id)
     {
         $id = intval($id);

Doc Comments +13 added lines, -5 removed lines

@@ -66,6 +66,7 @@ 
      * @param int user id
      * @param int user friend id
      * @param string
+     * @param integer $user_friend
      * @return int
      * @author isaac flores paz
      */
@@ -129,6 +130,8 @@ 
      * @param int group id
      * @param string name to search
      * @param bool true will load firstname, lastname, and image name
+     * @param integer $user_id
+     * @param integer $id_group
      * @return array
      * @author Julio Montoya <gugli100@gmail.com> Cleaning code, function renamed, $load_extra_info option added
      * @author isaac flores paz
@@ -210,6 +213,9 @@ 
      * @param int user friend id
      * @param string title of the message
      * @param string content of the message
+     * @param integer $user_id
+     * @param string $message_title
+     * @param string $message_content
      * @return boolean
      * @author isaac flores paz
      * @author Julio Montoya <gugli100@gmail.com> Cleaning code
@@ -287,6 +293,7 @@ 
      * Get number messages of the inbox
      * @author isaac flores paz
      * @param int user receiver id
+     * @param integer $user_receiver_id
      * @return int
      */
     public static function get_message_number_invitation_by_user_id($user_receiver_id)
@@ -477,6 +484,7 @@ 
      * Denies invitation
      * @param int user sender id
      * @param int user receiver id
+     * @param integer $user_receiver_id
      * @return bool
      *
      * @author isaac flores paz
@@ -579,7 +587,7 @@ 
      * @param string $subject
      * @param string $content
      *
-     * @return string message invitation
+     * @return false|null message invitation
      */
     public static function sendInvitationToUser($userId, $subject = '', $content = '')
     {
@@ -1379,7 +1387,7 @@ 
      * @param string $messageContent of the message
      * @param int $messageId id parent
      * @param string $messageStatus status type of message
-     * @return boolean
+     * @return false|string
      * @author Yannick Warnier
      */
     public static function sendWallMessage(
@@ -1480,7 +1488,7 @@ 
      * Gets all messages from someone's wall (within specific limits)
      * @param int $userId id of wall shown
      * @param string $messageStatus status wall message
-     * @param int|string $parentId id message (Post main)
+     * @param integer|null $parentId id message (Post main)
      * @param string $start Date from which we want to show the messages, in UTC time
      * @param int $limit Limit for the number of parent messages we want to show
      * @param int $offset Wall message query offset
@@ -1796,7 +1804,7 @@ 
 
     /**
      * verify if Url Exist - Using Curl
-     * @param $uri url
+     * @param string $uri url
      *
      * @return boolean
      */
@@ -1822,7 +1830,7 @@ 
     /**
     * Delete messages delete logic
     * @param int $id id message to delete.
-    * @return bool status query
+    * @return Statement status query
     */
     public static function deleteMessage($id)
     {

main/inc/lib/usergroup.lib.php

Braces +3 added lines, -2 removed lines

@@ -1947,8 +1947,9 @@
                 $new_relation_type[] = "'$rel'";
             }
             $relation_type = implode(',', $new_relation_type);
-            if (!empty($relation_type))
-                $where_relation_condition = "AND gu.relation_type IN ($relation_type) ";
+            if (!empty($relation_type)) {
+                            $where_relation_condition = "AND gu.relation_type IN ($relation_type) ";
+            }
         }
 
         $sql = "SELECT picture_uri as image, u.id, CONCAT (u.firstname,' ', u.lastname) as fullname, relation_type

Upper-Lower-Casing +6 added lines, -6 removed lines

@@ -1760,7 +1760,7 @@ 
         $group_id = intval($group_id);
         $user_id = intval($user_id);
 
-        $sql = "UPDATE $table_group_rel_user
+        $sql = "update $table_group_rel_user
    				SET relation_type = ".intval($relation_type)."
                 WHERE user_id = $user_id AND usergroup_id = $group_id";
         Database::query($sql);
@@ -1935,7 +1935,7 @@ 
         if (isset($from) && isset($limit)) {
             $from = intval($from);
             $limit = intval($limit);
-            $limit_text = "LIMIT $from, $limit";
+            $limit_text = "limit $from, $limit";
         }
 
         if (count($relation_type) == 0) {
@@ -2102,7 +2102,7 @@ 
         $table_message = Database::get_main_table(TABLE_MESSAGE);
         $topic_id = intval($topic_id);
         $group_id = intval($group_id);
-        $sql = "UPDATE $table_message SET
+        $sql = "update $table_message SET
                 msg_status = 3
                 WHERE
                     group_id = $group_id AND
@@ -2214,7 +2214,7 @@ 
                 $select_part .= "rg$rg_number.group_id as id_$rg_number, ";
             }
             if ($i == 1) {
-                $cond_part .= "FROM $t_rel_group rg0 LEFT JOIN $t_rel_group rg$i on rg$rg_number.group_id = rg$i.subgroup_id ";
+                $cond_part .= "from $t_rel_group rg0 LEFT JOIN $t_rel_group rg$i on rg$rg_number.group_id = rg$i.subgroup_id ";
             } else {
                 $cond_part .= " LEFT JOIN $t_rel_group rg$i on rg$rg_number.group_id = rg$i.subgroup_id ";
             }
@@ -2301,7 +2301,7 @@ 
         $groupRelGroupTable = Database::get_main_table(TABLE_USERGROUP_REL_USERGROUP);
 
         $select = "SELECT ";
-        $from = "FROM $groupTable g1 ";
+        $from = "from $groupTable g1 ";
 
         for ($i = 1; $i <= $levels; $i++) {
             $tableIndexNumber = $i;
@@ -2355,7 +2355,7 @@ 
                         subgroup_id = $group_id,
                         relation_type = $relation_type";
             } else {
-                $sql = "UPDATE $table SET
+                $sql = "update $table SET
                         group_id = $parent_group_id,
                         relation_type = $relation_type
                         WHERE subgroup_id = $group_id";

Doc Comments +13 added lines, -7 removed lines

@@ -1067,7 +1067,7 @@ 
      * @param int    $groupId
      * @param string $picture
      *
-     * @return bool|string
+     * @return false|string
      */
     public function manageFileUpload($groupId, $picture)
     {
@@ -1096,7 +1096,7 @@ 
      * If an empty name is provided, then old user photos are deleted only,
      * @see UserManager::delete_user_picture() as the prefered way for deletion.
      * @param    string $source_file The full system name of the image from which user photos will be created.
-     * @return   mixed    Returns the resulting common file name of created images which usually should be stored in database.
+     * @return   false|string    Returns the resulting common file name of created images which usually should be stored in database.
      * When an image is removed the function returns an empty string. In case of internal error or negative validation it returns FALSE.
      */
     public function update_group_picture($group_id, $file = null, $source_file = null)
@@ -1209,7 +1209,7 @@ 
     }
 
     /**
-     * @return mixed
+     * @return integer
      */
     public function getGroupType()
     {
@@ -1408,6 +1408,8 @@ 
      * @param string height
      * @param string picture size it can be small_,  medium_  or  big_
      * @param string style css
+     * @param integer $height
+     * @param integer $size_picture
      * @return array with the file and the style of an image i.e $array['file'] $array['style']
      */
     public function get_picture_group(
@@ -1475,7 +1477,7 @@ 
      * @param    string    Type of path to return (can be 'none', 'system', 'rel', 'web')
      * @param    bool    Whether we want to have the directory name returned 'as if' there was a file or not (in the case we want to know which directory to create - otherwise no file means no split subdir)
      * @param    bool    If we want that the function returns the /main/img/unknown.jpg image set it at true
-     * @return   array    Array of 2 elements: 'dir' and 'file' which contain the dir and file as the name implies if image does not exist it will return the unknow image if anonymous parameter is true if not it returns an empty er's
+     * @return   integer    Array of 2 elements: 'dir' and 'file' which contain the dir and file as the name implies if image does not exist it will return the unknow image if anonymous parameter is true if not it returns an empty er's
      */
     public function get_group_picture_path_by_id($id, $type = 'none', $preview = false, $anonymous = false)
     {
@@ -1525,7 +1527,7 @@ 
     }
 
     /**
-     * @return array
+     * @return string[]
      */
     public function getAllowedPictureExtensions()
     {
@@ -1716,7 +1718,7 @@ 
      * @author Julio Montoya
      * @param  int  $user_id
      * @param  int $group_id
-     * @return boolean true if success
+     * @return Doctrine\DBAL\Driver\Statement true if success
      * */
     public function delete_user_rel_group($user_id, $group_id)
     {
@@ -1927,6 +1929,8 @@ 
      * @param int from value
      * @param int limit
      * @param array image configuration, i.e array('height'=>'20px', 'size'=> '20px')
+     * @param integer $from
+     * @param integer $limit
      * @return array list of users in a group
      */
     public function get_users_by_group(
@@ -2025,6 +2029,8 @@ 
      * Shows the left column of the group page
      * @param int group id
      * @param int user id
+     * @param integer $group_id
+     * @param integer $user_id
      * @return string
      */
     public function show_group_column_information($group_id, $user_id, $show = '')
@@ -2353,7 +2359,7 @@ 
      * @param int $group_id
      * @param int $parent_group_id if 0, we delete the parent_group association
      * @param int $relation_type
-     * @return resource
+     * @return Doctrine\DBAL\Driver\Statement
      **/
     public static function set_parent_group($group_id, $parent_group_id, $relation_type = 1)
     {

Indentation +1 added lines, -1 removed lines

@@ -1736,7 +1736,7 @@
      * @param  int $user_id
      * @param  int $group_id
      * @param  int $relation_type
-    *
+     *
      * @return boolean true if success
      **/
     public function add_user_to_group($user_id, $group_id, $relation_type = GROUP_USER_PERMISSION_READER)

main/inc/lib/course_category.lib.php

Upper-Lower-Casing +13 added lines, -13 removed lines

@@ -158,10 +158,10 @@ 
         // Now we're at the top, get back down to update each child
         //$children_count = courseCategoryChildrenCount($categoryId);
         if ($delta >= 0) {
-            $sql = "UPDATE $tbl_category SET children_count = (children_count + $delta)
+            $sql = "update $tbl_category SET children_count = (children_count + $delta)
                 WHERE code = '$categoryId'";
         } else {
-            $sql = "UPDATE $tbl_category SET children_count = (children_count - ".abs($delta).")
+            $sql = "update $tbl_category SET children_count = (children_count - ".abs($delta).")
                 WHERE code = '$categoryId'";
         }
         Database::query($sql);
@@ -180,15 +180,15 @@ 
         if ($row = Database::fetch_array($result)) {
             if (!empty($row['parent_id'])) {
                 Database::query(
-                    "UPDATE $tbl_course SET category_code = '".$row['parent_id']."' WHERE category_code='$node'"
+                    "update $tbl_course SET category_code = '".$row['parent_id']."' WHERE category_code='$node'"
                 );
-                Database::query("UPDATE $tbl_category SET parent_id='".$row['parent_id']."' WHERE parent_id='$node'");
+                Database::query("update $tbl_category SET parent_id='".$row['parent_id']."' WHERE parent_id='$node'");
             } else {
-                Database::query("UPDATE $tbl_course SET category_code='' WHERE category_code='$node'");
-                Database::query("UPDATE $tbl_category SET parent_id=NULL WHERE parent_id='$node'");
+                Database::query("update $tbl_course SET category_code='' WHERE category_code='$node'");
+                Database::query("update $tbl_category SET parent_id=NULL WHERE parent_id='$node'");
             }
 
-            Database::query("UPDATE $tbl_category SET tree_pos=tree_pos-1 WHERE tree_pos > '".$row['tree_pos']."'");
+            Database::query("update $tbl_category SET tree_pos=tree_pos-1 WHERE tree_pos > '".$row['tree_pos']."'");
             Database::query("DELETE FROM $tbl_category WHERE code='$node'");
 
             if (!empty($row['parent_id'])) {
@@ -216,7 +216,7 @@ 
 
         $code = CourseManager::generate_course_code($code);
         // Updating category
-        $sql = "UPDATE $tbl_category SET 
+        $sql = "update $tbl_category SET 
                     name='$name', 
                     code='$code', 
                     auth_course_child = '$canHaveCourses'
@@ -224,12 +224,12 @@ 
         Database::query($sql);
 
         // Updating children
-        $sql = "UPDATE $tbl_category SET parent_id = '$code'
+        $sql = "update $tbl_category SET parent_id = '$code'
             WHERE parent_id = '$old_code'";
         Database::query($sql);
 
         // Updating course category
-        $sql = "UPDATE $tbl_course SET category_code = '$code'
+        $sql = "update $tbl_course SET category_code = '$code'
             WHERE category_code = '$old_code' ";
         Database::query($sql);
 
@@ -279,12 +279,12 @@ 
             }
         }
 
-        $sql = "UPDATE $tbl_category
+        $sql = "update $tbl_category
                 SET tree_pos ='".$row['tree_pos']."'
                 WHERE code='$code'";
         Database::query($sql);
 
-        $sql = "UPDATE $tbl_category
+        $sql = "update $tbl_category
                 SET tree_pos = '$tree_pos'
                 WHERE code= '".$row['code']."'";
         Database::query($sql);
@@ -312,7 +312,7 @@ 
         while ($row = Database::fetch_array($result)) {
             $count += self::courseCategoryChildrenCount($row['id']);
         }
-        $sql = "UPDATE $tbl_category SET 
+        $sql = "update $tbl_category SET 
                     children_count = $count 
                 WHERE id = $categoryId";
         Database::query($sql);

Doc Comments +5 added lines, -5 removed lines

@@ -98,7 +98,7 @@ 
      * @param string $canHaveCourses
      * @param int $parent_id
      *
-     * @return bool
+     * @return false|string
      */
     public static function addNode($code, $name, $canHaveCourses, $parent_id)
     {
@@ -294,7 +294,7 @@ 
      * Counts the number of children categories a category has
      * @param int $categoryId The ID of the category of which we want to count the children
      *
-     * @return mixed The number of subcategories this category has
+     * @return integer The number of subcategories this category has
      */
     public static function courseCategoryChildrenCount($categoryId)
     {
@@ -492,7 +492,7 @@ 
     /**
      * @param int $id
      *
-     * @return bool
+     * @return boolean|null
      */
     public static function addToUrl($id)
     {
@@ -963,7 +963,7 @@ 
      * Get Pagination HTML div
      * @param $pageCurrent
      * @param $pageLength
-     * @param $pageTotal
+     * @param integer $pageTotal
      * @return string
      */
     public static function getCatalogPagination($pageCurrent, $pageLength, $pageTotal)
@@ -1192,7 +1192,7 @@ 
      * @param $categoryId
      * @param string $description
      *
-     * @return string
+     * @return boolean
      */
     public static function saveDescription($categoryId, $description)
     {

main/inc/lib/agenda.lib.php

Braces +4 added lines, -2 removed lines

@@ -3413,7 +3413,8 @@ 
             $sql = "SELECT * FROM ".$tbl_global_agenda." WHERE MONTH(start_date) = ".$month." AND YEAR(start_date) = ".$year."  AND access_url_id = $current_access_url_id ORDER BY start_date ASC";
         }
         // 2. creating the SQL statement for getting the personal agenda items in WEEK view
-        if ($type == "week_view") { // we are in week view
+        if ($type == "week_view") {
+// we are in week view
             $start_end_day_of_week = self::calculate_start_end_of_week(
                 $week,
                 $year
@@ -3433,7 +3434,8 @@ 
             $sql = " SELECT * FROM ".$tbl_global_agenda." WHERE start_date>='".$start_filter."' AND start_date<='".$end_filter."' AND  access_url_id = $current_access_url_id ";
         }
         // 3. creating the SQL statement for getting the personal agenda items in DAY view
-        if ($type == "day_view") { // we are in day view
+        if ($type == "day_view") {
+// we are in day view
             // we could use mysql date() function but this is only available from 4.1 and higher
             $start_filter = $year."-".$month."-".$day." 00:00:00";
             $start_filter = api_get_utc_datetime($start_filter);

Upper-Lower-Casing +7 added lines, -7 removed lines

@@ -1296,13 +1296,13 @@ 
         if (!empty($event)) {
             switch ($this->type) {
                 case 'personal':
-                    $sql = "UPDATE $this->tbl_personal_agenda SET
+                    $sql = "update $this->tbl_personal_agenda SET
                             enddate = DATE_ADD(enddate, INTERVAL $delta MINUTE)
 							WHERE id = ".$id;
                     Database::query($sql);
                     break;
                 case 'course':
-                    $sql = "UPDATE $this->tbl_course_agenda SET
+                    $sql = "update $this->tbl_course_agenda SET
                             end_date = DATE_ADD(end_date, INTERVAL $delta MINUTE)
 							WHERE 
 							    c_id = ".$this->course['real_id']." AND 
@@ -1310,7 +1310,7 @@ 
                     Database::query($sql);
                     break;
                 case 'admin':
-                    $sql = "UPDATE $this->tbl_global_agenda SET
+                    $sql = "update $this->tbl_global_agenda SET
                             end_date = DATE_ADD(end_date, INTERVAL $delta MINUTE)
 							WHERE id = ".$id;
                     Database::query($sql);
@@ -1343,14 +1343,14 @@ 
         if (!empty($event)) {
             switch ($this->type) {
                 case 'personal':
-                    $sql = "UPDATE $this->tbl_personal_agenda SET
+                    $sql = "update $this->tbl_personal_agenda SET
                             all_day = $allDay, date = DATE_ADD(date, INTERVAL $delta MINUTE),
                             enddate = DATE_ADD(enddate, INTERVAL $delta MINUTE)
 							WHERE id=".$id;
                     Database::query($sql);
                     break;
                 case 'course':
-                    $sql = "UPDATE $this->tbl_course_agenda SET
+                    $sql = "update $this->tbl_course_agenda SET
                             all_day = $allDay, 
                             start_date = DATE_ADD(start_date, INTERVAL $delta MINUTE),
                             end_date = DATE_ADD(end_date, INTERVAL $delta MINUTE)
@@ -1360,7 +1360,7 @@ 
                     Database::query($sql);
                     break;
                 case 'admin':
-                    $sql = "UPDATE $this->tbl_global_agenda SET
+                    $sql = "update $this->tbl_global_agenda SET
                             all_day = $allDay,
                             start_date = DATE_ADD(start_date,INTERVAL $delta MINUTE),
                             end_date = DATE_ADD(end_date, INTERVAL $delta MINUTE)
@@ -2725,7 +2725,7 @@ 
                     ];
                     $id = Database::insert($agenda_table_attachment, $params);
                     if ($id) {
-                        $sql = "UPDATE $agenda_table_attachment
+                        $sql = "update $agenda_table_attachment
                                 SET id = iid WHERE iid = $id";
                         Database::query($sql);
 

Doc Comments +1 added lines, -1 removed lines

@@ -677,7 +677,7 @@
      * @param bool $updateContent
      * @param int $authorId
      *
-     * @return bool
+     * @return null|boolean
      */
     public function editEvent(
         $id,

main/inc/lib/lp_item.lib.php

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -79,7 +79,7 @@
     {

         $item_view_table = Database::get_course_table(TABLE_LP_ITEM);

         if ($this->c_id > 0 && $this->id > 0) {

-            $sql = "UPDATE $item_view_table SET

+            $sql = "update $item_view_table SET

                         lp_id = '".intval($this->lp_id)."' ,

                         item_type = '".Database::escape_string($this->item_type)."' ,

                         ref = '".Database::escape_string($this->ref)."' ,

Braces +9 added lines, -9 removed lines

@@ -9,8 +9,8 @@ 
  * You can add lp_item database manipulation function here

  *

  */

-class LpItem

-{

+class LpItem
+{
     public $c_id = 0;

     public $id = 0;

     public $lp_id = 0;

@@ -34,9 +34,9 @@ 
     public $search_did = 0;

     public $audio = '';

 

-    public function __construct($in_c_id = 0, $in_id = 0)

-    {

-        if ($in_c_id > 0 && $in_id > 0) {

+    public function __construct($in_c_id = 0, $in_id = 0)
+    {
+        if ($in_c_id > 0 && $in_id > 0) {
             $item_view_table = Database::get_course_table(TABLE_LP_ITEM);

             $sql = "SELECT * FROM $item_view_table

                     WHERE

@@ -45,7 +45,7 @@ 
 

             $res = Database::query($sql);

             $data = Database::fetch_array($res);

-            if (Database::num_rows($res) > 0) {

+            if (Database::num_rows($res) > 0) {
                 $this->c_id = $data['c_id'];

                 $this->id = $data['id'];

                 $this->lp_id = $data['lp_id'];

@@ -75,10 +75,10 @@ 
     /**

      * Update in database

      */

-    public function update_in_bdd()

-    {

+    public function update_in_bdd()
+    {
         $item_view_table = Database::get_course_table(TABLE_LP_ITEM);

-        if ($this->c_id > 0 && $this->id > 0) {

+        if ($this->c_id > 0 && $this->id > 0) {
             $sql = "UPDATE $item_view_table SET

                         lp_id = '".intval($this->lp_id)."' ,

                         item_type = '".Database::escape_string($this->item_type)."' ,