UserManager::delete_user()

Complexity

Conditions	12
Paths	12

Size

Total Lines	70
Code Lines	41

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    public static function delete_user(int $user_id, bool $destroy = false): bool
    {
        $user_id = (int) $user_id;

        if (empty($user_id)) {
            return false;
        }

        if (!self::canDeleteUser($user_id)) {
            return false;
        }

        $repository = Container::getUserRepository();

        /** @var User $user */
        $user = $repository->find($user_id);

        if (!$user) {

$user is of type Chamilo\CoreBundle\Entity\User, thus it always evaluated to true.

            return false;
        }

        $fallbackUser = $repository->getFallbackUser();
        $fallbackId = (int) $fallbackUser->getId();
        if ($destroy) {
            if ($fallbackId && $fallbackId !== $user_id) {
                $em = Database::getManager();
                $em->createQuery(
                    'UPDATE ' . User::class . ' u
                     SET u.creatorId = :newCreator
                     WHERE u.creatorId = :oldCreator AND u.id <> :fallbackId'
                            )
                    ->setParameter('newCreator', $fallbackId)
                    ->setParameter('oldCreator', $user_id)
                    ->setParameter('fallbackId', $fallbackId)
                    ->execute();
            }
        }

        $repository->deleteUser($user, $destroy);

        if ($destroy) {
            Event::addEvent(
                LOG_USER_DELETE,
                LOG_USER_ID,
                $user_id,
                api_get_utc_datetime(),
                api_get_user_id()
            );

            // Log one event per affected user AFTER the deletion
            if (!empty($affectedIds) && $fallbackId && $fallbackId !== $user_id) {

The variable $affectedIds seems to never exist and therefore empty should always be true.

                $nowUtc = api_get_utc_datetime();
                $actor  = api_get_user_id();
                foreach ($affectedIds as $affectedId) {
                    Event::addEvent(
                        LOG_USER_CREATOR_DELETED,
                        LOG_USER_ID,
                        [
                            'user_id'        => $affectedId,
                            'old_creator_id' => $user_id,
                            'new_creator_id' => $fallbackId,
                        ],
                        $nowUtc,
                        $actor
                    );
                }
            }
        }

        return true;
    }