| Conditions | 11 |
| Paths | 1024 |
| Total Lines | 94 |
| Code Lines | 58 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 1 | ||
| Bugs | 1 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 15 | public function up(Schema $schema): void |
||
| 16 | { |
||
| 17 | $table = $schema->getTable('c_forum_attachment'); |
||
| 18 | |||
| 19 | if (false === $table->hasColumn('resource_node_id')) { |
||
| 20 | $this->addSql('ALTER TABLE c_forum_attachment ADD resource_node_id INT DEFAULT NULL'); |
||
| 21 | $this->addSql( |
||
| 22 | 'ALTER TABLE c_forum_attachment ADD CONSTRAINT FK_F1113A884B89032C FOREIGN KEY (post_id) REFERENCES c_forum_post (iid) ON DELETE CASCADE' |
||
| 23 | ); |
||
| 24 | $this->addSql( |
||
| 25 | 'ALTER TABLE c_forum_attachment ADD CONSTRAINT FK_F1113A881BAD783F FOREIGN KEY (resource_node_id) REFERENCES resource_node (id) ON DELETE CASCADE' |
||
| 26 | ); |
||
| 27 | $this->addSql('CREATE UNIQUE INDEX UNIQ_F1113A881BAD783F ON c_forum_attachment (resource_node_id)'); |
||
| 28 | |||
| 29 | $this->addSql('CREATE INDEX IDX_F1113A884B89032C ON c_forum_attachment (post_id)'); |
||
| 30 | } |
||
| 31 | $table = $schema->getTable('c_forum_category'); |
||
| 32 | |||
| 33 | if (false === $table->hasColumn('resource_node_id')) { |
||
| 34 | $this->addSql('ALTER TABLE c_forum_category ADD resource_node_id INT DEFAULT NULL'); |
||
| 35 | $this->addSql( |
||
| 36 | 'ALTER TABLE c_forum_category ADD CONSTRAINT FK_D627B86E1BAD783F FOREIGN KEY (resource_node_id) REFERENCES resource_node (id) ON DELETE CASCADE' |
||
| 37 | ); |
||
| 38 | $this->addSql('CREATE UNIQUE INDEX UNIQ_D627B86E1BAD783F ON c_forum_category (resource_node_id)'); |
||
| 39 | } |
||
| 40 | |||
| 41 | $table = $schema->getTable('c_forum_forum'); |
||
| 42 | if (false === $table->hasColumn('resource_node_id')) { |
||
| 43 | $this->addSql('ALTER TABLE c_forum_forum ADD resource_node_id INT DEFAULT NULL, DROP forum_id'); |
||
| 44 | $this->addSql( |
||
| 45 | 'ALTER TABLE c_forum_forum ADD CONSTRAINT FK_47A9C991BAD783F FOREIGN KEY (resource_node_id) REFERENCES resource_node (id) ON DELETE CASCADE' |
||
| 46 | ); |
||
| 47 | $this->addSql( |
||
| 48 | 'ALTER TABLE c_forum_forum ADD CONSTRAINT FK_47A9C9921BF9426 FOREIGN KEY (forum_category) REFERENCES c_forum_category (iid) ON DELETE SET NULL' |
||
| 49 | ); |
||
| 50 | $this->addSql('CREATE UNIQUE INDEX UNIQ_47A9C991BAD783F ON c_forum_forum (resource_node_id)'); |
||
| 51 | } |
||
| 52 | |||
| 53 | $this->addSql('ALTER TABLE c_forum_forum DROP FOREIGN KEY FK_47A9C9921BF9426'); |
||
| 54 | |||
| 55 | $table = $schema->getTable('c_forum_thread'); |
||
| 56 | if ($table->hasForeignKey('FK_5DA7884C29CCBAD0')) { |
||
| 57 | $this->addSql('ALTER TABLE c_forum_thread DROP FOREIGN KEY FK_5DA7884C29CCBAD0'); |
||
| 58 | } |
||
| 59 | |||
| 60 | if (false === $table->hasColumn('resource_node_id')) { |
||
| 61 | $this->addSql('ALTER TABLE c_forum_thread ADD resource_node_id INT DEFAULT NULL, DROP thread_id'); |
||
| 62 | $this->addSql( |
||
| 63 | 'ALTER TABLE c_forum_thread ADD CONSTRAINT FK_5DA7884C1BAD783F FOREIGN KEY (resource_node_id) REFERENCES resource_node (id) ON DELETE CASCADE' |
||
| 64 | ); |
||
| 65 | $this->addSql( |
||
| 66 | 'ALTER TABLE c_forum_thread ADD CONSTRAINT FK_5DA7884C29CCBAD0 FOREIGN KEY (forum_id) REFERENCES c_forum_forum (iid) ON DELETE SET NULL' |
||
| 67 | ); |
||
| 68 | $this->addSql('CREATE UNIQUE INDEX UNIQ_5DA7884C1BAD783F ON c_forum_thread (resource_node_id)'); |
||
| 69 | } |
||
| 70 | //$this->addSql('ALTER TABLE c_forum_thread_qualify DROP id'); |
||
| 71 | //$this->addSql('ALTER TABLE c_forum_thread_qualify_log DROP id'); |
||
| 72 | |||
| 73 | $table = $schema->getTable('c_forum_post'); |
||
| 74 | if ($table->hasForeignKey('FK_B5BEF559E2904019')) { |
||
| 75 | $this->addSql('ALTER TABLE c_forum_post DROP FOREIGN KEY FK_B5BEF559E2904019'); |
||
| 76 | } |
||
| 77 | |||
| 78 | if (false === $table->hasColumn('resource_node_id')) { |
||
| 79 | $this->addSql('CREATE UNIQUE INDEX UNIQ_B5BEF5591BAD783F ON c_forum_post (resource_node_id)'); |
||
| 80 | $this->addSql('ALTER TABLE c_forum_post ADD resource_node_id INT DEFAULT NULL'); |
||
| 81 | $this->addSql( |
||
| 82 | 'ALTER TABLE c_forum_post ADD CONSTRAINT FK_B5BEF55929CCBAD0 FOREIGN KEY (forum_id) REFERENCES c_forum_forum (iid) ON DELETE SET NULL' |
||
| 83 | ); |
||
| 84 | $this->addSql( |
||
| 85 | 'ALTER TABLE c_forum_post ADD CONSTRAINT FK_B5BEF5591BAD783F FOREIGN KEY (resource_node_id) REFERENCES resource_node (id) ON DELETE CASCADE' |
||
| 86 | ); |
||
| 87 | $this->addSql( |
||
| 88 | 'ALTER TABLE c_forum_post ADD CONSTRAINT FK_B5BEF559E2904019 FOREIGN KEY (thread_id) REFERENCES c_forum_thread (iid) ON DELETE SET NULL' |
||
| 89 | ); |
||
| 90 | } |
||
| 91 | |||
| 92 | $table = $schema->getTable('c_course_description'); |
||
| 93 | if (false === $table->hasColumn('resource_node_id')) { |
||
| 94 | $this->addSql('ALTER TABLE c_course_description ADD resource_node_id INT DEFAULT NULL'); |
||
| 95 | $this->addSql('ALTER TABLE c_course_description ADD CONSTRAINT FK_EC3CD8091BAD783F FOREIGN KEY (resource_node_id) REFERENCES resource_node (id) ON DELETE CASCADE'); |
||
| 96 | $this->addSql('CREATE UNIQUE INDEX UNIQ_EC3CD8091BAD783F ON c_course_description (resource_node_id)'); |
||
| 97 | } |
||
| 98 | |||
| 99 | $table = $schema->getTable('c_notebook'); |
||
| 100 | |||
| 101 | if ($table->hasIndex('course')) { |
||
| 102 | $this->addSql('DROP INDEX course ON c_notebook'); |
||
| 103 | } |
||
| 104 | |||
| 105 | if (false === $table->hasColumn('resource_node_id')) { |
||
| 106 | $this->addSql('ALTER TABLE c_notebook ADD resource_node_id INT DEFAULT NULL, DROP notebook_id'); |
||
| 107 | $this->addSql('ALTER TABLE c_notebook ADD CONSTRAINT FK_E7EE1CE01BAD783F FOREIGN KEY (resource_node_id) REFERENCES resource_node (id) ON DELETE CASCADE'); |
||
| 108 | $this->addSql('CREATE UNIQUE INDEX UNIQ_E7EE1CE01BAD783F ON c_notebook (resource_node_id)'); |
||
| 109 | } |
||
| 112 |