ProfileType::buildForm() - Code Metrics - Inspection of "Add extra fields types in profile (WIP) + add test..." - chamilo/chamilo-lms - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( c7999a...c902dc )

by Julito

created 2021-10-13 13:10 UTC

ProfileType::buildForm() D

↳ Parent: ProfileType

Complexity

Conditions	18
Paths	141

Size

Total Lines	164
Code Lines	87

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	18
eloc	87
nc	141
nop	2
dl	0
loc	164
rs	4.525
c	0
b	0
f	0

How to fix Long Method Complexity

<?php

declare(strict_types=1);

/* For licensing terms, see /license.txt */

namespace Chamilo\CoreBundle\Form;

use Chamilo\CoreBundle\Entity\ExtraField;
use Chamilo\CoreBundle\Entity\ExtraFieldValues;
use Chamilo\CoreBundle\Entity\User;
use Chamilo\CoreBundle\Form\Type\IllustrationType;
use Chamilo\CoreBundle\Repository\ExtraFieldRepository;
use Chamilo\CoreBundle\Repository\ExtraFieldValuesRepository;
use Chamilo\CoreBundle\Repository\LanguageRepository;
use Symfony\Component\Form\AbstractType;
use Symfony\Component\Form\Extension\Core\Type\BirthdayType;
use Symfony\Component\Form\Extension\Core\Type\ChoiceType;
use Symfony\Component\Form\Extension\Core\Type\DateTimeType;
use Symfony\Component\Form\Extension\Core\Type\DateType;
use Symfony\Component\Form\Extension\Core\Type\EmailType;
use Symfony\Component\Form\Extension\Core\Type\LocaleType;
use Symfony\Component\Form\Extension\Core\Type\TextareaType;
use Symfony\Component\Form\Extension\Core\Type\TextType;
use Symfony\Component\Form\Extension\Core\Type\TimezoneType;
use Symfony\Component\Form\Extension\Core\Type\UrlType;
use Symfony\Component\Form\FormBuilderInterface;
use Symfony\Component\Form\FormEvent;
use Symfony\Component\Form\FormEvents;
use Symfony\Component\OptionsResolver\OptionsResolver;
use Symfony\Component\Security\Core\Security;

class ProfileType extends AbstractType
{
    private LanguageRepository $languageRepository;
    private ExtraFieldValuesRepository $extraFieldValuesRepository;
    private Security $security;
    private ExtraFieldRepository $extraFieldRepository;

    public function __construct(
        LanguageRepository $languageRepository,
        ExtraFieldValuesRepository $extraFieldValuesRepository,
        ExtraFieldRepository $extraFieldRepository,
        Security $security
    ) {
        $this->languageRepository = $languageRepository;
        $this->extraFieldValuesRepository = $extraFieldValuesRepository;
        $this->extraFieldRepository = $extraFieldRepository;
        $this->security = $security;
    }

    public function buildForm(FormBuilderInterface $builder, array $options): void
    {
        $languages = array_flip($this->languageRepository->getAllAvailableToArray());

        $builder
            ->add('firstname', TextType::class, ['label' => 'Firstname', 'required' => true])
            ->add('lastname', TextType::class, ['label' => 'Lastname', 'required' => true])
            ->add('email', EmailType::class, ['label' => 'Email', 'required' => true])
            //->add('official_code', TextType::class)
            //->add('groups')
            ->add('locale', LocaleType::class, [
                //'preferred_choices' => ['en', 'fr_FR', 'es_ES', 'pt', 'nl'],
                'choices' => $languages,
                'choice_loader' => null,
            ])
            /*->add(                'dateOfBirth',
                BirthdayType::class,
                [
                    'label' => 'form.label_date_of_birth',
                    'required' => false,
                    'widget' => 'single_text',
                ]
            )
            ->add(
                'biography',
                TextareaType::class,
                [
                    'label' => 'form.label_biography',
                    'required' => false,
                ]
            )*/
            /*->add('locale', 'locale', array(
                'label'    => 'form.label_locale',
                'required' => false,
            ))*/
            ->add('timezone', TimezoneType::class, ['label' => 'Timezone', 'required' => true])
            ->add('phone', TextType::class, ['label' => 'Phone number', 'required' => false])
            ->add(
                'illustration',
                IllustrationType::class,
                ['label' => 'Picture', 'required' => false, 'mapped' => false]
            )
            //->add('website', UrlType::class, ['label' => 'Website', 'required' => false])
            /*->add(
                'extraFieldValues',
                CollectionType::class,
                array(
                    'required' => false,
                    'allow_add' => true,
                    'allow_delete' => true,
                    'type' => 'chamilo_user_extra_field_value',
                    'by_reference' => false,
                    'prototype' => true,
                    'widget_add_btn' => ['label' => 'Add'],
                    'options' => array( // options for collection fields
                        'widget_remove_btn' => array('label' => 'Remove'),
                        'label_render' => false,
                    )
                )
            )*/
            //->add('save', 'submit', array('label' => 'Update')            )
        ;

        $user = $this->security->getUser();

        if (null === $user) {
            return;
        }

        $extraFields = $this->extraFieldRepository->getExtraFields(ExtraField::USER_FIELD_TYPE);
        $values = $this->extraFieldValuesRepository->getExtraFieldValuesFromItem($user, ExtraField::USER_FIELD_TYPE);

        $data = [];
        foreach ($values as $value) {
            $data[$value->getField()->getVariable()] = $value->getValue();
        }

        foreach ($extraFields as $extraField) {
            $text = $extraField->getDisplayText();
            $variable = $extraField->getVariable();
            $value = $data[$extraField->getVariable()] ?? '';

            // @todo
            switch ($extraField->getFieldType()) {
                case \ExtraField::FIELD_TYPE_DATETIME:
                    $builder->add($variable, DateTimeType::class, [
                        'label' => $text,
                        'required' => false,
                        'by_reference' => false,
                        'mapped' => false,
                        'data' => $value,
                    ]);

                    break;
                case \ExtraField::FIELD_TYPE_DATE:
                    $builder->add($variable, DateType::class, [
                        'label' => $text,
                        'required' => false,
                        'by_reference' => false,
                        'mapped' => false,
                        'data' => $value,
                    ]);

                    break;
                case \ExtraField::FIELD_TYPE_TEXTAREA:
                case \ExtraField::FIELD_TYPE_TEXT:
                    $builder->add($variable, TextType::class, [
                        'label' => $text,
                        'required' => false,
                        'by_reference' => false,
                        'mapped' => false,
                        'data' => $value,
                    ]);

                    break;
                case \ExtraField::FIELD_TYPE_CHECKBOX:
                case \ExtraField::FIELD_TYPE_RADIO:
                case \ExtraField::FIELD_TYPE_SELECT:
                case \ExtraField::FIELD_TYPE_SELECT_MULTIPLE:
                    $options = $extraField->getOptions();
                    $choices = [];
                    foreach ($options as $option) {
                        $choices[$option->getDisplayText()] = $option->getValue();
                    }

                    $params = [
                        'label' => $text,
                        'required' => false,
                        'by_reference' => false,
                        'mapped' => false,
                        'data' => $value,
                        'choices' => $choices,
                    ];

                    if (\ExtraField::FIELD_TYPE_CHECKBOX === $extraField->getFieldType()) {
                        $params['expanded'] = true;
                        $params['multiple'] = true;
                    }
                    if (\ExtraField::FIELD_TYPE_SELECT === $extraField->getFieldType()) {
                        $params['expanded'] = false;
                        $params['multiple'] = false;
                    }
                    if (\ExtraField::FIELD_TYPE_SELECT_MULTIPLE === $extraField->getFieldType()) {
                        $params['expanded'] = false;
                        $params['multiple'] = true;
                    }
                    $builder->add($variable, ChoiceType::class, $params);

                    break;
            }
        }

        $builder->addEventListener(
            FormEvents::PRE_SUBMIT,
            function (FormEvent $event) use ($user, $extraFields): void {
                $data = $event->getData();

                /** @var ExtraField $extraField */
                foreach ($extraFields as $extraField) {
                    $newValue = $data[$extraField->getVariable()] ?? '';
                    if (empty($newValue)) {
                        continue;
                    }
                    $this->extraFieldValuesRepository->updateItemData($extraField, $user, $newValue);
                }
            }
        );
    }

    public function configureOptions(OptionsResolver $resolver): void
    {
        $resolver->setDefaults(
            [
                'data_class' => User::class,
            ]
        );
    }

    public function getName(): string
    {
        return 'chamilo_user_profile';
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			/* For licensing terms, see /license.txt */
6
7			namespace Chamilo\CoreBundle\Form;
8
9			use Chamilo\CoreBundle\Entity\ExtraField;
10			use Chamilo\CoreBundle\Entity\ExtraFieldValues;
11			use Chamilo\CoreBundle\Entity\User;
12			use Chamilo\CoreBundle\Form\Type\IllustrationType;
13			use Chamilo\CoreBundle\Repository\ExtraFieldRepository;
14			use Chamilo\CoreBundle\Repository\ExtraFieldValuesRepository;
15			use Chamilo\CoreBundle\Repository\LanguageRepository;
16			use Symfony\Component\Form\AbstractType;
17			use Symfony\Component\Form\Extension\Core\Type\BirthdayType;
18			use Symfony\Component\Form\Extension\Core\Type\ChoiceType;
19			use Symfony\Component\Form\Extension\Core\Type\DateTimeType;
20			use Symfony\Component\Form\Extension\Core\Type\DateType;
21			use Symfony\Component\Form\Extension\Core\Type\EmailType;
22			use Symfony\Component\Form\Extension\Core\Type\LocaleType;
23			use Symfony\Component\Form\Extension\Core\Type\TextareaType;
24			use Symfony\Component\Form\Extension\Core\Type\TextType;
25			use Symfony\Component\Form\Extension\Core\Type\TimezoneType;
26			use Symfony\Component\Form\Extension\Core\Type\UrlType;
27			use Symfony\Component\Form\FormBuilderInterface;
28			use Symfony\Component\Form\FormEvent;
29			use Symfony\Component\Form\FormEvents;
30			use Symfony\Component\OptionsResolver\OptionsResolver;
31			use Symfony\Component\Security\Core\Security;
32
33			class ProfileType extends AbstractType
34			{
35			private LanguageRepository $languageRepository;
36			private ExtraFieldValuesRepository $extraFieldValuesRepository;
37			private Security $security;
38			private ExtraFieldRepository $extraFieldRepository;
39
40			public function __construct(
41			LanguageRepository $languageRepository,
42			ExtraFieldValuesRepository $extraFieldValuesRepository,
43			ExtraFieldRepository $extraFieldRepository,
44			Security $security
45			) {
46			$this->languageRepository = $languageRepository;
47			$this->extraFieldValuesRepository = $extraFieldValuesRepository;
48			$this->extraFieldRepository = $extraFieldRepository;
49			$this->security = $security;
50			}
51
52			public function buildForm(FormBuilderInterface $builder, array $options): void
53			{
54			$languages = array_flip($this->languageRepository->getAllAvailableToArray());
55
56			$builder
57			->add('firstname', TextType::class, ['label' => 'Firstname', 'required' => true])
58			->add('lastname', TextType::class, ['label' => 'Lastname', 'required' => true])
59			->add('email', EmailType::class, ['label' => 'Email', 'required' => true])
60			//->add('official_code', TextType::class)
61			//->add('groups')
62			->add('locale', LocaleType::class, [
63			//'preferred_choices' => ['en', 'fr_FR', 'es_ES', 'pt', 'nl'],
64			'choices' => $languages,
65			'choice_loader' => null,
66			])
67			/*->add( 'dateOfBirth',
68			BirthdayType::class,
69			[
70			'label' => 'form.label_date_of_birth',
71			'required' => false,
72			'widget' => 'single_text',
73			]
74			)
75			->add(
76			'biography',
77			TextareaType::class,
78			[
79			'label' => 'form.label_biography',
80			'required' => false,
81			]
82			)*/
83			/*->add('locale', 'locale', array(
84			'label' => 'form.label_locale',
85			'required' => false,
86			))*/
87			->add('timezone', TimezoneType::class, ['label' => 'Timezone', 'required' => true])
88			->add('phone', TextType::class, ['label' => 'Phone number', 'required' => false])
89			->add(
90			'illustration',
91			IllustrationType::class,
92			['label' => 'Picture', 'required' => false, 'mapped' => false]
93			)
94			//->add('website', UrlType::class, ['label' => 'Website', 'required' => false])
95			/*->add(
96			'extraFieldValues',
97			CollectionType::class,
98			array(
99			'required' => false,
100			'allow_add' => true,
101			'allow_delete' => true,
102			'type' => 'chamilo_user_extra_field_value',
103			'by_reference' => false,
104			'prototype' => true,
105			'widget_add_btn' => ['label' => 'Add'],
106			'options' => array( // options for collection fields
107			'widget_remove_btn' => array('label' => 'Remove'),
108			'label_render' => false,
109			)
110			)
111			)*/
112			//->add('save', 'submit', array('label' => 'Update') )
113			;
114
115			$user = $this->security->getUser();
116
117			if (null === $user) {
118			return;
119			}
120
121			$extraFields = $this->extraFieldRepository->getExtraFields(ExtraField::USER_FIELD_TYPE);
122			$values = $this->extraFieldValuesRepository->getExtraFieldValuesFromItem($user, ExtraField::USER_FIELD_TYPE);
123
124			$data = [];
125			foreach ($values as $value) {
126			$data[$value->getField()->getVariable()] = $value->getValue();
127			}
128
129			foreach ($extraFields as $extraField) {
130			$text = $extraField->getDisplayText();
131			$variable = $extraField->getVariable();
132			$value = $data[$extraField->getVariable()] ?? '';
133
134			// @todo
135			switch ($extraField->getFieldType()) {
136			case \ExtraField::FIELD_TYPE_DATETIME:
137			$builder->add($variable, DateTimeType::class, [
138			'label' => $text,
139			'required' => false,
140			'by_reference' => false,
141			'mapped' => false,
142			'data' => $value,
143			]);
144
145			break;
146			case \ExtraField::FIELD_TYPE_DATE:
147			$builder->add($variable, DateType::class, [
148			'label' => $text,
149			'required' => false,
150			'by_reference' => false,
151			'mapped' => false,
152			'data' => $value,
153			]);
154
155			break;
156			case \ExtraField::FIELD_TYPE_TEXTAREA:
157			case \ExtraField::FIELD_TYPE_TEXT:
158			$builder->add($variable, TextType::class, [
159			'label' => $text,
160			'required' => false,
161			'by_reference' => false,
162			'mapped' => false,
163			'data' => $value,
164			]);
165
166			break;
167			case \ExtraField::FIELD_TYPE_CHECKBOX:
168			case \ExtraField::FIELD_TYPE_RADIO:
169			case \ExtraField::FIELD_TYPE_SELECT:
170			case \ExtraField::FIELD_TYPE_SELECT_MULTIPLE:
171			$options = $extraField->getOptions();
172			$choices = [];
173			foreach ($options as $option) {
174			$choices[$option->getDisplayText()] = $option->getValue();
175			}
176
177			$params = [
178			'label' => $text,
179			'required' => false,
180			'by_reference' => false,
181			'mapped' => false,
182			'data' => $value,
183			'choices' => $choices,
184			];
185
186			if (\ExtraField::FIELD_TYPE_CHECKBOX === $extraField->getFieldType()) {
187			$params['expanded'] = true;
188			$params['multiple'] = true;
189			}
190			if (\ExtraField::FIELD_TYPE_SELECT === $extraField->getFieldType()) {
191			$params['expanded'] = false;
192			$params['multiple'] = false;
193			}
194			if (\ExtraField::FIELD_TYPE_SELECT_MULTIPLE === $extraField->getFieldType()) {
195			$params['expanded'] = false;
196			$params['multiple'] = true;
197			}
198			$builder->add($variable, ChoiceType::class, $params);
199
200			break;
201			}
202			}
203
204			$builder->addEventListener(
205			FormEvents::PRE_SUBMIT,
206			function (FormEvent $event) use ($user, $extraFields): void {
207			$data = $event->getData();
208
209			/** @var ExtraField $extraField */
210			foreach ($extraFields as $extraField) {
211			$newValue = $data[$extraField->getVariable()] ?? '';
212			if (empty($newValue)) {
213			continue;
214			}
215			$this->extraFieldValuesRepository->updateItemData($extraField, $user, $newValue);
216			}
217			}
218			);
219			}
220
221			public function configureOptions(OptionsResolver $resolver): void
222			{
223			$resolver->setDefaults(
224			[
225			'data_class' => User::class,
226			]
227			);
228			}
229
230			public function getName(): string
231			{
232			return 'chamilo_user_profile';
233			}
234			}
235

chamilo / chamilo-lms

Push — master ( c7999a...c902dc )

ProfileType::buildForm() D

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like