chamilo /
chamilo-lms
| Conditions | 11 |
| Paths | 576 |
| Total Lines | 107 |
| Code Lines | 57 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
Methods with many parameters are not only hard to understand, but their parameters also often become inconsistent when you need more, or different data.
There are several approaches to avoid long parameter lists:
| 1 | <?php |
||
| 62 | public function getIndexCourseItems( |
||
| 63 | User $currentUser, |
||
| 64 | User $owner, |
||
| 65 | Course $course, |
||
| 66 | ?Session $session = null, |
||
| 67 | bool $showBaseContentInSession = false, |
||
| 68 | bool $listByUser = false, |
||
| 69 | ?DateTime $date = null, |
||
| 70 | array $tags = [], |
||
| 71 | ?string $searchText = null, |
||
| 72 | array $searchCategories = [], |
||
| 73 | array $searchNoInCategories = [], |
||
| 74 | bool $advancedSharingEnabled = false |
||
| 75 | ): array { |
||
| 76 | $queryBuilder = $this->getResources(); |
||
| 77 | $this->addCourseQueryBuilder($course, $queryBuilder); |
||
| 78 | |||
| 79 | if ($session) { |
||
| 80 | if ($showBaseContentInSession) { |
||
| 81 | $this->addSessionAndBaseContentQueryBuilder($session, $queryBuilder); |
||
| 82 | } else { |
||
| 83 | $this->addSessionOnlyQueryBuilder($session, $queryBuilder); |
||
| 84 | } |
||
| 85 | } else { |
||
| 86 | $this->addSessionNullQueryBuilder($queryBuilder); |
||
| 87 | } |
||
| 88 | |||
| 89 | if ($date) { |
||
| 90 | $queryBuilder |
||
| 91 | ->andWhere('resource.creationDate >= :date') |
||
| 92 | ->setParameter(':date', $date) |
||
| 93 | ; |
||
| 94 | } |
||
| 95 | |||
| 96 | if ($tags) { |
||
| 97 | $queryBuilder |
||
| 98 | ->innerJoin(ExtraFieldRelTag::class, 'efrt', Join::WITH, 'efrt.itemId = resource.id') |
||
| 99 | ->innerJoin(ExtraField::class, 'ef', Join::WITH, 'ef.id = efrt.fieldId') |
||
| 100 | ->andWhere('ef.extraFieldType = :efType') |
||
| 101 | ->andWhere('ef.variable = :variable') |
||
| 102 | ->andWhere('efrt.tagId IN (:tags)') |
||
| 103 | ; |
||
| 104 | |||
| 105 | $queryBuilder->setParameter('efType', ExtraField::PORTFOLIO_TYPE); |
||
| 106 | $queryBuilder->setParameter('variable', 'tags'); |
||
| 107 | $queryBuilder->setParameter('tags', $tags); |
||
| 108 | } |
||
| 109 | |||
| 110 | if (!empty($searchText)) { |
||
| 111 | $queryBuilder->andWhere( |
||
| 112 | $queryBuilder->expr()->orX( |
||
| 113 | $queryBuilder->expr()->like('resource.title', ':text'), |
||
| 114 | $queryBuilder->expr()->like('resource.content', ':text') |
||
| 115 | ) |
||
| 116 | ); |
||
| 117 | |||
| 118 | $queryBuilder->setParameter('text', '%'.$searchText.'%'); |
||
| 119 | } |
||
| 120 | |||
| 121 | if ($searchCategories) { |
||
| 122 | $queryBuilder->andWhere( |
||
| 123 | $queryBuilder->expr()->in('resource.category', $searchCategories) |
||
| 124 | ); |
||
| 125 | } |
||
| 126 | |||
| 127 | if ($searchNoInCategories) { |
||
| 128 | $queryBuilder->andWhere('resource.category NOT IN('.implode(',', $searchNoInCategories).')'); |
||
| 129 | } |
||
| 130 | |||
| 131 | if ($listByUser) { |
||
| 132 | $queryBuilder |
||
| 133 | ->andWhere('resource.user = :user') |
||
| 134 | ->setParameter('user', $owner) |
||
| 135 | ; |
||
| 136 | } |
||
| 137 | |||
| 138 | if ($advancedSharingEnabled) { |
||
| 139 | $queryBuilder->andWhere( |
||
| 140 | $queryBuilder->expr()->orX( |
||
| 141 | $queryBuilder->expr()->eq('resource.visibility', Portfolio::VISIBILITY_VISIBLE), |
||
| 142 | $queryBuilder->expr()->eq('links.user', ':current_user') |
||
| 143 | ) |
||
| 144 | ); |
||
| 145 | } else { |
||
| 146 | $visibilityCriteria = [Portfolio::VISIBILITY_VISIBLE]; |
||
| 147 | |||
| 148 | if (api_is_allowed_to_edit()) { |
||
| 149 | $visibilityCriteria[] = Portfolio::VISIBILITY_HIDDEN_EXCEPT_TEACHER; |
||
| 150 | } |
||
| 151 | |||
| 152 | $queryBuilder->andWhere( |
||
| 153 | $queryBuilder->expr()->orX( |
||
| 154 | 'node.creator = :current_user', |
||
| 155 | $queryBuilder->expr()->andX( |
||
| 156 | 'node.creator != :current_user', |
||
| 157 | $queryBuilder->expr()->in('resource.visibility', $visibilityCriteria) |
||
| 158 | ) |
||
| 159 | ) |
||
| 160 | ); |
||
| 161 | } |
||
| 162 | |||
| 163 | $queryBuilder |
||
| 164 | ->setParameter('current_user', $currentUser->getId()) |
||
| 165 | ->orderBy('node.createdAt', 'DESC') |
||
| 166 | ; |
||
| 167 | |||
| 168 | return $queryBuilder->getQuery()->getResult(); |
||
| 169 | } |
||
| 171 |
Loading history...
This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent.
Consider making the comparison explicit by using
empty(..)or! empty(...)instead.