chamilo / chamilo-lms

main/lp/storageapi.php

Switch Indentation +46 added lines, -46 removed lines

@@ -15,52 +15,52 @@
 }
 
 switch ($_REQUEST['action']) {
-    case "get":
-        print storage_get($_REQUEST['svuser'], $_REQUEST['svcourse'], $_REQUEST['svsco'], $_REQUEST['svkey']);
-        break;
-    case "set":
-        if (storage_can_set($_REQUEST['svuser'])) {
-            print storage_set($_REQUEST['svuser'], $_REQUEST['svcourse'], $_REQUEST['svsco'], $_REQUEST['svkey'], $_REQUEST['svvalue']);
-        }
-        break;
-    case "getall":
-        print storage_getall($_REQUEST['svuser'], $_REQUEST['svcourse'], $_REQUEST['svsco']);
-        break;
-    case "stackpush":
-        if (storage_can_set($_REQUEST['svuser'])) {
-            print storage_stack_push($_REQUEST['svuser'], $_REQUEST['svcourse'], $_REQUEST['svsco'], $_REQUEST['svkey'], $_REQUEST['svvalue']);
-        }
-        break;
-    case "stackpop":
-        if (storage_can_set($_REQUEST['svuser'])) {
-            print storage_stack_pop($_REQUEST['svuser'], $_REQUEST['svcourse'], $_REQUEST['svsco'], $_REQUEST['svkey']);
-        }
-        break;
-    case "stacklength":
-        print storage_stack_length($_REQUEST['svuser'], $_REQUEST['svcourse'], $_REQUEST['svsco'], $_REQUEST['svkey']);
-        break;
-    case "stackclear":
-        if (storage_can_set($_REQUEST['svuser'])) {
-            print storage_stack_clear($_REQUEST['svuser'], $_REQUEST['svcourse'], $_REQUEST['svsco'], $_REQUEST['svkey']);
-        }
-        break;
-    case "stackgetall":
-        if (storage_can_set($_REQUEST['svuser']))
-            print storage_stack_getall($_REQUEST['svuser'], $_REQUEST['svcourse'], $_REQUEST['svsco'], $_REQUEST['svkey']);
-        break;
-    case "getposition":
-        print storage_get_position($_REQUEST['svuser'], $_REQUEST['svcourse'], $_REQUEST['svsco'], $_REQUEST['svkey'], $_REQUEST['svasc']);
-        break;
-    case "getleaders":
-        print storage_get_leaders($_REQUEST['svuser'], $_REQUEST['svcourse'], $_REQUEST['svsco'], $_REQUEST['svkey'], $_REQUEST['svasc'], $_REQUEST['svlength']);
-        break;
-    case "usersgetall":
-// security issue
-        print "NOT allowed, security issue, see sources";
-//		print storage_get_all_users();
-        break;
-    default:
-        // Do nothing
+        case "get":
+            print storage_get($_REQUEST['svuser'], $_REQUEST['svcourse'], $_REQUEST['svsco'], $_REQUEST['svkey']);
+            break;
+        case "set":
+            if (storage_can_set($_REQUEST['svuser'])) {
+                print storage_set($_REQUEST['svuser'], $_REQUEST['svcourse'], $_REQUEST['svsco'], $_REQUEST['svkey'], $_REQUEST['svvalue']);
+            }
+            break;
+        case "getall":
+            print storage_getall($_REQUEST['svuser'], $_REQUEST['svcourse'], $_REQUEST['svsco']);
+            break;
+        case "stackpush":
+            if (storage_can_set($_REQUEST['svuser'])) {
+                print storage_stack_push($_REQUEST['svuser'], $_REQUEST['svcourse'], $_REQUEST['svsco'], $_REQUEST['svkey'], $_REQUEST['svvalue']);
+            }
+            break;
+        case "stackpop":
+            if (storage_can_set($_REQUEST['svuser'])) {
+                print storage_stack_pop($_REQUEST['svuser'], $_REQUEST['svcourse'], $_REQUEST['svsco'], $_REQUEST['svkey']);
+            }
+            break;
+        case "stacklength":
+            print storage_stack_length($_REQUEST['svuser'], $_REQUEST['svcourse'], $_REQUEST['svsco'], $_REQUEST['svkey']);
+            break;
+        case "stackclear":
+            if (storage_can_set($_REQUEST['svuser'])) {
+                print storage_stack_clear($_REQUEST['svuser'], $_REQUEST['svcourse'], $_REQUEST['svsco'], $_REQUEST['svkey']);
+            }
+            break;
+        case "stackgetall":
+            if (storage_can_set($_REQUEST['svuser']))
+                print storage_stack_getall($_REQUEST['svuser'], $_REQUEST['svcourse'], $_REQUEST['svsco'], $_REQUEST['svkey']);
+            break;
+        case "getposition":
+            print storage_get_position($_REQUEST['svuser'], $_REQUEST['svcourse'], $_REQUEST['svsco'], $_REQUEST['svkey'], $_REQUEST['svasc']);
+            break;
+        case "getleaders":
+            print storage_get_leaders($_REQUEST['svuser'], $_REQUEST['svcourse'], $_REQUEST['svsco'], $_REQUEST['svkey'], $_REQUEST['svasc'], $_REQUEST['svlength']);
+            break;
+        case "usersgetall":
+    // security issue
+            print "NOT allowed, security issue, see sources";
+    //		print storage_get_all_users();
+            break;
+        default:
+            // Do nothing
 }
 
 function storage_can_set($sv_user) {

Spacing +2 added lines, -2 removed lines

@@ -103,7 +103,7 @@ 
         and sco_id = '$sv_sco'
         and course_id = '$sv_course'
         and sv_key = '$sv_key'
-        order by sv_value ".($sv_asc ? "ASC": "DESC")." limit $sv_length";
+        order by sv_value ".($sv_asc ? "ASC" : "DESC")." limit $sv_length";
 //	$sql_data = "select sv.user_id as user_id, sv_key as variable, sv_value as value
 //		from ".Database::get_main_table(TABLE_TRACK_STORED_VALUES)." sv
 //		where sv.user_id in (select u2.user_id from ($sql_leaders) u2)
@@ -135,7 +135,7 @@ 
         and search.sco_id = '$sv_sco'
         and search.course_id = '$sv_course'
         and search.sv_key = '$sv_key'
-        and list.sv_value ".($sv_asc ? "<=": ">=")." search.sv_value
+        and list.sv_value ".($sv_asc ? "<=" : ">=")." search.sv_value
         and list.sco_id = search.sco_id
         and list.course_id = search.course_id
         and list.sv_key = search.sv_key

Braces +6 added lines, -8 removed lines

@@ -45,8 +45,9 @@ 
         }
         break;
     case "stackgetall":
-        if (storage_can_set($_REQUEST['svuser']))
-            print storage_stack_getall($_REQUEST['svuser'], $_REQUEST['svcourse'], $_REQUEST['svsco'], $_REQUEST['svkey']);
+        if (storage_can_set($_REQUEST['svuser'])) {
+                    print storage_stack_getall($_REQUEST['svuser'], $_REQUEST['svcourse'], $_REQUEST['svsco'], $_REQUEST['svkey']);
+        }
         break;
     case "getposition":
         print storage_get_position($_REQUEST['svuser'], $_REQUEST['svcourse'], $_REQUEST['svsco'], $_REQUEST['svkey'], $_REQUEST['svasc']);
@@ -87,8 +88,7 @@ 
         } else {
             return $row['sv_value'];
         }
-    }
-    else {
+    } else {
         return null;
     }
 }
@@ -144,8 +144,7 @@ 
     if (Database::num_rows($res) > 0) {
         $row = Database::fetch_assoc($res);
         return $row['position'];
-    }
-    else {
+    } else {
         return null;
     }
 }
@@ -198,8 +197,7 @@ 
     if ($resorder && $resinsert) {
         Database::query("commit");
         return 1;
-    }
-    else {
+    } else {
         Database::query("rollback");
         return 0;
     }

main/lp/lp_content.php

Spacing +1 added lines, -1 removed lines

@@ -106,7 +106,7 @@
 // Define the 'doc.inc.php' as language file.
 $nameTools = $_SESSION['oLP']->get_name();
 $interbreadcrumb[] = array(
-    'url' => api_get_path(WEB_CODE_PATH) . 'lp/lp_list.php?'.api_get_cidreq(),
+    'url' => api_get_path(WEB_CODE_PATH).'lp/lp_list.php?'.api_get_cidreq(),
     'name' => get_lang('Doc'),
 );
 // Update global setting to avoid displaying right menu.

main/lp/scormItem.class.php

Spacing +5 added lines, -5 removed lines

@@ -100,7 +100,7 @@ 
                                         }
                                         break;
                                     case 'item':
-                                        $oItem = new scormItem('manifest',$child);
+                                        $oItem = new scormItem('manifest', $child);
                                         if ($oItem->identifier != '') {
                                             $this->sub_items[$oItem->identifier] = $oItem;
                                         }
@@ -119,7 +119,7 @@ 
                         $attributes = $element->attributes;
                         //$keep_href = '';
                         foreach ($attributes as $attrib) {
-                            switch($attrib->name){
+                            switch ($attrib->name) {
                                 case 'identifier':
                                     $this->identifier = $attrib->value;
                                     break;
@@ -172,8 +172,8 @@ 
         );
         $abs_order++;
         $i = 1;
-        foreach($this->sub_items as $id => $dummy) {
-            $oSubitem =& $this->sub_items[$id];
+        foreach ($this->sub_items as $id => $dummy) {
+            $oSubitem = & $this->sub_items[$id];
             $oSubitem->get_flat_list($list, $abs_order, $i, $level + 1);
             $i++;
         }
@@ -188,7 +188,7 @@ 
         parent::save($from_outside, $prereqs_complete);
         // Under certain conditions, the scorm_contact should not be set, because no scorm signal was sent.
         $this->scorm_contact = true;
-        if (!$this->scorm_contact){
+        if (!$this->scorm_contact) {
             //error_log('New LP - was expecting SCORM message but none received', 0);
         }
     }

main/lp/lp_report.php

Spacing +2 added lines, -2 removed lines

@@ -106,7 +106,7 @@ 
 
 // View
 $interbreadcrumb[] = [
-    'url' => api_get_path(WEB_CODE_PATH) . 'lp/lp_controller.php?'.api_get_cidreq(),
+    'url' => api_get_path(WEB_CODE_PATH).'lp/lp_controller.php?'.api_get_cidreq(),
     'name' => get_lang('LearningPaths')
 ];
 
@@ -117,7 +117,7 @@ 
         array(),
         ICON_SIZE_MEDIUM
     ),
-    api_get_path(WEB_CODE_PATH) . 'lp/lp_controller.php?' . api_get_cidreq()
+    api_get_path(WEB_CODE_PATH).'lp/lp_controller.php?'.api_get_cidreq()
 );
 
 $template = new Template(get_lang('StudentScore'));

main/lp/aiccItem.class.php

Indentation +3 added lines, -3 removed lines

@@ -48,7 +48,7 @@ 
                 default:
                      //if($first_item->type == XML_ELEMENT_NODE) this is already check prior to the call to this function
                      foreach ($params as $a => $value) {
-                         switch ($a) {
+                            switch ($a) {
                             case 'system_id':
                                 $this->identifier = Database::escape_string(strtolower($value));
                                 break;
@@ -82,8 +82,8 @@ 
                             case 'web_launch':
                                 $this->parameters = Database::escape_string($value);
                                 break;
-                         }
-                     }
+                            }
+                        }
 
                     return true;
             }

Spacing +1 added lines, -1 removed lines

@@ -117,7 +117,7 @@
         $abs_order++;
         $i = 1;
         foreach ($this->sub_items as $id => $dummy) {
-            $oSubitem =& $this->sub_items[$id];
+            $oSubitem = & $this->sub_items[$id];
             $oSubitem->get_flat_list($list, $abs_order, $i, $level + 1);
             $i++;
         }

main/lp/lp_subscribe_users.php

Spacing +1 added lines, -1 removed lines

@@ -163,7 +163,7 @@
     exit;
 } else {
     $headers = [get_lang('SubscribeUsersToLp'), get_lang('SubscribeGroupsToLp')];
-    $tabs = Display::tabs($headers, [$formUsers->toHtml(),$form->toHtml()]);
+    $tabs = Display::tabs($headers, [$formUsers->toHtml(), $form->toHtml()]);
     $tpl->assign('tabs', $tabs);
 }
 

main/lp/scormOrganization.class.php

Indentation +15 added lines, -15 removed lines

@@ -38,14 +38,14 @@ 
                     //if ($first_item->type == XML_ELEMENT_NODE) this is already check prior to the call to this function.
                     $children = $element->childNodes;
                     foreach ($children as $child) {
-                         switch ($child->nodeType) {
+                            switch ($child->nodeType) {
                             case XML_ELEMENT_NODE:
                                 switch ($child->tagName) {
                                     case 'item':
                                          $oItem = new scormItem('manifest', $child);
-                                         if ($oItem->identifier != '') {
+                                            if ($oItem->identifier != '') {
                                             $this->items[$oItem->identifier] = $oItem;
-                                         }
+                                            }
                                         break;
                                     case 'metadata':
                                         $this->metadata = new scormMetadata('manifest', $child);
@@ -58,24 +58,24 @@ 
                                         break;
                                 }
                                 break;
-                             case XML_TEXT_NODE:
+                                case XML_TEXT_NODE:
                                  break;
-                         }
+                            }
                     }
 
                     if ($element->hasAttributes()) {
-                         $attributes = $element->attributes;
-                         //$keep_href = '';
-                         foreach ($attributes as $attrib) {
-                             switch ($attrib->name) {
-                                 case 'identifier':
+                            $attributes = $element->attributes;
+                            //$keep_href = '';
+                            foreach ($attributes as $attrib) {
+                                switch ($attrib->name) {
+                                    case 'identifier':
                                      $this->identifier = $attrib->value;
-                                     break;
-                                 case 'structure':
+                                        break;
+                                    case 'structure':
                                      $this->structure = $attrib->value;
-                                     break;
-                             }
-                         }
+                                        break;
+                                }
+                            }
                     }
 
                     return true;

Spacing +1 added lines, -1 removed lines

@@ -98,7 +98,7 @@
         foreach ($this->items as $id => $dummy) {
             $abs_order = 0;
             // Passes the array as a pointer so it is modified in $list directly.
-            $this->items[$id]->get_flat_list($list,$abs_order, $i, 0);
+            $this->items[$id]->get_flat_list($list, $abs_order, $i, 0);
             $i++;
         }
 

main/lp/aicc_api.php

Indentation +8 added lines, -8 removed lines

@@ -142,7 +142,7 @@ 
           <?php
             $who = addslashes(api_get_person_name($_user['firstName'], $_user['lastName']));
             echo "result='$who';";
-          ?>
+            ?>
     }else if(param == 'cmi.core.lesson_location'){
         result=lesson_location;
     }else if(param == 'cmi.core.total_time'){
@@ -198,7 +198,7 @@ 
           <?php
             $who = addslashes(api_get_person_name($_user['firstName'], $_user['lastName']));
             echo "result='$who';";
-          ?>	break;
+            ?>	break;
         case 'cmi.core.lesson_location'	:
             result='';
             break;
@@ -322,12 +322,12 @@ 
 }
 <?php
 /**
- * Chamilo-specific code that deals with event handling and inter-frames
- * messaging/refreshing.
- * Note that from now on, the Chamilo JS code in this library will act as
- * a controller, of the MVC pattern, and receive all requests for frame
- * updates, then redispatch to any frame concerned.
- */
+     * Chamilo-specific code that deals with event handling and inter-frames
+     * messaging/refreshing.
+     * Note that from now on, the Chamilo JS code in this library will act as
+     * a controller, of the MVC pattern, and receive all requests for frame
+     * updates, then redispatch to any frame concerned.
+     */
 ?>
 /**
  * Defining the AJAX-object class to be made available from other frames.

Spacing +23 added lines, -23 removed lines

@@ -78,33 +78,33 @@ 
 var commit = false ;
 
 // Strictly SCORM variables.
-var score=<?php echo $oItem->get_score();?>;
-var max=<?php echo $oItem->get_max();?>;
-var min=<?php echo $oItem->get_min();?>;
-var lesson_status='<?php echo $oItem->get_status();?>';
-var session_time='<?php echo $oItem->get_scorm_time('js');?>';
-var suspend_data = '<?php echo $oItem->get_suspend_data();?>';
-var lesson_location = '<?php echo $oItem->get_lesson_location();?>';
-var total_time = '<?php echo $oItem->get_scorm_time('js');?>';
+var score=<?php echo $oItem->get_score(); ?>;
+var max=<?php echo $oItem->get_max(); ?>;
+var min=<?php echo $oItem->get_min(); ?>;
+var lesson_status='<?php echo $oItem->get_status(); ?>';
+var session_time='<?php echo $oItem->get_scorm_time('js'); ?>';
+var suspend_data = '<?php echo $oItem->get_suspend_data(); ?>';
+var lesson_location = '<?php echo $oItem->get_lesson_location(); ?>';
+var total_time = '<?php echo $oItem->get_scorm_time('js'); ?>';
 
 // Chamilo internal variables.
 var saved_lesson_status = 'not attempted';
-var lms_lp_id = <?php echo $oLP->get_id();?>;
-var lms_item_id = <?php echo $oItem->get_id();?>;
+var lms_lp_id = <?php echo $oLP->get_id(); ?>;
+var lms_item_id = <?php echo $oItem->get_id(); ?>;
 //var lms_new_item_id = 0; //temporary value (only there between a load_item() and a LMSInitialize())
 var lms_been_synchronized = 0;
 var lms_initialized = 0;
 var lms_total_lessons = <?php echo $oLP->get_total_items_count(); ?>;
-var lms_complete_lessons = <?php echo $oLP->get_complete_items_count();?>;
-var lms_progress_bar_mode = '<?php echo $oLP->progress_bar_mode;?>';
+var lms_complete_lessons = <?php echo $oLP->get_complete_items_count(); ?>;
+var lms_progress_bar_mode = '<?php echo $oLP->progress_bar_mode; ?>';
 if(lms_progress_bar_mode == ''){lms_progress_bar_mode='%';}
-var lms_view_id = '<?php echo $oLP->get_view();?>';
+var lms_view_id = '<?php echo $oLP->get_view(); ?>';
 if(lms_view_id == ''){ lms_view_id = 1;}
-var lms_user_id = '<?php echo $_user['user_id'];?>';
-var lms_next_item = '<?php echo $oLP->get_next_item_id();?>';
-var lms_previous_item = '<?php echo $oLP->get_previous_item_id();?>';
-var lms_lp_type = '<?php echo $oLP->get_type();?>';
-var lms_item_type = '<?php echo $oItem->get_type();?>';
+var lms_user_id = '<?php echo $_user['user_id']; ?>';
+var lms_next_item = '<?php echo $oLP->get_next_item_id(); ?>';
+var lms_previous_item = '<?php echo $oLP->get_previous_item_id(); ?>';
+var lms_lp_type = '<?php echo $oLP->get_type(); ?>';
+var lms_item_type = '<?php echo $oItem->get_type(); ?>';
 
 // Backup for old values.
 var old_score = 0;
@@ -162,11 +162,11 @@ 
     }else if(param == 'cmi.core.lesson_mode'){
         result='normal';
     }else if(param == 'cmi.suspend_data'){
-        result='<?php echo $oItem->get_suspend_data();?>';
+        result='<?php echo $oItem->get_suspend_data(); ?>';
     }else if(param == 'cmi.launch_data'){
         result='';
     }else if(param == 'cmi.objectives._count'){
-        result='<?php echo $oItem->get_view_count();?>';
+        result='<?php echo $oItem->get_view_count(); ?>';
     }
     /*
     // Switch not working??? WTF???
@@ -227,13 +227,13 @@ 
             result='normal';
             break;
         case 'cmi.suspend_data'		:
-            result='<?php echo $oItem->get_suspend_data();?>';
+            result='<?php echo $oItem->get_suspend_data(); ?>';
             break;
         case 'cmi.launch_data'		:
             result='';
             break;
         case 'cmi.objectives._count':
-            result='<?php echo $oItem->get_view_count();?>';
+            result='<?php echo $oItem->get_view_count(); ?>';
             break;
         default 					:
             result='';
@@ -285,7 +285,7 @@ 
     $url = $_SERVER['HTTP_HOST'].$self;
     $url = substr($url, 0, -14); // 14 is the length of this file's name (/scorm_api.php).
     echo $url;
-    ?>/lp_controller.php?<?php echo api_get_cidreq(); ?>&action=save&lp_id=<?php echo $oLP->get_id();?>&" + param + "";
+    ?>/lp_controller.php?<?php echo api_get_cidreq(); ?>&action=save&lp_id=<?php echo $oLP->get_id(); ?>&" + param + "";
     logit_lms('saving data (status='+lesson_status+')',1);
     xajax_save_item(lms_lp_id, lms_user_id, lms_view_id, lms_item_id, score, max, min, lesson_status, session_time, suspend_data, lesson_location);
     //xajax_update_pgs();

main/lp/scormMetadata.class.php

Indentation +47 added lines, -47 removed lines

@@ -39,60 +39,60 @@
                 case 'manifest': // Do the same as the default.
                      $children = $element->childNodes;
                     foreach ($children as $child) {
-                         switch ($child->nodeType) {
-                             case XML_ELEMENT_NODE:
+                            switch ($child->nodeType) {
+                                case XML_ELEMENT_NODE:
                                 // Could be 'lom', 'schema', 'schemaversion' or 'location'.
                                  switch ($child->tagName) {
-                                     case 'lom':
+                                        case 'lom':
                                          $childchildren = $child->childNodes;
-                                         foreach ($childchildren as $childchild) {
-                                             $this->lom = $childchild->nodeValue;
-                                         }
-                                         break;
-                                     case 'schema':
+                                            foreach ($childchildren as $childchild) {
+                                                $this->lom = $childchild->nodeValue;
+                                            }
+                                            break;
+                                        case 'schema':
                                          $childchildren = $child->childNodes;
-                                         foreach ($childchildren as $childchild) {
-                                             // There is generally only one child here.
-                                             $this->schema = $childchild->nodeValue;
-                                         }
-                                         break;
-                                     case 'schemaversion':
+                                            foreach ($childchildren as $childchild) {
+                                                // There is generally only one child here.
+                                                $this->schema = $childchild->nodeValue;
+                                            }
+                                            break;
+                                        case 'schemaversion':
                                          $childchildren = $child->childNodes;
-                                         foreach ($childchildren as $childchild) {
-                                             // There is generally only one child here.
-                                             $this->schemaversion = $childchild->nodeValue;
-                                         }
-                                         break;
-                                     case 'location':
+                                            foreach ($childchildren as $childchild) {
+                                                // There is generally only one child here.
+                                                $this->schemaversion = $childchild->nodeValue;
+                                            }
+                                            break;
+                                        case 'location':
                                          $childchildren = $child->childNodes;
-                                         foreach ($childchildren as $childchild) {
-                                             // There is generally only one child here.
-                                             $this->location = $childchild->nodeValue;
-                                         }
-                                         break;
-                                 }
-                                 break;
-                             case XML_TEXT_NODE:
+                                            foreach ($childchildren as $childchild) {
+                                                // There is generally only one child here.
+                                                $this->location = $childchild->nodeValue;
+                                            }
+                                            break;
+                                    }
+                                    break;
+                                case XML_TEXT_NODE:
                                  if (trim($child->textContent) != '') {
-                                     if (count($children == 1)) {
-                                         // If this is the only child at this level and it is a content... save differently.
-                                         $this->text = $child->textContent;
-                                     } else {
-                                         $this->text[$element->tagName] = $child->textContent;
-                                     }
-                                 }
-                                 break;
-                         }
-                     }
-                     $attributes = $element->attributes;
-                     //$keep_href = '';
-                     if (is_array($attributes)) {
-                         foreach ($attributes as $attrib) {
-                             if (trim($attrib->value) != ''){
-                                 $this->attribs[$attrib->name] = $attrib->value;
-                             }
-                         }
-                     }
+                                        if (count($children == 1)) {
+                                            // If this is the only child at this level and it is a content... save differently.
+                                            $this->text = $child->textContent;
+                                        } else {
+                                            $this->text[$element->tagName] = $child->textContent;
+                                        }
+                                    }
+                                    break;
+                            }
+                        }
+                        $attributes = $element->attributes;
+                        //$keep_href = '';
+                        if (is_array($attributes)) {
+                            foreach ($attributes as $attrib) {
+                                if (trim($attrib->value) != ''){
+                                    $this->attribs[$attrib->name] = $attrib->value;
+                                }
+                            }
+                        }
                     return true;
                     //break;
             }

Spacing +1 added lines, -1 removed lines

@@ -88,7 +88,7 @@
                      //$keep_href = '';
                      if (is_array($attributes)) {
                          foreach ($attributes as $attrib) {
-                             if (trim($attrib->value) != ''){
+                             if (trim($attrib->value) != '') {
                                  $this->attribs[$attrib->name] = $attrib->value;
                              }
                          }