| Conditions | 1 |
| Paths | 1 |
| Total Lines | 58 |
| Code Lines | 41 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 47 | public function buildForm(FormBuilderInterface $builder): void |
||
| 48 | { |
||
| 49 | // admin → workflows |
||
| 50 | $builder |
||
| 51 | ->add('plugin_redirection_enabled', YesNoType::class) |
||
| 52 | ->add('usergroup_do_not_unsubscribe_users_from_course_nor_session_on_user_unsubscribe', YesNoType::class) |
||
| 53 | ->add('usergroup_do_not_unsubscribe_users_from_course_on_course_unsubscribe', YesNoType::class) |
||
| 54 | ->add('usergroup_do_not_unsubscribe_users_from_session_on_session_unsubscribe', YesNoType::class) |
||
| 55 | ->add('drh_allow_access_to_all_students', YesNoType::class) |
||
| 56 | ->add('send_all_emails_to', TextareaType::class, [ |
||
| 57 | 'attr' => ['rows' => 5, 'style' => 'font-family: monospace;'], |
||
| 58 | ]) |
||
| 59 | ->add('go_to_course_after_login', YesNoType::class) |
||
| 60 | ->add('allow_users_to_create_courses', YesNoType::class) |
||
| 61 | ->add('allow_user_course_subscription_by_course_admin', YesNoType::class) |
||
| 62 | ->add('teacher_can_select_course_template', YesNoType::class) |
||
| 63 | ->add('disabled_edit_session_coaches_course_editing_course', YesNoType::class) |
||
| 64 | ->add('course_visibility_change_only_admin', YesNoType::class) |
||
| 65 | ->add('multiple_url_hide_disabled_settings', YesNoType::class) |
||
| 66 | ->add('gamification_mode', TextType::class) |
||
| 67 | ->add( |
||
| 68 | 'load_term_conditions_section', |
||
| 69 | ChoiceType::class, |
||
| 70 | [ |
||
| 71 | 'choices' => [ |
||
| 72 | 'Login' => 'login', |
||
| 73 | 'Course' => 'course', |
||
| 74 | ], |
||
| 75 | ] |
||
| 76 | ) |
||
| 77 | ->add('update_student_expiration_x_date', TextareaType::class) |
||
| 78 | ->add('user_number_of_days_for_default_expiration_date_per_role', TextareaType::class) |
||
| 79 | ->add('user_edition_extra_field_to_check', TextType::class) |
||
| 80 | ->add('allow_working_time_edition', YesNoType::class) |
||
| 81 | ->add('disable_user_conditions_sender_id', TextType::class) |
||
| 82 | ->add('redirect_index_to_url_for_logged_users', TextType::class) |
||
| 83 | ->add( |
||
| 84 | 'default_menu_entry_for_course_or_session', |
||
| 85 | ChoiceType::class, |
||
| 86 | [ |
||
| 87 | 'choices' => [ |
||
| 88 | 'My courses' => 'my_courses', |
||
| 89 | 'My sessions' => 'my_sessions', |
||
| 90 | ], |
||
| 91 | ] |
||
| 92 | ) |
||
| 93 | ->add( |
||
| 94 | 'session_admin_user_subscription_search_extra_field_to_search', |
||
| 95 | TextType::class, |
||
| 96 | [ |
||
| 97 | 'required' => false, |
||
| 98 | 'empty_data' => '', |
||
| 99 | 'help' => 'User extra field key to use when searching and naming sessions from /admin-dashboard/register.', |
||
| 100 | ] |
||
| 101 | ) |
||
| 102 | ; |
||
| 103 | |||
| 104 | $this->updateFormFieldsFromSettingsInfo($builder); |
||
| 105 | } |
||
| 107 |