GroupRepository::createDefaultGroups() - Code Metrics - Inspection of "Fix installation, centralize languages definition,..." - chamilo/chamilo-lms - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( bb15d1...ce9f14 )

by Julito

created 2021-06-15 13:23 UTC

GroupRepository::createDefaultGroups() A

↳ Parent: GroupRepository

Complexity

Conditions	5
Paths	6

Size

Total Lines	67
Code Lines	38

Duplication

Lines	0
Ratio	0 %

Importance

Changes	3
Bugs	0	Features	0

Metric	Value
cc	5
eloc	38
c	3
b	0
f	0
nc	6
nop	1
dl	0
loc	67
rs	9.0008

How to fix Long Method

<?php

declare(strict_types=1);

/* For licensing terms, see /license.txt */

namespace Chamilo\CoreBundle\Repository;

use Chamilo\CoreBundle\DataFixtures\AccessGroupFixtures;
use Chamilo\CoreBundle\Entity\Group;
use Chamilo\CoreBundle\Entity\User;
use Doctrine\Bundle\DoctrineBundle\Repository\ServiceEntityRepository;
use Doctrine\Persistence\ManagerRegistry;

class GroupRepository extends ServiceEntityRepository
{
    public function __construct(ManagerRegistry $registry)
    {
        parent::__construct($registry, Group::class);
    }

    /**
     * @return User[]
     */
    public function getAdmins()
    {
        $criteria = [
            'name' => 'admins',
        ];

        /** @var Group $group */
        $group = $this->findOneBy($criteria);

        return $group->getUsers();
    }

    public function createDefaultGroups(AccessGroupFixtures $accessGroupFixtures = null): void
    {
        $groups = [
            [
                'code' => 'ADMIN',
                'title' => 'Administrators',
                'roles' => ['ROLE_ADMIN'],
            ],
            [
                'code' => 'STUDENT',
                'title' => 'Students',
                'roles' => ['ROLE_STUDENT'],
            ],
            [
                'code' => 'TEACHER',
                'title' => 'Teachers',
                'roles' => ['ROLE_TEACHER'],
            ],
            [
                'code' => 'RRHH',
                'title' => 'Human resources manager',
                'roles' => ['ROLE_RRHH'],
            ],
            [
                'code' => 'SESSION_MANAGER',
                'title' => 'Session',
                'roles' => ['ROLE_SESSION_MANAGER'],
            ],
            [
                'code' => 'QUESTION_MANAGER',
                'title' => 'Question manager',
                'roles' => ['ROLE_QUESTION_MANAGER'],
            ],
            [
                'code' => 'STUDENT_BOSS',
                'title' => 'Student boss',
                'roles' => ['ROLE_STUDENT_BOSS'],
            ],
            [
                'code' => 'INVITEE',
                'title' => 'Invitee',
                'roles' => ['ROLE_INVITEE'],
            ],
        ];

        $manager = $this->getEntityManager();

        foreach ($groups as $groupData) {
            $groupExists = $this->findOneBy(['code' => $groupData['code']]);
            if (null === $groupExists) {
                $group = new Group($groupData['title']);
                $group
                    ->setCode($groupData['code'])
                ;

                foreach ($groupData['roles'] as $role) {
                    $group->addRole($role);
                }
                $manager->persist($group);

                if (null !== $accessGroupFixtures) {
                    $accessGroupFixtures->addReference('GROUP_'.$groupData['code'], $group);
                }
            }
        }

        $manager->flush();
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			/* For licensing terms, see /license.txt */
6
7			namespace Chamilo\CoreBundle\Repository;
8
9			use Chamilo\CoreBundle\DataFixtures\AccessGroupFixtures;
10			use Chamilo\CoreBundle\Entity\Group;
11			use Chamilo\CoreBundle\Entity\User;
12			use Doctrine\Bundle\DoctrineBundle\Repository\ServiceEntityRepository;
13			use Doctrine\Persistence\ManagerRegistry;
14
15			class GroupRepository extends ServiceEntityRepository
16			{
17			public function __construct(ManagerRegistry $registry)
18			{
19			parent::__construct($registry, Group::class);
20			}
21
22			/**
23			* @return User[]
24			*/
25			public function getAdmins()
26			{
27			$criteria = [
28			'name' => 'admins',
29			];
30
31			/** @var Group $group */
32			$group = $this->findOneBy($criteria);
33
34			return $group->getUsers();
35			}
36
37			public function createDefaultGroups(AccessGroupFixtures $accessGroupFixtures = null): void
38			{
39			$groups = [
40			[
41			'code' => 'ADMIN',
42			'title' => 'Administrators',
43			'roles' => ['ROLE_ADMIN'],
44			],
45			[
46			'code' => 'STUDENT',
47			'title' => 'Students',
48			'roles' => ['ROLE_STUDENT'],
49			],
50			[
51			'code' => 'TEACHER',
52			'title' => 'Teachers',
53			'roles' => ['ROLE_TEACHER'],
54			],
55			[
56			'code' => 'RRHH',
57			'title' => 'Human resources manager',
58			'roles' => ['ROLE_RRHH'],
59			],
60			[
61			'code' => 'SESSION_MANAGER',
62			'title' => 'Session',
63			'roles' => ['ROLE_SESSION_MANAGER'],
64			],
65			[
66			'code' => 'QUESTION_MANAGER',
67			'title' => 'Question manager',
68			'roles' => ['ROLE_QUESTION_MANAGER'],
69			],
70			[
71			'code' => 'STUDENT_BOSS',
72			'title' => 'Student boss',
73			'roles' => ['ROLE_STUDENT_BOSS'],
74			],
75			[
76			'code' => 'INVITEE',
77			'title' => 'Invitee',
78			'roles' => ['ROLE_INVITEE'],
79			],
80			];
81
82			$manager = $this->getEntityManager();
83
84			foreach ($groups as $groupData) {
85			$groupExists = $this->findOneBy(['code' => $groupData['code']]);
86			if (null === $groupExists) {
87			$group = new Group($groupData['title']);
88			$group
89			->setCode($groupData['code'])
90			;
91
92			foreach ($groupData['roles'] as $role) {
93			$group->addRole($role);
94			}
95			$manager->persist($group);
96
97			if (null !== $accessGroupFixtures) {
98			$accessGroupFixtures->addReference('GROUP_'.$groupData['code'], $group);
99			}
100			}
101			}
102
103			$manager->flush();
104			}
105			}
106

chamilo / chamilo-lms

Push — master ( bb15d1...ce9f14 )

GroupRepository::createDefaultGroups() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like