chamilo /
chamilo-lms
| Conditions | 1 |
| Paths | 1 |
| Total Lines | 74 |
| Code Lines | 55 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 2 | ||
| Bugs | 1 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 30 | public function load(ObjectManager $manager): void |
||
| 31 | { |
||
| 32 | $timezone = 'Europe\Paris'; |
||
| 33 | $container = $this->container; |
||
| 34 | $toolChain = $container->get(ToolChain::class); |
||
| 35 | $toolChain->createTools(); |
||
| 36 | |||
| 37 | // Defined in AccessGroupFixtures.php. |
||
| 38 | // $group = $this->getReference('GROUP_ADMIN'); |
||
| 39 | |||
| 40 | $admin = (new User()) |
||
| 41 | ->setSkipResourceNode(true) |
||
| 42 | ->setLastname('Doe') |
||
| 43 | ->setFirstname('Joe') |
||
| 44 | ->setUsername('admin') |
||
| 45 | ->setStatus(1) |
||
| 46 | ->setPlainPassword('admin') |
||
| 47 | ->setEmail('[email protected]') |
||
| 48 | ->setOfficialCode('ADMIN') |
||
| 49 | ->setCreatorId(1) |
||
| 50 | ->setTimezone($timezone) |
||
| 51 | ->addUserAsAdmin() |
||
| 52 | ->addRole('ROLE_GLOBAL_ADMIN') // Only for the first user |
||
| 53 | // ->addGroup($group) |
||
| 54 | ; |
||
| 55 | |||
| 56 | $manager->persist($admin); |
||
| 57 | |||
| 58 | /** @var UserRepository $userRepo */ |
||
| 59 | $userRepo = $container->get(UserRepository::class); |
||
| 60 | $userRepo->updateUser($admin); |
||
| 61 | |||
| 62 | $anon = (new User()) |
||
| 63 | ->setSkipResourceNode(true) |
||
| 64 | ->setLastname('Joe') |
||
| 65 | ->setFirstname('Anonymous') |
||
| 66 | ->setUsername('anon') |
||
| 67 | ->setStatus(ANONYMOUS) |
||
| 68 | ->setPlainPassword('anon') |
||
| 69 | ->setEmail('anonymous@localhost') |
||
| 70 | ->setOfficialCode('anonymous') |
||
| 71 | ->setCreatorId(1) |
||
| 72 | ->setTimezone($timezone) |
||
| 73 | ; |
||
| 74 | $manager->persist($anon); |
||
| 75 | |||
| 76 | $fallbackUser = new User(); |
||
| 77 | $fallbackUser |
||
| 78 | ->setSkipResourceNode(true) |
||
| 79 | ->setUsername('fallback_user') |
||
| 80 | ->setEmail('[email protected]') |
||
| 81 | ->setPlainPassword('fallback_user') |
||
| 82 | ->setStatus(User::ROLE_FALLBACK) |
||
| 83 | ->setLastname('Fallback') |
||
| 84 | ->setFirstname('User') |
||
| 85 | ->setCreatorId(1) |
||
| 86 | ->setOfficialCode('FALLBACK') |
||
| 87 | ->setAuthSource(PLATFORM_AUTH_SOURCE) |
||
| 88 | ->setPhone('0000000000') |
||
| 89 | ->setTimezone($timezone) |
||
| 90 | ->setActive(USER_SOFT_DELETED) |
||
| 91 | ; |
||
| 92 | $manager->persist($fallbackUser); |
||
| 93 | |||
| 94 | $manager->flush(); |
||
| 95 | |||
| 96 | $userRepo->addUserToResourceNode($admin->getId(), $admin->getId()); |
||
| 97 | $userRepo->addUserToResourceNode($anon->getId(), $admin->getId()); |
||
| 98 | $userRepo->addUserToResourceNode($fallbackUser->getId(), $admin->getId()); |
||
| 99 | |||
| 100 | $manager->flush(); |
||
| 101 | |||
| 102 | $this->addReference(self::ADMIN_USER_REFERENCE, $admin); |
||
| 103 | $this->addReference(self::ANON_USER_REFERENCE, $anon); |
||
| 104 | } |
||
| 106 |
