SecurityController::loginJson() - Code Metrics - Inspection of "Merge pull request #5621 from christianbeeznest/of..." - chamilo/chamilo-lms - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( df6980...5d597b )

unknown

created 2024-06-30 23:59 UTC

SecurityController::loginJson() C

↳ Parent: SecurityController

Complexity

Conditions	12
Paths	12

Size

Total Lines	78
Code Lines	48

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	12
eloc	48
c	0
b	0
f	0
nc	12
nop	5
dl	0
loc	78
rs	6.9666

How to fix Long Method Complexity

<?php

declare(strict_types=1);

/* For licensing terms, see /license.txt */

namespace Chamilo\CoreBundle\Controller;

use Chamilo\CoreBundle\Entity\ExtraFieldValues;
use Chamilo\CoreBundle\Entity\Legal;
use Chamilo\CoreBundle\Repository\TrackELoginRecordRepository;
use Chamilo\CoreBundle\ServiceHelper\UserHelper;
use Chamilo\CoreBundle\Settings\SettingsManager;
use DateTime;
use Doctrine\ORM\EntityManager;
use Doctrine\ORM\EntityManagerInterface;
use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
use Symfony\Component\HttpFoundation\JsonResponse;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\Routing\Attribute\Route;
use Symfony\Component\Security\Core\Authentication\Token\Storage\TokenStorageInterface;
use Symfony\Component\Security\Core\Authorization\AuthorizationCheckerInterface;
use Symfony\Component\Serializer\SerializerInterface;
use Symfony\Contracts\Translation\TranslatorInterface;

class SecurityController extends AbstractController
{
    public function __construct(
        private SerializerInterface $serializer,
        private TrackELoginRecordRepository $trackELoginRecordRepository,
        private EntityManagerInterface $entityManager,
        private SettingsManager $settingsManager,
        private TokenStorageInterface $tokenStorage,
        private AuthorizationCheckerInterface $authorizationChecker,
        private readonly UserHelper $userHelper,
    ) {}

    #[Route('/login_json', name: 'login_json', methods: ['POST'])]
    public function loginJson(Request $request, EntityManager $entityManager, SettingsManager $settingsManager, TokenStorageInterface $tokenStorage, TranslatorInterface $translator): Response
    {
        if (!$this->isGranted('IS_AUTHENTICATED_FULLY')) {
            return $this->json(
                [
                    'error' => 'Invalid login request: check that the Content-Type header is "application/json".',
                ],
                400
            );
        }

        $user = $this->userHelper->getCurrent();

        if (1 !== $user->getActive()) {
            if (0 === $user->getActive()) {
                $message = $translator->trans('Account not activated.');
            } else {
                $message = $translator->trans('Invalid credentials. Please try again or contact support if you continue to experience issues.');
            }

            $tokenStorage->setToken(null);
            $request->getSession()->invalidate();

            return $this->json(['error' => $message], 401);
        }

        if (null !== $user->getExpirationDate() && $user->getExpirationDate() <= new DateTime()) {
            $message = $translator->trans('Your account has expired.');

            $tokenStorage->setToken(null);
            $request->getSession()->invalidate();

            return $this->json(['error' => $message], 401);
        }

        $extraFieldValuesRepository = $this->entityManager->getRepository(ExtraFieldValues::class);
        $legalTermsRepo = $this->entityManager->getRepository(Legal::class);
        if ($user->hasRole('ROLE_STUDENT')
            && 'true' === $this->settingsManager->getSetting('allow_terms_conditions')
            && 'login' === $this->settingsManager->getSetting('load_term_conditions_section')
        ) {
            $termAndConditionStatus = false;
            $extraValue = $extraFieldValuesRepository->findLegalAcceptByItemId($user->getId());
            if (!empty($extraValue['value'])) {
                $result = $extraValue['value'];
                $userConditions = explode(':', $result);
                $version = $userConditions[0];
                $langId = (int) $userConditions[1];
                $realVersion = $legalTermsRepo->getLastVersion($langId);
                $termAndConditionStatus = ($version >= $realVersion);
            }

            if (false === $termAndConditionStatus) {
                $tempTermAndCondition = ['user_id' => $user->getId()];

                $this->tokenStorage->setToken(null);
                $request->getSession()->invalidate();

                $request->getSession()->start();
                $request->getSession()->set('term_and_condition', $tempTermAndCondition);

                $responseData = [
                    'redirect' => '/main/auth/inscription.php',
                    'load_terms' => true,
                ];

                return new JsonResponse($responseData, Response::HTTP_OK);
            }
            $request->getSession()->remove('term_and_condition');
        }

        $data = null;
        if ($user) {
            $data = $this->serializer->serialize($user, 'jsonld', ['groups' => ['user_json:read']]);
        }

        return new JsonResponse($data, Response::HTTP_OK, [], true);
    }

    #[Route('/check-session', name: 'check_session', methods: ['GET'])]
    public function checkSession(): JsonResponse
    {
        if ($this->authorizationChecker->isGranted('IS_AUTHENTICATED_FULLY')) {
            return new JsonResponse(['isAuthenticated' => true]);
        }

        return new JsonResponse(['isAuthenticated' => false]);
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			/* For licensing terms, see /license.txt */
6
7			namespace Chamilo\CoreBundle\Controller;
8
9			use Chamilo\CoreBundle\Entity\ExtraFieldValues;
10			use Chamilo\CoreBundle\Entity\Legal;
11			use Chamilo\CoreBundle\Repository\TrackELoginRecordRepository;
12			use Chamilo\CoreBundle\ServiceHelper\UserHelper;
13			use Chamilo\CoreBundle\Settings\SettingsManager;
14			use DateTime;
15			use Doctrine\ORM\EntityManager;
16			use Doctrine\ORM\EntityManagerInterface;
17			use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
18			use Symfony\Component\HttpFoundation\JsonResponse;
19			use Symfony\Component\HttpFoundation\Request;
20			use Symfony\Component\HttpFoundation\Response;
21			use Symfony\Component\Routing\Attribute\Route;
22			use Symfony\Component\Security\Core\Authentication\Token\Storage\TokenStorageInterface;
23			use Symfony\Component\Security\Core\Authorization\AuthorizationCheckerInterface;
24			use Symfony\Component\Serializer\SerializerInterface;
25			use Symfony\Contracts\Translation\TranslatorInterface;
26
27			class SecurityController extends AbstractController
28			{
29			public function __construct(
30			private SerializerInterface $serializer,
31			private TrackELoginRecordRepository $trackELoginRecordRepository,
32			private EntityManagerInterface $entityManager,
33			private SettingsManager $settingsManager,
34			private TokenStorageInterface $tokenStorage,
35			private AuthorizationCheckerInterface $authorizationChecker,
36			private readonly UserHelper $userHelper,
37			) {}
38
39			#[Route('/login_json', name: 'login_json', methods: ['POST'])]
40			public function loginJson(Request $request, EntityManager $entityManager, SettingsManager $settingsManager, TokenStorageInterface $tokenStorage, TranslatorInterface $translator): Response
41			{
42			if (!$this->isGranted('IS_AUTHENTICATED_FULLY')) {
43			return $this->json(
44			[
45			'error' => 'Invalid login request: check that the Content-Type header is "application/json".',
46			],
47			400
48			);
49			}
50
51			$user = $this->userHelper->getCurrent();
52
53			if (1 !== $user->getActive()) {
54			if (0 === $user->getActive()) {
55			$message = $translator->trans('Account not activated.');
56			} else {
57			$message = $translator->trans('Invalid credentials. Please try again or contact support if you continue to experience issues.');
58			}
59
60			$tokenStorage->setToken(null);
61			$request->getSession()->invalidate();
62
63			return $this->json(['error' => $message], 401);
64			}
65
66			if (null !== $user->getExpirationDate() && $user->getExpirationDate() <= new DateTime()) {
67			$message = $translator->trans('Your account has expired.');
68
69			$tokenStorage->setToken(null);
70			$request->getSession()->invalidate();
71
72			return $this->json(['error' => $message], 401);
73			}
74
75			$extraFieldValuesRepository = $this->entityManager->getRepository(ExtraFieldValues::class);
76			$legalTermsRepo = $this->entityManager->getRepository(Legal::class);
77			if ($user->hasRole('ROLE_STUDENT')
78			&& 'true' === $this->settingsManager->getSetting('allow_terms_conditions')
79			&& 'login' === $this->settingsManager->getSetting('load_term_conditions_section')
80			) {
81			$termAndConditionStatus = false;
82			$extraValue = $extraFieldValuesRepository->findLegalAcceptByItemId($user->getId());
83			if (!empty($extraValue['value'])) {
84			$result = $extraValue['value'];
85			$userConditions = explode(':', $result);
86			$version = $userConditions[0];
87			$langId = (int) $userConditions[1];
88			$realVersion = $legalTermsRepo->getLastVersion($langId);
89			$termAndConditionStatus = ($version >= $realVersion);
90			}
91
92			if (false === $termAndConditionStatus) {
93			$tempTermAndCondition = ['user_id' => $user->getId()];
94
95			$this->tokenStorage->setToken(null);
96			$request->getSession()->invalidate();
97
98			$request->getSession()->start();
99			$request->getSession()->set('term_and_condition', $tempTermAndCondition);
100
101			$responseData = [
102			'redirect' => '/main/auth/inscription.php',
103			'load_terms' => true,
104			];
105
106			return new JsonResponse($responseData, Response::HTTP_OK);
107			}
108			$request->getSession()->remove('term_and_condition');
109			}
110
111			$data = null;
112			if ($user) {
113			$data = $this->serializer->serialize($user, 'jsonld', ['groups' => ['user_json:read']]);
114			}
115
116			return new JsonResponse($data, Response::HTTP_OK, [], true);
117			}
118
119			#[Route('/check-session', name: 'check_session', methods: ['GET'])]
120			public function checkSession(): JsonResponse
121			{
122			if ($this->authorizationChecker->isGranted('IS_AUTHENTICATED_FULLY')) {
123			return new JsonResponse(['isAuthenticated' => true]);
124			}
125
126			return new JsonResponse(['isAuthenticated' => false]);
127			}
128			}
129

chamilo / chamilo-lms

Push — master ( df6980...5d597b )

SecurityController::loginJson() C

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like