| Conditions | 17 |
| Paths | 481 |
| Total Lines | 139 |
| Code Lines | 82 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 2 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 35 | public function up(Schema $schema): void |
||
| 36 | { |
||
| 37 | $container = $this->getContainer(); |
||
| 38 | $doctrine = $container->get('doctrine'); |
||
| 39 | $em = $doctrine->getManager(); |
||
| 40 | /** @var Connection $connection */ |
||
| 41 | $connection = $em->getConnection(); |
||
| 42 | |||
| 43 | $quizRepo = $container->get(CQuizRepository::class); |
||
| 44 | $quizQuestionRepo = $container->get(CQuizQuestionRepository::class); |
||
| 45 | $quizQuestionCategoryRepo = $container->get(CQuizQuestionCategoryRepository::class); |
||
| 46 | |||
| 47 | $documentRepo = $container->get(CDocumentRepository::class); |
||
| 48 | $courseRepo = $container->get(CourseRepository::class); |
||
| 49 | $sessionRepo = $container->get(SessionRepository::class); |
||
| 50 | $groupRepo = $container->get(CGroupRepository::class); |
||
| 51 | $userRepo = $container->get(UserRepository::class); |
||
| 52 | |||
| 53 | $admin = $this->getAdmin(); |
||
| 54 | |||
| 55 | $q = $em->createQuery('SELECT c FROM Chamilo\CoreBundle\Entity\Course c'); |
||
| 56 | /** @var Course $course */ |
||
| 57 | foreach ($q->toIterable() as $course) { |
||
| 58 | $courseId = $course->getId(); |
||
| 59 | $course = $courseRepo->find($courseId); |
||
| 60 | $courseRelUserList = $course->getTeachers(); |
||
| 61 | $courseAdmin = null; |
||
| 62 | if (!empty($courseRelUserList)) { |
||
| 63 | foreach ($courseRelUserList as $courseRelUser) { |
||
| 64 | $courseAdmin = $courseRelUser->getUser(); |
||
| 65 | break; |
||
| 66 | } |
||
| 67 | } |
||
| 68 | |||
| 69 | if (null === $courseAdmin) { |
||
| 70 | $courseAdmin = $admin; |
||
| 71 | } |
||
| 72 | |||
| 73 | // Quiz |
||
| 74 | $sql = "SELECT * FROM c_quiz WHERE c_id = $courseId |
||
| 75 | ORDER BY iid"; |
||
| 76 | $result = $connection->executeQuery($sql); |
||
| 77 | $items = $result->fetchAllAssociative(); |
||
| 78 | foreach ($items as $itemData) { |
||
| 79 | $id = $itemData['iid']; |
||
| 80 | /** @var CQuiz $resource */ |
||
| 81 | $resource = $quizRepo->find($id); |
||
| 82 | if ($resource->hasResourceNode()) { |
||
| 83 | continue; |
||
| 84 | } |
||
| 85 | $result = $this->fixItemProperty( |
||
| 86 | 'quiz', |
||
| 87 | $quizRepo, |
||
| 88 | $course, |
||
| 89 | $courseAdmin, |
||
| 90 | $resource, |
||
| 91 | $course |
||
| 92 | ); |
||
| 93 | if (false === $result) { |
||
| 94 | continue; |
||
| 95 | } |
||
| 96 | |||
| 97 | $em->persist($resource); |
||
| 98 | $em->flush(); |
||
| 99 | |||
| 100 | /*$sql = "SELECT q.* FROM c_quiz_question q |
||
| 101 | INNER JOIN c_quiz_rel_question cq |
||
| 102 | ON (q.iid = cq.exercice_id and q.c_id = cq.c_id) |
||
| 103 | WHERE q.c_id = $courseId AND exercice_id = $id |
||
| 104 | ORDER BY iid"; |
||
| 105 | $result = $connection->executeQuery($sql); |
||
| 106 | $questions = $result->fetchAllAssociative(); |
||
| 107 | foreach ($questions as $questionData) { |
||
| 108 | $questionData['']; |
||
| 109 | } |
||
| 110 | $sql = "SELECT * FROM c_quiz_question WHERE c_id = $courseId |
||
| 111 | ORDER BY iid"; |
||
| 112 | $result = $connection->executeQuery($sql); |
||
| 113 | $items = $result->fetchAllAssociative(); |
||
| 114 | foreach ($items as $itemData) { |
||
| 115 | }*/ |
||
| 116 | } |
||
| 117 | |||
| 118 | // Question categories |
||
| 119 | $sql = "SELECT * FROM c_quiz_question_category WHERE c_id = $courseId |
||
| 120 | ORDER BY iid"; |
||
| 121 | $result = $connection->executeQuery($sql); |
||
| 122 | $items = $result->fetchAllAssociative(); |
||
| 123 | foreach ($items as $itemData) { |
||
| 124 | $id = $itemData['iid']; |
||
| 125 | /** @var CQuizQuestionCategory $resource */ |
||
| 126 | $resource = $quizQuestionCategoryRepo->find($id); |
||
| 127 | if ($resource->hasResourceNode()) { |
||
| 128 | continue; |
||
| 129 | } |
||
| 130 | $result = $this->fixItemProperty( |
||
| 131 | 'test_category', |
||
| 132 | $quizQuestionCategoryRepo, |
||
| 133 | $course, |
||
| 134 | $courseAdmin, |
||
| 135 | $resource, |
||
| 136 | $course |
||
| 137 | ); |
||
| 138 | if (false === $result) { |
||
| 139 | continue; |
||
| 140 | } |
||
| 141 | |||
| 142 | $em->persist($resource); |
||
| 143 | $em->flush(); |
||
| 144 | } |
||
| 145 | |||
| 146 | $sql = "SELECT * FROM c_quiz_question WHERE c_id = $courseId |
||
| 147 | ORDER BY iid"; |
||
| 148 | $result = $connection->executeQuery($sql); |
||
| 149 | $items = $result->fetchAllAssociative(); |
||
| 150 | foreach ($items as $itemData) { |
||
| 151 | $id = $itemData['iid']; |
||
| 152 | /** @var CQuizQuestion $resource */ |
||
| 153 | $resource = $quizQuestionRepo->find($id); |
||
| 154 | if ($resource->hasResourceNode()) { |
||
| 155 | continue; |
||
| 156 | } |
||
| 157 | |||
| 158 | $resourceNode = $quizQuestionRepo->addResourceNode($resource, $courseAdmin, $course); |
||
| 159 | $resource->addCourseLink($course, null, null, ResourceLink::VISIBILITY_PUBLISHED); |
||
| 160 | $em->persist($resourceNode); |
||
| 161 | |||
| 162 | $pictureId = $resource->getPicture(); |
||
| 163 | if (!empty($pictureId)) { |
||
| 164 | /** @var CDocument $document */ |
||
| 165 | $document = $documentRepo->find($pictureId); |
||
| 166 | if ($document && $document->hasResourceNode() && $document->getResourceNode()->hasResourceFile()) { |
||
| 167 | $resourceFile = $document->getResourceNode()->getResourceFile(); |
||
| 168 | $resourceNode->setResourceFile($resourceFile); |
||
| 169 | } |
||
| 170 | } |
||
| 171 | |||
| 172 | $em->persist($resource); |
||
| 173 | $em->flush(); |
||
| 174 | } |
||
| 178 |