chamilo / chamilo-lms

main/inc/lib/pear/Text/Diff/Engine/native.php

Doc Comments +5 added lines

@@ -147,6 +147,7 @@ 
      * the two files do not match, and likewise that the last lines do not
      * match.  The caller must trim matching lines from the beginning and end
      * of the portions it is going to specify.
+     * @param double $nchunks
      */
     function _diag ($xoff, $xlim, $yoff, $ylim, $nchunks)
     {
@@ -267,6 +268,10 @@ 
      *
      * Note that XLIM, YLIM are exclusive bounds.  All line numbers are
      * origin-0 and discarded lines are not counted.
+     * @param integer $xoff
+     * @param integer $xlim
+     * @param integer $yoff
+     * @param integer $ylim
      */
     function _compareseq ($xoff, $xlim, $yoff, $ylim)
     {

Spacing +8 added lines, -8 removed lines

@@ -148,7 +148,7 @@ 
      * match.  The caller must trim matching lines from the beginning and end
      * of the portions it is going to specify.
      */
-    function _diag ($xoff, $xlim, $yoff, $ylim, $nchunks)
+    function _diag($xoff, $xlim, $yoff, $ylim, $nchunks)
     {
         $flip = false;
 
@@ -171,7 +171,7 @@ 
         }
 
         $this->lcs = 0;
-        $this->seq[0]= $yoff - 1;
+        $this->seq[0] = $yoff - 1;
         $this->in_seq = array();
         $ymids[0] = array();
 
@@ -184,7 +184,7 @@ 
                 }
             }
 
-            $x1 = $xoff + (int)(($numer + ($xlim - $xoff) * $chunk) / $nchunks);
+            $x1 = $xoff + (int) (($numer + ($xlim - $xoff) * $chunk) / $nchunks);
             for (; $x < $x1; $x++) {
                 $line = $flip ? $this->yv[$x] : $this->xv[$x];
                 if (empty($ymatches[$line])) {
@@ -220,7 +220,7 @@ 
         $seps[] = $flip ? array($yoff, $xoff) : array($xoff, $yoff);
         $ymid = $ymids[$this->lcs];
         for ($n = 0; $n < $nchunks - 1; $n++) {
-            $x1 = $xoff + (int)(($numer + ($xlim - $xoff) * $n) / $nchunks);
+            $x1 = $xoff + (int) (($numer + ($xlim - $xoff) * $n) / $nchunks);
             $y1 = $ymid[$n] + 1;
             $seps[] = $flip ? array($y1, $x1) : array($x1, $y1);
         }
@@ -240,7 +240,7 @@ 
 
         $beg = 1;
         while ($beg < $end) {
-            $mid = (int)(($beg + $end) / 2);
+            $mid = (int) (($beg + $end) / 2);
             if ($ypos > $this->seq[$mid]) {
                 $beg = $mid + 1;
             } else {
@@ -268,7 +268,7 @@ 
      * Note that XLIM, YLIM are exclusive bounds.  All line numbers are
      * origin-0 and discarded lines are not counted.
      */
-    function _compareseq ($xoff, $xlim, $yoff, $ylim)
+    function _compareseq($xoff, $xlim, $yoff, $ylim)
     {
         /* Slide down the bottom initial diagonal. */
         while ($xoff < $xlim && $yoff < $ylim
@@ -309,7 +309,7 @@ 
             reset($seps);
             $pt1 = $seps[0];
             while ($pt2 = next($seps)) {
-                $this->_compareseq ($pt1[0], $pt2[0], $pt1[1], $pt2[1]);
+                $this->_compareseq($pt1[0], $pt2[0], $pt1[1], $pt2[1]);
                 $pt1 = $pt2;
             }
         }
@@ -352,7 +352,7 @@ 
                 $j++;
             }
 
-            while ($i < $len && ! $changed[$i]) {
+            while ($i < $len && !$changed[$i]) {
                 assert('$j < $other_len && ! $other_changed[$j]');
                 $i++; $j++;
                 while ($j < $other_len && $other_changed[$j]) {

main/inc/lib/pear/Text/Diff/Renderer.php

Doc Comments +9 added lines

@@ -143,6 +143,12 @@ 
         return $output . $this->_endDiff();
     }
 
+    /**
+     * @param integer $xbeg
+     * @param integer $xlen
+     * @param integer $ybeg
+     * @param integer $ylen
+     */
     function _block($xbeg, $xlen, $ybeg, $ylen, &$edits)
     {
         $output = $this->_startBlock($this->_blockHeader($xbeg, $xlen, $ybeg, $ylen));
@@ -199,6 +205,9 @@ 
         return $xbeg . ($xlen ? ($ylen ? 'c' : 'd') : 'a') . $ybeg;
     }
 
+    /**
+     * @param string $header
+     */
     function _startBlock($header)
     {
         return $header . "\n";

Switch Indentation +12 added lines, -12 removed lines

@@ -149,21 +149,21 @@
 
         foreach ($edits as $edit) {
             switch (strtolower(get_class($edit))) {
-            case 'text_diff_op_copy':
-                $output .= $this->_context($edit->orig);
-                break;
+                case 'text_diff_op_copy':
+                    $output .= $this->_context($edit->orig);
+                    break;
 
-            case 'text_diff_op_add':
-                $output .= $this->_added($edit->final);
-                break;
+                case 'text_diff_op_add':
+                    $output .= $this->_added($edit->final);
+                    break;
 
-            case 'text_diff_op_delete':
-                $output .= $this->_deleted($edit->orig);
-                break;
+                case 'text_diff_op_delete':
+                    $output .= $this->_deleted($edit->orig);
+                    break;
 
-            case 'text_diff_op_change':
-                $output .= $this->_changed($edit->orig, $edit->final);
-                break;
+                case 'text_diff_op_change':
+                    $output .= $this->_changed($edit->orig, $edit->final);
+                    break;
             }
         }
 

Spacing +9 added lines, -9 removed lines

@@ -38,7 +38,7 @@ 
     function Text_Diff_Renderer($params = array())
     {
         foreach ($params as $param => $value) {
-            $v = '_' . $param;
+            $v = '_'.$param;
             if (isset($this->$v)) {
                 $this->$v = $value;
             }
@@ -140,7 +140,7 @@ 
                                      $block);
         }
 
-        return $output . $this->_endDiff();
+        return $output.$this->_endDiff();
     }
 
     function _block($xbeg, $xlen, $ybeg, $ylen, &$edits)
@@ -167,7 +167,7 @@ 
             }
         }
 
-        return $output . $this->_endBlock();
+        return $output.$this->_endBlock();
     }
 
     function _startDiff()
@@ -183,10 +183,10 @@ 
     function _blockHeader($xbeg, $xlen, $ybeg, $ylen)
     {
         if ($xlen > 1) {
-            $xbeg .= ',' . ($xbeg + $xlen - 1);
+            $xbeg .= ','.($xbeg + $xlen - 1);
         }
         if ($ylen > 1) {
-            $ybeg .= ',' . ($ybeg + $ylen - 1);
+            $ybeg .= ','.($ybeg + $ylen - 1);
         }
 
         // this matches the GNU Diff behaviour
@@ -196,12 +196,12 @@ 
             $xbeg--;
         }
 
-        return $xbeg . ($xlen ? ($ylen ? 'c' : 'd') : 'a') . $ybeg;
+        return $xbeg.($xlen ? ($ylen ? 'c' : 'd') : 'a').$ybeg;
     }
 
     function _startBlock($header)
     {
-        return $header . "\n";
+        return $header."\n";
     }
 
     function _endBlock()
@@ -211,7 +211,7 @@ 
 
     function _lines($lines, $prefix = ' ')
     {
-        return $prefix . implode("\n$prefix", $lines) . "\n";
+        return $prefix.implode("\n$prefix", $lines)."\n";
     }
 
     function _context($lines)
@@ -231,7 +231,7 @@ 
 
     function _changed($orig, $final)
     {
-        return $this->_deleted($orig) . "---\n" . $this->_added($final);
+        return $this->_deleted($orig)."---\n".$this->_added($final);
     }
 
 }

Indentation +18 added lines, -18 removed lines

@@ -1,19 +1,19 @@ 
 <?php
 /**
- * A class to render Diffs in different formats.
- *
- * This class renders the diff in classic diff format. It is intended that
- * this class be customized via inheritance, to obtain fancier outputs.
- *
- * $Horde: framework/Text_Diff/Diff/Renderer.php,v 1.5.10.12 2009/07/24 13:26:40 jan Exp $
- *
- * Copyright 2004-2009 The Horde Project (http://www.horde.org/)
- *
- * See the enclosed file COPYING for license information (LGPL). If you did
- * not receive this file, see http://opensource.org/licenses/lgpl-license.php.
- *
- * @package Text_Diff
- */
+     * A class to render Diffs in different formats.
+     *
+     * This class renders the diff in classic diff format. It is intended that
+     * this class be customized via inheritance, to obtain fancier outputs.
+     *
+     * $Horde: framework/Text_Diff/Diff/Renderer.php,v 1.5.10.12 2009/07/24 13:26:40 jan Exp $
+     *
+     * Copyright 2004-2009 The Horde Project (http://www.horde.org/)
+     *
+     * See the enclosed file COPYING for license information (LGPL). If you did
+     * not receive this file, see http://opensource.org/licenses/lgpl-license.php.
+     *
+     * @package Text_Diff
+     */
 class Text_Diff_Renderer {
 
     /**
@@ -104,8 +104,8 @@ 
                         }
                         /* @todo */
                         $output .= $this->_block($x0, $ntrail + $xi - $x0,
-                                                 $y0, $ntrail + $yi - $y0,
-                                                 $block);
+                                                    $y0, $ntrail + $yi - $y0,
+                                                    $block);
                         $block = false;
                     }
                 }
@@ -136,8 +136,8 @@ 
 
         if (is_array($block)) {
             $output .= $this->_block($x0, $xi - $x0,
-                                     $y0, $yi - $y0,
-                                     $block);
+                                        $y0, $yi - $y0,
+                                        $block);
         }
 
         return $output . $this->_endDiff();

main/inc/lib/pear/Text/Diff/Renderer/inline.php

Doc Comments +6 added lines

@@ -74,6 +74,9 @@ 
         return $header;
     }
 
+    /**
+     * @param string[] $lines
+     */
     function _lines($lines, $prefix = ' ', $encode = true)
     {
         if ($encode) {
@@ -141,6 +144,9 @@ 
         return str_replace($nl, "\n", $renderer->render($diff)) . "\n";
     }
 
+    /**
+     * @param string $string
+     */
     function _splitOnWords($string, $newlineEscape = "\n")
     {
         // Ignore \0; otherwise the while loop will never finish.

Indentation +2 added lines, -2 removed lines

@@ -129,13 +129,13 @@
          * preserve whitespace as well. Therefore we split on words,
          * but include all blocks of whitespace in the wordlist. */
         $diff = new Text_Diff('native',
-                              array($this->_splitOnWords($text1, $nl),
+                                array($this->_splitOnWords($text1, $nl),
                                     $this->_splitOnWords($text2, $nl)));
 
         /* Get the diff in inline format. */
         $renderer = new Text_Diff_Renderer_inline
             (array_merge($this->getParams(),
-                         array('split_level' => 'words')));
+                            array('split_level' => 'words')));
 
         /* Run the diff and get the output. */
         return str_replace($nl, "\n", $renderer->render($diff)) . "\n";

Spacing +6 added lines, -7 removed lines

@@ -83,14 +83,14 @@ 
         if ($this->_split_level == 'words') {
             return implode('', $lines);
         } else {
-            return implode("\n", $lines) . "\n";
+            return implode("\n", $lines)."\n";
         }
     }
 
     function _added($lines)
     {
         array_walk($lines, array(&$this, '_encode'));
-        $lines[0] = $this->_ins_prefix . $lines[0];
+        $lines[0] = $this->_ins_prefix.$lines[0];
         $lines[count($lines) - 1] .= $this->_ins_suffix;
         return $this->_lines($lines, ' ', false);
     }
@@ -98,7 +98,7 @@ 
     function _deleted($lines, $words = false)
     {
         array_walk($lines, array(&$this, '_encode'));
-        $lines[0] = $this->_del_prefix . $lines[0];
+        $lines[0] = $this->_del_prefix.$lines[0];
         $lines[count($lines) - 1] .= $this->_del_suffix;
         return $this->_lines($lines, ' ', false);
     }
@@ -116,7 +116,7 @@ 
                 $orig[0] = substr($orig[0], 1);
                 $final[0] = substr($final[0], 1);
             }
-            return $prefix . $this->_deleted($orig) . $this->_added($final);
+            return $prefix.$this->_deleted($orig).$this->_added($final);
         }
 
         $text1 = implode("\n", $orig);
@@ -133,12 +133,11 @@ 
                                     $this->_splitOnWords($text2, $nl)));
 
         /* Get the diff in inline format. */
-        $renderer = new Text_Diff_Renderer_inline
-            (array_merge($this->getParams(),
+        $renderer = new Text_Diff_Renderer_inline(array_merge($this->getParams(),
                          array('split_level' => 'words')));
 
         /* Run the diff and get the output. */
-        return str_replace($nl, "\n", $renderer->render($diff)) . "\n";
+        return str_replace($nl, "\n", $renderer->render($diff))."\n";
     }
 
     function _splitOnWords($string, $newlineEscape = "\n")

main/inc/lib/pear/Text/Password.php

Doc Comments +10 added lines

@@ -180,6 +180,7 @@ 
      * @access private
      * @param  string  Login
      * @param  integer Key
+     * @param integer $key
      * @return string
      */
     function _xor($login, $key)
@@ -208,6 +209,7 @@ 
      * @access private
      * @param  string  Login
      * @param  integer Key
+     * @param integer $key
      * @return string
      */
     function _rotx($login, $key)
@@ -241,6 +243,7 @@ 
      * @access private
      * @param  string  Login
      * @param  integer Key
+     * @param integer $key
      * @return string
      */
     function _rotxpp($login, $key)
@@ -274,6 +277,7 @@ 
      * @access private
      * @param  string  Login
      * @param  integer Key
+     * @param integer $key
      * @return string
      */
     function _rotxmm($login, $key)
@@ -306,6 +310,7 @@ 
      * @access private
      * @param  string  Login
      * @param  integer Key
+     * @param integer $key
      * @return string
      */
     function _asciiRotx($login, $key)
@@ -340,6 +345,7 @@ 
      * @access private
      * @param  string  Login
      * @param  integer Key
+     * @param integer $key
      * @return string
      */
     function _asciiRotxpp($login, $key)
@@ -374,6 +380,7 @@ 
      * @access private
      * @param  string  Login
      * @param  integer Key
+     * @param integer $key
      * @return string
      */
     function _asciiRotxmm($login, $key)
@@ -430,6 +437,7 @@ 
      *
      * @access private
      * @param  integer Length of the password
+     * @param integer $length
      * @return string  Returns the password
      */
     function _createPronounceable($length)
@@ -475,6 +483,8 @@ 
      * @param  string  Character which could be use in the
      *                 unpronounceable password ex : 'ABCDEFG'
      *                 or numeric, alphabetical or alphanumeric.
+     * @param integer $length
+     * @param string $chars
      * @return string  Returns the password
      */
     function _createUnpronounceable($length, $chars)

Indentation +37 added lines, -37 removed lines

@@ -441,17 +441,17 @@ 
          * List of vowels and vowel sounds
          */
         $v = array('a', 'e', 'i', 'o', 'u', 'ae', 'ou', 'io',
-                   'ea', 'ou', 'ia', 'ai'
-                   );
+                    'ea', 'ou', 'ia', 'ai'
+                    );
 
         /**
          * List of consonants and consonant sounds
          */
         $c = array('b', 'c', 'd', 'g', 'h', 'j', 'k', 'l', 'm',
-                   'n', 'p', 'r', 's', 't', 'u', 'v', 'w',
-                   'tr', 'cr', 'fr', 'dr', 'wr', 'pr', 'th',
-                   'ch', 'ph', 'st', 'sl', 'cl'
-                   );
+                    'n', 'p', 'r', 's', 't', 'u', 'v', 'w',
+                    'tr', 'cr', 'fr', 'dr', 'wr', 'pr', 'th',
+                    'ch', 'ph', 'st', 'sl', 'cl'
+                    );
 
         $v_count = 12;
         $c_count = 29;
@@ -484,50 +484,50 @@ 
         /**
          * List of character which could be use in the password
          */
-         switch($chars) {
+            switch($chars) {
 
-         case 'alphanumeric':
+            case 'alphanumeric':
              $chars = 'ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789';
-             $GLOBALS['_Text_Password_NumberOfPossibleCharacters'] = 62;
-             break;
+                $GLOBALS['_Text_Password_NumberOfPossibleCharacters'] = 62;
+                break;
 
-         case 'alphabetical':
+            case 'alphabetical':
              $chars = 'ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz';
-             $GLOBALS['_Text_Password_NumberOfPossibleCharacters'] = 52;
-             break;
+                $GLOBALS['_Text_Password_NumberOfPossibleCharacters'] = 52;
+                break;
 
-         case 'numeric':
+            case 'numeric':
              $chars = '0123456789';
-             $GLOBALS['_Text_Password_NumberOfPossibleCharacters'] = 10;
-             break;
+                $GLOBALS['_Text_Password_NumberOfPossibleCharacters'] = 10;
+                break;
 
-         case '':
+            case '':
              $chars = '_#@%&ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789';
-             $GLOBALS['_Text_Password_NumberOfPossibleCharacters'] = 67;
-             break;
+                $GLOBALS['_Text_Password_NumberOfPossibleCharacters'] = 67;
+                break;
 
-         default:
+            default:
              /**
               * Some characters shouldn't be used
               */
              $chars = trim($chars);
-             $chars = str_replace(array('+', '|', '$', '^', '/', '\\', ','), '', $chars);
-
-             $GLOBALS['_Text_Password_NumberOfPossibleCharacters'] = strlen($chars);
-         }
-
-         /**
-          * Generate password
-          */
-         for ($i = 0; $i < $length; $i++) {
-             $num = mt_rand(0, $GLOBALS['_Text_Password_NumberOfPossibleCharacters'] - 1);
-             $password .= $chars{$num};
-         }
-
-         /**
-          * Return password
-          */
-         return $password;
+                $chars = str_replace(array('+', '|', '$', '^', '/', '\\', ','), '', $chars);
+
+                $GLOBALS['_Text_Password_NumberOfPossibleCharacters'] = strlen($chars);
+            }
+
+            /**
+             * Generate password
+             */
+            for ($i = 0; $i < $length; $i++) {
+                $num = mt_rand(0, $GLOBALS['_Text_Password_NumberOfPossibleCharacters'] - 1);
+                $password .= $chars{$num};
+            }
+
+            /**
+             * Return password
+             */
+            return $password;
     }
 }
 ?>

Switch Indentation +61 added lines, -61 removed lines

@@ -55,12 +55,12 @@ 
     function create($length = 10, $type = 'pronounceable', $chars = '')
     {
         switch ($type) {
-        case 'unpronounceable' :
-            return Text_Password::_createUnpronounceable($length, $chars);
+            case 'unpronounceable' :
+                return Text_Password::_createUnpronounceable($length, $chars);
 
-        case 'pronounceable' :
-        default :
-            return Text_Password::_createPronounceable($length);
+            case 'pronounceable' :
+            default :
+                return Text_Password::_createPronounceable($length);
         }
     }
 
@@ -110,35 +110,35 @@ 
     function createFromLogin($login, $type, $key = 0)
     {
         switch ($type) {
-        case 'reverse':
-            return strrev($login);
+            case 'reverse':
+                return strrev($login);
 
-        case 'shuffle':
-            return Text_Password::_shuffle($login);
+            case 'shuffle':
+                return Text_Password::_shuffle($login);
 
-        case 'xor':
-            return Text_Password::_xor($login, $key);
+            case 'xor':
+                return Text_Password::_xor($login, $key);
 
-        case 'rot13':
-            return str_rot13($login);
+            case 'rot13':
+                return str_rot13($login);
 
-        case 'rotx':
-            return Text_Password::_rotx($login, $key);
+            case 'rotx':
+                return Text_Password::_rotx($login, $key);
 
-        case 'rotx++':
-            return Text_Password::_rotxpp($login, $key);
+            case 'rotx++':
+                return Text_Password::_rotxpp($login, $key);
 
-        case 'rotx--':
-            return Text_Password::_rotxmm($login, $key);
+            case 'rotx--':
+                return Text_Password::_rotxmm($login, $key);
 
-        case 'ascii_rotx':
-            return Text_Password::_asciiRotx($login, $key);
+            case 'ascii_rotx':
+                return Text_Password::_asciiRotx($login, $key);
 
-        case 'ascii_rotx++':
-            return Text_Password::_asciiRotxpp($login, $key);
+            case 'ascii_rotx++':
+                return Text_Password::_asciiRotxpp($login, $key);
 
-        case 'ascii_rotx--':
-            return Text_Password::_asciiRotxmm($login, $key);
+            case 'ascii_rotx--':
+                return Text_Password::_asciiRotxmm($login, $key);
         }
     }
 
@@ -320,11 +320,11 @@ 
                 $next += 255;
             }
             switch ($next) { // delete white space
-            case 0x09:
-            case 0x20:
-            case 0x0A:
-            case 0x0D:
-                $next++;
+                case 0x09:
+                case 0x20:
+                case 0x0A:
+                case 0x0D:
+                    $next++;
             }
             $tmp .= chr($next);
         }
@@ -354,11 +354,11 @@ 
                 $next += 255;
             }
             switch ($next) { // delete white space
-            case 0x09:
-            case 0x20:
-            case 0x0A:
-            case 0x0D:
-                $next++;
+                case 0x09:
+                case 0x20:
+                case 0x0A:
+                case 0x0D:
+                    $next++;
             }
             $tmp .= chr($next);
         }
@@ -388,11 +388,11 @@ 
                 $next += 255;
             }
             switch ($next) { // delete white space
-            case 0x09:
-            case 0x20:
-            case 0x0A:
-            case 0x0D:
-                $next++;
+                case 0x09:
+                case 0x20:
+                case 0x0A:
+                case 0x0D:
+                    $next++;
             }
             $tmp .= chr($next);
         }
@@ -486,34 +486,34 @@ 
          */
          switch($chars) {
 
-         case 'alphanumeric':
-             $chars = 'ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789';
-             $GLOBALS['_Text_Password_NumberOfPossibleCharacters'] = 62;
-             break;
+             case 'alphanumeric':
+                 $chars = 'ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789';
+                 $GLOBALS['_Text_Password_NumberOfPossibleCharacters'] = 62;
+                 break;
 
-         case 'alphabetical':
-             $chars = 'ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz';
-             $GLOBALS['_Text_Password_NumberOfPossibleCharacters'] = 52;
-             break;
+             case 'alphabetical':
+                 $chars = 'ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz';
+                 $GLOBALS['_Text_Password_NumberOfPossibleCharacters'] = 52;
+                 break;
 
-         case 'numeric':
-             $chars = '0123456789';
-             $GLOBALS['_Text_Password_NumberOfPossibleCharacters'] = 10;
-             break;
+             case 'numeric':
+                 $chars = '0123456789';
+                 $GLOBALS['_Text_Password_NumberOfPossibleCharacters'] = 10;
+                 break;
 
-         case '':
-             $chars = '_#@%&ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789';
-             $GLOBALS['_Text_Password_NumberOfPossibleCharacters'] = 67;
-             break;
+             case '':
+                 $chars = '_#@%&ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789';
+                 $GLOBALS['_Text_Password_NumberOfPossibleCharacters'] = 67;
+                 break;
 
-         default:
-             /**
+             default:
+                 /**
               * Some characters shouldn't be used
               */
-             $chars = trim($chars);
-             $chars = str_replace(array('+', '|', '$', '^', '/', '\\', ','), '', $chars);
+                 $chars = trim($chars);
+                 $chars = str_replace(array('+', '|', '$', '^', '/', '\\', ','), '', $chars);
 
-             $GLOBALS['_Text_Password_NumberOfPossibleCharacters'] = strlen($chars);
+                 $GLOBALS['_Text_Password_NumberOfPossibleCharacters'] = strlen($chars);
          }
 
          /**

Spacing +2 added lines, -2 removed lines

@@ -459,7 +459,7 @@ 
         $GLOBALS['_Text_Password_NumberOfPossibleCharacters'] = $v_count + $c_count;
 
         for ($i = 0; $i < $length; $i++) {
-            $retVal .= $c[mt_rand(0, $c_count-1)] . $v[mt_rand(0, $v_count-1)];
+            $retVal .= $c[mt_rand(0, $c_count - 1)].$v[mt_rand(0, $v_count - 1)];
         }
 
         return substr($retVal, 0, $length);
@@ -484,7 +484,7 @@ 
         /**
          * List of character which could be use in the password
          */
-         switch($chars) {
+         switch ($chars) {
 
          case 'alphanumeric':
              $chars = 'ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789';

main/inc/lib/phpdocx/lib/log4php/appenders/LoggerAppenderAdodb.php

Doc Comments +1 added lines, -1 removed lines

@@ -115,7 +115,7 @@
      * Setup db connection.
      * Based on defined options, this method connects to db defined in {@link $dsn}
      * and creates a {@link $table} table if {@link $createTable} is true.
-     * @return boolean true if all ok.
+     * @return boolean|null true if all ok.
      */
     function activateOptions()
     {        

Indentation +4 added lines, -4 removed lines

@@ -121,10 +121,10 @@
     {        
         $this->db = &ADONewConnection($this->type);
         if (! $this->db->PConnect($this->host, $this->user, $this->password, $this->database)) {
-          $this->db = null;
-          $this->closed = true;
-          $this->canAppend = false;
-          return;
+            $this->db = null;
+            $this->closed = true;
+            $this->canAppend = false;
+            return;
         }
         
         $this->layout = LoggerReflectionUtils::createObject('LoggerLayoutPattern');

Spacing +4 added lines, -4 removed lines

@@ -19,7 +19,7 @@ 
  */
 
 /** A docblok to make phpdoc happy */
-require_once(ADODB_DIR . '/adodb.inc.php');
+require_once(ADODB_DIR.'/adodb.inc.php');
 
 /**
  * Appends log events to a db table using adodb class.
@@ -120,7 +120,7 @@ 
     function activateOptions()
     {        
         $this->db = &ADONewConnection($this->type);
-        if (! $this->db->PConnect($this->host, $this->user, $this->password, $this->database)) {
+        if (!$this->db->PConnect($this->host, $this->user, $this->password, $this->database)) {
           $this->db = null;
           $this->closed = true;
           $this->canAppend = false;
@@ -131,14 +131,14 @@ 
         $this->layout->setConversionPattern($this->getSql());
     
         // test if log table exists
-        $sql = 'select * from ' . $this->table . ' where 1 = 0';
+        $sql = 'select * from '.$this->table.' where 1 = 0';
         $dbrs = $this->db->Execute($sql);
         if ($dbrs == false and $this->getCreateTable()) {
             $query = "CREATE TABLE {$this->table} (timestamp varchar(32),logger varchar(32),level varchar(32),message varchar(64),thread varchar(32),file varchar(64),line varchar(4) );";
 
                      
             $result = $this->db->Execute($query);
-            if (! $result) {
+            if (!$result) {
                 $this->canAppend = false;
                 return;
             }

Braces +3 added lines, -2 removed lines

@@ -155,8 +155,9 @@
     
     function close()
     {
-        if ($this->db !== null)
-            $this->db->Close();
+        if ($this->db !== null) {
+                    $this->db->Close();
+        }
         $this->closed = true;
     }
     

main/inc/lib/phpdocx/lib/log4php/appenders/LoggerAppenderFile.php

Doc Comments +6 added lines

@@ -151,10 +151,16 @@
 		return $this->append;
 	}
 
+	/**
+	 * @param boolean $flag
+	 */
 	public function setAppend($flag) {
 		$this->append = LoggerOptionConverter::toBoolean($flag, true);		  
 	}
 
+	/**
+	 * @param string $fileName
+	 */
 	public function setFileName($fileName) {
 		$this->fileName = $fileName;
 	}

Spacing +14 added lines, -14 removed lines

@@ -67,17 +67,17 @@ 
 	public function activateOptions() {
 		$fileName = $this->getFile();
 
-		if(!is_file($fileName)) {
+		if (!is_file($fileName)) {
 			$dir = dirname($fileName);
-			if(!is_dir($dir)) {
+			if (!is_dir($dir)) {
 				mkdir($dir, 0777, true);
 			}
 		}
 
-		$this->fp = fopen($fileName, ($this->getAppend()? 'a':'w'));
-		if($this->fp) {
-			if(flock($this->fp, LOCK_EX)) {
-				if($this->getAppend()) {
+		$this->fp = fopen($fileName, ($this->getAppend() ? 'a' : 'w'));
+		if ($this->fp) {
+			if (flock($this->fp, LOCK_EX)) {
+				if ($this->getAppend()) {
 					fseek($this->fp, 0, SEEK_END);
 				}
 				fwrite($this->fp, $this->layout->getHeader());
@@ -93,9 +93,9 @@ 
 	}
 	
 	public function close() {
-		if($this->closed != true) {
-			if($this->fp and $this->layout !== null) {
-				if(flock($this->fp, LOCK_EX)) {
+		if ($this->closed != true) {
+			if ($this->fp and $this->layout !== null) {
+				if (flock($this->fp, LOCK_EX)) {
 					fwrite($this->fp, $this->layout->getFooter());
 					flock($this->fp, LOCK_UN);
 				}
@@ -106,8 +106,8 @@ 
 	}
 
 	public function append(LoggerLoggingEvent $event) {
-		if($this->fp and $this->layout !== null) {
-			if(flock($this->fp, LOCK_EX)) {
+		if ($this->fp and $this->layout !== null) {
+			if (flock($this->fp, LOCK_EX)) {
 				fwrite($this->fp, $this->layout->format($event));
 				flock($this->fp, LOCK_UN);
 			} else {
@@ -127,11 +127,11 @@ 
 	 */
 	public function setFile() {
 		$numargs = func_num_args();
-		$args	 = func_get_args();
+		$args = func_get_args();
 
-		if($numargs == 1 and is_string($args[0])) {
+		if ($numargs == 1 and is_string($args[0])) {
 			$this->setFileName($args[0]);
-		} else if ($numargs >=2 and is_string($args[0]) and is_bool($args[1])) {
+		} else if ($numargs >= 2 and is_string($args[0]) and is_bool($args[1])) {
 			$this->setFile($args[0]);
 			$this->setAppend($args[1]);
 		}

Indentation +109 added lines, -109 removed lines

@@ -42,129 +42,129 @@
  */
 class LoggerAppenderFile extends LoggerAppender {
 
-	/**
-	 * @var boolean if {@link $file} exists, appends events.
-	 */
-	private $append = true;
-	/**
-	 * @var string the file name used to append events
-	 */
-	protected $fileName;
-	/**
-	 * @var mixed file resource
-	 */
-	protected $fp = false;
+    /**
+     * @var boolean if {@link $file} exists, appends events.
+     */
+    private $append = true;
+    /**
+     * @var string the file name used to append events
+     */
+    protected $fileName;
+    /**
+     * @var mixed file resource
+     */
+    protected $fp = false;
 	
-	public function __construct($name = '') {
-		parent::__construct($name);
-		$this->requiresLayout = true;
-	}
+    public function __construct($name = '') {
+        parent::__construct($name);
+        $this->requiresLayout = true;
+    }
 
-	public function __destruct() {
-       $this->close();
-   	}
+    public function __destruct() {
+        $this->close();
+        }
    	
-	public function activateOptions() {
-		$fileName = $this->getFile();
+    public function activateOptions() {
+        $fileName = $this->getFile();
 
-		if(!is_file($fileName)) {
-			$dir = dirname($fileName);
-			if(!is_dir($dir)) {
-				mkdir($dir, 0777, true);
-			}
-		}
+        if(!is_file($fileName)) {
+            $dir = dirname($fileName);
+            if(!is_dir($dir)) {
+                mkdir($dir, 0777, true);
+            }
+        }
 
-		$this->fp = fopen($fileName, ($this->getAppend()? 'a':'w'));
-		if($this->fp) {
-			if(flock($this->fp, LOCK_EX)) {
-				if($this->getAppend()) {
-					fseek($this->fp, 0, SEEK_END);
-				}
-				fwrite($this->fp, $this->layout->getHeader());
-				flock($this->fp, LOCK_UN);
-				$this->closed = false;
-			} else {
-				// TODO: should we take some action in this case?
-				$this->closed = true;
-			}		 
-		} else {
-			$this->closed = true;
-		}
-	}
+        $this->fp = fopen($fileName, ($this->getAppend()? 'a':'w'));
+        if($this->fp) {
+            if(flock($this->fp, LOCK_EX)) {
+                if($this->getAppend()) {
+                    fseek($this->fp, 0, SEEK_END);
+                }
+                fwrite($this->fp, $this->layout->getHeader());
+                flock($this->fp, LOCK_UN);
+                $this->closed = false;
+            } else {
+                // TODO: should we take some action in this case?
+                $this->closed = true;
+            }		 
+        } else {
+            $this->closed = true;
+        }
+    }
 	
-	public function close() {
-		if($this->closed != true) {
-			if($this->fp and $this->layout !== null) {
-				if(flock($this->fp, LOCK_EX)) {
-					fwrite($this->fp, $this->layout->getFooter());
-					flock($this->fp, LOCK_UN);
-				}
-				fclose($this->fp);
-			}
-			$this->closed = true;
-		}
-	}
+    public function close() {
+        if($this->closed != true) {
+            if($this->fp and $this->layout !== null) {
+                if(flock($this->fp, LOCK_EX)) {
+                    fwrite($this->fp, $this->layout->getFooter());
+                    flock($this->fp, LOCK_UN);
+                }
+                fclose($this->fp);
+            }
+            $this->closed = true;
+        }
+    }
 
-	public function append(LoggerLoggingEvent $event) {
-		if($this->fp and $this->layout !== null) {
-			if(flock($this->fp, LOCK_EX)) {
-				fwrite($this->fp, $this->layout->format($event));
-				flock($this->fp, LOCK_UN);
-			} else {
-				$this->closed = true;
-			}
-		} 
-	}
+    public function append(LoggerLoggingEvent $event) {
+        if($this->fp and $this->layout !== null) {
+            if(flock($this->fp, LOCK_EX)) {
+                fwrite($this->fp, $this->layout->format($event));
+                flock($this->fp, LOCK_UN);
+            } else {
+                $this->closed = true;
+            }
+        } 
+    }
 	
-	/**
-	 * Sets and opens the file where the log output will go.
-	 *
-	 * This is an overloaded method. It can be called with:
-	 * - setFile(string $fileName) to set filename.
-	 * - setFile(string $fileName, boolean $append) to set filename and append.
-	 * 
-	 * TODO: remove overloading. Use only file as alias to filename
-	 */
-	public function setFile() {
-		$numargs = func_num_args();
-		$args	 = func_get_args();
+    /**
+     * Sets and opens the file where the log output will go.
+     *
+     * This is an overloaded method. It can be called with:
+     * - setFile(string $fileName) to set filename.
+     * - setFile(string $fileName, boolean $append) to set filename and append.
+     * 
+     * TODO: remove overloading. Use only file as alias to filename
+     */
+    public function setFile() {
+        $numargs = func_num_args();
+        $args	 = func_get_args();
 
-		if($numargs == 1 and is_string($args[0])) {
-			$this->setFileName($args[0]);
-		} else if ($numargs >=2 and is_string($args[0]) and is_bool($args[1])) {
-			$this->setFile($args[0]);
-			$this->setAppend($args[1]);
-		}
-	}
+        if($numargs == 1 and is_string($args[0])) {
+            $this->setFileName($args[0]);
+        } else if ($numargs >=2 and is_string($args[0]) and is_bool($args[1])) {
+            $this->setFile($args[0]);
+            $this->setAppend($args[1]);
+        }
+    }
 	
-	/**
-	 * @return string
-	 */
-	public function getFile() {
-		return $this->getFileName();
-	}
+    /**
+     * @return string
+     */
+    public function getFile() {
+        return $this->getFileName();
+    }
 	
-	/**
-	 * @return boolean
-	 */
-	public function getAppend() {
-		return $this->append;
-	}
+    /**
+     * @return boolean
+     */
+    public function getAppend() {
+        return $this->append;
+    }
 
-	public function setAppend($flag) {
-		$this->append = LoggerOptionConverter::toBoolean($flag, true);		  
-	}
+    public function setAppend($flag) {
+        $this->append = LoggerOptionConverter::toBoolean($flag, true);		  
+    }
 
-	public function setFileName($fileName) {
-		$this->fileName = $fileName;
-	}
+    public function setFileName($fileName) {
+        $this->fileName = $fileName;
+    }
 	
-	/**
-	 * @return string
-	 */
-	public function getFileName() {
-		return $this->fileName;
-	}
+    /**
+     * @return string
+     */
+    public function getFileName() {
+        return $this->fileName;
+    }
 	
 	 
 }

main/inc/lib/phpdocx/lib/log4php/appenders/LoggerAppenderRollingFile.php

Doc Comments +1 added lines, -1 removed lines

@@ -92,7 +92,7 @@
    	
 	/**
 	 * Returns the value of the MaxBackupIndex option.
-	 * @return integer 
+	 * @return string 
 	 */
 	private function getExpandedFileName() {
 		return $this->expandedFileName;

Spacing +20 added lines, -20 removed lines

@@ -78,7 +78,7 @@ 
 	 *
 	 * @var integer 
 	 */
-	private $maxBackupIndex	 = 1;
+	private $maxBackupIndex = 1;
 	
 	/**
 	 * @var string the filename expanded
@@ -117,17 +117,17 @@ 
 	 */
 	private function rollOver() {
 		// If maxBackups <= 0, then there is no file renaming to be done.
-		if($this->maxBackupIndex > 0) {
+		if ($this->maxBackupIndex > 0) {
 			$fileName = $this->getExpandedFileName();
 			// Delete the oldest file, to keep Windows happy.
-			$file = $fileName . '.' . $this->maxBackupIndex;
-			if(is_writable($file))
+			$file = $fileName.'.'.$this->maxBackupIndex;
+			if (is_writable($file))
 				unlink($file);
 			// Map {(maxBackupIndex - 1), ..., 2, 1} to {maxBackupIndex, ..., 3, 2}
-			for($i = $this->maxBackupIndex - 1; $i >= 1; $i--) {
-				$file = $fileName . "." . $i;
-				if(is_readable($file)) {
-					$target = $fileName . '.' . ($i + 1);
+			for ($i = $this->maxBackupIndex - 1; $i >= 1; $i--) {
+				$file = $fileName.".".$i;
+				if (is_readable($file)) {
+					$target = $fileName.'.'.($i + 1);
 					rename($file, $target);
 				}
 			}
@@ -135,7 +135,7 @@ 
 			$this->close();
 	
 			// Rename fileName to fileName.1
-			$target = $fileName . ".1";
+			$target = $fileName.".1";
 			$file = $fileName;
 			rename($file, $target);
 		}
@@ -167,8 +167,8 @@ 
 	 * @param mixed $maxBackups
 	 */
 	public function setMaxBackupIndex($maxBackups) {
-		if(is_numeric($maxBackups)) {
-			$this->maxBackupIndex = abs((int)$maxBackups);
+		if (is_numeric($maxBackups)) {
+			$this->maxBackupIndex = abs((int) $maxBackups);
 		}
 	}
 
@@ -199,20 +199,20 @@ 
 	 */
 	public function setMaxFileSize($value) {
 		$maxFileSize = null;
-		$numpart = substr($value,0, strlen($value) -2);
+		$numpart = substr($value, 0, strlen($value) - 2);
 		$suffix = strtoupper(substr($value, -2));
 
-		switch($suffix) {
-			case 'KB': $maxFileSize = (int)((int)$numpart * 1024); break;
-			case 'MB': $maxFileSize = (int)((int)$numpart * 1024 * 1024); break;
-			case 'GB': $maxFileSize = (int)((int)$numpart * 1024 * 1024 * 1024); break;
+		switch ($suffix) {
+			case 'KB': $maxFileSize = (int) ((int) $numpart * 1024); break;
+			case 'MB': $maxFileSize = (int) ((int) $numpart * 1024 * 1024); break;
+			case 'GB': $maxFileSize = (int) ((int) $numpart * 1024 * 1024 * 1024); break;
 			default:
-				if(is_numeric($value)) {
-					$maxFileSize = (int)$value;
+				if (is_numeric($value)) {
+					$maxFileSize = (int) $value;
 				}
 		}
 		
-		if($maxFileSize !== null) {
+		if ($maxFileSize !== null) {
 			$this->maxFileSize = abs($maxFileSize);
 		}
 		return $this->maxFileSize;
@@ -223,7 +223,7 @@ 
 	 */
 	public function append(LoggerLoggingEvent $event) {
 		parent::append($event);
-		if(ftell($this->fp) > $this->getMaximumFileSize()) {
+		if (ftell($this->fp) > $this->getMaximumFileSize()) {
 			$this->rollOver();
 		}
 	}

Braces +6 added lines, -3 removed lines

@@ -121,8 +121,9 @@ 
 			$fileName = $this->getExpandedFileName();
 			// Delete the oldest file, to keep Windows happy.
 			$file = $fileName . '.' . $this->maxBackupIndex;
-			if(is_writable($file))
-				unlink($file);
+			if(is_writable($file)) {
+							unlink($file);
+			}
 			// Map {(maxBackupIndex - 1), ..., 2, 1} to {maxBackupIndex, ..., 3, 2}
 			for($i = $this->maxBackupIndex - 1; $i >= 1; $i--) {
 				$file = $fileName . "." . $i;
@@ -150,7 +151,9 @@ 
 		// As LoggerAppenderFile does not create the directory, it has to exist.
 		// realpath() fails if the argument does not exist so the filename is separated.
 		$this->expandedFileName = realpath(dirname($fileName));
-		if ($this->expandedFileName === false) throw new Exception("Directory of $fileName does not exist!");
+		if ($this->expandedFileName === false) {
+		    throw new Exception("Directory of $fileName does not exist!");
+		}
 		$this->expandedFileName .= '/'.basename($fileName);
 	}
 

Indentation +179 added lines, -179 removed lines

@@ -1,22 +1,22 @@ 
 <?php
 /**
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- *	   http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- *
- * @package log4php
- */
+     * Licensed to the Apache Software Foundation (ASF) under one or more
+     * contributor license agreements. See the NOTICE file distributed with
+     * this work for additional information regarding copyright ownership.
+     * The ASF licenses this file to You under the Apache License, Version 2.0
+     * (the "License"); you may not use this file except in compliance with
+     * the License. You may obtain a copy of the License at
+     *
+     *	   http://www.apache.org/licenses/LICENSE-2.0
+     *
+     * Unless required by applicable law or agreed to in writing, software
+     * distributed under the License is distributed on an "AS IS" BASIS,
+     * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+     * See the License for the specific language governing permissions and
+     * limitations under the License.
+     *
+     * @package log4php
+     */
 
 /**
  * LoggerAppenderRollingFile extends LoggerAppenderFile to backup the log files 
@@ -48,183 +48,183 @@ 
  */
 class LoggerAppenderRollingFile extends LoggerAppenderFile {
 
-	/**
-	 * Set the maximum size that the output file is allowed to reach
-	 * before being rolled over to backup files.
-	 *
-	 * <p>In configuration files, the <var>MaxFileSize</var> option takes a
-	 * long integer in the range 0 - 2^63. You can specify the value
-	 * with the suffixes "KB", "MB" or "GB" so that the integer is
-	 * interpreted being expressed respectively in kilobytes, megabytes
-	 * or gigabytes. For example, the value "10KB" will be interpreted
-	 * as 10240.</p>
-	 * <p>The default maximum file size is 10MB.</p>
-	 *
-	 * <p>Note that MaxFileSize cannot exceed <b>2 GB</b>.</p>
-	 *
-	 * @var integer
-	 */
-	private $maxFileSize = 10485760;
+    /**
+     * Set the maximum size that the output file is allowed to reach
+     * before being rolled over to backup files.
+     *
+     * <p>In configuration files, the <var>MaxFileSize</var> option takes a
+     * long integer in the range 0 - 2^63. You can specify the value
+     * with the suffixes "KB", "MB" or "GB" so that the integer is
+     * interpreted being expressed respectively in kilobytes, megabytes
+     * or gigabytes. For example, the value "10KB" will be interpreted
+     * as 10240.</p>
+     * <p>The default maximum file size is 10MB.</p>
+     *
+     * <p>Note that MaxFileSize cannot exceed <b>2 GB</b>.</p>
+     *
+     * @var integer
+     */
+    private $maxFileSize = 10485760;
 	
-	/**
-	 * Set the maximum number of backup files to keep around.
-	 * 
-	 * <p>The <var>MaxBackupIndex</var> option determines how many backup
-	 * files are kept before the oldest is erased. This option takes
-	 * a positive integer value. If set to zero, then there will be no
-	 * backup files and the log file will be truncated when it reaches
-	 * MaxFileSize.</p>
-	 * <p>There is one backup file by default.</p>
-	 *
-	 * @var integer 
-	 */
-	private $maxBackupIndex	 = 1;
+    /**
+     * Set the maximum number of backup files to keep around.
+     * 
+     * <p>The <var>MaxBackupIndex</var> option determines how many backup
+     * files are kept before the oldest is erased. This option takes
+     * a positive integer value. If set to zero, then there will be no
+     * backup files and the log file will be truncated when it reaches
+     * MaxFileSize.</p>
+     * <p>There is one backup file by default.</p>
+     *
+     * @var integer 
+     */
+    private $maxBackupIndex	 = 1;
 	
-	/**
-	 * @var string the filename expanded
-	 * @access private
-	 */
-	private $expandedFileName = null;
+    /**
+     * @var string the filename expanded
+     * @access private
+     */
+    private $expandedFileName = null;
 
-	public function __destruct() {
-       parent::__destruct();
-   	}
+    public function __destruct() {
+        parent::__destruct();
+        }
    	
-	/**
-	 * Returns the value of the MaxBackupIndex option.
-	 * @return integer 
-	 */
-	private function getExpandedFileName() {
-		return $this->expandedFileName;
-	}
+    /**
+     * Returns the value of the MaxBackupIndex option.
+     * @return integer 
+     */
+    private function getExpandedFileName() {
+        return $this->expandedFileName;
+    }
 
-	/**
-	 * Get the maximum size that the output file is allowed to reach
-	 * before being rolled over to backup files.
-	 * @return integer
-	 */
-	private function getMaximumFileSize() {
-		return $this->maxFileSize;
-	}
+    /**
+     * Get the maximum size that the output file is allowed to reach
+     * before being rolled over to backup files.
+     * @return integer
+     */
+    private function getMaximumFileSize() {
+        return $this->maxFileSize;
+    }
 
-	/**
-	 * Implements the usual roll over behaviour.
-	 *
-	 * <p>If MaxBackupIndex is positive, then files File.1, ..., File.MaxBackupIndex -1 are renamed to File.2, ..., File.MaxBackupIndex. 
-	 * Moreover, File is renamed File.1 and closed. A new File is created to receive further log output.
-	 * 
-	 * <p>If MaxBackupIndex is equal to zero, then the File is truncated with no backup files created.
-	 */
-	private function rollOver() {
-		// If maxBackups <= 0, then there is no file renaming to be done.
-		if($this->maxBackupIndex > 0) {
-			$fileName = $this->getExpandedFileName();
-			// Delete the oldest file, to keep Windows happy.
-			$file = $fileName . '.' . $this->maxBackupIndex;
-			if(is_writable($file))
-				unlink($file);
-			// Map {(maxBackupIndex - 1), ..., 2, 1} to {maxBackupIndex, ..., 3, 2}
-			for($i = $this->maxBackupIndex - 1; $i >= 1; $i--) {
-				$file = $fileName . "." . $i;
-				if(is_readable($file)) {
-					$target = $fileName . '.' . ($i + 1);
-					rename($file, $target);
-				}
-			}
+    /**
+     * Implements the usual roll over behaviour.
+     *
+     * <p>If MaxBackupIndex is positive, then files File.1, ..., File.MaxBackupIndex -1 are renamed to File.2, ..., File.MaxBackupIndex. 
+     * Moreover, File is renamed File.1 and closed. A new File is created to receive further log output.
+     * 
+     * <p>If MaxBackupIndex is equal to zero, then the File is truncated with no backup files created.
+     */
+    private function rollOver() {
+        // If maxBackups <= 0, then there is no file renaming to be done.
+        if($this->maxBackupIndex > 0) {
+            $fileName = $this->getExpandedFileName();
+            // Delete the oldest file, to keep Windows happy.
+            $file = $fileName . '.' . $this->maxBackupIndex;
+            if(is_writable($file))
+                unlink($file);
+            // Map {(maxBackupIndex - 1), ..., 2, 1} to {maxBackupIndex, ..., 3, 2}
+            for($i = $this->maxBackupIndex - 1; $i >= 1; $i--) {
+                $file = $fileName . "." . $i;
+                if(is_readable($file)) {
+                    $target = $fileName . '.' . ($i + 1);
+                    rename($file, $target);
+                }
+            }
 	
-			$this->close();
+            $this->close();
 	
-			// Rename fileName to fileName.1
-			$target = $fileName . ".1";
-			$file = $fileName;
-			rename($file, $target);
-		}
+            // Rename fileName to fileName.1
+            $target = $fileName . ".1";
+            $file = $fileName;
+            rename($file, $target);
+        }
 		
-		//unset($this->fp);
-		$this->activateOptions();
-		$this->setFile($fileName, false);
-	}
+        //unset($this->fp);
+        $this->activateOptions();
+        $this->setFile($fileName, false);
+    }
 	
-	public function setFileName($fileName) {
-		$this->fileName = $fileName;
-		// As LoggerAppenderFile does not create the directory, it has to exist.
-		// realpath() fails if the argument does not exist so the filename is separated.
-		$this->expandedFileName = realpath(dirname($fileName));
-		if ($this->expandedFileName === false) throw new Exception("Directory of $fileName does not exist!");
-		$this->expandedFileName .= '/'.basename($fileName);
-	}
+    public function setFileName($fileName) {
+        $this->fileName = $fileName;
+        // As LoggerAppenderFile does not create the directory, it has to exist.
+        // realpath() fails if the argument does not exist so the filename is separated.
+        $this->expandedFileName = realpath(dirname($fileName));
+        if ($this->expandedFileName === false) throw new Exception("Directory of $fileName does not exist!");
+        $this->expandedFileName .= '/'.basename($fileName);
+    }
 
 
-	/**
-	 * Set the maximum number of backup files to keep around.
-	 * 
-	 * <p>The <b>MaxBackupIndex</b> option determines how many backup
-	 * files are kept before the oldest is erased. This option takes
-	 * a positive integer value. If set to zero, then there will be no
-	 * backup files and the log file will be truncated when it reaches
-	 * MaxFileSize.
-	 *
-	 * @param mixed $maxBackups
-	 */
-	public function setMaxBackupIndex($maxBackups) {
-		if(is_numeric($maxBackups)) {
-			$this->maxBackupIndex = abs((int)$maxBackups);
-		}
-	}
+    /**
+     * Set the maximum number of backup files to keep around.
+     * 
+     * <p>The <b>MaxBackupIndex</b> option determines how many backup
+     * files are kept before the oldest is erased. This option takes
+     * a positive integer value. If set to zero, then there will be no
+     * backup files and the log file will be truncated when it reaches
+     * MaxFileSize.
+     *
+     * @param mixed $maxBackups
+     */
+    public function setMaxBackupIndex($maxBackups) {
+        if(is_numeric($maxBackups)) {
+            $this->maxBackupIndex = abs((int)$maxBackups);
+        }
+    }
 
-	/**
-	 * Set the maximum size that the output file is allowed to reach
-	 * before being rolled over to backup files.
-	 *
-	 * @param mixed $maxFileSize
-	 * @see setMaxFileSize()
-	 * @deprecated
-	 */
-	public function setMaximumFileSize($maxFileSize) {
-		return $this->setMaxFileSize($maxFileSize);
-	}
+    /**
+     * Set the maximum size that the output file is allowed to reach
+     * before being rolled over to backup files.
+     *
+     * @param mixed $maxFileSize
+     * @see setMaxFileSize()
+     * @deprecated
+     */
+    public function setMaximumFileSize($maxFileSize) {
+        return $this->setMaxFileSize($maxFileSize);
+    }
 
-	/**
-	 * Set the maximum size that the output file is allowed to reach
-	 * before being rolled over to backup files.
-	 * <p>In configuration files, the <b>MaxFileSize</b> option takes an
-	 * long integer in the range 0 - 2^63. You can specify the value
-	 * with the suffixes "KB", "MB" or "GB" so that the integer is
-	 * interpreted being expressed respectively in kilobytes, megabytes
-	 * or gigabytes. For example, the value "10KB" will be interpreted
-	 * as 10240.
-	 *
-	 * @param mixed $value
-	 * @return the actual file size set
-	 */
-	public function setMaxFileSize($value) {
-		$maxFileSize = null;
-		$numpart = substr($value,0, strlen($value) -2);
-		$suffix = strtoupper(substr($value, -2));
+    /**
+     * Set the maximum size that the output file is allowed to reach
+     * before being rolled over to backup files.
+     * <p>In configuration files, the <b>MaxFileSize</b> option takes an
+     * long integer in the range 0 - 2^63. You can specify the value
+     * with the suffixes "KB", "MB" or "GB" so that the integer is
+     * interpreted being expressed respectively in kilobytes, megabytes
+     * or gigabytes. For example, the value "10KB" will be interpreted
+     * as 10240.
+     *
+     * @param mixed $value
+     * @return the actual file size set
+     */
+    public function setMaxFileSize($value) {
+        $maxFileSize = null;
+        $numpart = substr($value,0, strlen($value) -2);
+        $suffix = strtoupper(substr($value, -2));
 
-		switch($suffix) {
-			case 'KB': $maxFileSize = (int)((int)$numpart * 1024); break;
-			case 'MB': $maxFileSize = (int)((int)$numpart * 1024 * 1024); break;
-			case 'GB': $maxFileSize = (int)((int)$numpart * 1024 * 1024 * 1024); break;
-			default:
-				if(is_numeric($value)) {
-					$maxFileSize = (int)$value;
-				}
-		}
+        switch($suffix) {
+            case 'KB': $maxFileSize = (int)((int)$numpart * 1024); break;
+            case 'MB': $maxFileSize = (int)((int)$numpart * 1024 * 1024); break;
+            case 'GB': $maxFileSize = (int)((int)$numpart * 1024 * 1024 * 1024); break;
+            default:
+                if(is_numeric($value)) {
+                    $maxFileSize = (int)$value;
+                }
+        }
 		
-		if($maxFileSize !== null) {
-			$this->maxFileSize = abs($maxFileSize);
-		}
-		return $this->maxFileSize;
-	}
+        if($maxFileSize !== null) {
+            $this->maxFileSize = abs($maxFileSize);
+        }
+        return $this->maxFileSize;
+    }
 
-	/**
-	 * @param LoggerLoggingEvent $event
-	 */
-	public function append(LoggerLoggingEvent $event) {
-		parent::append($event);
-		if(ftell($this->fp) > $this->getMaximumFileSize()) {
-			$this->rollOver();
-		}
-	}
+    /**
+     * @param LoggerLoggingEvent $event
+     */
+    public function append(LoggerLoggingEvent $event) {
+        parent::append($event);
+        if(ftell($this->fp) > $this->getMaximumFileSize()) {
+            $this->rollOver();
+        }
+    }
 }

main/inc/lib/phpdocx/lib/log4php/appenders/LoggerAppenderSocket.php

Doc Comments +1 added lines

@@ -225,6 +225,7 @@
 	
 	/**
 	 * @param mixed
+	 * @param boolean $flag
 	 */
 	public function setUseXml($flag) {
 		$this->useXml = LoggerOptionConverter::toBoolean($flag, $this->getUseXml());

Indentation +181 added lines, -181 removed lines

@@ -46,215 +46,215 @@
  */ 
 class LoggerAppenderSocket extends LoggerAppender {
 
-	/**
-	 * @var mixed socket connection resource
-	 * @access private
-	 */
-	private $sp = false;
+    /**
+     * @var mixed socket connection resource
+     * @access private
+     */
+    private $sp = false;
 	
-	/**
-	 * Target host. On how to define remote hostaname see 
-	 * {@link PHP_MANUAL#fsockopen}
-	 * @var string 
-	 */
-	private $remoteHost = '';
+    /**
+     * Target host. On how to define remote hostaname see 
+     * {@link PHP_MANUAL#fsockopen}
+     * @var string 
+     */
+    private $remoteHost = '';
 	
-	/**
-	 * @var integer the network port.
-	 */
-	private $port = 4446;
+    /**
+     * @var integer the network port.
+     */
+    private $port = 4446;
 	
-	/**
-	 * @var boolean get event's location info.
-	 */
-	private $locationInfo = false;
+    /**
+     * @var boolean get event's location info.
+     */
+    private $locationInfo = false;
 	
-	/**
-	 * @var integer connection timeout
-	 */
-	private $timeout = 30;
+    /**
+     * @var integer connection timeout
+     */
+    private $timeout = 30;
 	
-	/**
-	 * @var boolean output events via {@link LoggerXmlLayout}
-	 */
-	private $useXml = false;
+    /**
+     * @var boolean output events via {@link LoggerXmlLayout}
+     */
+    private $useXml = false;
 	
-	/**
-	 * @var boolean forward this option to {@link LoggerXmlLayout}. 
-	 *				Ignored if {@link $useXml} is <i>false</i>.
-	 */
-	private $log4jNamespace = false;
+    /**
+     * @var boolean forward this option to {@link LoggerXmlLayout}. 
+     *				Ignored if {@link $useXml} is <i>false</i>.
+     */
+    private $log4jNamespace = false;
 
-	/**
-	 * @var LoggerXmlLayout
-	 * @access private
-	 */
-	private $xmlLayout = null;
+    /**
+     * @var LoggerXmlLayout
+     * @access private
+     */
+    private $xmlLayout = null;
 	
-	/** @var indiciates if this appender should run in dry mode */
-	private $dry = false;
+    /** @var indiciates if this appender should run in dry mode */
+    private $dry = false;
 	
-	public function __destruct() {
-       $this->close();
-   	}
+    public function __destruct() {
+        $this->close();
+        }
    	
-	/**
-	 * Create a socket connection using defined parameters
-	 */
-	public function activateOptions() {
-		if(!$this->dry) {
-			$this->sp = @fsockopen($this->getRemoteHost(), $this->getPort(), $errno, $errstr, $this->getTimeout());
-			if ($this->sp === false) {
-			    throw new LoggerException("Could not open socket to ".$this->getRemoteHost().":".$this->getPort().": $errstr ($errno)");
-			}
-		}
-		if($this->getUseXml()) {
-			$this->xmlLayout = LoggerReflectionUtils::createObject('LoggerLayoutXml');
-			if($this->xmlLayout === null) {
-				$this->setUseXml(false);
-			} else {
-				$this->xmlLayout->setLocationInfo($this->getLocationInfo());
-				$this->xmlLayout->setLog4jNamespace($this->getLog4jNamespace());
-				$this->xmlLayout->activateOptions();
-			}			 
-		}
+    /**
+     * Create a socket connection using defined parameters
+     */
+    public function activateOptions() {
+        if(!$this->dry) {
+            $this->sp = @fsockopen($this->getRemoteHost(), $this->getPort(), $errno, $errstr, $this->getTimeout());
+            if ($this->sp === false) {
+                throw new LoggerException("Could not open socket to ".$this->getRemoteHost().":".$this->getPort().": $errstr ($errno)");
+            }
+        }
+        if($this->getUseXml()) {
+            $this->xmlLayout = LoggerReflectionUtils::createObject('LoggerLayoutXml');
+            if($this->xmlLayout === null) {
+                $this->setUseXml(false);
+            } else {
+                $this->xmlLayout->setLocationInfo($this->getLocationInfo());
+                $this->xmlLayout->setLog4jNamespace($this->getLog4jNamespace());
+                $this->xmlLayout->activateOptions();
+            }			 
+        }
         $this->closed = false;
-	}
+    }
 	
-	public function close() {
-		if($this->closed != true) {
-			if(!$this->dry and $this->sp !== false) {
-				fclose($this->sp);
-			}
-			$this->closed = true;
-		}
-	}
+    public function close() {
+        if($this->closed != true) {
+            if(!$this->dry and $this->sp !== false) {
+                fclose($this->sp);
+            }
+            $this->closed = true;
+        }
+    }
 
-	public function setDry($dry) {
-		$this->dry = $dry;
-	}
+    public function setDry($dry) {
+        $this->dry = $dry;
+    }
 	
-	/**
-	 * @return string
-	 */
-	public function getHostname() {
-		return $this->getRemoteHost();
-	}
+    /**
+     * @return string
+     */
+    public function getHostname() {
+        return $this->getRemoteHost();
+    }
 	
-	/**
-	 * @return boolean
-	 */
-	public function getLocationInfo() {
-		return $this->locationInfo;
-	} 
+    /**
+     * @return boolean
+     */
+    public function getLocationInfo() {
+        return $this->locationInfo;
+    } 
 	 
-	/**
-	 * @return boolean
-	 */
-	public function getLog4jNamespace() {
-		return $this->log4jNamespace;
-	}
+    /**
+     * @return boolean
+     */
+    public function getLog4jNamespace() {
+        return $this->log4jNamespace;
+    }
 
-	/**
-	 * @return integer
-	 */
-	public function getPort() {
-		return $this->port;
-	}
+    /**
+     * @return integer
+     */
+    public function getPort() {
+        return $this->port;
+    }
 	
-	public function getRemoteHost() {
-		return $this->remoteHost;
-	}
+    public function getRemoteHost() {
+        return $this->remoteHost;
+    }
 	
-	/**
-	 * @return integer
-	 */
-	public function getTimeout() {
-		return $this->timeout;
-	}
+    /**
+     * @return integer
+     */
+    public function getTimeout() {
+        return $this->timeout;
+    }
 	
-	/**
-	 * @var boolean
-	 */
-	public function getUseXml() {
-		return $this->useXml;
-	} 
+    /**
+     * @var boolean
+     */
+    public function getUseXml() {
+        return $this->useXml;
+    } 
 	 
-	public function reset() {
-		$this->close();
-		parent::reset();
-	}
+    public function reset() {
+        $this->close();
+        parent::reset();
+    }
 
-	/**
-	 * @param mixed
-	 */
-	public function setLocationInfo($flag) {
-		$this->locationInfo = LoggerOptionConverter::toBoolean($flag, $this->getLocationInfo());
-	} 
+    /**
+     * @param mixed
+     */
+    public function setLocationInfo($flag) {
+        $this->locationInfo = LoggerOptionConverter::toBoolean($flag, $this->getLocationInfo());
+    } 
 
-	/**
-	 * @param mixed
-	 */
-	public function setLog4jNamespace($flag) {
-		$this->log4jNamespace = LoggerOptionConverter::toBoolean($flag, $this->getLog4jNamespace());
-	} 
+    /**
+     * @param mixed
+     */
+    public function setLog4jNamespace($flag) {
+        $this->log4jNamespace = LoggerOptionConverter::toBoolean($flag, $this->getLog4jNamespace());
+    } 
 			
-	/**
-	 * @param integer
-	 */
-	public function setPort($port) {
-		$port = LoggerOptionConverter::toInt($port, 0);
-		if($port > 0 and $port < 65535) {
-			$this->port = $port;	
-		}
-	}
+    /**
+     * @param integer
+     */
+    public function setPort($port) {
+        $port = LoggerOptionConverter::toInt($port, 0);
+        if($port > 0 and $port < 65535) {
+            $this->port = $port;	
+        }
+    }
 	
-	/**
-	 * @param string
-	 */
-	public function setRemoteHost($hostname) {
-		$this->remoteHost = $hostname;
-	}
+    /**
+     * @param string
+     */
+    public function setRemoteHost($hostname) {
+        $this->remoteHost = $hostname;
+    }
 	
-	/**
-	 * @param integer
-	 */
-	public function setTimeout($timeout) {
-		$this->timeout = LoggerOptionConverter::toInt($timeout, $this->getTimeout());
-	}
+    /**
+     * @param integer
+     */
+    public function setTimeout($timeout) {
+        $this->timeout = LoggerOptionConverter::toInt($timeout, $this->getTimeout());
+    }
 	
-	/**
-	 * @param mixed
-	 */
-	public function setUseXml($flag) {
-		$this->useXml = LoggerOptionConverter::toBoolean($flag, $this->getUseXml());
-	} 
+    /**
+     * @param mixed
+     */
+    public function setUseXml($flag) {
+        $this->useXml = LoggerOptionConverter::toBoolean($flag, $this->getUseXml());
+    } 
  
-	public function append(LoggerLoggingEvent $event) {
-		if($this->sp || $this->dry) {
-			if($this->getLocationInfo()) {
-				$event->getLocationInformation();
-			}
+    public function append(LoggerLoggingEvent $event) {
+        if($this->sp || $this->dry) {
+            if($this->getLocationInfo()) {
+                $event->getLocationInformation();
+            }
 		
-			if(!$this->getUseXml()) {
-				$sEvent = serialize($event);
-				if(!$this->dry) {
-					fwrite($this->sp, $sEvent, strlen($sEvent));
-				} else {
-				    echo "DRY MODE OF SOCKET APPENDER: ".$sEvent;
-				}
-			} else {
-				if(!$this->dry) {
-					fwrite($this->sp, $this->xmlLayout->format($event));
-				} else {
-				    echo "DRY MODE OF SOCKET APPENDER: ".$this->xmlLayout->format($event);
-				}
-			}			 
+            if(!$this->getUseXml()) {
+                $sEvent = serialize($event);
+                if(!$this->dry) {
+                    fwrite($this->sp, $sEvent, strlen($sEvent));
+                } else {
+                    echo "DRY MODE OF SOCKET APPENDER: ".$sEvent;
+                }
+            } else {
+                if(!$this->dry) {
+                    fwrite($this->sp, $this->xmlLayout->format($event));
+                } else {
+                    echo "DRY MODE OF SOCKET APPENDER: ".$this->xmlLayout->format($event);
+                }
+            }			 
 
-			// not sure about it...
-			if(!$this->dry) {
-				fflush($this->sp);
-			}
-		} 
-	}
+            // not sure about it...
+            if(!$this->dry) {
+                fflush($this->sp);
+            }
+        } 
+    }
 }

Spacing +12 added lines, -12 removed lines

@@ -102,15 +102,15 @@ 
 	 * Create a socket connection using defined parameters
 	 */
 	public function activateOptions() {
-		if(!$this->dry) {
+		if (!$this->dry) {
 			$this->sp = @fsockopen($this->getRemoteHost(), $this->getPort(), $errno, $errstr, $this->getTimeout());
 			if ($this->sp === false) {
 			    throw new LoggerException("Could not open socket to ".$this->getRemoteHost().":".$this->getPort().": $errstr ($errno)");
 			}
 		}
-		if($this->getUseXml()) {
+		if ($this->getUseXml()) {
 			$this->xmlLayout = LoggerReflectionUtils::createObject('LoggerLayoutXml');
-			if($this->xmlLayout === null) {
+			if ($this->xmlLayout === null) {
 				$this->setUseXml(false);
 			} else {
 				$this->xmlLayout->setLocationInfo($this->getLocationInfo());
@@ -122,8 +122,8 @@ 
 	}
 	
 	public function close() {
-		if($this->closed != true) {
-			if(!$this->dry and $this->sp !== false) {
+		if ($this->closed != true) {
+			if (!$this->dry and $this->sp !== false) {
 				fclose($this->sp);
 			}
 			$this->closed = true;
@@ -204,7 +204,7 @@ 
 	 */
 	public function setPort($port) {
 		$port = LoggerOptionConverter::toInt($port, 0);
-		if($port > 0 and $port < 65535) {
+		if ($port > 0 and $port < 65535) {
 			$this->port = $port;	
 		}
 	}
@@ -231,20 +231,20 @@ 
 	} 
  
 	public function append(LoggerLoggingEvent $event) {
-		if($this->sp || $this->dry) {
-			if($this->getLocationInfo()) {
+		if ($this->sp || $this->dry) {
+			if ($this->getLocationInfo()) {
 				$event->getLocationInformation();
 			}
 		
-			if(!$this->getUseXml()) {
+			if (!$this->getUseXml()) {
 				$sEvent = serialize($event);
-				if(!$this->dry) {
+				if (!$this->dry) {
 					fwrite($this->sp, $sEvent, strlen($sEvent));
 				} else {
 				    echo "DRY MODE OF SOCKET APPENDER: ".$sEvent;
 				}
 			} else {
-				if(!$this->dry) {
+				if (!$this->dry) {
 					fwrite($this->sp, $this->xmlLayout->format($event));
 				} else {
 				    echo "DRY MODE OF SOCKET APPENDER: ".$this->xmlLayout->format($event);
@@ -252,7 +252,7 @@ 
 			}			 
 
 			// not sure about it...
-			if(!$this->dry) {
+			if (!$this->dry) {
 				fflush($this->sp);
 			}
 		} 

main/inc/lib/phpdocx/lib/log4php/configurators/LoggerConfiguratorIni.php

Doc Comments -1 removed lines

@@ -279,7 +279,6 @@
 	 * 
 	 * @param string $url The name of the configuration file where the
 	 *					  configuration information is stored.
-	 * @param LoggerHierarchy $repository the repository to apply the configuration
 	 */
 	public function configure(LoggerHierarchy $hierarchy, $url = '') {
 		$properties = @parse_ini_file($url);

Spacing +26 added lines, -26 removed lines

@@ -313,16 +313,16 @@ 
 		$effectivePrefix = self::ROOT_LOGGER_PREFIX;
 		$value = @$props[self::ROOT_LOGGER_PREFIX];
 
-		if(empty($value)) {
+		if (empty($value)) {
 			$value = @$props[self::ROOT_CATEGORY_PREFIX];
 			$effectivePrefix = self::ROOT_CATEGORY_PREFIX;
 		}
 
-		if(empty($value)) {
+		if (empty($value)) {
 			// TODO "Could not find root logger information. Is this OK?"
 		} else {
 			$root = $hierarchy->getRootLogger();
-			$this->parseCategory($props, $root, $effectivePrefix, self::INTERNAL_ROOT_NAME,	$value);
+			$this->parseCategory($props, $root, $effectivePrefix, self::INTERNAL_ROOT_NAME, $value);
 		}
 	}
 
@@ -333,19 +333,19 @@ 
 	 * @param LoggerHierarchy $hierarchy
 	 */
 	private function parseCatsAndRenderers($props, LoggerHierarchy $hierarchy) {
-		while(list($key,$value) = each($props)) {
-			if(strpos($key, self::CATEGORY_PREFIX) === 0 or 
+		while (list($key, $value) = each($props)) {
+			if (strpos($key, self::CATEGORY_PREFIX) === 0 or 
 				strpos($key, self::LOGGER_PREFIX) === 0) {
-				if(strpos($key, self::CATEGORY_PREFIX) === 0) {
+				if (strpos($key, self::CATEGORY_PREFIX) === 0) {
 					$loggerName = substr($key, strlen(self::CATEGORY_PREFIX));
-				} else if(strpos($key, self::LOGGER_PREFIX) === 0) {
+				} else if (strpos($key, self::LOGGER_PREFIX) === 0) {
 					$loggerName = substr($key, strlen(self::LOGGER_PREFIX));
 				}
 				
 				$logger = $hierarchy->getLogger($loggerName);
 				$this->parseCategory($props, $logger, $key, $loggerName, $value);
 				$this->parseAdditivityForLogger($props, $logger, $loggerName);
-			} else if(strpos($key, self::RENDERER_PREFIX) === 0) {
+			} else if (strpos($key, self::RENDERER_PREFIX) === 0) {
 				$renderedClass = substr($key, strlen(self::RENDERER_PREFIX));
 				$renderingClass = $value;
 				$hierarchy->getRendererMap()->addRenderer($renderedClass, $renderingClass);
@@ -361,10 +361,10 @@ 
 	 * @param string $loggerName
 	 */
 	private function parseAdditivityForLogger($props, Logger $cat, $loggerName) {
-		$value = LoggerOptionConverter::findAndSubst(self::ADDITIVITY_PREFIX . $loggerName, $props);
+		$value = LoggerOptionConverter::findAndSubst(self::ADDITIVITY_PREFIX.$loggerName, $props);
 		
 		// touch additivity only if necessary
-		if(!empty($value)) {
+		if (!empty($value)) {
 			$additivity = LoggerOptionConverter::toBoolean($value, true);
 			$cat->setAdditivity($additivity);
 		}
@@ -387,9 +387,9 @@ 
 		// If value is not in the form ", appender.." or "", then we should set
 		// the level of the loggeregory.
 
-		if(!(empty($value) || @$value[0] == ',')) {
+		if (!(empty($value) || @$value[0] == ',')) {
 			// just to be on the safe side...
-			if(count($st) == 0) {
+			if (count($st) == 0) {
 				return;
 			}
 			$levelStr = current($st);
@@ -397,8 +397,8 @@ 
 			// If the level value is inherited, set category level value to
 			// null. We also check that the user has not specified inherited for the
 			// root category.
-			if('INHERITED' == strtoupper($levelStr) || 'NULL' == strtoupper($levelStr)) {
-				if($loggerName == self::INTERNAL_ROOT_NAME) {
+			if ('INHERITED' == strtoupper($levelStr) || 'NULL' == strtoupper($levelStr)) {
+				if ($loggerName == self::INTERNAL_ROOT_NAME) {
 					// TODO: throw exception?	"The root logger cannot be set to null."
 				} else {
 					$logger->setLevel(null);
@@ -410,14 +410,14 @@ 
 
 		// TODO: removing should be done by the logger, if necessary and wanted 
 		// $logger->removeAllAppenders();
-		while($appenderName = next($st)) {
+		while ($appenderName = next($st)) {
 			$appenderName = trim($appenderName);
-			if(empty($appenderName)) {
+			if (empty($appenderName)) {
 				continue;
 			}
 			
 			$appender = $this->parseAppender($props, $appenderName);
-			if($appender !== null) {
+			if ($appender !== null) {
 					$logger->addAppender($appender);
 			}
 		}
@@ -430,34 +430,34 @@ 
 	 */
 	private function parseAppender($props, $appenderName) {
 		$appender = LoggerAppenderPool::getAppenderFromPool($appenderName);
-		$prefix = self::APPENDER_PREFIX . $appenderName;
-		if($appender === null) {
+		$prefix = self::APPENDER_PREFIX.$appenderName;
+		if ($appender === null) {
 			// Appender was not previously initialized.
 			$appenderClass = @$props[$prefix];
 			$appender = LoggerAppenderPool::getAppenderFromPool($appenderName, $appenderClass);
-			if($appender === null) {
+			if ($appender === null) {
 				return null;
 			}
 		}
 		
-		if($appender->requiresLayout() ) {
-			$layoutPrefix = $prefix . ".layout";
+		if ($appender->requiresLayout()) {
+			$layoutPrefix = $prefix.".layout";
 			$layoutClass = @$props[$layoutPrefix];
 			$layoutClass = LoggerOptionConverter::substVars($layoutClass, $props);
-			if(empty($layoutClass)) {
+			if (empty($layoutClass)) {
 				$layout = LoggerReflectionUtils::createObject('LoggerLayoutSimple');
 			} else {
 				$layout = LoggerReflectionUtils::createObject($layoutClass);
-				if($layout === null) {
+				if ($layout === null) {
 					$layout = LoggerReflectionUtils::createObject('LoggerLayoutSimple');
 				}
 			}
 			
-			LoggerReflectionUtils::setPropertiesByObject($layout, $props, $layoutPrefix . ".");				  
+			LoggerReflectionUtils::setPropertiesByObject($layout, $props, $layoutPrefix.".");				  
 			$appender->setLayout($layout);
 			
 		}
-		LoggerReflectionUtils::setPropertiesByObject($appender, $props, $prefix . ".");
+		LoggerReflectionUtils::setPropertiesByObject($appender, $props, $prefix.".");
 		return $appender;		 
 	}
 }

Indentation +376 added lines, -376 removed lines

@@ -63,401 +63,401 @@
  * @since 0.5
  */
 class LoggerConfiguratorIni implements LoggerConfigurator {
- 	const CATEGORY_PREFIX = "log4php.category.";
- 	const LOGGER_PREFIX = "log4php.logger.";
-	const FACTORY_PREFIX = "log4php.factory";
-	const ADDITIVITY_PREFIX = "log4php.additivity.";
-	const ROOT_CATEGORY_PREFIX = "log4php.rootCategory";
-	const ROOT_LOGGER_PREFIX = "log4php.rootLogger";
-	const APPENDER_PREFIX = "log4php.appender.";
-	const RENDERER_PREFIX = "log4php.renderer.";
-	const THRESHOLD_PREFIX = "log4php.threshold";
+        const CATEGORY_PREFIX = "log4php.category.";
+        const LOGGER_PREFIX = "log4php.logger.";
+    const FACTORY_PREFIX = "log4php.factory";
+    const ADDITIVITY_PREFIX = "log4php.additivity.";
+    const ROOT_CATEGORY_PREFIX = "log4php.rootCategory";
+    const ROOT_LOGGER_PREFIX = "log4php.rootLogger";
+    const APPENDER_PREFIX = "log4php.appender.";
+    const RENDERER_PREFIX = "log4php.renderer.";
+    const THRESHOLD_PREFIX = "log4php.threshold";
 	
-	/** 
-	 * Key for specifying the {@link LoggerFactory}.  
-	 */
-	const LOGGER_FACTORY_KEY = "log4php.loggerFactory";
-	const LOGGER_DEBUG_KEY = "log4php.debug";
-	const INTERNAL_ROOT_NAME = "root";
+    /** 
+     * Key for specifying the {@link LoggerFactory}.  
+     */
+    const LOGGER_FACTORY_KEY = "log4php.loggerFactory";
+    const LOGGER_DEBUG_KEY = "log4php.debug";
+    const INTERNAL_ROOT_NAME = "root";
 	
-	/**
-	 * Constructor
-	 */
-	public function __construct() {
-	}
+    /**
+     * Constructor
+     */
+    public function __construct() {
+    }
 
-	/**
-	 * Read configuration from a file.
-	 *
-	 * <p>The function {@link PHP_MANUAL#parse_ini_file} is used to read the
-	 * file.</p>
-	 *
-	 * <b>The existing configuration is not cleared nor reset.</b> 
-	 * If you require a different behavior, then call 
-	 * {@link  Logger::resetConfiguration()} 
-	 * method before calling {@link doConfigure()}.
-	 * 
-	 * <p>The configuration file consists of statements in the format
-	 * <b>key=value</b>. The syntax of different configuration
-	 * elements are discussed below.
-	 * 
-	 * <p><b>Repository-wide threshold</b></p>
-	 * 
-	 * <p>The repository-wide threshold filters logging requests by level
-	 * regardless of logger. The syntax is:
-	 * 
-	 * <pre>
-	 * log4php.threshold=[level]
-	 * </pre>
-	 * 
-	 * <p>The level value can consist of the string values OFF, FATAL,
-	 * ERROR, WARN, INFO, DEBUG, ALL or a <i>custom level</i> value. A
-	 * custom level value can be specified in the form
-	 * <samp>level#classname</samp>. By default the repository-wide threshold is set
-	 * to the lowest possible value, namely the level <b>ALL</b>.
-	 * </p>
-	 * 
-	 * 
-	 * <p><b>Appender configuration</b></p>
-	 * 
-	 * <p>Appender configuration syntax is:</p>
-	 * <pre>
-	 * ; For appender named <i>appenderName</i>, set its class.
-	 * ; Note: The appender name can contain dots.
-	 * log4php.appender.appenderName=name_of_appender_class
-	 * 
-	 * ; Set appender specific options.
-	 * 
-	 * log4php.appender.appenderName.option1=value1
-	 * log4php.appender.appenderName.optionN=valueN
-	 * </pre>
-	 * 
-	 * For each named appender you can configure its {@link LoggerLayout}. The
-	 * syntax for configuring an appender's layout is:
-	 * <pre>
-	 * log4php.appender.appenderName.layout=name_of_layout_class
-	 * log4php.appender.appenderName.layout.option1=value1
-	 *	....
-	 * log4php.appender.appenderName.layout.optionN=valueN
-	 * </pre>
-	 * 
-	 * <p><b>Configuring loggers</b></p>
-	 * 
-	 * <p>The syntax for configuring the root logger is:
-	 * <pre>
-	 * log4php.rootLogger=[level], appenderName, appenderName, ...
-	 * </pre>
-	 * 
-	 * <p>This syntax means that an optional <i>level</i> can be
-	 * supplied followed by appender names separated by commas.
-	 * 
-	 * <p>The level value can consist of the string values OFF, FATAL,
-	 * ERROR, WARN, INFO, DEBUG, ALL or a <i>custom level</i> value. A
-	 * custom level value can be specified in the form</p>
-	 *
-	 * <pre>level#classname</pre>
-	 * 
-	 * <p>If a level value is specified, then the root level is set
-	 * to the corresponding level.	If no level value is specified,
-	 * then the root level remains untouched.
-	 * 
-	 * <p>The root logger can be assigned multiple appenders.
-	 * 
-	 * <p>Each <i>appenderName</i> (separated by commas) will be added to
-	 * the root logger. The named appender is defined using the
-	 * appender syntax defined above.
-	 * 
-	 * <p>For non-root categories the syntax is almost the same:
-	 * <pre>
-	 * log4php.logger.logger_name=[level|INHERITED|NULL], appenderName, appenderName, ...
-	 * </pre>
-	 * 
-	 * <p>The meaning of the optional level value is discussed above
-	 * in relation to the root logger. In addition however, the value
-	 * INHERITED can be specified meaning that the named logger should
-	 * inherit its level from the logger hierarchy.</p>
-	 * 
-	 * <p>If no level value is supplied, then the level of the
-	 * named logger remains untouched.</p>
-	 * 
-	 * <p>By default categories inherit their level from the
-	 * hierarchy. However, if you set the level of a logger and later
-	 * decide that that logger should inherit its level, then you should
-	 * specify INHERITED as the value for the level value. NULL is a
-	 * synonym for INHERITED.</p>
-	 * 
-	 * <p>Similar to the root logger syntax, each <i>appenderName</i>
-	 * (separated by commas) will be attached to the named logger.</p>
-	 * 
-	 * <p>See the <i>appender additivity rule</i> in the user manual for 
-	 * the meaning of the <b>additivity</b> flag.
-	 * 
-	 * <p><b>ObjectRenderers</b></p>
-	 * 
-	 * <p>You can customize the way message objects of a given type are
-	 * converted to String before being logged. This is done by
-	 * specifying a {@link LoggerRendererObject}
-	 * for the object type would like to customize.</p>
-	 * 
-	 * <p>The syntax is:
-	 * 
-	 * <pre>
-	 * log4php.renderer.name_of_rendered_class=name_of_rendering.class
-	 * </pre>
-	 * 
-	 * As in,
-	 * <pre>
-	 * log4php.renderer.myFruit=myFruitRenderer
-	 * </pre>
-	 * 
-	 * <p><b>Logger Factories</b></p>
-	 * 
-	 * The usage of custom logger factories is discouraged and no longer
-	 * documented.
-	 * 
-	 * <p><b>Example</b></p>
-	 * 
-	 * <p>An example configuration is given below. Other configuration
-	 * file examples are given in the <b>tests</b> folder.
-	 * 
-	 * <pre>
-	 * ; Set options for appender named "A1".
-	 * ; Appender "A1" will be a LoggerAppenderSyslog
-	 * log4php.appender.A1=LoggerAppenderSyslog
-	 * 
-	 * ; The syslog daemon resides on www.abc.net
-	 * log4php.appender.A1.ident=log4php-test
-	 * 
-	 * ; A1's layout is a LoggerPatternLayout, using the conversion pattern
-	 * ; <b>%r %-5p %c{2} %M.%L %x - %m%n</b>. Thus, the log output will
-	 * ; include the relative time since the start of the application in
-	 * ; milliseconds, followed by the level of the log request,
-	 * ; followed by the two rightmost components of the logger name,
-	 * ; followed by the callers method name, followed by the line number,
-	 * ; the nested disgnostic context and finally the message itself.
-	 * ; Refer to the documentation of LoggerPatternLayout} for further information
-	 * ; on the syntax of the ConversionPattern key.
-	 * log4php.appender.A1.layout=LoggerPatternLayout
-	 * log4php.appender.A1.layout.ConversionPattern="%-4r %-5p %c{2} %M.%L %x - %m%n"
-	 * 
-	 * ; Set options for appender named "A2"
-	 * ; A2 should be a LoggerAppenderRollingFile, with maximum file size of 10 MB
-	 * ; using at most one backup file. A2's layout is TTCC, using the
-	 * ; ISO8061 date format with context printing enabled.
-	 * log4php.appender.A2=LoggerAppenderRollingFile
-	 * log4php.appender.A2.MaxFileSize=10MB
-	 * log4php.appender.A2.MaxBackupIndex=1
-	 * log4php.appender.A2.layout=LoggerLayoutTTCC
-	 * log4php.appender.A2.layout.ContextPrinting="true"
-	 * log4php.appender.A2.layout.DateFormat="%c"
-	 * 
-	 * ; Root logger set to DEBUG using the A2 appender defined above.
-	 * log4php.rootLogger=DEBUG, A2
-	 * 
-	 * ; Logger definitions:
-	 * ; The SECURITY logger inherits is level from root. However, it's output
-	 * ; will go to A1 appender defined above. It's additivity is non-cumulative.
-	 * log4php.logger.SECURITY=INHERIT, A1
-	 * log4php.additivity.SECURITY=false
-	 * 
-	 * ; Only warnings or above will be logged for the logger "SECURITY.access".
-	 * ; Output will go to A1.
-	 * log4php.logger.SECURITY.access=WARN
-	 * 
-	 * 
-	 * ; The logger "class.of.the.day" inherits its level from the
-	 * ; logger hierarchy.	Output will go to the appender's of the root
-	 * ; logger, A2 in this case.
-	 * log4php.logger.class.of.the.day=INHERIT
-	 * </pre>
-	 * 
-	 * <p>Refer to the <b>setOption</b> method in each Appender and
-	 * Layout for class specific options.</p>
-	 * 
-	 * <p>Use the <b>&quot;;&quot;</b> character at the
-	 * beginning of a line for comments.</p>
-	 * 
-	 * @param string $url The name of the configuration file where the
-	 *					  configuration information is stored.
-	 * @param LoggerHierarchy $repository the repository to apply the configuration
-	 */
-	public function configure(LoggerHierarchy $hierarchy, $url = '') {
-		$properties = @parse_ini_file($url);
-		if ($properties === false || count($properties) == 0) {
-			$error = error_get_last();
-		    throw new LoggerException("LoggerConfiguratorIni: ".$error['message']);
-		}
-		return $this->doConfigureProperties($properties, $hierarchy);
-	}
+    /**
+     * Read configuration from a file.
+     *
+     * <p>The function {@link PHP_MANUAL#parse_ini_file} is used to read the
+     * file.</p>
+     *
+     * <b>The existing configuration is not cleared nor reset.</b> 
+     * If you require a different behavior, then call 
+     * {@link  Logger::resetConfiguration()} 
+     * method before calling {@link doConfigure()}.
+     * 
+     * <p>The configuration file consists of statements in the format
+     * <b>key=value</b>. The syntax of different configuration
+     * elements are discussed below.
+     * 
+     * <p><b>Repository-wide threshold</b></p>
+     * 
+     * <p>The repository-wide threshold filters logging requests by level
+     * regardless of logger. The syntax is:
+     * 
+     * <pre>
+     * log4php.threshold=[level]
+     * </pre>
+     * 
+     * <p>The level value can consist of the string values OFF, FATAL,
+     * ERROR, WARN, INFO, DEBUG, ALL or a <i>custom level</i> value. A
+     * custom level value can be specified in the form
+     * <samp>level#classname</samp>. By default the repository-wide threshold is set
+     * to the lowest possible value, namely the level <b>ALL</b>.
+     * </p>
+     * 
+     * 
+     * <p><b>Appender configuration</b></p>
+     * 
+     * <p>Appender configuration syntax is:</p>
+     * <pre>
+     * ; For appender named <i>appenderName</i>, set its class.
+     * ; Note: The appender name can contain dots.
+     * log4php.appender.appenderName=name_of_appender_class
+     * 
+     * ; Set appender specific options.
+     * 
+     * log4php.appender.appenderName.option1=value1
+     * log4php.appender.appenderName.optionN=valueN
+     * </pre>
+     * 
+     * For each named appender you can configure its {@link LoggerLayout}. The
+     * syntax for configuring an appender's layout is:
+     * <pre>
+     * log4php.appender.appenderName.layout=name_of_layout_class
+     * log4php.appender.appenderName.layout.option1=value1
+     *	....
+     * log4php.appender.appenderName.layout.optionN=valueN
+     * </pre>
+     * 
+     * <p><b>Configuring loggers</b></p>
+     * 
+     * <p>The syntax for configuring the root logger is:
+     * <pre>
+     * log4php.rootLogger=[level], appenderName, appenderName, ...
+     * </pre>
+     * 
+     * <p>This syntax means that an optional <i>level</i> can be
+     * supplied followed by appender names separated by commas.
+     * 
+     * <p>The level value can consist of the string values OFF, FATAL,
+     * ERROR, WARN, INFO, DEBUG, ALL or a <i>custom level</i> value. A
+     * custom level value can be specified in the form</p>
+     *
+     * <pre>level#classname</pre>
+     * 
+     * <p>If a level value is specified, then the root level is set
+     * to the corresponding level.	If no level value is specified,
+     * then the root level remains untouched.
+     * 
+     * <p>The root logger can be assigned multiple appenders.
+     * 
+     * <p>Each <i>appenderName</i> (separated by commas) will be added to
+     * the root logger. The named appender is defined using the
+     * appender syntax defined above.
+     * 
+     * <p>For non-root categories the syntax is almost the same:
+     * <pre>
+     * log4php.logger.logger_name=[level|INHERITED|NULL], appenderName, appenderName, ...
+     * </pre>
+     * 
+     * <p>The meaning of the optional level value is discussed above
+     * in relation to the root logger. In addition however, the value
+     * INHERITED can be specified meaning that the named logger should
+     * inherit its level from the logger hierarchy.</p>
+     * 
+     * <p>If no level value is supplied, then the level of the
+     * named logger remains untouched.</p>
+     * 
+     * <p>By default categories inherit their level from the
+     * hierarchy. However, if you set the level of a logger and later
+     * decide that that logger should inherit its level, then you should
+     * specify INHERITED as the value for the level value. NULL is a
+     * synonym for INHERITED.</p>
+     * 
+     * <p>Similar to the root logger syntax, each <i>appenderName</i>
+     * (separated by commas) will be attached to the named logger.</p>
+     * 
+     * <p>See the <i>appender additivity rule</i> in the user manual for 
+     * the meaning of the <b>additivity</b> flag.
+     * 
+     * <p><b>ObjectRenderers</b></p>
+     * 
+     * <p>You can customize the way message objects of a given type are
+     * converted to String before being logged. This is done by
+     * specifying a {@link LoggerRendererObject}
+     * for the object type would like to customize.</p>
+     * 
+     * <p>The syntax is:
+     * 
+     * <pre>
+     * log4php.renderer.name_of_rendered_class=name_of_rendering.class
+     * </pre>
+     * 
+     * As in,
+     * <pre>
+     * log4php.renderer.myFruit=myFruitRenderer
+     * </pre>
+     * 
+     * <p><b>Logger Factories</b></p>
+     * 
+     * The usage of custom logger factories is discouraged and no longer
+     * documented.
+     * 
+     * <p><b>Example</b></p>
+     * 
+     * <p>An example configuration is given below. Other configuration
+     * file examples are given in the <b>tests</b> folder.
+     * 
+     * <pre>
+     * ; Set options for appender named "A1".
+     * ; Appender "A1" will be a LoggerAppenderSyslog
+     * log4php.appender.A1=LoggerAppenderSyslog
+     * 
+     * ; The syslog daemon resides on www.abc.net
+     * log4php.appender.A1.ident=log4php-test
+     * 
+     * ; A1's layout is a LoggerPatternLayout, using the conversion pattern
+     * ; <b>%r %-5p %c{2} %M.%L %x - %m%n</b>. Thus, the log output will
+     * ; include the relative time since the start of the application in
+     * ; milliseconds, followed by the level of the log request,
+     * ; followed by the two rightmost components of the logger name,
+     * ; followed by the callers method name, followed by the line number,
+     * ; the nested disgnostic context and finally the message itself.
+     * ; Refer to the documentation of LoggerPatternLayout} for further information
+     * ; on the syntax of the ConversionPattern key.
+     * log4php.appender.A1.layout=LoggerPatternLayout
+     * log4php.appender.A1.layout.ConversionPattern="%-4r %-5p %c{2} %M.%L %x - %m%n"
+     * 
+     * ; Set options for appender named "A2"
+     * ; A2 should be a LoggerAppenderRollingFile, with maximum file size of 10 MB
+     * ; using at most one backup file. A2's layout is TTCC, using the
+     * ; ISO8061 date format with context printing enabled.
+     * log4php.appender.A2=LoggerAppenderRollingFile
+     * log4php.appender.A2.MaxFileSize=10MB
+     * log4php.appender.A2.MaxBackupIndex=1
+     * log4php.appender.A2.layout=LoggerLayoutTTCC
+     * log4php.appender.A2.layout.ContextPrinting="true"
+     * log4php.appender.A2.layout.DateFormat="%c"
+     * 
+     * ; Root logger set to DEBUG using the A2 appender defined above.
+     * log4php.rootLogger=DEBUG, A2
+     * 
+     * ; Logger definitions:
+     * ; The SECURITY logger inherits is level from root. However, it's output
+     * ; will go to A1 appender defined above. It's additivity is non-cumulative.
+     * log4php.logger.SECURITY=INHERIT, A1
+     * log4php.additivity.SECURITY=false
+     * 
+     * ; Only warnings or above will be logged for the logger "SECURITY.access".
+     * ; Output will go to A1.
+     * log4php.logger.SECURITY.access=WARN
+     * 
+     * 
+     * ; The logger "class.of.the.day" inherits its level from the
+     * ; logger hierarchy.	Output will go to the appender's of the root
+     * ; logger, A2 in this case.
+     * log4php.logger.class.of.the.day=INHERIT
+     * </pre>
+     * 
+     * <p>Refer to the <b>setOption</b> method in each Appender and
+     * Layout for class specific options.</p>
+     * 
+     * <p>Use the <b>&quot;;&quot;</b> character at the
+     * beginning of a line for comments.</p>
+     * 
+     * @param string $url The name of the configuration file where the
+     *					  configuration information is stored.
+     * @param LoggerHierarchy $repository the repository to apply the configuration
+     */
+    public function configure(LoggerHierarchy $hierarchy, $url = '') {
+        $properties = @parse_ini_file($url);
+        if ($properties === false || count($properties) == 0) {
+            $error = error_get_last();
+            throw new LoggerException("LoggerConfiguratorIni: ".$error['message']);
+        }
+        return $this->doConfigureProperties($properties, $hierarchy);
+    }
 
-	/**
-	 * Read configuration options from <b>properties</b>.
-	 *
-	 * @see doConfigure().
-	 * @param array $properties
-	 * @param LoggerHierarchy $hierarchy
-	 */
-	private function doConfigureProperties($properties, LoggerHierarchy $hierarchy) {
-		$thresholdStr = @$properties[self::THRESHOLD_PREFIX];
-		$hierarchy->setThreshold(LoggerOptionConverter::toLevel($thresholdStr, LoggerLevel::getLevelAll()));
-		$this->configureRootCategory($properties, $hierarchy);
-		$this->parseCatsAndRenderers($properties, $hierarchy);
-		return true;
-	}
+    /**
+     * Read configuration options from <b>properties</b>.
+     *
+     * @see doConfigure().
+     * @param array $properties
+     * @param LoggerHierarchy $hierarchy
+     */
+    private function doConfigureProperties($properties, LoggerHierarchy $hierarchy) {
+        $thresholdStr = @$properties[self::THRESHOLD_PREFIX];
+        $hierarchy->setThreshold(LoggerOptionConverter::toLevel($thresholdStr, LoggerLevel::getLevelAll()));
+        $this->configureRootCategory($properties, $hierarchy);
+        $this->parseCatsAndRenderers($properties, $hierarchy);
+        return true;
+    }
 
-	/**
-	 * @param array $props array of properties
-	 * @param LoggerHierarchy $hierarchy
-	 */
-	private function configureRootCategory($props, LoggerHierarchy $hierarchy) {
-		$effectivePrefix = self::ROOT_LOGGER_PREFIX;
-		$value = @$props[self::ROOT_LOGGER_PREFIX];
+    /**
+     * @param array $props array of properties
+     * @param LoggerHierarchy $hierarchy
+     */
+    private function configureRootCategory($props, LoggerHierarchy $hierarchy) {
+        $effectivePrefix = self::ROOT_LOGGER_PREFIX;
+        $value = @$props[self::ROOT_LOGGER_PREFIX];
 
-		if(empty($value)) {
-			$value = @$props[self::ROOT_CATEGORY_PREFIX];
-			$effectivePrefix = self::ROOT_CATEGORY_PREFIX;
-		}
+        if(empty($value)) {
+            $value = @$props[self::ROOT_CATEGORY_PREFIX];
+            $effectivePrefix = self::ROOT_CATEGORY_PREFIX;
+        }
 
-		if(empty($value)) {
-			// TODO "Could not find root logger information. Is this OK?"
-		} else {
-			$root = $hierarchy->getRootLogger();
-			$this->parseCategory($props, $root, $effectivePrefix, self::INTERNAL_ROOT_NAME,	$value);
-		}
-	}
+        if(empty($value)) {
+            // TODO "Could not find root logger information. Is this OK?"
+        } else {
+            $root = $hierarchy->getRootLogger();
+            $this->parseCategory($props, $root, $effectivePrefix, self::INTERNAL_ROOT_NAME,	$value);
+        }
+    }
 
-	/**
-	 * Parse non-root elements, such non-root categories and renderers.
-	 *
-	 * @param array $props array of properties
-	 * @param LoggerHierarchy $hierarchy
-	 */
-	private function parseCatsAndRenderers($props, LoggerHierarchy $hierarchy) {
-		while(list($key,$value) = each($props)) {
-			if(strpos($key, self::CATEGORY_PREFIX) === 0 or 
-				strpos($key, self::LOGGER_PREFIX) === 0) {
-				if(strpos($key, self::CATEGORY_PREFIX) === 0) {
-					$loggerName = substr($key, strlen(self::CATEGORY_PREFIX));
-				} else if(strpos($key, self::LOGGER_PREFIX) === 0) {
-					$loggerName = substr($key, strlen(self::LOGGER_PREFIX));
-				}
+    /**
+     * Parse non-root elements, such non-root categories and renderers.
+     *
+     * @param array $props array of properties
+     * @param LoggerHierarchy $hierarchy
+     */
+    private function parseCatsAndRenderers($props, LoggerHierarchy $hierarchy) {
+        while(list($key,$value) = each($props)) {
+            if(strpos($key, self::CATEGORY_PREFIX) === 0 or 
+                strpos($key, self::LOGGER_PREFIX) === 0) {
+                if(strpos($key, self::CATEGORY_PREFIX) === 0) {
+                    $loggerName = substr($key, strlen(self::CATEGORY_PREFIX));
+                } else if(strpos($key, self::LOGGER_PREFIX) === 0) {
+                    $loggerName = substr($key, strlen(self::LOGGER_PREFIX));
+                }
 				
-				$logger = $hierarchy->getLogger($loggerName);
-				$this->parseCategory($props, $logger, $key, $loggerName, $value);
-				$this->parseAdditivityForLogger($props, $logger, $loggerName);
-			} else if(strpos($key, self::RENDERER_PREFIX) === 0) {
-				$renderedClass = substr($key, strlen(self::RENDERER_PREFIX));
-				$renderingClass = $value;
-				$hierarchy->getRendererMap()->addRenderer($renderedClass, $renderingClass);
-			}
-		}
-	}
+                $logger = $hierarchy->getLogger($loggerName);
+                $this->parseCategory($props, $logger, $key, $loggerName, $value);
+                $this->parseAdditivityForLogger($props, $logger, $loggerName);
+            } else if(strpos($key, self::RENDERER_PREFIX) === 0) {
+                $renderedClass = substr($key, strlen(self::RENDERER_PREFIX));
+                $renderingClass = $value;
+                $hierarchy->getRendererMap()->addRenderer($renderedClass, $renderingClass);
+            }
+        }
+    }
 
-	/**
-	 * Parse the additivity option for a non-root category.
-	 *
-	 * @param array $props array of properties
-	 * @param Logger $cat
-	 * @param string $loggerName
-	 */
-	private function parseAdditivityForLogger($props, Logger $cat, $loggerName) {
-		$value = LoggerOptionConverter::findAndSubst(self::ADDITIVITY_PREFIX . $loggerName, $props);
+    /**
+     * Parse the additivity option for a non-root category.
+     *
+     * @param array $props array of properties
+     * @param Logger $cat
+     * @param string $loggerName
+     */
+    private function parseAdditivityForLogger($props, Logger $cat, $loggerName) {
+        $value = LoggerOptionConverter::findAndSubst(self::ADDITIVITY_PREFIX . $loggerName, $props);
 		
-		// touch additivity only if necessary
-		if(!empty($value)) {
-			$additivity = LoggerOptionConverter::toBoolean($value, true);
-			$cat->setAdditivity($additivity);
-		}
-	}
+        // touch additivity only if necessary
+        if(!empty($value)) {
+            $additivity = LoggerOptionConverter::toBoolean($value, true);
+            $cat->setAdditivity($additivity);
+        }
+    }
 
-	/**
-	 * This method must work for the root category as well.
-	 *
-	 * @param array $props array of properties
-	 * @param Logger $logger
-	 * @param string $optionKey
-	 * @param string $loggerName
-	 * @param string $value
-	 * @return Logger
-	 */
-	private function parseCategory($props, Logger $logger, $optionKey, $loggerName, $value) {
-		// We must skip over ',' but not white space
-		$st = explode(',', $value);
+    /**
+     * This method must work for the root category as well.
+     *
+     * @param array $props array of properties
+     * @param Logger $logger
+     * @param string $optionKey
+     * @param string $loggerName
+     * @param string $value
+     * @return Logger
+     */
+    private function parseCategory($props, Logger $logger, $optionKey, $loggerName, $value) {
+        // We must skip over ',' but not white space
+        $st = explode(',', $value);
 
-		// If value is not in the form ", appender.." or "", then we should set
-		// the level of the loggeregory.
+        // If value is not in the form ", appender.." or "", then we should set
+        // the level of the loggeregory.
 
-		if(!(empty($value) || @$value[0] == ',')) {
-			// just to be on the safe side...
-			if(count($st) == 0) {
-				return;
-			}
-			$levelStr = current($st);
+        if(!(empty($value) || @$value[0] == ',')) {
+            // just to be on the safe side...
+            if(count($st) == 0) {
+                return;
+            }
+            $levelStr = current($st);
 			
-			// If the level value is inherited, set category level value to
-			// null. We also check that the user has not specified inherited for the
-			// root category.
-			if('INHERITED' == strtoupper($levelStr) || 'NULL' == strtoupper($levelStr)) {
-				if($loggerName == self::INTERNAL_ROOT_NAME) {
-					// TODO: throw exception?	"The root logger cannot be set to null."
-				} else {
-					$logger->setLevel(null);
-				}
-			} else {
-				$logger->setLevel(LoggerOptionConverter::toLevel($levelStr, LoggerLevel::getLevelDebug()));
-			}
-		}
+            // If the level value is inherited, set category level value to
+            // null. We also check that the user has not specified inherited for the
+            // root category.
+            if('INHERITED' == strtoupper($levelStr) || 'NULL' == strtoupper($levelStr)) {
+                if($loggerName == self::INTERNAL_ROOT_NAME) {
+                    // TODO: throw exception?	"The root logger cannot be set to null."
+                } else {
+                    $logger->setLevel(null);
+                }
+            } else {
+                $logger->setLevel(LoggerOptionConverter::toLevel($levelStr, LoggerLevel::getLevelDebug()));
+            }
+        }
 
-		// TODO: removing should be done by the logger, if necessary and wanted 
-		// $logger->removeAllAppenders();
-		while($appenderName = next($st)) {
-			$appenderName = trim($appenderName);
-			if(empty($appenderName)) {
-				continue;
-			}
+        // TODO: removing should be done by the logger, if necessary and wanted 
+        // $logger->removeAllAppenders();
+        while($appenderName = next($st)) {
+            $appenderName = trim($appenderName);
+            if(empty($appenderName)) {
+                continue;
+            }
 			
-			$appender = $this->parseAppender($props, $appenderName);
-			if($appender !== null) {
-					$logger->addAppender($appender);
-			}
-		}
-	}
+            $appender = $this->parseAppender($props, $appenderName);
+            if($appender !== null) {
+                    $logger->addAppender($appender);
+            }
+        }
+    }
 
-	/**
-	 * @param array $props array of properties
-	 * @param string $appenderName
-	 * @return LoggerAppender
-	 */
-	private function parseAppender($props, $appenderName) {
-		$appender = LoggerAppenderPool::getAppenderFromPool($appenderName);
-		$prefix = self::APPENDER_PREFIX . $appenderName;
-		if($appender === null) {
-			// Appender was not previously initialized.
-			$appenderClass = @$props[$prefix];
-			$appender = LoggerAppenderPool::getAppenderFromPool($appenderName, $appenderClass);
-			if($appender === null) {
-				return null;
-			}
-		}
+    /**
+     * @param array $props array of properties
+     * @param string $appenderName
+     * @return LoggerAppender
+     */
+    private function parseAppender($props, $appenderName) {
+        $appender = LoggerAppenderPool::getAppenderFromPool($appenderName);
+        $prefix = self::APPENDER_PREFIX . $appenderName;
+        if($appender === null) {
+            // Appender was not previously initialized.
+            $appenderClass = @$props[$prefix];
+            $appender = LoggerAppenderPool::getAppenderFromPool($appenderName, $appenderClass);
+            if($appender === null) {
+                return null;
+            }
+        }
 		
-		if($appender->requiresLayout() ) {
-			$layoutPrefix = $prefix . ".layout";
-			$layoutClass = @$props[$layoutPrefix];
-			$layoutClass = LoggerOptionConverter::substVars($layoutClass, $props);
-			if(empty($layoutClass)) {
-				$layout = LoggerReflectionUtils::createObject('LoggerLayoutSimple');
-			} else {
-				$layout = LoggerReflectionUtils::createObject($layoutClass);
-				if($layout === null) {
-					$layout = LoggerReflectionUtils::createObject('LoggerLayoutSimple');
-				}
-			}
+        if($appender->requiresLayout() ) {
+            $layoutPrefix = $prefix . ".layout";
+            $layoutClass = @$props[$layoutPrefix];
+            $layoutClass = LoggerOptionConverter::substVars($layoutClass, $props);
+            if(empty($layoutClass)) {
+                $layout = LoggerReflectionUtils::createObject('LoggerLayoutSimple');
+            } else {
+                $layout = LoggerReflectionUtils::createObject($layoutClass);
+                if($layout === null) {
+                    $layout = LoggerReflectionUtils::createObject('LoggerLayoutSimple');
+                }
+            }
 			
-			LoggerReflectionUtils::setPropertiesByObject($layout, $props, $layoutPrefix . ".");				  
-			$appender->setLayout($layout);
+            LoggerReflectionUtils::setPropertiesByObject($layout, $props, $layoutPrefix . ".");				  
+            $appender->setLayout($layout);
 			
-		}
-		LoggerReflectionUtils::setPropertiesByObject($appender, $props, $prefix . ".");
-		return $appender;		 
-	}
+        }
+        LoggerReflectionUtils::setPropertiesByObject($appender, $props, $prefix . ".");
+        return $appender;		 
+    }
 }