MessageVoter::voteOnAttribute() - Code Metrics - Inspection of "Messages: Refactor code" - chamilo/chamilo-lms - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( bb9802...b428f1 )

by Julito

created 2021-07-11 08:22 UTC

MessageVoter::voteOnAttribute() B

↳ Parent: MessageVoter

Complexity

Conditions	10
Paths	9

Size

Total Lines	47
Code Lines	19

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
cc	10
eloc	19
nc	9
nop	3
dl	0
loc	47
rs	7.6666
c	2
b	0
f	0

How to fix Complexity

<?php

declare(strict_types=1);

/* For licensing terms, see /license.txt */

namespace Chamilo\CoreBundle\Security\Authorization\Voter;

use Chamilo\CoreBundle\Entity\Message;
use Chamilo\CoreBundle\Entity\User;
use Doctrine\ORM\EntityManagerInterface;
use Symfony\Component\Security\Core\Authentication\Token\TokenInterface;
use Symfony\Component\Security\Core\Authorization\Voter\Voter;
use Symfony\Component\Security\Core\Security;
use Symfony\Component\Security\Core\User\UserInterface;

class MessageVoter extends Voter
{
    public const CREATE = 'CREATE';
    public const VIEW = 'VIEW';
    public const EDIT = 'EDIT';
    public const DELETE = 'DELETE';

    private EntityManagerInterface $entityManager;
    private Security $security;

    public function __construct(
        EntityManagerInterface $entityManager,
        Security $security
    ) {
        $this->entityManager = $entityManager;
        $this->security = $security;
    }

    protected function supports(string $attribute, $subject): bool
    {
        $options = [
            self::CREATE,
            self::VIEW,
            self::EDIT,
            self::DELETE,
        ];

        // if the attribute isn't one we support, return false
        if (!\in_array($attribute, $options, true)) {
            return false;
        }

        // only vote on Post objects inside this voter
        return $subject instanceof Message;
    }

    protected function voteOnAttribute(string $attribute, $subject, TokenInterface $token): bool
    {
        /** @var User $user */
        $user = $token->getUser();

        if (!$user instanceof UserInterface) {
            return false;
        }

        // Admins have access to everything.
        if ($this->security->isGranted('ROLE_ADMIN')) {
            return true;
        }

        /** @var Message $message */
        $message = $subject;

        switch ($attribute) {
            case self::CREATE:
                if ($message->getSender() === $user) {
                    return true;
                }

                break;
            case self::VIEW:
                if ($message->hasReceiver($user) || $message->getSender() === $user) {
                    return true;
                }

                break;
            case self::EDIT:
            case self::DELETE:
                // @todo
                break;
                /*if ($message->hasReceiver($user) &&
                    Message::MESSAGE_TYPE_INBOX === $message->getMsgType()
                ) {
                    return true;
                }*/

                // User cannot delete.
                /*if ($message->getSender() === $user && Message::MESSAGE_TYPE_OUTBOX === $message->getMsgType()) {
                    return true;
                }*/
        }

        return false;
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			/* For licensing terms, see /license.txt */
6
7			namespace Chamilo\CoreBundle\Security\Authorization\Voter;
8
9			use Chamilo\CoreBundle\Entity\Message;
10			use Chamilo\CoreBundle\Entity\User;
11			use Doctrine\ORM\EntityManagerInterface;
12			use Symfony\Component\Security\Core\Authentication\Token\TokenInterface;
13			use Symfony\Component\Security\Core\Authorization\Voter\Voter;
14			use Symfony\Component\Security\Core\Security;
15			use Symfony\Component\Security\Core\User\UserInterface;
16
17			class MessageVoter extends Voter
18			{
19			public const CREATE = 'CREATE';
20			public const VIEW = 'VIEW';
21			public const EDIT = 'EDIT';
22			public const DELETE = 'DELETE';
23
24			private EntityManagerInterface $entityManager;
25			private Security $security;
26
27			public function __construct(
28			EntityManagerInterface $entityManager,
29			Security $security
30			) {
31			$this->entityManager = $entityManager;
32			$this->security = $security;
33			}
34
35			protected function supports(string $attribute, $subject): bool
36			{
37			$options = [
38			self::CREATE,
39			self::VIEW,
40			self::EDIT,
41			self::DELETE,
42			];
43
44			// if the attribute isn't one we support, return false
45			if (!\in_array($attribute, $options, true)) {
46			return false;
47			}
48
49			// only vote on Post objects inside this voter
50			return $subject instanceof Message;
51			}
52
53			protected function voteOnAttribute(string $attribute, $subject, TokenInterface $token): bool
54			{
55			/** @var User $user */
56			$user = $token->getUser();
57
58			if (!$user instanceof UserInterface) {
59			return false;
60			}
61
62			// Admins have access to everything.
63			if ($this->security->isGranted('ROLE_ADMIN')) {
64			return true;
65			}
66
67			/** @var Message $message */
68			$message = $subject;
69
70			switch ($attribute) {
71			case self::CREATE:
72			if ($message->getSender() === $user) {
73			return true;
74			}
75
76			break;
77			case self::VIEW:
78			if ($message->hasReceiver($user) \|\| $message->getSender() === $user) {
79			return true;
80			}
81
82			break;
83			case self::EDIT:
84			case self::DELETE:
85			// @todo
86			break;
87			/*if ($message->hasReceiver($user) &&
88			Message::MESSAGE_TYPE_INBOX === $message->getMsgType()
89			) {
90			return true;
91			}*/
92
93			// User cannot delete.
94			/*if ($message->getSender() === $user && Message::MESSAGE_TYPE_OUTBOX === $message->getMsgType()) {
95			return true;
96			}*/
97			}
98
99			return false;
100			}
101			}
102

chamilo / chamilo-lms

Push — master ( bb9802...b428f1 )

MessageVoter::voteOnAttribute() B

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like