Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 18 | class UserGroupAdmin extends AbstractAdmin |
||
| 19 | { |
||
| 20 | /** |
||
| 21 | * @param FormMapper $formMapper |
||
| 22 | */ |
||
| 23 | View Code Duplication | protected function configureFormFields(FormMapper $formMapper) |
|
| 48 | |||
| 49 | /** |
||
| 50 | * Very important in order to save the related entities! |
||
| 51 | * @param Course $userGroup |
||
| 52 | * @return mixed|void |
||
| 53 | */ |
||
| 54 | public function preUpdate($userGroup) |
||
| 58 | |||
| 59 | /** |
||
| 60 | * @param ShowMapper $showMapper |
||
| 61 | */ |
||
| 62 | protected function configureShowField(ShowMapper $showMapper) |
||
| 69 | |||
| 70 | /** |
||
| 71 | * @param DatagridMapper $datagridMapper |
||
| 72 | */ |
||
| 73 | protected function configureDatagridFilters(DatagridMapper $datagridMapper) |
||
| 80 | |||
| 81 | /** |
||
| 82 | * @param ListMapper $listMapper |
||
| 83 | */ |
||
| 84 | protected function configureListFields(ListMapper $listMapper) |
||
| 91 | } |
||
| 92 |