PermissionsController::index() - Code Metrics - Inspection of "Merge pull request #5659 from christianbeeznest/fi..." - chamilo/chamilo-lms - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( b06bd0...2df28d )

unknown

created 2024-07-11 23:36 UTC

PermissionsController::index() B

↳ Parent: PermissionsController

Complexity

Conditions	10
Paths	10

Size

Total Lines	55
Code Lines	35

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	10
eloc	35
c	1
b	0
f	0
nc	10
nop	4
dl	0
loc	55
rs	7.6666

How to fix Long Method Complexity

<?php

/* For licensing terms, see /license.txt */

declare(strict_types=1);

namespace Chamilo\CoreBundle\Controller;

use Chamilo\CoreBundle\Entity\PermissionRelRole;
use Chamilo\CoreBundle\Form\PermissionType;
use Chamilo\CoreBundle\Repository\PermissionRelRoleRepository;
use Chamilo\CoreBundle\Repository\PermissionRepository;
use Chamilo\CoreBundle\ServiceHelper\PermissionServiceHelper;
use Doctrine\ORM\EntityManagerInterface;
use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\Routing\Annotation\Route;
use Symfony\Component\Security\Http\Attribute\IsGranted;

#[Route('/permissions')]
class PermissionsController extends AbstractController
{
    public function __construct(
        private PermissionServiceHelper $permissionServiceHelper
    ) {}

    #[IsGranted('ROLE_ADMIN')]
    #[Route('', name: 'permissions')]
    public function index(
        PermissionRepository $permissionRepo,
        PermissionRelRoleRepository $permissionRelRoleRepo,
        Request $request,
        EntityManagerInterface $em
    ): Response {
        $permissions = $permissionRepo->findAll();
        $roles = $this->permissionServiceHelper->getUserRoles();

        if ($request->isMethod('POST')) {
            $data = $request->request->all('permissions');
            foreach ($permissions as $permission) {
                foreach ($roles as $role) {
                    $checkboxValue = isset($data[$permission->getSlug()][$role]);
                    $permRelRole = $permissionRelRoleRepo->findOneBy(['permission' => $permission, 'roleCode' => $role]);

                    if ($checkboxValue) {
                        if (!$permRelRole) {
                            $permRelRole = new PermissionRelRole();
                            $permRelRole->setPermission($permission);
                            $permRelRole->setRoleCode($role);
                        }
                        $permRelRole->setChangeable(true);
                        $permRelRole->setUpdatedAt(new \DateTime());
                        $em->persist($permRelRole);
                    } else {
                        if ($permRelRole) {
                            $em->remove($permRelRole);
                        }
                    }
                }
            }
            $em->flush();

            return $this->redirectToRoute('permissions');
        }

        $forms = [];
        foreach ($permissions as $permission) {
            $defaultData = [];
            foreach ($roles as $role) {
                $permRelRole = $permissionRelRoleRepo->findOneBy(['permission' => $permission, 'roleCode' => $role]);
                $defaultData[$role] = $permRelRole ? $permRelRole->isChangeable() : false;
            }

            $form = $this->createForm(PermissionType::class, $defaultData, ['roles' => $roles]);
            $forms[$permission->getSlug()] = $form->createView();
        }

        return $this->render('@ChamiloCore/Permission/index.html.twig', [
            'permissions' => $permissions,
            'forms' => $forms,
            'roles' => $roles
        ]);
    }

    #[Route('/is_allowed_to_edit', name: 'is_allowed_to_edit')]
    public function isAllowedToEdit(Request $request): Response
    {
        $tutor = $request->query->getBoolean('tutor');
        $coach = $request->query->getBoolean('coach');
        $sessionCoach = $request->query->getBoolean('sessioncoach');
        $checkStudentView = $request->query->getBoolean('checkstudentview');

        $isAllowed = api_is_allowed_to_edit(
            $tutor,
            $coach,
            $sessionCoach,
            $checkStudentView
        );

        return $this->json([
            'isAllowedToEdit' => $isAllowed,
        ]);
    }
}


1			<?php
2
3			/* For licensing terms, see /license.txt */
4
5			declare(strict_types=1);
6
7			namespace Chamilo\CoreBundle\Controller;
8
9			use Chamilo\CoreBundle\Entity\PermissionRelRole;
10			use Chamilo\CoreBundle\Form\PermissionType;
11			use Chamilo\CoreBundle\Repository\PermissionRelRoleRepository;
12			use Chamilo\CoreBundle\Repository\PermissionRepository;
13			use Chamilo\CoreBundle\ServiceHelper\PermissionServiceHelper;
14			use Doctrine\ORM\EntityManagerInterface;
15			use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
16			use Symfony\Component\HttpFoundation\Request;
17			use Symfony\Component\HttpFoundation\Response;
18			use Symfony\Component\Routing\Annotation\Route;
19			use Symfony\Component\Security\Http\Attribute\IsGranted;
20
21			#[Route('/permissions')]
22			class PermissionsController extends AbstractController
23			{
24			public function __construct(
25			private PermissionServiceHelper $permissionServiceHelper
26			) {}
27
28			#[IsGranted('ROLE_ADMIN')]
29			#[Route('', name: 'permissions')]
30			public function index(
31			PermissionRepository $permissionRepo,
32			PermissionRelRoleRepository $permissionRelRoleRepo,
33			Request $request,
34			EntityManagerInterface $em
35			): Response {
36			$permissions = $permissionRepo->findAll();
37			$roles = $this->permissionServiceHelper->getUserRoles();
38
39			if ($request->isMethod('POST')) {
40			$data = $request->request->all('permissions');
41			foreach ($permissions as $permission) {
42			foreach ($roles as $role) {
43			$checkboxValue = isset($data[$permission->getSlug()][$role]);
44			$permRelRole = $permissionRelRoleRepo->findOneBy(['permission' => $permission, 'roleCode' => $role]);
45
46			if ($checkboxValue) {
47			if (!$permRelRole) {
48			$permRelRole = new PermissionRelRole();
49			$permRelRole->setPermission($permission);
50			$permRelRole->setRoleCode($role);
51			}
52			$permRelRole->setChangeable(true);
53			$permRelRole->setUpdatedAt(new \DateTime());
54			$em->persist($permRelRole);
55			} else {
56			if ($permRelRole) {
57			$em->remove($permRelRole);
58			}
59			}
60			}
61			}
62			$em->flush();
63
64			return $this->redirectToRoute('permissions');
65			}
66
67			$forms = [];
68			foreach ($permissions as $permission) {
69			$defaultData = [];
70			foreach ($roles as $role) {
71			$permRelRole = $permissionRelRoleRepo->findOneBy(['permission' => $permission, 'roleCode' => $role]);
72			$defaultData[$role] = $permRelRole ? $permRelRole->isChangeable() : false;
73			}
74
75			$form = $this->createForm(PermissionType::class, $defaultData, ['roles' => $roles]);
76			$forms[$permission->getSlug()] = $form->createView();
77			}
78
79			return $this->render('@ChamiloCore/Permission/index.html.twig', [
80			'permissions' => $permissions,
81			'forms' => $forms,
82			'roles' => $roles
83			]);
84			}
85
86			#[Route('/is_allowed_to_edit', name: 'is_allowed_to_edit')]
87			public function isAllowedToEdit(Request $request): Response
88			{
89			$tutor = $request->query->getBoolean('tutor');
90			$coach = $request->query->getBoolean('coach');
91			$sessionCoach = $request->query->getBoolean('sessioncoach');
92			$checkStudentView = $request->query->getBoolean('checkstudentview');
93
94			$isAllowed = api_is_allowed_to_edit(
95			$tutor,
96			$coach,
97			$sessionCoach,
98			$checkStudentView
99			);
100
101			return $this->json([
102			'isAllowedToEdit' => $isAllowed,
103			]);
104			}
105			}
106

chamilo / chamilo-lms

Push — master ( b06bd0...2df28d )

PermissionsController::index() B

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like