| Total Complexity | 44 |
| Total Lines | 439 |
| Duplicated Lines | 0 % |
| Changes | 0 | ||
Complex classes like ResourceController often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use ResourceController, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 30 | class ResourceController extends BaseResourceController implements CourseControllerInterface |
||
| 31 | { |
||
| 32 | use CourseControllerTrait; |
||
| 33 | |||
| 34 | /** |
||
| 35 | * @param Request $request |
||
| 36 | * |
||
| 37 | * @return Response |
||
| 38 | */ |
||
| 39 | public function indexAction(Request $request): Response |
||
| 40 | { |
||
| 41 | $source = new Entity('ChamiloCourseBundle:CDocument'); |
||
| 42 | |||
| 43 | /* @var $grid \APY\DataGridBundle\Grid\Grid */ |
||
| 44 | $grid = $this->get('grid'); |
||
| 45 | |||
| 46 | /*$tableAlias = $source->getTableAlias(); |
||
| 47 | $source->manipulateQuery(function (QueryBuilder $query) use ($tableAlias, $course) { |
||
| 48 | $query->andWhere($tableAlias . '.cId = '.$course->getId()); |
||
| 49 | //$query->resetDQLPart('orderBy'); |
||
| 50 | } |
||
| 51 | );*/ |
||
| 52 | |||
| 53 | /** @var CDocumentRepository $repository */ |
||
| 54 | $repository = $this->repository; |
||
| 55 | $course = $this->getCourse(); |
||
| 56 | $tool = $repository->getTool('document'); |
||
| 57 | $resources = $repository->getResourceByCourse($course, $tool); |
||
| 58 | |||
| 59 | $source->setData($resources); |
||
| 60 | $grid->setSource($source); |
||
| 61 | |||
| 62 | //$grid->hideFilters(); |
||
| 63 | $grid->setLimits(5); |
||
| 64 | //$grid->isReadyForRedirect(); |
||
| 65 | |||
| 66 | //$grid->setMaxResults(1); |
||
| 67 | //$grid->setLimits(2); |
||
| 68 | /*$grid->getColumn('id')->manipulateRenderCell( |
||
| 69 | function ($value, $row, $router) use ($course) { |
||
| 70 | //$router = $this->get('router'); |
||
| 71 | return $router->generate( |
||
| 72 | 'chamilo_notebook_show', |
||
| 73 | array('id' => $row->getField('id'), 'course' => $course) |
||
| 74 | ); |
||
| 75 | } |
||
| 76 | );*/ |
||
| 77 | |||
| 78 | if ($this->isGranted(ResourceNodeVoter::ROLE_CURRENT_COURSE_TEACHER)) { |
||
| 79 | $deleteMassAction = new MassAction( |
||
| 80 | 'Delete', |
||
| 81 | 'chamilo.controller.notebook:deleteMassAction', |
||
| 82 | true, |
||
| 83 | array('course' => $request->get('course')) |
||
| 84 | ); |
||
| 85 | $grid->addMassAction($deleteMassAction); |
||
| 86 | } |
||
| 87 | |||
| 88 | $translation = $this->container->get('translator'); |
||
| 89 | |||
| 90 | $myRowAction = new RowAction( |
||
| 91 | $translation->trans('View'), |
||
| 92 | 'app_document_show', |
||
| 93 | false, |
||
| 94 | '_self', |
||
| 95 | ['class' => 'btn btn-default'] |
||
| 96 | ); |
||
| 97 | $myRowAction->setRouteParameters(array('course' => $course, 'id')); |
||
| 98 | $grid->addRowAction($myRowAction); |
||
| 99 | |||
| 100 | if ($this->isGranted(ResourceNodeVoter::ROLE_CURRENT_COURSE_TEACHER)) { |
||
| 101 | $myRowAction = new RowAction( |
||
| 102 | $translation->trans('Edit'), |
||
| 103 | 'app_document_update', |
||
| 104 | false, |
||
| 105 | '_self', |
||
| 106 | ['class' => 'btn btn-info'] |
||
| 107 | ); |
||
| 108 | $myRowAction->setRouteParameters(array('course' => $course, 'id')); |
||
| 109 | $grid->addRowAction($myRowAction); |
||
| 110 | |||
| 111 | $myRowAction = new RowAction( |
||
| 112 | $translation->trans('Delete'), |
||
| 113 | 'app_document_delete', |
||
| 114 | false, |
||
| 115 | '_self', |
||
| 116 | ['class' => 'btn btn-danger', 'form_delete' => true] |
||
| 117 | ); |
||
| 118 | $myRowAction->setRouteParameters(['course' => $course, 'id']); |
||
| 119 | $grid->addRowAction($myRowAction); |
||
| 120 | } |
||
| 121 | |||
| 122 | $grid->addExport( |
||
| 123 | new CSVExport( |
||
| 124 | $translation->trans('CSV Export'), 'export', ['course' => $course] |
||
| 125 | ) |
||
| 126 | ); |
||
| 127 | |||
| 128 | $grid->addExport( |
||
| 129 | new ExcelExport( |
||
| 130 | $translation->trans('Excel Export'), |
||
| 131 | 'export', |
||
| 132 | ['course' => $course] |
||
| 133 | ) |
||
| 134 | ); |
||
| 135 | |||
| 136 | return $grid->getGridResponse('ChamiloCoreBundle:Document:index.html.twig'); |
||
| 137 | } |
||
| 138 | |||
| 139 | /** |
||
| 140 | * @param Request $request |
||
| 141 | * |
||
| 142 | * @return RedirectResponse|Response |
||
| 143 | */ |
||
| 144 | public function createAction(Request $request): Response |
||
| 334 | } |
||
| 335 | |||
| 336 | /** |
||
| 337 | * @param Request $request |
||
| 338 | * |
||
| 339 | * @return Response |
||
| 340 | */ |
||
| 341 | public function showAction(Request $request): Response |
||
| 342 | { |
||
| 343 | $configuration = $this->requestConfigurationFactory->create($this->metadata, $request); |
||
| 344 | $this->isGrantedOr403($configuration, ResourceActions::SHOW); |
||
| 345 | |||
| 346 | /** @var AbstractResource $resource */ |
||
| 347 | $resource = $this->findOr404($configuration); |
||
| 348 | $resourceNode = $resource->getResourceNode(); |
||
| 349 | |||
| 350 | $this->eventDispatcher->dispatch(ResourceActions::SHOW, $configuration, $resource); |
||
| 351 | |||
| 352 | $this->denyAccessUnlessGranted( |
||
| 353 | ResourceNodeVoter::VIEW, |
||
| 354 | $resourceNode, |
||
| 355 | 'Unauthorised access to resource' |
||
| 356 | ); |
||
| 357 | |||
| 358 | $view = View::create($resource); |
||
| 359 | |||
| 360 | if ($configuration->isHtmlRequest()) { |
||
| 361 | $view |
||
| 362 | ->setTemplate($configuration->getTemplate(ResourceActions::SHOW . '.html')) |
||
| 363 | ->setTemplateVar($this->metadata->getName()) |
||
| 364 | ->setData([ |
||
| 365 | 'configuration' => $configuration, |
||
| 366 | 'metadata' => $this->metadata, |
||
| 367 | 'resource' => $resource, |
||
| 368 | $this->metadata->getName() => $resource, |
||
| 369 | ]) |
||
| 370 | ; |
||
| 371 | } |
||
| 372 | |||
| 373 | return $this->viewHandler->handle($configuration, $view); |
||
| 374 | } |
||
| 375 | |||
| 376 | /** |
||
| 377 | * @param Request $request |
||
| 378 | * |
||
| 379 | * @return Response |
||
| 380 | */ |
||
| 381 | public function updateAction(Request $request): Response |
||
| 469 | } |
||
| 470 | } |
||
| 471 |