GroupVoter::voteOnAttribute() - Code Metrics - Inspection of "Fix PHP errors" - chamilo/chamilo-lms - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 53f6ec...d4770b )

by Julito

created 2019-12-18 16:14 UTC

GroupVoter::voteOnAttribute() B

↳ Parent: GroupVoter

Complexity

Conditions	9
Paths	4

Size

Total Lines	51
Code Lines	27

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	9
eloc	27
nc	4
nop	3
dl	0
loc	51
rs	8.0555
c	0
b	0
f	0

How to fix Long Method

<?php

/* For licensing terms, see /license.txt */

namespace Chamilo\CoreBundle\Security\Authorization\Voter;

use Chamilo\CoreBundle\Repository\CourseRepository;
use Chamilo\CourseBundle\Entity\CGroupInfo;
use Chamilo\CourseBundle\Repository\CGroupInfoRepository;
use Doctrine\ORM\EntityManager;
use Symfony\Component\Security\Core\Authentication\Token\TokenInterface;
use Symfony\Component\Security\Core\Authorization\AuthorizationCheckerInterface;
use Symfony\Component\Security\Core\Authorization\Voter\Voter;
use Symfony\Component\Security\Core\User\UserInterface;

/**
 * Class GroupVoter.
 */
class GroupVoter extends Voter
{
    public const VIEW = 'VIEW';
    public const EDIT = 'EDIT';
    public const DELETE = 'DELETE';

    private $entityManager;
    private $courseManager;
    private $groupManager;
    private $authorizationChecker;

    public function __construct(
        EntityManager $entityManager,
        CourseRepository $courseManager,
        CGroupInfoRepository $groupManager,
        AuthorizationCheckerInterface $authorizationChecker
    ) {
        $this->entityManager = $entityManager;
        $this->courseManager = $courseManager;
        $this->groupManager = $groupManager;
        $this->authorizationChecker = $authorizationChecker;
    }

    /**
     * @return AuthorizationCheckerInterface
     */
    public function getAuthorizationChecker()
    {
        return $this->authorizationChecker;
    }

    /**
     * @return EntityManager
     */
    public function getEntityManager()
    {
        return $this->entityManager;
    }

    /**
     * @return CourseRepository
     */
    public function getCourseManager(): CourseRepository
    {
        return $this->courseManager;
    }

    /**
     * @param CourseRepository $courseManager
     *
     * @return GroupVoter
     */
    public function setCourseManager(CourseRepository $courseManager): self
    {
        $this->courseManager = $courseManager;

        return $this;
    }

    /**
     * @return CGroupInfoRepository
     */
    public function getGroupManager(): CGroupInfoRepository
    {
        return $this->groupManager;
    }

    /**
     * @param CGroupInfoRepository $groupManager
     *
     * @return GroupVoter
     */
    public function setGroupManager(CGroupInfoRepository $groupManager): self
    {
        $this->groupManager = $groupManager;

        return $this;
    }

    /**
     * {@inheritdoc}
     */
    protected function supports($attribute, $subject): bool
    {
        $options = [
            self::VIEW,
            self::EDIT,
            self::DELETE,
        ];

        // if the attribute isn't one we support, return false
        if (!in_array($attribute, $options)) {
            return false;
        }

        // only vote on Post objects inside this voter
        if (!$subject instanceof CGroupInfo) {
            return false;
        }

        return true;
    }

    /**
     * {@inheritdoc}
     */
    protected function voteOnAttribute($attribute, $group, TokenInterface $token): bool
    {
        $user = $token->getUser();

        // make sure there is a user object (i.e. that the user is logged in)
        if (!$user instanceof UserInterface) {
            return false;
        }

        if (false == $group) {
            return false;
        }

        $authChecker = $this->getAuthorizationChecker();

        // Admins have access to everything
        if ($authChecker->isGranted('ROLE_ADMIN')) {
            return true;
        }

        $groupInfo = [
            'id' => $group->getId(),
            'session_id' => 0,
            'status' => $group->getStatus(),
        ];

        // Legacy
        return \GroupManager::userHasAccessToBrowse($user->getId(), $groupInfo);

        switch ($attribute) {
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
            case self::VIEW:
                if (!$group->hasUserInCourse($user, $course)) {
                    $user->addRole(ResourceNodeVoter::ROLE_CURRENT_SESSION_COURSE_STUDENT);

                    return true;
                }

                break;
            case self::EDIT:
            case self::DELETE:
                if (!$session->hasCoachInCourseWithStatus($user, $course)) {
                    $user->addRole(ResourceNodeVoter::ROLE_CURRENT_SESSION_COURSE_TEACHER);

                    return true;
                }

                break;
        }
        dump("You don't have access to this group!!");
        dump("You don't have access to this group!!");

        return false;
    }
}


chamilo / chamilo-lms

Push — master ( 53f6ec...d4770b )

GroupVoter::voteOnAttribute() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like