chamilo /
chamilo-lms
| Conditions | 8 |
| Paths | 32 |
| Total Lines | 75 |
| Code Lines | 47 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 52 | public function updateSettingAction(Request $request, $namespace) |
||
| 53 | { |
||
| 54 | $manager = $this->getSettingsManager(); |
||
| 55 | |||
| 56 | $builder = $this->container->get('form.factory')->createNamedBuilder( |
||
| 57 | 'search' |
||
| 58 | ); |
||
| 59 | $builder->add('keyword', 'text'); |
||
| 60 | $builder->add('search', 'submit'); |
||
| 61 | $searchForm = $builder->getForm(); |
||
| 62 | |||
| 63 | $keyword = ''; |
||
| 64 | if ($searchForm->handleRequest($request)->isValid()) { |
||
| 65 | $values = $searchForm->getData(); |
||
| 66 | $keyword = $values['keyword']; |
||
| 67 | $settingsFromKeyword = $manager->getParametersFromKeyword( |
||
| 68 | $namespace, |
||
| 69 | $keyword |
||
| 70 | ); |
||
| 71 | } |
||
| 72 | |||
| 73 | $keywordFromGet = $request->query->get('keyword'); |
||
| 74 | if ($keywordFromGet) { |
||
| 75 | $keyword = $keywordFromGet; |
||
| 76 | $searchForm->setData(['keyword' => $keyword]); |
||
| 77 | $settingsFromKeyword = $manager->getParametersFromKeyword( |
||
| 78 | $namespace, |
||
| 79 | $keywordFromGet |
||
| 80 | ); |
||
| 81 | } |
||
| 82 | |||
| 83 | $settings = $manager->load($manager->convertNameSpaceToService($namespace)); |
||
| 84 | |||
| 85 | $form = $this->getSettingsFormFactory()->create($namespace); |
||
| 86 | |||
| 87 | if (!empty($keyword)) { |
||
| 88 | $params = $settings->getParameters(); |
||
| 89 | foreach ($params as $name => $value) { |
||
| 90 | if (!in_array($name, array_keys($settingsFromKeyword))) { |
||
| 91 | $form->remove($name); |
||
| 92 | } |
||
| 93 | } |
||
| 94 | } |
||
| 95 | |||
| 96 | $form->setData($settings); |
||
| 97 | |||
| 98 | if ($form->handleRequest($request)->isValid()) { |
||
| 99 | $messageType = 'success'; |
||
| 100 | try { |
||
| 101 | $manager->save($namespace, $form->getData()); |
||
| 102 | $message = $this->getTranslator()->trans('sylius.settings.update', array(), 'flashes'); |
||
| 103 | } catch (ValidatorException $exception) { |
||
| 104 | $message = $this->getTranslator()->trans($exception->getMessage(), array(), 'validators'); |
||
| 105 | $messageType = 'error'; |
||
| 106 | } |
||
| 107 | |||
| 108 | $this->addFlash($messageType, $message); |
||
| 109 | |||
| 110 | /*if ($request->headers->has('referer')) { |
||
| 111 | return $this->redirect($request->headers->get('referer')); |
||
| 112 | }*/ |
||
| 113 | } |
||
| 114 | $schemas = $manager->getSchemas(); |
||
| 115 | |||
| 116 | return $this->render( |
||
| 117 | '@ChamiloCore/Admin/Settings/default.html.twig', |
||
| 118 | array( |
||
| 119 | 'schemas' => $schemas, |
||
| 120 | 'settings' => $settings, |
||
| 121 | 'form' => $form->createView(), |
||
| 122 | 'keyword' => $keyword, |
||
| 123 | 'search_form' => $searchForm->createView(), |
||
| 124 | ) |
||
| 125 | ); |
||
| 126 | } |
||
| 127 | |||
| 136 |
