ZombieManager::listZombies()

Complexity

Conditions	7
Paths	32

Size

Total Lines	68
Code Lines	27

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public static function listZombies(
        $ceiling,
        $active_only = true,
        $from = 0,
        $count = 10,
        $column = 'user.firstname',
        $direction = 'desc'
    ) {
        if (empty($column)) {
            $column = 'user.firstname';
        }
        $ceiling = is_numeric($ceiling) ? (int) $ceiling : strtotime($ceiling);
        $ceiling = date('Y-m-d H:i:s', $ceiling);

        $user_table = Database::get_main_table(TABLE_MAIN_USER);
        $login_table = Database::get_main_table(TABLE_STATISTIC_TRACK_E_LOGIN);

        $sql = 'SELECT
                    user.user_id,
                    user.official_code,
                    user.firstname,
                    user.lastname,
                    user.username,
                    user.auth_source,
                    user.email,
                    user.status,
                    user.registration_date,
                    user.active,
                    access.login_date';

        if (api_is_multiple_url_enabled()) {
            $access_url_rel_user_table = Database::get_main_table(TABLE_MAIN_ACCESS_URL_REL_USER);
            $current_url_id = api_get_current_access_url_id();

            $sql .= " FROM $user_table as user, $login_table as access, $access_url_rel_user_table as url
                      WHERE
                        access.login_date = (SELECT MAX(a.login_date)
                                             FROM $login_table as a
                                             WHERE a.login_user_id = user.user_id
                                             ) AND
                        access.login_date <= '$ceiling' AND
                        user.user_id = access.login_user_id AND
                        url.user_id = user.user_id AND url.access_url_id=$current_url_id";
        } else {
            $sql .= " FROM $user_table as user, $login_table as access
                      WHERE
                        access.login_date = (SELECT MAX(a.login_date)
                                             FROM $login_table as a
                                             WHERE a.login_user_id = user.user_id
                                             ) AND
                        access.login_date <= '$ceiling' AND
                        user.user_id = access.login_user_id";
        }

        if ($active_only) {
            $sql .= ' AND user.active = 1';
        }

        $sql .= " ORDER BY $column $direction";
        if (!is_null($from) && !is_null($count)) {
        $count = intval($count);
        $from = intval($from);
            $sql .= " LIMIT $from, $count ";
        }

        $result = Database::query($sql);

        return Database::store_result($result, 'ASSOC');

The expression return Database::store_result($result, 'ASSOC') returns the type array which is incompatible with the documented return type ResultSet.

    }