Chamilo\CourseBundle\Repository\CForumThreadRepository

Complexity

Total Complexity

8

Size/Duplication

Total Lines	101
Duplicated Lines	0 %

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	findOneInCourse()	0	36	3
A	findAllInCourseByForum()	0	49	5

<?php

/* For licensing terms, see /license.txt */

namespace Chamilo\CourseBundle\Repository;

use Chamilo\CoreBundle\Entity\Course;
use Chamilo\CoreBundle\Entity\Session;
use Chamilo\CoreBundle\Repository\ResourceRepository;
use Chamilo\CourseBundle\Entity\CForumForum;
use Chamilo\CourseBundle\Entity\CForumThread;
use Chamilo\CourseBundle\Entity\CGroupInfo;
use Chamilo\CourseBundle\Entity\CItemProperty;

/**
 * Class CForumThreadRepository.
 */
class CForumThreadRepository extends ResourceRepository
{
    /**
     * @param bool $isAllowedToEdit
     *
     * @todo Remove api_get_session_condition
     */
    public function findAllInCourseByForum(
        $isAllowedToEdit,
        CForumForum $forum,
        Course $course,
        CGroupInfo $group = null,
        Session $session = null
    ): array {
        $conditionSession = api_get_session_condition(
            $session ? $session->getId() : 0,
            true,
            false,
            't.sessionId'
        );
        $conditionVisibility = $isAllowedToEdit ? 'ip.visibility != 2' : 'ip.visibility = 1';
        $conditionGroup = $group
            ? 'AND ip.group = '.$group->getIid()
            : '';

        $dql = "SELECT DISTINCT t, ip
            FROM ChamiloCourseBundle:CForumThread t
            INNER JOIN ChamiloCourseBundle:CItemProperty ip
                WITH (t.iid = ip.ref AND t.cId = ip.course AND ip.tool = :tool)
            WHERE
                ip.course = :course AND
                t.forum = :forum AND
                $conditionVisibility
                $conditionGroup
                $conditionSession
            ORDER BY t.threadSticky DESC, t.threadDate DESC";

        $result = $this
            ->_em
            ->createQuery($dql)
            ->setParameters(['forum' => $forum, 'course' => $course, 'tool' => TOOL_FORUM_THREAD])
            ->getResult();

        $forums = [];

        for ($i = 0; $i < count($result); $i += 2) {

It seems like you are calling the size function count() as part of the test condition. You might want to compute the size beforehand, and not on each iteration.

            /** @var CForumThread $t */
            $t = $result[$i];
            /** @var CItemProperty $ip */
            $ip = $result[$i + 1];
            $t->setItemProperty($ip);

            $forums[] = $t;
        }

        return $forums;
    }

    /**
     * @param int $id
     *
     * @return CForumThread|null
     *
     * @todo Remove api_get_session_condition
     */
    public function findOneInCourse($id, Course $course, Session $session = null)
    {
        $conditionSession = api_get_session_condition(
            $session ? $session->getId() : 0,
            true,
            false,
            't.sessionId'
        );

        $dql = "SELECT t, ip
            FROM ChamiloCourseBundle:CForumThread AS t
            INNER JOIN ChamiloCourseBundle:CItemProperty AS ip
                WITH (t.iid = ip.ref AND t.cId = ip.course)
            WHERE
                t.iid = :id AND
                ip.tool = :tool AND
                t.cId = :course
                $conditionSession";

        $result = $this
            ->_em
            ->createQuery($dql)
            ->setParameters(['id' => (int) $id, 'course' => $course, 'tool' => TOOL_FORUM_THREAD])
            ->getResult();

        if (empty($result)) {
            return null;
        }

        /** @var CForumThread $t */
        $t = $result[0];
        /** @var CItemProperty $ip */
        $ip = $result[1];
        $t->setItemProperty($ip);

        return $t;
    }
}