DocumentUsageAction::__invoke() - Code Metrics - Inspection of "Merge pull request #7178 from Coussecousse/space_6..." - chamilo/chamilo-lms - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( f3154a...a09ea0 )

unknown

created 2025-12-18 23:14 UTC

DocumentUsageAction::__invoke() B

↳ Parent: DocumentUsageAction

Complexity

Conditions	6
Paths	17

Size

Total Lines	57
Code Lines	32

Duplication

Lines	0
Ratio	0 %

Importance

Changes	4
Bugs	0	Features	0

Metric	Value
cc	6
eloc	32
c	4
b	0
f	0
nc	17
nop	1
dl	0
loc	57
rs	8.7857

How to fix Long Method

<?php

declare(strict_types=1);

namespace Chamilo\CoreBundle\Controller\Api;

use Chamilo\CoreBundle\Repository\Node\CourseRepository;
use Chamilo\CourseBundle\Repository\CDocumentRepository;
use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
use Symfony\Component\HttpFoundation\JsonResponse;
use Symfony\Component\HttpKernel\Attribute\AsController;

#[AsController]
final class DocumentUsageAction extends AbstractController
{
    /**
     * Fallback quota (MB) when the course quota is empty or not set.
     */
    private const DEFAULT_QUOTA_MB = 100;

    public function __construct(
        private readonly CourseRepository $courseRepository,
        private readonly CDocumentRepository $documentRepository,
    ) {}

    public function __invoke($cid): JsonResponse
    {
        $courseId = (int) $cid;

        $course = $this->courseRepository->find($courseId);
        if (null === $course) {
            return new JsonResponse(['error' => 'Course not found'], 404);
        }

        // Resolve quota in MB safely (avoid "($x * ...) ?? fallback").
        $quotaMb = (int) ($course->getDiskQuota() ?? 0);
        if ($quotaMb <= 0) {
            $quotaMb = self::DEFAULT_QUOTA_MB;
        }

        $totalQuotaBytes = $quotaMb * 1024 * 1024;

        // Compute usage using repository logic (deduplicated).
        $usage = $this->documentRepository->getDocumentUsageBreakdownByCourse($course);

        $bytesCourse = (int) ($usage['course'] ?? 0);
        $bytesSessions = (int) ($usage['sessions'] ?? 0);
        $bytesGroups = (int) ($usage['groups'] ?? 0);

        $usedBytes = (int) ($usage['used'] ?? ($bytesCourse + $bytesSessions + $bytesGroups));

        // Keep the pie meaningful even when used > quota.
        $denomBytes = max($totalQuotaBytes, $usedBytes, 1);

        $availableBytes = max($totalQuotaBytes - $usedBytes, 0);

        $labels = [];
        $data = [];

        if ($bytesCourse > 0) {
            $labels[] = get_lang('Course').' ('.$this->formatBytes($bytesCourse).')';
            $data[] = $this->pct($bytesCourse, $denomBytes);
        }

        if ($bytesSessions > 0) {
            $labels[] = get_lang('Session').' ('.$this->formatBytes($bytesSessions).')';
            $data[] = $this->pct($bytesSessions, $denomBytes);
        }

        if ($bytesGroups > 0) {
            $labels[] = get_lang('Group').' ('.$this->formatBytes($bytesGroups).')';
            $data[] = $this->pct($bytesGroups, $denomBytes);
        }

        $labels[] = get_lang('Available space').' ('.$this->formatBytes($availableBytes).')';
        $data[] = $this->pct($availableBytes, $denomBytes);

        return new JsonResponse([
            'datasets' => [
                ['data' => $data],
            ],
            'labels' => $labels,
        ]);
    }

    private function pct(int $part, int $total): float
    {
        if ($total <= 0) {
            return 0.0;
        }

        return round(($part / $total) * 100, 2);
    }

    private function formatBytes(int $bytes): string
    {
        // Simple dependency-free formatter for API responses.
        $units = ['B', 'KB', 'MB', 'GB', 'TB'];
        $size = (float) max($bytes, 0);
        $i = 0;

        $max = count($units) - 1;
        while ($size >= 1024 && $i < $max) {
            $size /= 1024;
            $i++;
        }

        return round($size, 2).' '.$units[$i];
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Chamilo\CoreBundle\Controller\Api;
6
7			use Chamilo\CoreBundle\Repository\Node\CourseRepository;
8			use Chamilo\CourseBundle\Repository\CDocumentRepository;
9			use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
10			use Symfony\Component\HttpFoundation\JsonResponse;
11			use Symfony\Component\HttpKernel\Attribute\AsController;
12
13			#[AsController]
14			final class DocumentUsageAction extends AbstractController
15			{
16			/**
17			* Fallback quota (MB) when the course quota is empty or not set.
18			*/
19			private const DEFAULT_QUOTA_MB = 100;
20
21			public function __construct(
22			private readonly CourseRepository $courseRepository,
23			private readonly CDocumentRepository $documentRepository,
24			) {}
25
26			public function __invoke($cid): JsonResponse
27			{
28			$courseId = (int) $cid;
29
30			$course = $this->courseRepository->find($courseId);
31			if (null === $course) {
32			return new JsonResponse(['error' => 'Course not found'], 404);
33			}
34
35			// Resolve quota in MB safely (avoid "($x * ...) ?? fallback").
36			$quotaMb = (int) ($course->getDiskQuota() ?? 0);
37			if ($quotaMb <= 0) {
38			$quotaMb = self::DEFAULT_QUOTA_MB;
39			}
40
41			$totalQuotaBytes = $quotaMb * 1024 * 1024;
42
43			// Compute usage using repository logic (deduplicated).
44			$usage = $this->documentRepository->getDocumentUsageBreakdownByCourse($course);
45
46			$bytesCourse = (int) ($usage['course'] ?? 0);
47			$bytesSessions = (int) ($usage['sessions'] ?? 0);
48			$bytesGroups = (int) ($usage['groups'] ?? 0);
49
50			$usedBytes = (int) ($usage['used'] ?? ($bytesCourse + $bytesSessions + $bytesGroups));
51
52			// Keep the pie meaningful even when used > quota.
53			$denomBytes = max($totalQuotaBytes, $usedBytes, 1);
54
55			$availableBytes = max($totalQuotaBytes - $usedBytes, 0);
56
57			$labels = [];
58			$data = [];
59
60			if ($bytesCourse > 0) {
61			$labels[] = get_lang('Course').' ('.$this->formatBytes($bytesCourse).')';
62			$data[] = $this->pct($bytesCourse, $denomBytes);
63			}
64
65			if ($bytesSessions > 0) {
66			$labels[] = get_lang('Session').' ('.$this->formatBytes($bytesSessions).')';
67			$data[] = $this->pct($bytesSessions, $denomBytes);
68			}
69
70			if ($bytesGroups > 0) {
71			$labels[] = get_lang('Group').' ('.$this->formatBytes($bytesGroups).')';
72			$data[] = $this->pct($bytesGroups, $denomBytes);
73			}
74
75			$labels[] = get_lang('Available space').' ('.$this->formatBytes($availableBytes).')';
76			$data[] = $this->pct($availableBytes, $denomBytes);
77
78			return new JsonResponse([
79			'datasets' => [
80			['data' => $data],
81			],
82			'labels' => $labels,
83			]);
84			}
85
86			private function pct(int $part, int $total): float
87			{
88			if ($total <= 0) {
89			return 0.0;
90			}
91
92			return round(($part / $total) * 100, 2);
93			}
94
95			private function formatBytes(int $bytes): string
96			{
97			// Simple dependency-free formatter for API responses.
98			$units = ['B', 'KB', 'MB', 'GB', 'TB'];
99			$size = (float) max($bytes, 0);
100			$i = 0;
101
102			$max = count($units) - 1;
103			while ($size >= 1024 && $i < $max) {
104			$size /= 1024;
105			$i++;
106			}
107
108			return round($size, 2).' '.$units[$i];
109			}
110			}
111

chamilo / chamilo-lms

Push — master ( f3154a...a09ea0 )

DocumentUsageAction::__invoke() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like