| Conditions | 18 |
| Paths | > 20000 |
| Total Lines | 90 |
| Code Lines | 54 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 19 | public function up(Schema $schema): void |
||
| 20 | { |
||
| 21 | $table = $schema->getTable('c_group_info'); |
||
| 22 | |||
| 23 | $this->addSql('ALTER TABLE c_group_info CHANGE doc_state doc_state INT NOT NULL, CHANGE calendar_state calendar_state INT NOT NULL, CHANGE work_state work_state INT NOT NULL'); |
||
| 24 | $this->addSql('ALTER TABLE c_group_info CHANGE announcements_state announcements_state INT NOT NULL, CHANGE forum_state forum_state INT NOT NULL, CHANGE wiki_state wiki_state INT NOT NULL, CHANGE chat_state chat_state INT NOT NULL;'); |
||
| 25 | |||
| 26 | if ($table->hasIndex('session_id')) { |
||
| 27 | $this->addSql('DROP INDEX session_id ON c_group_info'); |
||
| 28 | } |
||
| 29 | if ($table->hasIndex('course')) { |
||
| 30 | $this->addSql('DROP INDEX course ON c_group_info'); |
||
| 31 | } |
||
| 32 | if (!$table->hasColumn('document_access')) { |
||
| 33 | $this->addSql('ALTER TABLE c_group_info ADD document_access INT DEFAULT 0 NOT NULL;'); |
||
| 34 | } |
||
| 35 | |||
| 36 | if (false === $table->hasColumn('resource_node_id')) { |
||
| 37 | $this->addSql('ALTER TABLE c_group_info ADD resource_node_id INT DEFAULT NULL'); |
||
| 38 | $this->addSql('ALTER TABLE c_group_info ADD CONSTRAINT FK_CE0653241BAD783F FOREIGN KEY (resource_node_id) REFERENCES resource_node (id) ON DELETE CASCADE'); |
||
| 39 | $this->addSql('CREATE UNIQUE INDEX UNIQ_CE0653241BAD783F ON c_group_info (resource_node_id)'); |
||
| 40 | } |
||
| 41 | |||
| 42 | if (false === $table->hasIndex('IDX_CE06532412469DE2')) { |
||
| 43 | $this->addSql('CREATE INDEX IDX_CE06532412469DE2 ON c_group_info (category_id)'); |
||
| 44 | } |
||
| 45 | |||
| 46 | $this->addSql('ALTER TABLE c_group_info CHANGE category_id category_id INT DEFAULT NULL'); |
||
| 47 | |||
| 48 | $table = $schema->getTable('c_group_rel_user'); |
||
| 49 | |||
| 50 | $this->addSql('DELETE FROM c_group_rel_user WHERE user_id NOT IN (SELECT id FROM user)'); |
||
| 51 | $this->addSql('DELETE FROM c_group_rel_user WHERE group_id NOT IN (SELECT iid FROM c_group_info)'); |
||
| 52 | if (false === $table->hasForeignKey('FK_C5D3D49FA76ED395')) { |
||
| 53 | $this->addSql( |
||
| 54 | 'ALTER TABLE c_group_rel_user ADD CONSTRAINT FK_C5D3D49FA76ED395 FOREIGN KEY (user_id) REFERENCES user (id)' |
||
| 55 | ); |
||
| 56 | } |
||
| 57 | |||
| 58 | if (false === $table->hasForeignKey('FK_C5D3D49FFE54D947')) { |
||
| 59 | $this->addSql( |
||
| 60 | 'ALTER TABLE c_group_rel_user ADD CONSTRAINT FK_C5D3D49FFE54D947 FOREIGN KEY (group_id) REFERENCES c_group_info (iid) ON DELETE CASCADE;' |
||
| 61 | ); |
||
| 62 | } |
||
| 63 | if (false === $table->hasIndex('IDX_C5D3D49FA76ED395')) { |
||
| 64 | $this->addSql('CREATE INDEX IDX_C5D3D49FA76ED395 ON c_group_rel_user (user_id)'); |
||
| 65 | } |
||
| 66 | if (false === $table->hasIndex('IDX_C5D3D49FFE54D947')) { |
||
| 67 | $this->addSql('CREATE INDEX IDX_C5D3D49FFE54D947 ON c_group_rel_user (group_id)'); |
||
| 68 | } |
||
| 69 | |||
| 70 | $this->addSql('DELETE FROM c_group_rel_tutor WHERE user_id NOT IN (SELECT id FROM user)'); |
||
| 71 | $this->addSql('DELETE FROM c_group_rel_tutor WHERE group_id NOT IN (SELECT iid FROM c_group_info)'); |
||
| 72 | |||
| 73 | $table = $schema->getTable('c_group_rel_tutor'); |
||
| 74 | if (false === $table->hasForeignKey('FK_F6FF71ABA76ED395')) { |
||
| 75 | $this->addSql( |
||
| 76 | 'ALTER TABLE c_group_rel_tutor ADD CONSTRAINT FK_F6FF71ABA76ED395 FOREIGN KEY (user_id) REFERENCES user (id)' |
||
| 77 | ); |
||
| 78 | } |
||
| 79 | if (false === $table->hasForeignKey('FK_F6FF71ABFE54D947')) { |
||
| 80 | $this->addSql( |
||
| 81 | 'ALTER TABLE c_group_rel_tutor ADD CONSTRAINT FK_F6FF71ABFE54D947 FOREIGN KEY (group_id) REFERENCES c_group_info (iid)' |
||
| 82 | ); |
||
| 83 | } |
||
| 84 | if (false === $table->hasIndex('IDX_F6FF71ABA76ED395')) { |
||
| 85 | $this->addSql('CREATE INDEX IDX_F6FF71ABA76ED395 ON c_group_rel_tutor (user_id)'); |
||
| 86 | } |
||
| 87 | if (false === $table->hasIndex('IDX_F6FF71ABFE54D947')) { |
||
| 88 | $this->addSql('CREATE INDEX IDX_F6FF71ABFE54D947 ON c_group_rel_tutor (group_id)'); |
||
| 89 | } |
||
| 90 | |||
| 91 | $table = $schema->getTable('c_group_category'); |
||
| 92 | if ($table->hasIndex('course')) { |
||
| 93 | $this->addSql('DROP INDEX course ON c_group_category'); |
||
| 94 | } |
||
| 95 | |||
| 96 | if (!$table->hasColumn('document_access')) { |
||
| 97 | $this->addSql('ALTER TABLE c_group_category ADD document_access INT DEFAULT 0 NOT NULL;'); |
||
| 98 | } |
||
| 99 | |||
| 100 | if (false === $table->hasColumn('resource_node_id')) { |
||
| 101 | $this->addSql('ALTER TABLE c_group_category ADD resource_node_id INT DEFAULT NULL'); |
||
| 102 | $this->addSql('ALTER TABLE c_group_category ADD CONSTRAINT FK_F8E479F61BAD783F FOREIGN KEY (resource_node_id) REFERENCES resource_node (id) ON DELETE CASCADE'); |
||
| 103 | $this->addSql('CREATE UNIQUE INDEX UNIQ_F8E479F61BAD783F ON c_group_category (resource_node_id)'); |
||
| 104 | } |
||
| 105 | |||
| 106 | $this->addSql('UPDATE c_group_info SET category_id = NULL WHERE category_id NOT IN (select iid FROM c_group_category)'); |
||
| 107 | if (false === $schema->getTable('c_group_info')->hasForeignKey('FK_CE06532412469DE2')) { |
||
| 108 | $this->addSql('ALTER TABLE c_group_info ADD CONSTRAINT FK_CE06532412469DE2 FOREIGN KEY (category_id) REFERENCES c_group_category (iid) ON DELETE CASCADE'); |
||
| 109 | } |
||
| 116 |