CalendarEvent::__construct() - Code Metrics - Inspection of "Merge with 1.11.x" - chamilo/chamilo-lms - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( bd22e5...ae5621 )

by Julito

created 2018-04-30 09:46 UTC

CalendarEvent::__construct() A

↳ Parent: CalendarEvent

Complexity

Conditions	1
Paths	1

Size

Total Lines	23
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	10
nc	1
nop	10
dl	0
loc	23
rs	9.0856
c	0
b	0
f	0

How to fix Many Parameters

<?php
/* For licensing terms, see /license.txt */

namespace Chamilo\CourseBundle\Component\CourseCopy\Resources;

/**
 * Event backup script.
 *
 * @author Bart Mollet <[email protected]>
 *
 * @package chamilo.backup
 */
class CalendarEvent extends Resource
{
    /**
     * The title.
     */
    public $title;
    /**
     * The content.
     */
    public $content;
    /**
     * The start date.
     */
    public $start_date;
    /**
     * The end date.
     */
    public $end_date;
    /**
     * The attachment path.
     */
    public $attachment_path;

    /**
     * The attachment filename.
     */
    public $attachment_filename;
    /**
     * The attachment size.
     */
    public $attachment_size;

    /**
     * The attachment comment.
     */
    public $attachment_comment;

    /**
     * Create a new Event.
     *
     * @param int    $id
     * @param string $title
     * @param string $content
     */
    public function __construct(
        $id,
        $title,
        $content,
        $start_date,
        $end_date,
        $attachment_path = null,
        $attachment_filename = null,
        $attachment_size = null,
        $attachment_comment = null,
        $all_day = 0
    ) {
        parent::__construct($id, RESOURCE_EVENT);

        $this->title = $title;
        $this->content = $content;
        $this->start_date = $start_date;
        $this->end_date = $end_date;
        $this->all_day = $all_day;

        $this->attachment_path = $attachment_path;
        $this->attachment_filename = $attachment_filename;
        $this->attachment_size = $attachment_size;
        $this->attachment_comment = $attachment_comment;
    }

    /**
     * Show this Event.
     */
    public function show()
    {
        parent::show();
        echo $this->title.' ('.$this->start_date.' -> '.$this->end_date.')';
    }
}


1			<?php
2			/* For licensing terms, see /license.txt */
3
4			namespace Chamilo\CourseBundle\Component\CourseCopy\Resources;
5
6			/**
7			* Event backup script.
8			*
9			* @author Bart Mollet <[email protected]>
10			*
11			* @package chamilo.backup
12			*/
13			class CalendarEvent extends Resource
14			{
15			/**
16			* The title.
17			*/
18			public $title;
19			/**
20			* The content.
21			*/
22			public $content;
23			/**
24			* The start date.
25			*/
26			public $start_date;
27			/**
28			* The end date.
29			*/
30			public $end_date;
31			/**
32			* The attachment path.
33			*/
34			public $attachment_path;
35
36			/**
37			* The attachment filename.
38			*/
39			public $attachment_filename;
40			/**
41			* The attachment size.
42			*/
43			public $attachment_size;
44
45			/**
46			* The attachment comment.
47			*/
48			public $attachment_comment;
49
50			/**
51			* Create a new Event.
52			*
53			* @param int $id
54			* @param string $title
55			* @param string $content
56			*/
57			public function __construct(
58			$id,
59			$title,
60			$content,
61			$start_date,
62			$end_date,
63			$attachment_path = null,
64			$attachment_filename = null,
65			$attachment_size = null,
66			$attachment_comment = null,
67			$all_day = 0
68			) {
69			parent::__construct($id, RESOURCE_EVENT);
70
71			$this->title = $title;
72			$this->content = $content;
73			$this->start_date = $start_date;
74			$this->end_date = $end_date;
75			$this->all_day = $all_day;
			0 ignored issues – show Bug Best Practice introduced 2018-01-05 13:33 UTC by Report Bug Copy Issue Report The property `all_day` does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly. Loading history...
76			$this->attachment_path = $attachment_path;
77			$this->attachment_filename = $attachment_filename;
78			$this->attachment_size = $attachment_size;
79			$this->attachment_comment = $attachment_comment;
80			}
81
82			/**
83			* Show this Event.
84			*/
85			public function show()
86			{
87			parent::show();
88			echo $this->title.' ('.$this->start_date.' -> '.$this->end_date.')';
89			}
90			}
91

chamilo / chamilo-lms

Push — master ( bd22e5...ae5621 )

CalendarEvent::__construct() A

Complexity

Size

Duplication

Importance

How to fix Many Parameters

Many Parameters

Duplication Side-by-Side

Filter issues like