Chamilo\CourseBundle\Component\CourseCopy\Resources\QuizQuestion

Complexity

Total Complexity

10

Size/Duplication

Total Lines	167
Duplicated Lines	0 %

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	23	1
A	add_option()	0	3	1
B	addPicture()	0	24	6
A	add_answer()	0	20	1
A	show()	0	4	1

<?php
/* For licensing terms, see /license.txt */

namespace Chamilo\CourseBundle\Component\CourseCopy\Resources;

use Chamilo\CourseBundle\Component\CourseCopy\CourseBuilder;

/**
 * Exercises questions backup script
 * Class QuizQuestion.
 *
 * @author Bart Mollet <bart.mollet@hogent.be>
 *
 * @package chamilo.backup
 */
class QuizQuestion extends Resource
{
    /**
     * The question.
     */
    public $question;

    /**
     * The description.
     */
    public $description;

    /**
     * Ponderation.
     */
    public $ponderation;

    /**
     * Type.
     */
    public $quiz_type;

    /**
     * Position.
     */
    public $position;

    /**
     * Level.
     */
    public $level;

    /**
     * Answers.
     */
    public $answers;

    /**
     * Picture.
     */
    public $picture;
    public $extra;

    /**
     * @var int the question category if any, 0 by default
     */
    public $question_category;

    /**
     * QuizQuestion constructor.
     *
     * @param int    $id
     * @param string $question
     * @param string $description
     * @param int    $ponderation
     * @param        $type
     * @param        $position
     * @param string $picture
     * @param        $level
     * @param        $extra
     * @param int    $question_category
     */
    public function __construct(
        $id,
        $question,
        $description,
        $ponderation,
        $type,
        $position,
        $picture,
        $level,
        $extra,
        $question_category = 0
    ) {
        parent::__construct($id, RESOURCE_QUIZQUESTION);
        $this->question = $question;
        $this->description = $description;
        $this->ponderation = $ponderation;
        $this->quiz_type = $type;
        $this->position = $position;
        $this->level = $level;
        $this->answers = [];
        $this->extra = $extra;
        $this->question_category = $question_category;
        $this->picture = $picture;
    }

    /**
     * @param CourseBuilder $courseBuilder
     */
    public function addPicture(CourseBuilder $courseBuilder)
    {
        if (!empty($this->picture)) {
            $courseInfo = $courseBuilder->course->info;

The property info does not seem to exist on Chamilo\CourseBundle\Component\CourseCopy\Course.

            $courseId = $courseInfo['real_id'];
            $courseCode = $courseInfo['code'];
            $questionId = $this->source_id;
            $question = \Question::read($questionId, $courseId);
            $pictureId = $question->getPictureId();
            // Add the picture document in the builder
            if (!empty($pictureId)) {
                $itemsToAdd[] = $pictureId;

$itemsToAdd was never initialized. Although not strictly required by PHP, it is generally a good practice to add $itemsToAdd = array(); before regardless.

                // Add the "images" folder needed for correct restore
                $documentData = \DocumentManager::get_document_data_by_id($pictureId, $courseCode, true);

It seems like $pictureId can also be of type string; however, parameter $id of DocumentManager::get_document_data_by_id() does only seem to accept integer, maybe add an additional type check?

                if ($documentData) {

The expression $documentData of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

                    if (isset($documentData['parents'])) {
                        foreach ($documentData['parents'] as $parent) {
                            $itemsToAdd[] = $parent['id'];
                        }
                    }
                }

                // Add the picture
                $courseBuilder->build_documents(api_get_session_id(), $courseId, false, $itemsToAdd);
            }
        }
    }

    /**
     * Add an answer to this QuizQuestion.
     *
     * @param int    $answer_id
     * @param string $answer_text
     * @param string $correct
     * @param string $comment
     * @param string $ponderation
     * @param string $position
     * @param string $hotspot_coordinates
     * @param string $hotspot_type
     */
    public function add_answer(
        $answer_id,
        $answer_text,
        $correct,
        $comment,
        $ponderation,
        $position,
        $hotspot_coordinates,
        $hotspot_type
    ) {
        $answer = [];
        $answer['id'] = $answer_id;
        $answer['answer'] = $answer_text;
        $answer['correct'] = $correct;
        $answer['comment'] = $comment;
        $answer['ponderation'] = $ponderation;
        $answer['position'] = $position;
        $answer['hotspot_coordinates'] = $hotspot_coordinates;
        $answer['hotspot_type'] = $hotspot_type;
        $this->answers[] = $answer;
    }

    /**
     * @param QuizQuestionOption $option
     */
    public function add_option($option)
    {
        $this->question_options[$option->obj->id] = $option;

The property question_options does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

    }

    /**
     * Show this question.
     */
    public function show()
    {
        parent::show();
        echo $this->question;
    }
}