LpItemOrderList

Complexity

Total Complexity

11

Size/Duplication

Total Lines	63
Duplicated Lines	0 %

Importance

Changes	1
Bugs	1	Features	1

5 Methods

Rating	Name	Duplication	Size	Complexity
A	add()	0	3	1
A	setParametersForId()	0	6	3
A	getItemWithSameParent()	0	10	3
A	__construct()	0	3	1
A	getListOfParents()	0	10	3

<?php
/* For licensing terms, see /license.txt */

/**
 * Class LpItemOrderList.
 *
 * Classes to create a special data structure to manipulate LP Items used only in this file.
 */
class LpItemOrderList
{
    public $list = [];

    /**
     * LpItemOrderList constructor.
     */
    public function __construct()
    {
        $this->list = [];
    }

    /**
     * @param int $parentId
     *
     * @return LpItemOrderList
     */
    public function getItemWithSameParent($parentId)
    {
        $list = new LpItemOrderList();
        for ($i = 0; $i < count($this->list); $i++) {

It seems like you are calling the size function count() as part of the test condition. You might want to compute the size beforehand, and not on each iteration.

            if ($this->list[$i]->parent_item_id == $parentId) {
                $list->add($this->list[$i]);
            }
        }

        return $list;
    }

    /**
     * @param array $list
     */
    public function add($list)
    {
        $this->list[] = $list;
    }

    /**
     * @return array
     */
    public function getListOfParents()
    {
        $result = [];
        foreach ($this->list as $item) {
            if (!in_array($item->parent_item_id, $result)) {
                $result[] = $item->parent_item_id;
            }
        }

        return $result;
    }

    /**
     * @param int    $id
     * @param int    $value
     * @param string $parameter
     */
    public function setParametersForId($id, $value, $parameter)
    {
        for ($i = 0; $i < count($this->list); $i++) {

It seems like you are calling the size function count() as part of the test condition. You might want to compute the size beforehand, and not on each iteration.

            if ($this->list[$i]->id == $id) {
                $this->list[$i]->$parameter = $value;
                break;
            }
        }
    }
}