findResults() - Code Metrics - Inspection of "Plugin: Exercise monitoring and focused - refs BT#..." - chamilo/chamilo-lms - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — 1.11.x (#4900)

by Angel Fernando Quiroz

created 2023-11-21 15:57 UTC

findResults() C

↳ Parent: Project

Complexity

Conditions	10
Paths	192

Size

Total Lines	75
Code Lines	41

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	41
dl	0
loc	75
rs	6.9
c	1
b	0
f	0
cc	10
nc	192
nop	3

How to fix Long Method Complexity

<?php

/* For licensing terms, see /license.txt */

use Chamilo\CoreBundle\Entity\TrackEAttempt;
use Chamilo\CoreBundle\Entity\TrackEExercises;
use Chamilo\CourseBundle\Entity\CQuiz;
use Chamilo\PluginBundle\ExerciseFocused\Entity\Log as FocusedLog;
use Chamilo\PluginBundle\ExerciseMonitoring\Entity\Log as MonitoringLog;
use Chamilo\UserBundle\Entity\User;
use Doctrine\ORM\EntityManagerInterface;
use Doctrine\ORM\Query\Expr\Join;
use Symfony\Component\HttpFoundation\Request as HttpRequest;
.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php

require_once __DIR__.'/../../../main/inc/global.inc.php';

api_protect_course_script(true);

if (!api_is_allowed_to_edit()) {
    api_not_allowed(true);
}

$plugin = ExerciseFocusedPlugin::create();
$monitoringPlugin = ExerciseMonitoringPlugin::create();
$monitoringPluginIsEnabled = $monitoringPlugin->isEnabled(true);
$request = HttpRequest::createFromGlobals();
$em = Database::getManager();
$focusedLogRepository = $em->getRepository(FocusedLog::class);
$attempsRepository = $em->getRepository(TrackEAttempt::class);

if (!$plugin->isEnabled(true)) {
    api_not_allowed(true);
}

$params = $request->query->all();

$results = findResults($params, $em, $plugin);

$data = [];

/** @var array<string, mixed> $result */
foreach ($results as $result) {
    /** @var TrackEExercises $trackExe */
    $trackExe = $result['exe'];
    $user = api_get_user_entity($trackExe->getExeUserId());

    $outfocusedLimitCount = $focusedLogRepository->countByActionInExe($trackExe, FocusedLog::TYPE_OUTFOCUSED_LIMIT);
    $timeLimitCount = $focusedLogRepository->countByActionInExe($trackExe, FocusedLog::TYPE_TIME_LIMIT);

    $exercise = new Exercise($trackExe->getCId());
    $exercise->read($trackExe->getExeExoId());

    $quizType = (int) $exercise->selectType();

    $data[] = [
        get_lang('LoginName'),
        $user->getUsername(),
    ];
    $data[] = [
        get_lang('Student'),
        $user->getFirstname(),
        $user->getLastname(),
    ];

    if ($trackExe->getSessionId()) {
        $data[] = [
            get_lang('SessionName'),
            api_get_session_entity($trackExe->getSessionId())->getName(),
        ];
    }

    $data[] = [
        get_lang('CourseTitle'),
        api_get_course_entity($trackExe->getCId())->getTitle(),
    ];
    $data[] = [
        get_lang('ExerciseName'),
        $exercise->getUnformattedTitle(),
    ];
    $data[] = [
        $plugin->get_lang('ExerciseStartDateAndTime'),
        api_get_local_time($result['exe']->getStartDate(), null, null, true, true, true),
    ];
    $data[] = [
        $plugin->get_lang('ExerciseEndDateAndTime'),
        api_get_local_time($result['exe']->getExeDate(), null, null, true, true, true),
    ];
    $data[] = [
        get_lang('IP'),
        $result['exe']->getUserIp(),
    ];
    $data[] = [
        $plugin->get_lang('Motive'),
        $plugin->calculateMotive($outfocusedLimitCount, $timeLimitCount),
    ];
    $data[] = [];

    $data[] = [
        $plugin->get_lang('LevelReached'),
        get_lang('DateExo'),
        get_lang('Score'),
        $plugin->get_lang('Outfocused'),
        $plugin->get_lang('Returns'),
        $monitoringPluginIsEnabled ? $monitoringPlugin->get_lang('Snapshots') : '',
    ];

    if (ONE_PER_PAGE === $quizType) {
        $questionList = explode(',', $trackExe->getDataTracking());

        foreach ($questionList as $idx => $questionId) {
            $attempt = $attempsRepository->findOneBy(
                ['exeId' => $trackExe->getExeId(), 'questionId' => $questionId],
                ['tms' => 'DESC']
            );

            if (!$attempt) {
                continue;
            }

            $result = $exercise->manage_answer(
                $trackExe->getExeId(),
                $questionId,
                null,
                'exercise_result',
                false,
                false,
                true,
                false,
                $exercise->selectPropagateNeg()
            );

            $row = [
                get_lang('QuestionNumber').' '.($idx + 1),
                api_get_local_time($attempt->getTms()),
                $result['score'].' / '.$result['weight'],
                $focusedLogRepository->countByActionAndLevel($trackExe, FocusedLog::TYPE_OUTFOCUSED, $questionId),
                $focusedLogRepository->countByActionAndLevel($trackExe, FocusedLog::TYPE_RETURN, $questionId),
                getSnapshotListForLevel($questionId, $trackExe),
            ];

            $data[] = $row;
        }
    } elseif (ALL_ON_ONE_PAGE === $quizType) {
    }

    $data[] = [];
    $data[] = [];
    $data[] = [];
}

//var_dump($data);
Export::arrayToXls($data);

function getSessionIdFromFormValues(array $formValues, array $fieldVariableList): array
{
    $fieldItemIdList = [];
    $objFieldValue = new ExtraFieldValue('session');

    foreach ($fieldVariableList as $fieldVariable) {
        if (!isset($formValues["extra_$fieldVariable"])) {
            continue;
        }

        $itemValue = $objFieldValue->get_item_id_from_field_variable_and_field_value(
            $fieldVariable,
            $formValues["extra_$fieldVariable"]
        );

        if ($itemValue) {
            $fieldItemIdList[] = (int) $itemValue['item_id'];
        }
    }

    return array_unique($fieldItemIdList);
}

function findResults(array $formValues, EntityManagerInterface $em, ExerciseFocusedPlugin $plugin)
{
    $cId = api_get_course_int_id();

    $qb = $em->createQueryBuilder();
    $qb
        ->select('te AS exe, q.title, te.startDate , u.firstname, u.lastname, u.username')
        ->from(TrackEExercises::class, 'te')
        ->innerJoin(CQuiz::class, 'q', Join::WITH, 'te.exeExoId = q.iid')
        ->innerJoin(User::class, 'u', Join::WITH, 'te.exeUserId = u.id');

    $params = [];

    if ($cId) {
        $qb->andWhere($qb->expr()->eq('te.cId', ':cId'));

        $params['cId'] = $cId;
    }

    $sessionItemIdList = getSessionIdFromFormValues(
        $formValues,
        $plugin->getSessionFieldList()
    );

    if ($sessionItemIdList) {

        $qb->andWhere($qb->expr()->in('te.sessionId', ':sessionItemIdList'));

        $params['sessionItemIdList'] = $sessionItemIdList;
    }

    if (!empty($formValues['username'])) {
        $qb->andWhere($qb->expr()->eq('u.username', ':username'));

        $params['username'] = $formValues['username'];
    }

    if (!empty($formValues['firstname'])) {
        $qb->andWhere($qb->expr()->eq('u.firstname', ':firstname'));

        $params['firstname'] = $formValues['firstname'];
    }

    if (!empty($formValues['lastname'])) {
        $qb->andWhere($qb->expr()->eq('u.lastname', ':lastname'));

        $params['lastname'] = $formValues['lastname'];
    }

    if (!empty($formValues['start_date'])) {
        $qb->andWhere(
            $qb->expr()->andX(
                $qb->expr()->gte('te.startDate', ':start_date'),
                $qb->expr()->lte('te.exeDate', ':end_date')
            )
        );

        $params['start_date'] = api_get_utc_datetime($formValues['start_date'].' 00:00:00', false, true);
        $params['end_date'] = api_get_utc_datetime($formValues['start_date'].' 23:59:59', false, true);
    }

    if (empty($params)) {
        return [];
    }

    if ($cId && !empty($formValues['id'])) {
        $qb->andWhere($qb->expr()->eq('q.iid', ':q_id'));

        $params['q_id'] = $formValues['id'];
    }

    $qb->setParameters($params);

    $query = $qb->getQuery();

    return $query->getResult();
}

function getSnapshotListForLevel(int $level, TrackEExercises $trackExe): string
{
    $monitoringPluginIsEnabled = ExerciseMonitoringPlugin::create()->isEnabled(true);

    if (!$monitoringPluginIsEnabled) {
        return '';
    }

    $user = api_get_user_entity($trackExe->getExeUserId());
    $monitoringLogRepository = Database::getManager()->getRepository(MonitoringLog::class);

    $monitoringLogsByQuestion = $monitoringLogRepository->findByLevelAndExe($level, $trackExe);
    $snapshotList = [];

    /** @var MonitoringLog $logByQuestion */
    foreach ($monitoringLogsByQuestion as $logByQuestion) {
        $snapshotUrl = ExerciseMonitoringPlugin::generateSnapshotUrl(
            $user->getId(),
            $logByQuestion->getImageFilename()
        );
        $snapshotList[] = api_get_local_time($logByQuestion->getCreatedAt()).' '.$snapshotUrl;
    }

    return implode(PHP_EOL, $snapshotList);
}


1			<?php
2
3			/* For licensing terms, see /license.txt */
4
5			use Chamilo\CoreBundle\Entity\TrackEAttempt;
6			use Chamilo\CoreBundle\Entity\TrackEExercises;
7			use Chamilo\CourseBundle\Entity\CQuiz;
8			use Chamilo\PluginBundle\ExerciseFocused\Entity\Log as FocusedLog;
9			use Chamilo\PluginBundle\ExerciseMonitoring\Entity\Log as MonitoringLog;
10			use Chamilo\UserBundle\Entity\User;
11			use Doctrine\ORM\EntityManagerInterface;
12			use Doctrine\ORM\Query\Expr\Join;
13			use Symfony\Component\HttpFoundation\Request as HttpRequest;
			0 ignored issues – show Bug introduced 2023-10-06 16:55 UTC by Report Bug Copy Issue Report This use statement conflicts with another class in this namespace, `HttpRequest`. Consider defining an alias. Let?s assume that you have a directory layout like this: . \|-- OtherDir \| \|-- Bar.php \| `-- Foo.php `-- SomeDir `-- Foo.php and let?s assume the following content of `Bar.php`: // Bar.php namespace OtherDir; use SomeDir\Foo; // This now conflicts the class OtherDir\Foo If both files `OtherDir/Foo.php` and `SomeDir/Foo.php` are loaded in the same runtime, you will see a PHP error such as the following: PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php However, as `OtherDir/Foo.php` does not necessarily have to be loaded and the error is only triggered if it is loaded before `OtherDir/Bar.php`, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: // Bar.php namespace OtherDir; use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore. Loading history...
14
15			require_once __DIR__.'/../../../main/inc/global.inc.php';
16
17			api_protect_course_script(true);
18
19			if (!api_is_allowed_to_edit()) {
20			api_not_allowed(true);
21			}
22
23			$plugin = ExerciseFocusedPlugin::create();
24			$monitoringPlugin = ExerciseMonitoringPlugin::create();
25			$monitoringPluginIsEnabled = $monitoringPlugin->isEnabled(true);
26			$request = HttpRequest::createFromGlobals();
27			$em = Database::getManager();
28			$focusedLogRepository = $em->getRepository(FocusedLog::class);
29			$attempsRepository = $em->getRepository(TrackEAttempt::class);
30
31			if (!$plugin->isEnabled(true)) {
32			api_not_allowed(true);
33			}
34
35			$params = $request->query->all();
36
37			$results = findResults($params, $em, $plugin);
38
39			$data = [];
40
41			/** @var array<string, mixed> $result */
42			foreach ($results as $result) {
43			/** @var TrackEExercises $trackExe */
44			$trackExe = $result['exe'];
45			$user = api_get_user_entity($trackExe->getExeUserId());
46
47			$outfocusedLimitCount = $focusedLogRepository->countByActionInExe($trackExe, FocusedLog::TYPE_OUTFOCUSED_LIMIT);
48			$timeLimitCount = $focusedLogRepository->countByActionInExe($trackExe, FocusedLog::TYPE_TIME_LIMIT);
49
50			$exercise = new Exercise($trackExe->getCId());
51			$exercise->read($trackExe->getExeExoId());
52
53			$quizType = (int) $exercise->selectType();
54
55			$data[] = [
56			get_lang('LoginName'),
57			$user->getUsername(),
58			];
59			$data[] = [
60			get_lang('Student'),
61			$user->getFirstname(),
62			$user->getLastname(),
63			];
64
65			if ($trackExe->getSessionId()) {
66			$data[] = [
67			get_lang('SessionName'),
68			api_get_session_entity($trackExe->getSessionId())->getName(),
69			];
70			}
71
72			$data[] = [
73			get_lang('CourseTitle'),
74			api_get_course_entity($trackExe->getCId())->getTitle(),
75			];
76			$data[] = [
77			get_lang('ExerciseName'),
78			$exercise->getUnformattedTitle(),
79			];
80			$data[] = [
81			$plugin->get_lang('ExerciseStartDateAndTime'),
82			api_get_local_time($result['exe']->getStartDate(), null, null, true, true, true),
83			];
84			$data[] = [
85			$plugin->get_lang('ExerciseEndDateAndTime'),
86			api_get_local_time($result['exe']->getExeDate(), null, null, true, true, true),
87			];
88			$data[] = [
89			get_lang('IP'),
90			$result['exe']->getUserIp(),
91			];
92			$data[] = [
93			$plugin->get_lang('Motive'),
94			$plugin->calculateMotive($outfocusedLimitCount, $timeLimitCount),
95			];
96			$data[] = [];
97
98			$data[] = [
99			$plugin->get_lang('LevelReached'),
100			get_lang('DateExo'),
101			get_lang('Score'),
102			$plugin->get_lang('Outfocused'),
103			$plugin->get_lang('Returns'),
104			$monitoringPluginIsEnabled ? $monitoringPlugin->get_lang('Snapshots') : '',
105			];
106
107			if (ONE_PER_PAGE === $quizType) {
108			$questionList = explode(',', $trackExe->getDataTracking());
109
110			foreach ($questionList as $idx => $questionId) {
111			$attempt = $attempsRepository->findOneBy(
112			['exeId' => $trackExe->getExeId(), 'questionId' => $questionId],
113			['tms' => 'DESC']
114			);
115
116			if (!$attempt) {
117			continue;
118			}
119
120			$result = $exercise->manage_answer(
121			$trackExe->getExeId(),
122			$questionId,
123			null,
124			'exercise_result',
125			false,
126			false,
127			true,
128			false,
129			$exercise->selectPropagateNeg()
130			);
131
132			$row = [
133			get_lang('QuestionNumber').' '.($idx + 1),
134			api_get_local_time($attempt->getTms()),
135			$result['score'].' / '.$result['weight'],
136			$focusedLogRepository->countByActionAndLevel($trackExe, FocusedLog::TYPE_OUTFOCUSED, $questionId),
137			$focusedLogRepository->countByActionAndLevel($trackExe, FocusedLog::TYPE_RETURN, $questionId),
138			getSnapshotListForLevel($questionId, $trackExe),
139			];
140
141			$data[] = $row;
142			}
143			} elseif (ALL_ON_ONE_PAGE === $quizType) {
144			}
145
146			$data[] = [];
147			$data[] = [];
148			$data[] = [];
149			}
150
151			//var_dump($data);
152			Export::arrayToXls($data);
153
154			function getSessionIdFromFormValues(array $formValues, array $fieldVariableList): array
155			{
156			$fieldItemIdList = [];
157			$objFieldValue = new ExtraFieldValue('session');
158
159			foreach ($fieldVariableList as $fieldVariable) {
160			if (!isset($formValues["extra_$fieldVariable"])) {
161			continue;
162			}
163
164			$itemValue = $objFieldValue->get_item_id_from_field_variable_and_field_value(
165			$fieldVariable,
166			$formValues["extra_$fieldVariable"]
167			);
168
169			if ($itemValue) {
170			$fieldItemIdList[] = (int) $itemValue['item_id'];
171			}
172			}
173
174			return array_unique($fieldItemIdList);
175			}
176
177			function findResults(array $formValues, EntityManagerInterface $em, ExerciseFocusedPlugin $plugin)
178			{
179			$cId = api_get_course_int_id();
180
181			$qb = $em->createQueryBuilder();
182			$qb
183			->select('te AS exe, q.title, te.startDate , u.firstname, u.lastname, u.username')
184			->from(TrackEExercises::class, 'te')
185			->innerJoin(CQuiz::class, 'q', Join::WITH, 'te.exeExoId = q.iid')
186			->innerJoin(User::class, 'u', Join::WITH, 'te.exeUserId = u.id');
187
188			$params = [];
189
190			if ($cId) {
191			$qb->andWhere($qb->expr()->eq('te.cId', ':cId'));
192
193			$params['cId'] = $cId;
194			}
195
196			$sessionItemIdList = getSessionIdFromFormValues(
197			$formValues,
198			$plugin->getSessionFieldList()
199			);
200
201			if ($sessionItemIdList) {
			0 ignored issues – show Bug Best Practice introduced 2023-10-18 16:23 UTC by Report Bug Copy Issue Report The expression `$sessionItemIdList` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `! empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
202			$qb->andWhere($qb->expr()->in('te.sessionId', ':sessionItemIdList'));
203
204			$params['sessionItemIdList'] = $sessionItemIdList;
205			}
206
207			if (!empty($formValues['username'])) {
208			$qb->andWhere($qb->expr()->eq('u.username', ':username'));
209
210			$params['username'] = $formValues['username'];
211			}
212
213			if (!empty($formValues['firstname'])) {
214			$qb->andWhere($qb->expr()->eq('u.firstname', ':firstname'));
215
216			$params['firstname'] = $formValues['firstname'];
217			}
218
219			if (!empty($formValues['lastname'])) {
220			$qb->andWhere($qb->expr()->eq('u.lastname', ':lastname'));
221
222			$params['lastname'] = $formValues['lastname'];
223			}
224
225			if (!empty($formValues['start_date'])) {
226			$qb->andWhere(
227			$qb->expr()->andX(
228			$qb->expr()->gte('te.startDate', ':start_date'),
229			$qb->expr()->lte('te.exeDate', ':end_date')
230			)
231			);
232
233			$params['start_date'] = api_get_utc_datetime($formValues['start_date'].' 00:00:00', false, true);
234			$params['end_date'] = api_get_utc_datetime($formValues['start_date'].' 23:59:59', false, true);
235			}
236
237			if (empty($params)) {
238			return [];
239			}
240
241			if ($cId && !empty($formValues['id'])) {
242			$qb->andWhere($qb->expr()->eq('q.iid', ':q_id'));
243
244			$params['q_id'] = $formValues['id'];
245			}
246
247			$qb->setParameters($params);
248
249			$query = $qb->getQuery();
250
251			return $query->getResult();
252			}
253
254			function getSnapshotListForLevel(int $level, TrackEExercises $trackExe): string
255			{
256			$monitoringPluginIsEnabled = ExerciseMonitoringPlugin::create()->isEnabled(true);
257
258			if (!$monitoringPluginIsEnabled) {
259			return '';
260			}
261
262			$user = api_get_user_entity($trackExe->getExeUserId());
263			$monitoringLogRepository = Database::getManager()->getRepository(MonitoringLog::class);
264
265			$monitoringLogsByQuestion = $monitoringLogRepository->findByLevelAndExe($level, $trackExe);
266			$snapshotList = [];
267
268			/** @var MonitoringLog $logByQuestion */
269			foreach ($monitoringLogsByQuestion as $logByQuestion) {
270			$snapshotUrl = ExerciseMonitoringPlugin::generateSnapshotUrl(
271			$user->getId(),
272			$logByQuestion->getImageFilename()
273			);
274			$snapshotList[] = api_get_local_time($logByQuestion->getCreatedAt()).' '.$snapshotUrl;
275			}
276
277			return implode(PHP_EOL, $snapshotList);
278			}
279

chamilo / chamilo-lms

Pull Request — 1.11.x (#4900)

findResults() C

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like