PermissionController::index() - Code Metrics - Inspection of "Internal: Add permission management and role assig..." - chamilo/chamilo-lms - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#5651)

by Yannick

created 2024-07-10 11:51 UTC

PermissionController::index() B

↳ Parent: PermissionController

Complexity

Conditions	11
Paths	10

Size

Total Lines	59
Code Lines	39

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	11
eloc	39
c	1
b	0
f	0
nc	10
nop	4
dl	0
loc	59
rs	7.3166

How to fix Long Method Complexity

<?php

declare(strict_types=1);

/* For licensing terms, see /license.txt */

namespace Chamilo\CoreBundle\Controller;

use Chamilo\CoreBundle\Entity\PermissionRelRole;
use Chamilo\CoreBundle\Form\PermissionType;
use Chamilo\CoreBundle\Repository\PermissionRelRoleRepository;
use Chamilo\CoreBundle\Repository\PermissionRepository;
use Doctrine\ORM\EntityManagerInterface;
use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\Routing\Annotation\Route;
use Symfony\Component\Security\Http\Attribute\IsGranted;

/**
 * The Permission controller manages the /permissions page to control what roles has what permission
 */
class PermissionController extends AbstractController
{

    #[IsGranted('ROLE_ADMIN')]
    #[Route('/permissions/test', name: 'permissions_test')]
    public function testPermissions(): Response
    {
        // Test roles and permission slug
        $roles = ['ROLE_STUDENT', 'ROLE_TEACHER'];
        $permissionSlug = 'analytics:view';

        // Call the api_get_permission function and log the result
        $hasPermission = api_get_permission($permissionSlug, $roles);
        error_log('Permission check for ' . $permissionSlug . ' with roles ' . implode(', ', $roles) . ': ' . ($hasPermission ? 'true' : 'false'));

        // Return a simple response for testing purposes
        return new Response('<html><body>Permission check result: ' . ($hasPermission ? 'true' : 'false') . '</body></html>');
    }

    #[IsGranted('ROLE_ADMIN')]
    #[Route('/permissions', name: 'permissions')]
    public function index(
        PermissionRepository $permissionRepo,
        PermissionRelRoleRepository $permissionRelRoleRepo,
        Request $request,
        EntityManagerInterface $em
    ): Response {
        $permissions = $permissionRepo->findAll();
        $roles = ['ROLE_INVITEE', 'ROLE_STUDENT', 'ROLE_TEACHER', 'ROLE_ADMIN', 'ROLE_SUPER_ADMIN', 'ROLE_GLOBAL_ADMIN', 'ROLE_RRHH', 'ROLE_QUESTION_MANAGER', 'ROLE_SESSION_MANAGER', 'ROLE_STUDENT_BOSS'];

        if ($request->isMethod('POST')) {
            $data = $request->request->all('permissions');
            foreach ($permissions as $permission) {
                foreach ($roles as $role) {
                    $checkboxValue = isset($data[$permission->getSlug()][$role]);
                    error_log('Processing role: ' . $role . ' with value: ' . ($checkboxValue ? 'true' : 'false'));
                    $permRelRole = $permissionRelRoleRepo->findOneBy(['permission' => $permission, 'roleCode' => $role]);

                    if ($checkboxValue) {
                        if (!$permRelRole) {
                            $permRelRole = new PermissionRelRole();
                            $permRelRole->setPermission($permission);
                            $permRelRole->setRoleCode($role);
                        }
                        $permRelRole->setChangeable(true);
                        $permRelRole->setUpdatedAt(new \DateTime());
                        $em->persist($permRelRole);
                        error_log('Persisting PermissionRelRole for permission: ' . $permission->getSlug() . ' and role: ' . $role);
                    } else {
                        if ($permRelRole) {
                            $em->remove($permRelRole);
                            error_log('Removing PermissionRelRole for permission: ' . $permission->getSlug() . ' and role: ' . $role);
                        }
                    }
                }
            }
            $em->flush();
            error_log('Flush complete');

            return $this->redirectToRoute('permissions');
        }

        $forms = [];
        foreach ($permissions as $permission) {
            $defaultData = [];
            foreach ($roles as $role) {
                $permRelRole = $permissionRelRoleRepo->findOneBy(['permission' => $permission, 'roleCode' => $role]);
                $defaultData[$role] = $permRelRole ? $permRelRole->isChangeable() : false;
            }

            $form = $this->createForm(PermissionType::class, $defaultData, ['roles' => $roles]);
            $forms[$permission->getSlug()] = $form->createView();
        }

        return $this->render('@ChamiloCore/Permission/index.html.twig', [
            'permissions' => $permissions,
            'forms' => $forms,
            'roles' => $roles
        ]);
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			/* For licensing terms, see /license.txt */
6
7			namespace Chamilo\CoreBundle\Controller;
8
9			use Chamilo\CoreBundle\Entity\PermissionRelRole;
10			use Chamilo\CoreBundle\Form\PermissionType;
11			use Chamilo\CoreBundle\Repository\PermissionRelRoleRepository;
12			use Chamilo\CoreBundle\Repository\PermissionRepository;
13			use Doctrine\ORM\EntityManagerInterface;
14			use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
15			use Symfony\Component\HttpFoundation\Request;
16			use Symfony\Component\HttpFoundation\Response;
17			use Symfony\Component\Routing\Annotation\Route;
18			use Symfony\Component\Security\Http\Attribute\IsGranted;
19
20			/**
21			* The Permission controller manages the /permissions page to control what roles has what permission
22			*/
23			class PermissionController extends AbstractController
24			{
25
26			#[IsGranted('ROLE_ADMIN')]
27			#[Route('/permissions/test', name: 'permissions_test')]
28			public function testPermissions(): Response
29			{
30			// Test roles and permission slug
31			$roles = ['ROLE_STUDENT', 'ROLE_TEACHER'];
32			$permissionSlug = 'analytics:view';
33
34			// Call the api_get_permission function and log the result
35			$hasPermission = api_get_permission($permissionSlug, $roles);
36			error_log('Permission check for ' . $permissionSlug . ' with roles ' . implode(', ', $roles) . ': ' . ($hasPermission ? 'true' : 'false'));
37
38			// Return a simple response for testing purposes
39			return new Response('<html><body>Permission check result: ' . ($hasPermission ? 'true' : 'false') . '</body></html>');
40			}
41
42			#[IsGranted('ROLE_ADMIN')]
43			#[Route('/permissions', name: 'permissions')]
44			public function index(
45			PermissionRepository $permissionRepo,
46			PermissionRelRoleRepository $permissionRelRoleRepo,
47			Request $request,
48			EntityManagerInterface $em
49			): Response {
50			$permissions = $permissionRepo->findAll();
51			$roles = ['ROLE_INVITEE', 'ROLE_STUDENT', 'ROLE_TEACHER', 'ROLE_ADMIN', 'ROLE_SUPER_ADMIN', 'ROLE_GLOBAL_ADMIN', 'ROLE_RRHH', 'ROLE_QUESTION_MANAGER', 'ROLE_SESSION_MANAGER', 'ROLE_STUDENT_BOSS'];
52
53			if ($request->isMethod('POST')) {
54			$data = $request->request->all('permissions');
55			foreach ($permissions as $permission) {
56			foreach ($roles as $role) {
57			$checkboxValue = isset($data[$permission->getSlug()][$role]);
58			error_log('Processing role: ' . $role . ' with value: ' . ($checkboxValue ? 'true' : 'false'));
59			$permRelRole = $permissionRelRoleRepo->findOneBy(['permission' => $permission, 'roleCode' => $role]);
60
61			if ($checkboxValue) {
62			if (!$permRelRole) {
63			$permRelRole = new PermissionRelRole();
64			$permRelRole->setPermission($permission);
65			$permRelRole->setRoleCode($role);
66			}
67			$permRelRole->setChangeable(true);
68			$permRelRole->setUpdatedAt(new \DateTime());
69			$em->persist($permRelRole);
70			error_log('Persisting PermissionRelRole for permission: ' . $permission->getSlug() . ' and role: ' . $role);
71			} else {
72			if ($permRelRole) {
73			$em->remove($permRelRole);
74			error_log('Removing PermissionRelRole for permission: ' . $permission->getSlug() . ' and role: ' . $role);
75			}
76			}
77			}
78			}
79			$em->flush();
80			error_log('Flush complete');
81
82			return $this->redirectToRoute('permissions');
83			}
84
85			$forms = [];
86			foreach ($permissions as $permission) {
87			$defaultData = [];
88			foreach ($roles as $role) {
89			$permRelRole = $permissionRelRoleRepo->findOneBy(['permission' => $permission, 'roleCode' => $role]);
90			$defaultData[$role] = $permRelRole ? $permRelRole->isChangeable() : false;
91			}
92
93			$form = $this->createForm(PermissionType::class, $defaultData, ['roles' => $roles]);
94			$forms[$permission->getSlug()] = $form->createView();
95			}
96
97			return $this->render('@ChamiloCore/Permission/index.html.twig', [
98			'permissions' => $permissions,
99			'forms' => $forms,
100			'roles' => $roles
101			]);
102			}
103			}
104

chamilo / chamilo-lms

Pull Request — master (#5651)

PermissionController::index() B

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like