Completed
Pull Request — 1.11.x (#1237)
by José
45:45
created
main/exercise/exercise.class.php 1 patch
Doc Comments   +8 added lines, -5 removed lines patch added patch discarded remove patch
@@ -353,7 +353,7 @@  discard block
 block discarded – undo
353 353
     }
354 354
 
355 355
     /**
356
-     * @return int
356
+     * @return string
357 357
      */
358 358
     public function selectPassPercentage()
359 359
     {
@@ -462,7 +462,7 @@  discard block
 block discarded – undo
462 462
      * tells if questions are selected randomly, and if so returns the draws
463 463
      *
464 464
      * @author Olivier Brouckaert
465
-     * @return integer - 0 if not random, otherwise the draws
465
+     * @return boolean - 0 if not random, otherwise the draws
466 466
      */
467 467
     public function isRandom()
468 468
     {
@@ -2830,7 +2830,7 @@  discard block
 block discarded – undo
2830 2830
      * @param int  int lp id
2831 2831
      * @param int  int lp item id
2832 2832
      * @param int  int lp item_view id
2833
-     * @param float $weight
2833
+     * @param integer $weight
2834 2834
      * @param array question list
2835 2835
      */
2836 2836
     public function save_stat_track_exercise_info(
@@ -5327,6 +5327,9 @@  discard block
 block discarded – undo
5327 5327
         }
5328 5328
     }
5329 5329
 
5330
+    /**
5331
+     * @param integer $exe_id
5332
+     */
5330 5333
     function send_notification_for_oral_questions($question_list_answers, $origin, $exe_id)
5331 5334
     {
5332 5335
         if (api_get_course_setting('email_alert_manager_on_new_quiz') != 1 ) {
@@ -5478,7 +5481,7 @@  discard block
 block discarded – undo
5478 5481
      * @param int     Maximum number of attempts (0 if no limit)
5479 5482
      * @param int     Feedback type
5480 5483
      * @todo this was function was added due the import exercise via CSV
5481
-     * @return    int New exercise ID
5484
+     * @return    string New exercise ID
5482 5485
      */
5483 5486
     public function createExercise(
5484 5487
         $title,
@@ -6813,7 +6816,7 @@  discard block
 block discarded – undo
6813 6816
      * @param bool $show_comment
6814 6817
      * @param null $exercise_feedback
6815 6818
      * @param bool $show_answers
6816
-     * @param null $modelType
6819
+     * @param integer $modelType
6817 6820
      * @param bool $categoryMinusOne
6818 6821
      * @return bool|null|string
6819 6822
      */
Please login to merge, or discard this patch.
main/exercise/export/qti2/qti2_classes.php 1 patch
Doc Comments   +5 added lines patch added patch discarded remove patch
@@ -72,6 +72,7 @@  discard block
 block discarded – undo
72 72
     /**
73 73
      * Return the XML flow for the possible answers.
74 74
      *
75
+     * @param string $questionStatment
75 76
      */
76 77
     public function imsExportResponses($questionIdent, $questionStatment)
77 78
     {
@@ -147,6 +148,7 @@  discard block
 block discarded – undo
147 148
      * Export the text with missing words.
148 149
      *
149 150
      *
151
+     * @param string $questionStatment
150 152
      */
151 153
     public function imsExportResponses($questionIdent, $questionStatment)
152 154
     {
@@ -204,6 +206,7 @@  discard block
 block discarded – undo
204 206
 {
205 207
     /**
206 208
      * Export the question part as a matrix-choice, with only one possible answer per line.
209
+     * @param string $questionStatment
207 210
      */
208 211
     public function imsExportResponses($questionIdent, $questionStatment)
209 212
     {
@@ -295,6 +298,7 @@  discard block
 block discarded – undo
295 298
     /**
296 299
      * TODO update this to match hot spots instead of copying matching
297 300
      * Export the question part as a matrix-choice, with only one possible answer per line.
301
+     * @param string $questionStatment
298 302
      */
299 303
     public function imsExportResponses($questionIdent, $questionStatment, $questionDesc='', $questionMedia='')
300 304
     {
@@ -382,6 +386,7 @@  discard block
 block discarded – undo
382 386
     /**
383 387
      * TODO implement
384 388
      * Export the question part as a matrix-choice, with only one possible answer per line.
389
+     * @param string $questionStatment
385 390
      */
386 391
     public function imsExportResponses($questionIdent, $questionStatment, $questionDesc='', $questionMedia='')
387 392
 	{
Please login to merge, or discard this patch.
main/exercise/hotpotatoes.lib.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -259,7 +259,7 @@  discard block
 block discarded – undo
259 259
  * @param    reference    Reference to the array to search
260 260
  * @param    string       Node we are looking for in the array
261 261
  * @param string $node
262
- * @return   mixed        Node name or false if not found
262
+ * @return   false|string        Node name or false if not found
263 263
  */
264 264
 function myarraysearch(&$array, $node)
265 265
 {
@@ -280,7 +280,7 @@  discard block
 block discarded – undo
280 280
  * Searches an image name into an array.
281 281
  * @param    reference        Reference to an array to search
282 282
  * @param    string           String to look for
283
- * @return   mixed            String given if found, false otherwise
283
+ * @return   false|string            String given if found, false otherwise
284 284
  * @uses     myarraysearch    This function is just an additional layer on the myarraysearch() function
285 285
  */
286 286
 function CheckImageName(&$imgparams, $string)
Please login to merge, or discard this patch.
main/exercise/multiple_answer_true_false.class.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -58,7 +58,7 @@
 block discarded – undo
58 58
      * @param null $feedback_type
59 59
      * @param null $counter
60 60
      * @param null $score
61
-     * @return null|string
61
+     * @return string
62 62
      */
63 63
     function return_header($feedback_type = null, $counter = null, $score = null)
64 64
     {
Please login to merge, or discard this patch.
main/exercise/oral_expression.class.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -58,7 +58,7 @@
 block discarded – undo
58 58
      * @param null $feedback_type
59 59
      * @param null $counter
60 60
      * @param null $score
61
-     * @return null|string
61
+     * @return string
62 62
      */
63 63
     function return_header($feedback_type = null, $counter = null, $score = null)
64 64
     {
Please login to merge, or discard this patch.
main/exercise/question.class.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -264,7 +264,7 @@
 block discarded – undo
264 264
     }
265 265
 
266 266
     /**
267
-     * @return string|false
267
+     * @return string
268 268
      */
269 269
     public function selectPicturePath()
270 270
     {
Please login to merge, or discard this patch.
main/lp/aicc.class.php 1 patch
Doc Comments   +5 added lines, -3 removed lines patch added patch discarded remove patch
@@ -216,7 +216,7 @@  discard block
 block discarded – undo
216 216
     /**
217 217
      * Import the aicc object (as a result from the parse_config_files function) into the database structure
218 218
      * @param	string	$course_code
219
-     * @return	bool	Returns -1 on error
219
+     * @return	false|null	Returns -1 on error
220 220
      */
221 221
     public function import_aicc($course_code)
222 222
     {
@@ -780,7 +780,8 @@  discard block
 block discarded – undo
780 780
      * Static function to parse AICC ini files.
781 781
      * Based on work by sinedeo at gmail dot com published on php.net (parse_ini_file()).
782 782
      * @param	string	File path
783
-     * @return	array	Structured array
783
+     * @param string $f
784
+     * @return	string	Structured array
784 785
      */
785 786
     function parse_ini_file_quotes_safe($f) {
786 787
         $null = '';
@@ -831,7 +832,7 @@  discard block
 block discarded – undo
831 832
      * Based on work by sinedeo at gmail dot com published on php.net (parse_ini_file()).
832 833
      * @param		string	INI File string
833 834
      * @param		array	List of names of sections that should be considered as containing only hard string data (no variables), provided in lower case
834
-     * @return	array	Structured array
835
+     * @return	string	Structured array
835 836
      */
836 837
     function parse_ini_string_quotes_safe($s, $pure_strings = array()) {
837 838
         $null = '';
@@ -894,6 +895,7 @@  discard block
 block discarded – undo
894 895
      * @param	string	CSV delimiter
895 896
      * @param	string	CSV enclosure
896 897
      * @param	boolean	Might one field name happen more than once on the same line? (then split by comma in the values)
898
+     * @param string $f
897 899
      * @return array	Simple structured array
898 900
      */
899 901
     function parse_csv_file($f, $delim = ',', $enclosure = '"', $multiples = false) {
Please login to merge, or discard this patch.
main/lp/learnpath_functions.inc.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -60,6 +60,7 @@
 block discarded – undo
60 60
 /**
61 61
  * This function deletes an entire directory
62 62
  * @param	string	The directory path
63
+ * @param string $dir
63 64
  * @return boolean	True on success, false on failure
64 65
  */
65 66
 function deldir($dir) {
Please login to merge, or discard this patch.
main/lp/learnpathItem.class.php 1 patch
Doc Comments   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -1869,7 +1869,7 @@  discard block
 block discarded – undo
1869 1869
 
1870 1870
     /**
1871 1871
      * Get the extra terms (tags) that identify this item
1872
-     * @return mixed
1872
+     * @return string
1873 1873
      */
1874 1874
     public function get_terms()
1875 1875
     {
@@ -2069,7 +2069,7 @@  discard block
 block discarded – undo
2069 2069
 
2070 2070
     /**
2071 2071
      * Opens/launches the item. Initialises runtime values.
2072
-     * @return    boolean    True on success, false on failure.
2072
+     * @return    boolean|null    True on success, false on failure.
2073 2073
      */
2074 2074
     public function open($allow_new_attempt = false)
2075 2075
     {
@@ -3494,7 +3494,7 @@  discard block
 block discarded – undo
3494 3494
 
3495 3495
     /**
3496 3496
      * Checks if the current status is part of the list of status given
3497
-     * @param  array  $list  An array of status to check for.
3497
+     * @param  string[]  $list  An array of status to check for.
3498 3498
      * If the current status is one of the strings, return true
3499 3499
      *
3500 3500
      * @return boolean True if the status was one of the given strings,
@@ -3671,7 +3671,7 @@  discard block
 block discarded – undo
3671 3671
     /**
3672 3672
      * Write objectives to DB. This method is separate from write_to_db() because otherwise
3673 3673
      * objectives are lost as a side effect to AJAX and session concurrent access
3674
-     * @return    boolean        True or false on error
3674
+     * @return    boolean|null        True or false on error
3675 3675
      */
3676 3676
     public function write_objectives_to_db()
3677 3677
     {
@@ -4312,7 +4312,7 @@  discard block
 block discarded – undo
4312 4312
      * Removes the relation between the current item and an audio file. The file
4313 4313
      * is only removed from the lp_item table, but remains in the document table
4314 4314
      * and directory
4315
-     * @return bool
4315
+     * @return false|null
4316 4316
      */
4317 4317
     public function remove_audio()
4318 4318
     {
@@ -4333,7 +4333,7 @@  discard block
 block discarded – undo
4333 4333
      * @param $status
4334 4334
      * @param bool $decorate
4335 4335
      * @param string $type classic|simple
4336
-     * @return array|string
4336
+     * @return string
4337 4337
      */
4338 4338
     static function humanize_status($status, $decorate = true, $type = 'classic')
4339 4339
     {
Please login to merge, or discard this patch.