Test Setup Failed
Pull Request — 1.11.x (#1541)
by José
33:51 queued 05:26
created
main/inc/lib/extra_field_value.lib.php 1 patch
Doc Comments   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -75,7 +75,7 @@  discard block
 block discarded – undo
75 75
      * This function is used with $extraField->addElements()
76 76
      * @param array $params array for the insertion into the *_field_values table
77 77
      * @param bool $showQuery
78
-     * @return mixed false on empty params, void otherwise
78
+     * @return false|null false on empty params, void otherwise
79 79
      * @assert (array()) === false
80 80
      */
81 81
     public function saveFieldValues($params, $showQuery = false)
@@ -531,7 +531,7 @@  discard block
 block discarded – undo
531 531
      * @param int $item_id Item ID (It could be a session_id, course_id or user_id)
532 532
      * @param int $field_id Field ID (the ID from the *_field table)
533 533
      * @param bool $transform Whether to transform the result to a human readable strings
534
-     * @return mixed A structured array with the field_id and field_value, or false on error
534
+     * @return string A structured array with the field_id and field_value, or false on error
535 535
      * @assert (-1,-1) === false
536 536
      */
537 537
     public function get_values_by_handler_and_field_id($item_id, $field_id, $transform = false)
@@ -624,7 +624,7 @@  discard block
 block discarded – undo
624 624
      * @param int $item_id Item ID from the original table
625 625
      * @param string $field_variable The name of the field we are looking for
626 626
      * @param bool $transform
627
-     * @param bool $allVisibility
627
+     * @param bool $visibility
628 628
      *
629 629
      * @return mixed Array of results, or false on error or not found
630 630
      * @assert (-1,'') === false
@@ -686,7 +686,7 @@  discard block
 block discarded – undo
686 686
      * @param string $field_value Data we are looking for in the given field
687 687
      * @param bool $transform Whether to transform the result to a human readable strings
688 688
      * @param bool $last Whether to return the last element or simply the first one we get
689
-     * @return mixed Give the ID if found, or false on failure or not found
689
+     * @return string|null Give the ID if found, or false on failure or not found
690 690
      * @assert (-1,-1) === false
691 691
      */
692 692
     public function get_item_id_from_field_variable_and_field_value(
Please login to merge, or discard this patch.
main/inc/lib/MoodleImport.php 1 patch
Doc Comments   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -403,7 +403,7 @@  discard block
 block discarded – undo
403 403
      * Read and validate the quiz module XML
404 404
      *
405 405
      * @param resource $moduleXml XML file
406
-     * @return mixed | array if is a valid xml file, false otherwise
406
+     * @return string | array if is a valid xml file, false otherwise
407 407
      */
408 408
     public function readQuizModule($moduleXml)
409 409
     {
@@ -621,7 +621,7 @@  discard block
 block discarded – undo
621 621
      * Fix moodle files that contains spaces
622 622
      * @param array $importedFiles
623 623
      * @param string $text
624
-     * @return mixed
624
+     * @return string
625 625
      */
626 626
     public function fixPathInText($importedFiles, &$text)
627 627
     {
@@ -642,10 +642,10 @@  discard block
 block discarded – undo
642 642
      *
643 643
      * @param array $questionList
644 644
      * @param string $questionType
645
-     * @param object $questionInstance Question/Answer instance
645
+     * @param Question $questionInstance Question/Answer instance
646 646
      * @param array $currentQuestion
647 647
      * @param array $importedFiles
648
-     * @return integer db response
648
+     * @return boolean|null db response
649 649
      */
650 650
     public function processAnswers($questionList, $questionType, $questionInstance, $currentQuestion, $importedFiles)
651 651
     {
@@ -800,7 +800,7 @@  discard block
 block discarded – undo
800 800
     /**
801 801
      * Process Chamilo Unique Answer
802 802
      *
803
-     * @param object $objAnswer
803
+     * @param Answer $objAnswer
804 804
      * @param array $answerValues
805 805
      * @param integer $position
806 806
      * @param integer $questionWeighting
@@ -836,7 +836,7 @@  discard block
 block discarded – undo
836 836
     /**
837 837
      * Process Chamilo True False
838 838
      *
839
-     * @param object $objAnswer
839
+     * @param Answer $objAnswer
840 840
      * @param array $answerValues
841 841
      * @param integer $position
842 842
      * @param integer $questionWeighting
@@ -873,7 +873,7 @@  discard block
 block discarded – undo
873 873
     /**
874 874
      * Process Chamilo FillBlanks
875 875
      *
876
-     * @param object $objAnswer
876
+     * @param Answer $objAnswer
877 877
      * @param array $questionType
878 878
      * @param array $answerValues
879 879
      * @param string $placeholder
@@ -1026,7 +1026,7 @@  discard block
 block discarded – undo
1026 1026
      * Litle utility to delete the unuseful tags
1027 1027
      *
1028 1028
      * @param $array
1029
-     * @param $keys
1029
+     * @param string[] $keys
1030 1030
      */
1031 1031
     public function traverseArray(&$array, $keys)
1032 1032
     {
Please login to merge, or discard this patch.
main/inc/lib/usermanager.lib.php 1 patch
Doc Comments   +22 added lines, -16 removed lines patch added patch discarded remove patch
@@ -130,9 +130,9 @@  discard block
 block discarded – undo
130 130
     /**
131 131
      * Validates the password
132 132
      *
133
-     * @param $encoded
134
-     * @param $raw
135
-     * @param $salt
133
+     * @param string $encoded
134
+     * @param string $raw
135
+     * @param string $salt
136 136
      * @return bool
137 137
      */
138 138
     public static function isPasswordValid($encoded, $raw, $salt)
@@ -147,7 +147,7 @@  discard block
 block discarded – undo
147 147
      * @param string $raw
148 148
      * @param User   $user
149 149
      *
150
-     * @return bool
150
+     * @return string
151 151
      */
152 152
     public static function encryptPassword($raw, User $user)
153 153
     {
@@ -1094,6 +1094,7 @@  discard block
 block discarded – undo
1094 1094
     /**
1095 1095
      * Disables a user
1096 1096
      * @param int User id
1097
+     * @param integer $user_id
1097 1098
      * @return bool
1098 1099
      * @uses UserManager::change_active_state() to actually disable the user
1099 1100
      * @assert (0) === false
@@ -1110,6 +1111,7 @@  discard block
 block discarded – undo
1110 1111
     /**
1111 1112
      * Enable a user
1112 1113
      * @param int User id
1114
+     * @param integer $user_id
1113 1115
      * @return bool
1114 1116
      * @uses UserManager::change_active_state() to actually disable the user
1115 1117
      * @assert (0) === false
@@ -1276,6 +1278,7 @@  discard block
 block discarded – undo
1276 1278
      * Checks whether the user id exists in the database
1277 1279
      *
1278 1280
      * @param int User id
1281
+     * @param integer $userId
1279 1282
      * @return bool True if user id was found, false otherwise
1280 1283
      */
1281 1284
     public static function is_user_id_valid($userId)
@@ -1417,7 +1420,7 @@  discard block
 block discarded – undo
1417 1420
     /**
1418 1421
      * Get a list of users of which the given conditions match with a LIKE '%cond%'
1419 1422
      * @param array $conditions a list of condition (exemple : status=>STUDENT)
1420
-     * @param array $order_by a list of fields on which sort
1423
+     * @param string[] $order_by a list of fields on which sort
1421 1424
      * @return array An array with all users of the platform.
1422 1425
      * @todo optional course code parameter, optional sorting parameters...
1423 1426
      * @todo security filter order_by
@@ -1488,7 +1491,7 @@  discard block
 block discarded – undo
1488 1491
      * @param   array $userInfo user information to avoid query the DB
1489 1492
      * returns the /main/img/unknown.jpg image set it at true
1490 1493
      *
1491
-     * @return    array     Array of 2 elements: 'dir' and 'file' which contain
1494
+     * @return    integer     Array of 2 elements: 'dir' and 'file' which contain
1492 1495
      * the dir and file as the name implies if image does not exist it will
1493 1496
      * return the unknow image if anonymous parameter is true if not it returns an empty array
1494 1497
      */
@@ -1980,7 +1983,7 @@  discard block
 block discarded – undo
1980 1983
     /**
1981 1984
      * Returns an array with the user's productions.
1982 1985
      *
1983
-     * @param    $user_id    User id
1986
+     * @param    integer $user_id    User id
1984 1987
      * @return   array  An array containing the user's productions
1985 1988
      */
1986 1989
     public static function get_user_productions($user_id)
@@ -2135,7 +2138,7 @@  discard block
 block discarded – undo
2135 2138
 
2136 2139
     /**
2137 2140
      * Build a list of extra file already uploaded in $user_folder/{$extra_field}/
2138
-     * @param $user_id
2141
+     * @param integer $user_id
2139 2142
      * @param $extra_field
2140 2143
      * @param bool $force
2141 2144
      * @param bool $showDelete
@@ -2240,7 +2243,7 @@  discard block
 block discarded – undo
2240 2243
      * @param    int       $fieldType  Field's type
2241 2244
      * @param    string    $displayText Field's language var name
2242 2245
      * @param    string    $default Field's default value
2243
-     * @return int
2246
+     * @return boolean
2244 2247
      */
2245 2248
     public static function create_extra_field($variable, $fieldType, $displayText, $default)
2246 2249
     {
@@ -2274,6 +2277,7 @@  discard block
 block discarded – undo
2274 2277
      * @param    boolean    Whether to prefix the fields indexes with "extra_" (might be used by formvalidator)
2275 2278
      * @param    boolean    Whether to return invisible fields as well
2276 2279
      * @param    boolean    Whether to split multiple-selection fields or not
2280
+     * @param boolean $field_filter
2277 2281
      * @return    array    Array of fields => value for the given user
2278 2282
      */
2279 2283
     public static function get_extra_user_data(
@@ -3121,7 +3125,7 @@  discard block
 block discarded – undo
3121 3125
      * @param    string  $user_id   User ID
3122 3126
      * @param   string  $course course directory
3123 3127
      * @param   string  $resourcetype resourcetype: images, all
3124
-     * @return    int        User ID (or false if not found)
3128
+     * @return    string        User ID (or false if not found)
3125 3129
      */
3126 3130
     public static function get_user_upload_files_by_course($user_id, $course, $resourcetype = 'all')
3127 3131
     {
@@ -3205,7 +3209,7 @@  discard block
 block discarded – undo
3205 3209
     /**
3206 3210
      * Adds a new API key to the users' account
3207 3211
      * @param   int     Optional user ID (defaults to the results of api_get_user_id())
3208
-     * @return  boolean True on success, false on failure
3212
+     * @return  false|string True on success, false on failure
3209 3213
      */
3210 3214
     public static function add_api_key($user_id = null, $api_service = 'dokeos')
3211 3215
     {
@@ -3260,6 +3264,7 @@  discard block
 block discarded – undo
3260 3264
      * Regenerate an API key from the user's account
3261 3265
      * @param   int     user ID (defaults to the results of api_get_user_id())
3262 3266
      * @param   string  API key's internal ID
3267
+     * @param string $api_service
3263 3268
      * @return  int        num
3264 3269
      */
3265 3270
     public static function update_api_key($user_id, $api_service)
@@ -3289,6 +3294,7 @@  discard block
 block discarded – undo
3289 3294
     /**
3290 3295
      * @param   int     user ID (defaults to the results of api_get_user_id())
3291 3296
      * @param   string    API key's internal ID
3297
+     * @param string $api_service
3292 3298
      * @return  int    row ID, or return false if not found
3293 3299
      */
3294 3300
     public static function get_api_key_id($user_id, $api_service)
@@ -3504,7 +3510,7 @@  discard block
 block discarded – undo
3504 3510
      * @param int $field_id
3505 3511
      * @param bool $show_links show links or not
3506 3512
      *
3507
-     * @return array
3513
+     * @return string
3508 3514
      */
3509 3515
     public static function get_user_tags_to_string($user_id, $field_id, $show_links = true)
3510 3516
     {
@@ -3601,7 +3607,7 @@  discard block
 block discarded – undo
3601 3607
      * @param mixed $tag
3602 3608
      * @param int $user_id
3603 3609
      * @param int $field_id field id of the tag
3604
-     * @return bool
3610
+     * @return boolean|null
3605 3611
      */
3606 3612
     public static function add_tag($tag, $user_id, $field_id)
3607 3613
     {
@@ -5047,7 +5053,7 @@  discard block
 block discarded – undo
5047 5053
     }
5048 5054
 
5049 5055
     /**
5050
-     * @return array
5056
+     * @return string[]
5051 5057
      */
5052 5058
     public static function get_user_field_types()
5053 5059
     {
@@ -5339,7 +5345,7 @@  discard block
 block discarded – undo
5339 5345
 
5340 5346
     /**
5341 5347
      * Get the boss user ID from a followed user id
5342
-     * @param $userId
5348
+     * @param integer $userId
5343 5349
      * @return bool
5344 5350
      */
5345 5351
     public static function getStudentBossList($userId)
@@ -5391,7 +5397,7 @@  discard block
 block discarded – undo
5391 5397
      * Get either a Gravatar URL or complete image tag for a specified email address.
5392 5398
      *
5393 5399
      * @param string $email The email address
5394
-     * @param string $s Size in pixels, defaults to 80px [ 1 - 2048 ]
5400
+     * @param integer $s Size in pixels, defaults to 80px [ 1 - 2048 ]
5395 5401
      * @param string $d Default imageset to use [ 404 | mm | identicon | monsterid | wavatar ]
5396 5402
      * @param string $r Maximum rating (inclusive) [ g | pg | r | x ]
5397 5403
      * @param boole $img True to return a complete IMG tag False for just the URL
Please login to merge, or discard this patch.
plugin/google_maps/src/GoogleMapsPluginPlugin.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -43,7 +43,7 @@  discard block
 block discarded – undo
43 43
 
44 44
     /**
45 45
      * Install the plugin
46
-     * @return void
46
+     * @return boolean
47 47
      */
48 48
     public function install()
49 49
     {
@@ -52,7 +52,7 @@  discard block
 block discarded – undo
52 52
 
53 53
     /**
54 54
      * Uninstall the plugin
55
-     * @return void
55
+     * @return boolean
56 56
      */
57 57
     public function uninstall()
58 58
     {
Please login to merge, or discard this patch.