PlatformSettingsSchema::buildForm() - Code Metrics - Inspection of "Applied fixes from FlintCI" - chamilo/chamilo-lms - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#2349)

by Julito

created 2018-01-22 14:03 UTC

PlatformSettingsSchema::buildForm() B

↳ Parent: PlatformSettingsSchema

Complexity

Conditions	1
Paths	1

Size

Total Lines	79
Code Lines	59

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	59
nc	1
nop	1
dl	0
loc	79
rs	8.8701
c	0
b	0
f	0

How to fix Long Method

<?php
/* For licensing terms, see /license.txt */

namespace Chamilo\CoreBundle\Settings;

use Chamilo\CoreBundle\Form\Type\YesNoType;
use Chamilo\SettingsBundle\Transformer\ArrayToIdentifierTransformer;
use Sylius\Bundle\SettingsBundle\Schema\SchemaInterface;
use Sylius\Bundle\SettingsBundle\Schema\SettingsBuilderInterface;
use Symfony\Component\Form\FormBuilderInterface;

/**
 * Class PlatformSettingsSchema
 * @package Chamilo\CoreBundle\Settings
 */
class PlatformSettingsSchema extends AbstractSettingsSchema
{
    /**
     * {@inheritdoc}
     */
    public function buildSettings(SettingsBuilderInterface $builder)
    {
        $builder
            ->setDefaults(
                [
                    'institution' => 'Chamilo.org',
                    'institution_url' => 'http://www.chamilo.org',
                    'institution_address' => '',
                    'site_name' => 'Chamilo site',
//                    'administrator_email' => '[email protected]',
//                    'administrator_name' => 'Jane',
//                    'administrator_surname' => 'Doe',
//                    'administrator_phone' => '123456',
                    'timezone' => 'Europe/Paris',
                    'theme' => 'chamilo',
                    'gravatar_enabled' => 'false',
                    'gravatar_type' => 'mm',
                    'gamification_mode' => ' ',
                    'order_user_list_by_official_code' => 'false',
                    'cookie_warning' => 'false',
                    'donotlistcampus' => 'false',
                    'catalog_show_courses_sessions' => '0',
                    'course_catalog_hide_private' => 'false',
                    'use_custom_pages' => 'false',
                    'pdf_logo_header' => '',
                    'allow_my_files' => 'true',
                    'chamilo_database_version' => '2.0.0',
                    'registered' => 'false',
                    'load_term_conditions_section' => 'login',
                    'server_type' => 'false',
                    'show_full_skill_name_on_skill_wheel' => 'false',
                    'show_official_code_whoisonline' => 'false',
                    'show_tabs' => []
                    //
//('catalog_show_courses_sessions', '0', 'CatalogueShowOnlyCourses'),
//('catalog_show_courses_sessions', '1', 'CatalogueShowOnlySessions'),
//('catalog_show_courses_sessions', '2', 'CatalogueShowCoursesAndSessions'),
                ]
            )
            ->setTransformer(
                'show_tabs',
                new ArrayToIdentifierTransformer()
            )
        ;
        $allowedTypes = [
            'institution' => ['string'],
            'institution_url' => ['string'],
            'site_name' => ['string'],
//                    'administrator_email' => array('string'),
//                    'administrator_name' => array('string'),
//                    'administrator_surname' => array('string'),
//                    'administrator_phone' => array('string'),
            'timezone' => ['string'],
            'gravatar_enabled' => ['string'],
            'gravatar_type' => ['string'],
            'show_tabs' => ['array']
            //'gamification_mode' => array('string'),
        ];

        $this->setMultipleAllowedTypes($allowedTypes, $builder);
    }

    /**
     * {@inheritdoc}
     */
    public function buildForm(FormBuilderInterface $builder)
    {
        $tabs = [
            'TabsCampusHomepage' => 'campus_homepage',
            'TabsMyCourses' => 'my_courses',
            'TabsReporting' => 'reporting',
            'TabsPlatformAdministration' => 'platform_administration',
            'mypersonalopenarea' => 'my_agenda',
            'TabsMyAgenda' => 'my_profile',
            'TabsMyGradebook' => 'my_gradebook',
            'TabsSocial' => 'social',
            'TabsDashboard' => 'dashboard'
        ];

        $builder
            ->add('institution')
            ->add('institution_url', 'url')
            ->add('institution_address')
            ->add('site_name')
//            ->add('administrator_email', 'email')
//            ->add('administrator_name')
//            ->add('administrator_surname')
//            ->add('administrator_phone')
            ->add('timezone', 'timezone')
            ->add('theme')
            ->add('gravatar_enabled', YesNoType::class)
            ->add(
                'gravatar_type',
                'choice',
                [
                    'choices' => [
                        'mm' => 'mistery-man',
                        'identicon' => 'identicon',
                        'monsterid' => 'monsterid',
                        'wavatar' => 'wavatar',
                    ],
                ]
            )
            ->add('gamification_mode')
            ->add('order_user_list_by_official_code', YesNoType::class)
            ->add('cookie_warning', YesNoType::class)
            ->add('donotlistcampus', YesNoType::class)
            ->add('course_catalog_hide_private', YesNoType::class)
            ->add(
                'catalog_show_courses_sessions',
                'choice',
                ['choices' => [
                    '0' => 'CatalogueShowOnlyCourses',
                    '1' => 'CatalogueShowOnlySessions',
                    '2' => 'CatalogueShowCoursesAndSessions',
                ]]
            )
            ->add('use_custom_pages', YesNoType::class)
            ->add('pdf_logo_header')
            ->add('allow_my_files', YesNoType::class)
            // old settings with no category
            ->add('chamilo_database_version')
            ->add('registered', YesNoType::class)
            ->add(
                'load_term_conditions_section',
                'choice',
                [
                    'choices' => [
                        '0' => 'Login',
                        '1' => 'Course',
                    ],
                ]
            )
            ->add('server_type', YesNoType::class)
            ->add('show_full_skill_name_on_skill_wheel', YesNoType::class)
            ->add('show_official_code_whoisonline', YesNoType::class)
            ->add(
                'show_tabs',
                'choice',
                [
                    'multiple' => true,
                    'choices' => $tabs,
                    'label' => 'ShowTabsTitle',
                    'help_block' => 'ShowTabsComment'
                ]
            )
        ;
    }
}


1			<?php
2			/* For licensing terms, see /license.txt */
3
4			namespace Chamilo\CoreBundle\Settings;
5
6			use Chamilo\CoreBundle\Form\Type\YesNoType;
7			use Chamilo\SettingsBundle\Transformer\ArrayToIdentifierTransformer;
8			use Sylius\Bundle\SettingsBundle\Schema\SchemaInterface;
9			use Sylius\Bundle\SettingsBundle\Schema\SettingsBuilderInterface;
10			use Symfony\Component\Form\FormBuilderInterface;
11
12			/**
13			* Class PlatformSettingsSchema
14			* @package Chamilo\CoreBundle\Settings
15			*/
16			class PlatformSettingsSchema extends AbstractSettingsSchema
17			{
18			/**
19			* {@inheritdoc}
20			*/
21			public function buildSettings(SettingsBuilderInterface $builder)
22			{
23			$builder
24			->setDefaults(
25			[
26			'institution' => 'Chamilo.org',
27			'institution_url' => 'http://www.chamilo.org',
28			'institution_address' => '',
29			'site_name' => 'Chamilo site',
30			// 'administrator_email' => '[email protected]',
31			// 'administrator_name' => 'Jane',
32			// 'administrator_surname' => 'Doe',
33			// 'administrator_phone' => '123456',
34			'timezone' => 'Europe/Paris',
35			'theme' => 'chamilo',
36			'gravatar_enabled' => 'false',
37			'gravatar_type' => 'mm',
38			'gamification_mode' => ' ',
39			'order_user_list_by_official_code' => 'false',
40			'cookie_warning' => 'false',
41			'donotlistcampus' => 'false',
42			'catalog_show_courses_sessions' => '0',
43			'course_catalog_hide_private' => 'false',
44			'use_custom_pages' => 'false',
45			'pdf_logo_header' => '',
46			'allow_my_files' => 'true',
47			'chamilo_database_version' => '2.0.0',
48			'registered' => 'false',
49			'load_term_conditions_section' => 'login',
50			'server_type' => 'false',
51			'show_full_skill_name_on_skill_wheel' => 'false',
52			'show_official_code_whoisonline' => 'false',
53			'show_tabs' => []
54			//
55			//('catalog_show_courses_sessions', '0', 'CatalogueShowOnlyCourses'),
56			//('catalog_show_courses_sessions', '1', 'CatalogueShowOnlySessions'),
57			//('catalog_show_courses_sessions', '2', 'CatalogueShowCoursesAndSessions'),
58			]
59			)
60			->setTransformer(
61			'show_tabs',
62			new ArrayToIdentifierTransformer()
63			)
64			;
65			$allowedTypes = [
66			'institution' => ['string'],
67			'institution_url' => ['string'],
68			'site_name' => ['string'],
69			// 'administrator_email' => array('string'),
70			// 'administrator_name' => array('string'),
71			// 'administrator_surname' => array('string'),
72			// 'administrator_phone' => array('string'),
73			'timezone' => ['string'],
74			'gravatar_enabled' => ['string'],
75			'gravatar_type' => ['string'],
76			'show_tabs' => ['array']
77			//'gamification_mode' => array('string'),
78			];
79
80			$this->setMultipleAllowedTypes($allowedTypes, $builder);
81			}
82
83			/**
84			* {@inheritdoc}
85			*/
86			public function buildForm(FormBuilderInterface $builder)
87			{
88			$tabs = [
89			'TabsCampusHomepage' => 'campus_homepage',
90			'TabsMyCourses' => 'my_courses',
91			'TabsReporting' => 'reporting',
92			'TabsPlatformAdministration' => 'platform_administration',
93			'mypersonalopenarea' => 'my_agenda',
94			'TabsMyAgenda' => 'my_profile',
95			'TabsMyGradebook' => 'my_gradebook',
96			'TabsSocial' => 'social',
97			'TabsDashboard' => 'dashboard'
98			];
99
100			$builder
101			->add('institution')
102			->add('institution_url', 'url')
103			->add('institution_address')
104			->add('site_name')
105			// ->add('administrator_email', 'email')
106			// ->add('administrator_name')
107			// ->add('administrator_surname')
108			// ->add('administrator_phone')
109			->add('timezone', 'timezone')
110			->add('theme')
111			->add('gravatar_enabled', YesNoType::class)
112			->add(
113			'gravatar_type',
114			'choice',
115			[
116			'choices' => [
117			'mm' => 'mistery-man',
118			'identicon' => 'identicon',
119			'monsterid' => 'monsterid',
120			'wavatar' => 'wavatar',
121			],
122			]
123			)
124			->add('gamification_mode')
125			->add('order_user_list_by_official_code', YesNoType::class)
126			->add('cookie_warning', YesNoType::class)
127			->add('donotlistcampus', YesNoType::class)
128			->add('course_catalog_hide_private', YesNoType::class)
129			->add(
130			'catalog_show_courses_sessions',
131			'choice',
132			['choices' => [
133			'0' => 'CatalogueShowOnlyCourses',
134			'1' => 'CatalogueShowOnlySessions',
135			'2' => 'CatalogueShowCoursesAndSessions',
136			]]
137			)
138			->add('use_custom_pages', YesNoType::class)
139			->add('pdf_logo_header')
140			->add('allow_my_files', YesNoType::class)
141			// old settings with no category
142			->add('chamilo_database_version')
143			->add('registered', YesNoType::class)
144			->add(
145			'load_term_conditions_section',
146			'choice',
147			[
148			'choices' => [
149			'0' => 'Login',
150			'1' => 'Course',
151			],
152			]
153			)
154			->add('server_type', YesNoType::class)
155			->add('show_full_skill_name_on_skill_wheel', YesNoType::class)
156			->add('show_official_code_whoisonline', YesNoType::class)
157			->add(
158			'show_tabs',
159			'choice',
160			[
161			'multiple' => true,
162			'choices' => $tabs,
163			'label' => 'ShowTabsTitle',
164			'help_block' => 'ShowTabsComment'
165			]
166			)
167			;
168			}
169			}
170

chamilo / chamilo-lms

Pull Request — master (#2349)

PlatformSettingsSchema::buildForm() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like