@@ -73,8 +73,9 @@ |
||
73 | 73 | //$form->addElement('submit','submit',get_lang('Filter')); |
74 | 74 | $form->addButtonFilter(get_lang('Filter')); |
75 | 75 | |
76 | -if (!empty($_REQUEST['course_code'])) |
|
76 | +if (!empty($_REQUEST['course_code'])) { |
|
77 | 77 | $selected_course = $_REQUEST['course_code']; |
78 | +} |
|
78 | 79 | if (!empty($selected_course)) { |
79 | 80 | $selected_course = api_get_course_info($selected_course); |
80 | 81 | $course_list = array($selected_course); |
@@ -90,7 +90,9 @@ discard block |
||
90 | 90 | echo "<tr> |
91 | 91 | <td> |
92 | 92 | "; |
93 | - if(isset($_cid)) echo "<b>$_cid : </b>"; |
|
93 | + if(isset($_cid)) { |
|
94 | + echo "<b>$_cid : </b>"; |
|
95 | + } |
|
94 | 96 | echo " <b>".get_lang('ToolList')."</b> |
95 | 97 | </td> |
96 | 98 | </tr> |
@@ -116,27 +118,28 @@ discard block |
||
116 | 118 | echo"</tr>"; |
117 | 119 | } |
118 | 120 | |
119 | - } |
|
120 | - else |
|
121 | + } else |
|
121 | 122 | { |
122 | 123 | echo "<tr>"; |
123 | 124 | echo "<td colspan='2'><center>".get_lang('NoResult')."</center></td>"; |
124 | 125 | echo"</tr>"; |
125 | 126 | } |
126 | 127 | echo "</table></td></tr>"; |
127 | - } |
|
128 | - else |
|
128 | + } else |
|
129 | 129 | { |
130 | 130 | // this can prevent bug if there is special chars in $tool |
131 | 131 | $encodedTool = urlencode($tool); |
132 | 132 | $tool = urldecode($tool); |
133 | 133 | |
134 | - if( !isset($reqdate) ) |
|
135 | - $reqdate = time(); |
|
134 | + if( !isset($reqdate) ) { |
|
135 | + $reqdate = time(); |
|
136 | + } |
|
136 | 137 | echo "<tr> |
137 | 138 | <td> |
138 | 139 | "; |
139 | - if(isset($_cid)) echo "<b>$_cid : </b>"; |
|
140 | + if(isset($_cid)) { |
|
141 | + echo "<b>$_cid : </b>"; |
|
142 | + } |
|
140 | 143 | echo " <b>".get_lang($tool)."</b> |
141 | 144 | </td> |
142 | 145 | </tr> |
@@ -182,10 +182,11 @@ |
||
182 | 182 | echo "<td style='padding-left : 40px;' valign='top'>" . $beautifulDateTime . "</td>"; |
183 | 183 | echo"</tr>"; |
184 | 184 | // $limit is used to select only results between $results[$j] (current login) and next one |
185 | - if ($j == ( sizeof($results) - 1 )) |
|
186 | - $limit = date("Y-m-d H:i:s", $nextReqDate); |
|
187 | - else |
|
188 | - $limit = $results[$j + 1]; |
|
185 | + if ($j == ( sizeof($results) - 1 )) { |
|
186 | + $limit = date("Y-m-d H:i:s", $nextReqDate); |
|
187 | + } else { |
|
188 | + $limit = $results[$j + 1]; |
|
189 | + } |
|
189 | 190 | // select all access to tool between displayed date and next displayed date or now() if |
190 | 191 | // displayed date is the last login date |
191 | 192 | $sql = "SELECT access_tool, count(access_tool) |
@@ -38,20 +38,27 @@ discard block |
||
38 | 38 | |
39 | 39 | $view = $_REQUEST['view']; |
40 | 40 | |
41 | -if ($view == "0000001") |
|
41 | +if ($view == "0000001") { |
|
42 | 42 | $nameTools = get_lang('SynthesisView'); |
43 | -if ($view == "1000000") |
|
43 | +} |
|
44 | +if ($view == "1000000") { |
|
44 | 45 | $nameTools = get_lang('CourseStats'); |
45 | -if ($view == "0100000") |
|
46 | +} |
|
47 | +if ($view == "0100000") { |
|
46 | 48 | $nameTools = get_lang('CourseAccess'); |
47 | -if ($view == "0010000") |
|
49 | +} |
|
50 | +if ($view == "0010000") { |
|
48 | 51 | $nameTools = get_lang('ToolsAccess'); |
49 | -if ($view == "0001000") |
|
52 | +} |
|
53 | +if ($view == "0001000") { |
|
50 | 54 | $nameTools = get_lang('LinksAccess'); |
51 | -if ($view == "0000100") |
|
55 | +} |
|
56 | +if ($view == "0000100") { |
|
52 | 57 | $nameTools = get_lang('DocumentsAccess'); |
53 | -if ($view == "00000010") |
|
58 | +} |
|
59 | +if ($view == "00000010") { |
|
54 | 60 | $nameTools = get_lang('ScormAccess'); |
61 | +} |
|
55 | 62 | |
56 | 63 | $interbreadcrumb[] = array("url" => api_get_self() . "?view=0000000", "name" => get_lang('ToolName')); |
57 | 64 | |
@@ -79,8 +86,9 @@ discard block |
||
79 | 86 | </div><br> |
80 | 87 | "; */ |
81 | 88 | |
82 | - if (!isset($view)) |
|
83 | - $view = "0000000"; |
|
89 | + if (!isset($view)) { |
|
90 | + $view = "0000000"; |
|
91 | + } |
|
84 | 92 | |
85 | 93 | |
86 | 94 | /* Reporting */ |
@@ -47,8 +47,16 @@ |
||
47 | 47 | $form->addElement('select', 'session_id', get_lang('Sessions'), $my_session_list); |
48 | 48 | $form->addButtonFilter(get_lang('Filter')); |
49 | 49 | |
50 | -if (!empty($_REQUEST['score'])) $filter_score = intval($_REQUEST['score']); else $filter_score = 70; |
|
51 | -if (!empty($_REQUEST['session_id'])) $session_id = intval($_REQUEST['session_id']); else $session_id = 0; |
|
50 | +if (!empty($_REQUEST['score'])) { |
|
51 | + $filter_score = intval($_REQUEST['score']); |
|
52 | +} else { |
|
53 | + $filter_score = 70; |
|
54 | +} |
|
55 | +if (!empty($_REQUEST['session_id'])) { |
|
56 | + $session_id = intval($_REQUEST['session_id']); |
|
57 | +} else { |
|
58 | + $session_id = 0; |
|
59 | +} |
|
52 | 60 | |
53 | 61 | if (empty($session_id)) { |
54 | 62 | $session_id = key($my_session_list); |
@@ -57,8 +57,9 @@ |
||
57 | 57 | <table width="100%" cellpadding="2" cellspacing="3" border="0"> |
58 | 58 | <?php |
59 | 59 | if ($is_allowedToTrack) { |
60 | - if (!isset($reqdate) || $reqdate < 0 || $reqdate > 2149372861) |
|
61 | - $reqdate = time(); |
|
60 | + if (!isset($reqdate) || $reqdate < 0 || $reqdate > 2149372861) { |
|
61 | + $reqdate = time(); |
|
62 | + } |
|
62 | 63 | //** dislayed period |
63 | 64 | echo "<tr><td><b>"; |
64 | 65 | switch($period) { |
@@ -445,7 +445,10 @@ |
||
445 | 445 | } |
446 | 446 | } |
447 | 447 | ?> |
448 | - <input type="hidden" name="updatePath" value="<?php if (!$badUpdatePath) echo api_htmlentities($proposedUpdatePath, ENT_QUOTES); ?>" /> |
|
448 | + <input type="hidden" name="updatePath" value="<?php if (!$badUpdatePath) { |
|
449 | + echo api_htmlentities($proposedUpdatePath, ENT_QUOTES); |
|
450 | +} |
|
451 | +?>" /> |
|
449 | 452 | <input type="hidden" name="urlAppendPath" value="<?php echo api_htmlentities($urlAppendPath, ENT_QUOTES); ?>" /> |
450 | 453 | <input type="hidden" name="pathForm" value="<?php echo api_htmlentities($pathForm, ENT_QUOTES); ?>" /> |
451 | 454 | <input type="hidden" name="urlForm" value="<?php echo api_htmlentities($urlForm, ENT_QUOTES); ?>" /> |
@@ -149,8 +149,7 @@ discard block |
||
149 | 149 | <?php |
150 | 150 | if ($session['access_start_date'] == '00-00-0000' && $session['access_end_date']== '00-00-0000' ) { |
151 | 151 | echo get_lang('NoTimeLimits'); |
152 | - } |
|
153 | - else { |
|
152 | + } else { |
|
154 | 153 | if ($session['access_start_date'] != '00-00-0000') { |
155 | 154 | //$session['date_start'] = Display::tag('i', get_lang('NoTimeLimits')); |
156 | 155 | $session['access_start_date'] = get_lang('From').' '.$session['access_start_date']; |
@@ -189,12 +188,18 @@ discard block |
||
189 | 188 | <?php echo api_ucfirst(get_lang('SessionVisibility')) ?> : |
190 | 189 | </td> |
191 | 190 | <td> |
192 | - <?php if ($session['visibility']==1) echo get_lang('ReadOnly'); elseif($session['visibility']==2) echo get_lang('Visible');elseif($session['visibility']==3) echo api_ucfirst(get_lang('Invisible')) ?> |
|
191 | + <?php if ($session['visibility']==1) { |
|
192 | + echo get_lang('ReadOnly'); |
|
193 | +} elseif($session['visibility']==2) { |
|
194 | + echo get_lang('Visible'); |
|
195 | +} elseif($session['visibility']==3) { |
|
196 | + echo api_ucfirst(get_lang('Invisible')) ?> |
|
193 | 197 | </td> |
194 | 198 | </tr> |
195 | 199 | <?php |
196 | 200 | |
197 | 201 | $multiple_url_is_on = api_get_multiple_access_url(); |
202 | +} |
|
198 | 203 | if ($multiple_url_is_on) { |
199 | 204 | echo '<tr><td>'; |
200 | 205 | echo 'URL'; |
@@ -477,7 +477,10 @@ discard block |
||
477 | 477 | <div class="actions"> |
478 | 478 | <?php echo $link_add_type_unique ?> | <?php echo $link_add_type_multiple ?> | <?php echo $link_add_group; ?> |
479 | 479 | </div> |
480 | - <form name="formulaire" method="post" action="<?php echo api_get_self(); ?>?page=<?php echo $page; ?>&id_session=<?php echo $id_session; ?><?php if(!empty($_GET['add'])) echo '&add=true' ; ?>" style="margin:0px;" <?php if($ajax_search){echo ' onsubmit="valide();"';}?>> |
|
480 | + <form name="formulaire" method="post" action="<?php echo api_get_self(); ?>?page=<?php echo $page; ?>&id_session=<?php echo $id_session; ?><?php if(!empty($_GET['add'])) { |
|
481 | + echo '&add=true' ; |
|
482 | +} |
|
483 | +?>" style="margin:0px;" <?php if($ajax_search){echo ' onsubmit="valide();"';}?>> |
|
481 | 484 | <?php echo '<legend>'.$tool_name.' ('.$session_info['name'].') </legend>'; ?> |
482 | 485 | <?php |
483 | 486 | if ($add_type == 'multiple') { |
@@ -545,7 +548,10 @@ discard block |
||
545 | 548 | <?php |
546 | 549 | foreach ($nosessionUsersList as $uid => $enreg) { |
547 | 550 | ?> |
548 | - <option value="<?php echo $uid; ?>" <?php if(in_array($uid,$UserList)) echo 'selected="selected"'; ?>><?php echo api_get_person_name($enreg['fn'], $enreg['ln']).' ('.$enreg['un'].')'; ?></option> |
|
551 | + <option value="<?php echo $uid; ?>" <?php if(in_array($uid,$UserList)) { |
|
552 | + echo 'selected="selected"'; |
|
553 | +} |
|
554 | +?>><?php echo api_get_person_name($enreg['fn'], $enreg['ln']).' ('.$enreg['un'].')'; ?></option> |
|
549 | 555 | <?php |
550 | 556 | } |
551 | 557 | ?> |