Chamilo\CoreBundle\Controller\Api\LpReorderController

Complexity

Total Complexity

11

Size/Duplication

Total Lines	24
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__invoke()	0	3	1
A	__construct()	0	1	1
B	reorder()	0	15	9

<?php

declare(strict_types=1);

/* For licensing terms, see /license.txt */

namespace Chamilo\CoreBundle\Controller\Api;

use Chamilo\CourseBundle\Repository\CLpRepository;
use Symfony\Component\HttpFoundation\JsonResponse;
use Symfony\Component\HttpFoundation\Request;

final class LpReorderController
{
    public function __construct(private CLpRepository $lpRepo) {}

    public function __invoke(Request $request): JsonResponse
    {
        return $this->reorder($request);
    }

    public function reorder(Request $request): JsonResponse
    {
        $data       = json_decode($request->getContent() ?: '[]', true);
        $courseId   = isset($data['courseId']) ? (int) $data['courseId'] : null;
        $sid        = array_key_exists('sid', $data) ? ($data['sid'] !== null ? (int)$data['sid'] : null) : null;
        $order      = $data['order'] ?? $data['ids'] ?? null;
        $categoryId = array_key_exists('categoryId', $data) ? ($data['categoryId'] !== null ? (int)$data['categoryId'] : null) : null;

        if (!$courseId || !\is_array($order)) {

The expression $courseId of type integer|null is loosely compared to false; this is ambiguous if the integer can be 0. You might want to explicitly use === null instead.

            return new JsonResponse(['error' => 'Invalid payload'], 400);
        }

        $this->lpRepo->reorderByIds($courseId, $sid, array_map('intval', $order), $categoryId);

        return new JsonResponse(null, 204);
    }
}