Chamilo\CourseBundle\Repository\CForumCategoryRepository

Complexity

Total Complexity

8

Size/Duplication

Total Lines	100
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	1

3 Methods

Rating	Name	Duplication	Size	Complexity
A	findAllInCourse()	0	41	4
A	findOneInCourse()	0	38	3
A	getResources()	0	3	1

<?php

/* For licensing terms, see /license.txt */

namespace Chamilo\CourseBundle\Repository;

use Chamilo\CoreBundle\Entity\Course;
use Chamilo\CoreBundle\Entity\Resource\ResourceNode;
use Chamilo\CoreBundle\Entity\Session;
use Chamilo\CoreBundle\Repository\ResourceRepository;
use Chamilo\CourseBundle\Entity\CForumCategory;
use Chamilo\CourseBundle\Entity\CGroupInfo;
use Chamilo\CourseBundle\Entity\CItemProperty;
use Chamilo\UserBundle\Entity\User;

class CForumCategoryRepository extends ResourceRepository
{
    public function getResources(User $user, ResourceNode $parentNode, Course $course = null, Session $session = null, CGroupInfo $group = null)
    {
        return $this->getResourcesByCourse($course, $session, $group, $parentNode);

It seems like $course can also be of type null; however, parameter $course of Chamilo\CoreBundle\Repository\ResourceRepository::getResourcesByCourse() does only seem to accept Chamilo\CoreBundle\Entity\Course, maybe add an additional type check?

    }

    /**
     * @param bool $isAllowedToEdit
     *
     * @todo Remove api_get_session_condition
     */
    public function findAllInCourse($isAllowedToEdit, Course $course, Session $session = null): array
    {
        $conditionSession = api_get_session_condition(
            $session ? $session->getId() : 0,
            true,
            true,
            'fcat.sessionId'
        );
        $conditionVisibility = $isAllowedToEdit ? 'ip.visibility != 2' : 'ip.visibility = 1';

        $dql = "SELECT ip, fcat
            FROM ChamiloCourseBundle:CItemProperty AS ip
            INNER JOIN ChamiloCourseBundle:CForumCategory fcat
                WITH (fcat.catId = ip.ref AND ip.course = fcat.cId)
            WHERE
                ip.tool = :tool AND
                ip.course = :course
                $conditionSession AND
                $conditionVisibility
                ORDER BY fcat.catOrder ASC";

        $result = $this
            ->_em
            ->createQuery($dql)
            ->setParameters(['course' => $course, 'tool' => TOOL_FORUM_CATEGORY])
            ->getResult();

        $categories = [];

        for ($i = 0; $i < count($result); $i += 2) {

It seems like you are calling the size function count() as part of the test condition. You might want to compute the size beforehand, and not on each iteration.

            /** @var CItemProperty $ip */
            $ip = $result[$i];
            /** @var CForumCategory $fc */
            $fc = $result[$i + 1];

            $fc->setItemProperty($ip);

            $categories[] = $fc;
        }

        return $categories;
    }

    /**
     * @param int $id
     *
     * @return CForumCategory|null
     *
     * @todo Remove api_get_session_condition
     */
    public function findOneInCourse($id, Course $course, Session $session)
    {
        $conditionSession = api_get_session_condition(
            $session ? $session->getId() : 0,

$session is of type Chamilo\CoreBundle\Entity\Session, thus it always evaluated to true.

            true,
            true,
            'fcat.sessionId'
        );

        $dql = "SELECT ip, fcat
            FROM ChamiloCourseBundle:CItemProperty AS ip
            INNER JOIN ChamiloCourseBundle:CForumCategory fcat
                WITH (fcat.catId = ip.ref AND ip.course = fcat.cId)
            WHERE
                ip.tool = :tool AND
                ip.course = :course
                fcat.iid = :id
                $conditionSession AND
                ORDER BY fcat.catOrder ASC";

        $result = $this
            ->_em
            ->createQuery($dql)
            ->setParameters(['tool' => TOOL_FORUM_CATEGORY, 'course' => $course, 'id' => (int) $id])
            ->getResult();

        if (empty($result)) {
            return null;
        }

        /** @var CItemProperty $ip */
        $ip = $result[0];
        /** @var CForumCategory $fc */
        $fc = $result[1];

        $fc->setItemProperty($ip);

        return $fc;
    }
}