Test Setup Failed
Push — master ( b82aef...e4f80c )
by Angel Fernando Quiroz
345:44 queued 291:34
created
main/document/save_pixlr.php 1 patch
Braces   +5 added lines, -3 removed lines patch added patch discarded remove patch
@@ -124,7 +124,9 @@  discard block
 block discarded – undo
124 124
 
125 125
 	if (file_exists($saveDir.'/'.$filename.'.'.$extension)){
126 126
 		$i = 1;
127
-		while (file_exists($saveDir.'/'.$filename.'_'.$i.'.'.$extension)) $i++;
127
+		while (file_exists($saveDir.'/'.$filename.'_'.$i.'.'.$extension)) {
128
+		    $i++;
129
+		}
128 130
 		$paintFileName = $filename . '_' . $i . '.'.$extension;
129 131
 		$title = $filename . '_' . $i . '.'.$extension;
130 132
 	}
@@ -137,7 +139,7 @@  discard block
 block discarded – undo
137 139
 	$doc_id = add_document($_course, $relativeUrlPath.'/'.$paintFileName, 'file', filesize($documentPath), $title);
138 140
 	api_item_property_update($_course, TOOL_DOCUMENT, $doc_id, 'DocumentAdded', $_user['user_id'], $groupId, null, null, null, $current_session_id);
139 141
 
140
-}elseif($currentTool=='document/editpaint'){
142
+} elseif($currentTool=='document/editpaint'){
141 143
 
142 144
 	$documentPath = $saveDir.'/'.$paintFileName;
143 145
 	//add new document to disk
@@ -152,7 +154,7 @@  discard block
 block discarded – undo
152 154
 		$document_id = DocumentManager::get_document_id($_course, $relativeUrlPath.'/'.$paintFileName);
153 155
 		update_existing_document($_course, $document_id, filesize($documentPath), null);
154 156
 		api_item_property_update($_course, TOOL_DOCUMENT, $document_id, 'DocumentUpdated', $_user['user_id'], $groupId, null, null, null, $current_session_id);
155
-	}else{
157
+	} else{
156 158
 		//add a new document
157 159
 		$doc_id = add_document($_course, $relativeUrlPath.'/'.$paintFileName, 'file', filesize($documentPath), $title);
158 160
 		api_item_property_update($_course, TOOL_DOCUMENT, $doc_id, 'DocumentAdded', $_user['user_id'], $groupId, null, null, null, $current_session_id);
Please login to merge, or discard this patch.
main/document/create_document.php 1 patch
Braces   +3 added lines, -2 removed lines patch added patch discarded remove patch
@@ -561,8 +561,9 @@
 block discarded – undo
561 561
 			}
562 562
 			$dir= substr($dir,0,-1);
563 563
 			$selectcat = '';
564
-			if (isset($_REQUEST['selectcat']))
565
-				$selectcat = "&selectcat=".Security::remove_XSS($_REQUEST['selectcat']);
564
+			if (isset($_REQUEST['selectcat'])) {
565
+							$selectcat = "&selectcat=".Security::remove_XSS($_REQUEST['selectcat']);
566
+			}
566 567
 			$certificate_condition = '';
567 568
 			if ($is_certificate_mode) {
568 569
 				$df = DocumentManager::get_default_certificate_id($_course['code']);
Please login to merge, or discard this patch.
main/document/remote.php 1 patch
Braces   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -40,7 +40,9 @@
 block discarded – undo
40 40
 $user_id = api_get_user_id();
41 41
 $coursePath = api_get_path(SYS_COURSE_PATH).$cidReq.'/document';
42 42
 $_course = CourseManager::get_course_information($cidReq);
43
-if ($_course == null) die ("problem when fetching course information");
43
+if ($_course == null) {
44
+    die ("problem when fetching course information");
45
+}
44 46
 // stupid variable initialisation for old version of DocumentManager functions.
45 47
 $_course['path'] = $_course['directory'];
46 48
 $is_manager = (CourseManager::get_user_in_course_status($user_id, $cidReq) == COURSEMANAGER);
Please login to merge, or discard this patch.
main/upload/upload.document.php 1 patch
Braces   +9 added lines, -4 removed lines patch added patch discarded remove patch
@@ -65,12 +65,17 @@
 block discarded – undo
65 65
     	$new_comment = isset($_POST['comment']) ? trim($_POST['comment']) : '';
66 66
     	$new_title = isset($_POST['title']) ? trim($_POST['title']) : '';
67 67
 
68
-    	if ($new_path && ($new_comment || $new_title))
69
-    	if (($docid = DocumentManager::get_document_id($_course, $new_path))) {
68
+    	if ($new_path && ($new_comment || $new_title)) {
69
+    	    	if (($docid = DocumentManager::get_document_id($_course, $new_path))) {
70 70
         	$table_document = Database::get_course_table(TABLE_DOCUMENT);
71
+    	}
71 72
         	$ct = '';
72
-        	if ($new_comment) $ct .= ", comment='$new_comment'";
73
-        	if ($new_title)   $ct .= ", title='$new_title'";
73
+        	if ($new_comment) {
74
+        	    $ct .= ", comment='$new_comment'";
75
+        	}
76
+        	if ($new_title) {
77
+        	    $ct .= ", title='$new_title'";
78
+        	}
74 79
         	Database::query("UPDATE $table_document SET" . substr($ct, 1) ." WHERE id = '$docid'");
75 80
     	}
76 81
         //check for missing images in html files
Please login to merge, or discard this patch.
main/dropbox/dropbox_class.inc.php 1 patch
Braces   +12 added lines, -4 removed lines patch added patch discarded remove patch
@@ -303,7 +303,9 @@  discard block
 block discarded – undo
303 303
 		}
304 304
 
305 305
 		foreach ($recipient_ids as $rec) {
306
-			if (empty($rec)) die(get_lang('GeneralError').' (code 210)');
306
+			if (empty($rec)) {
307
+			    die(get_lang('GeneralError').' (code 210)');
308
+			}
307 309
 			//if (!isCourseMember($rec)) die(); //cannot sent document to someone outside of course
308 310
 				//this check is done when validating submitted data
309 311
 			$this->recipients[] = array('id' => $rec, 'name' => getUserNameFromId($rec));
@@ -593,13 +595,19 @@  discard block
 block discarded – undo
593 595
 		$id = intval($id);
594 596
 		$sql = "DELETE FROM ".$dropbox_cnf['tbl_file']."
595 597
 		        WHERE c_id = $course_id AND cat_id = '".$id."' ";
596
-		if (!Database::query($sql)) return false;
598
+		if (!Database::query($sql)) {
599
+		    return false;
600
+		}
597 601
 		$sql = "DELETE FROM ".$dropbox_cnf['tbl_category']."
598 602
 		        WHERE c_id = $course_id AND cat_id = '".$id."' ";
599
-		if (!Database::query($sql)) return false;
603
+		if (!Database::query($sql)) {
604
+		    return false;
605
+		}
600 606
 		$sql = "DELETE FROM ".$dropbox_cnf['tbl_post']."
601 607
 		        WHERE c_id = $course_id AND cat_id = '".$id."' ";
602
-		if (!Database::query($sql)) return false;
608
+		if (!Database::query($sql)) {
609
+		    return false;
610
+		}
603 611
 		return true;
604 612
 	}
605 613
 
Please login to merge, or discard this patch.
main/dropbox/dropbox_submit.php 1 patch
Braces   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -267,7 +267,9 @@
 block discarded – undo
267 267
 			   break;
268 268
 			}
269 269
 		}
270
-		if (!$found) die(get_lang('GeneralError').' (code 415)');
270
+		if (!$found) {
271
+		    die(get_lang('GeneralError').' (code 415)');
272
+		}
271 273
 
272 274
         echo '<form method="post" action="index.php">', "\n",
273 275
             '<input type="hidden" name="feedbackid" value="',
Please login to merge, or discard this patch.
main/course_progress/thematic_plan.php 1 patch
Braces   +6 added lines, -4 removed lines patch added patch discarded remove patch
@@ -9,17 +9,19 @@
 block discarded – undo
9 9
 
10 10
 // actions menu
11 11
 $new_thematic_plan_data = array();
12
-if (!empty($thematic_plan_data))
13
-foreach($thematic_plan_data as $thematic_item) {
12
+if (!empty($thematic_plan_data)) {
13
+    foreach($thematic_plan_data as $thematic_item) {
14 14
     $thematic_simple_list[] = $thematic_item['description_type'];
15
+}
15 16
     $new_thematic_plan_data[$thematic_item['description_type']] = $thematic_item;
16 17
 }
17 18
 
18 19
 $new_id = ADD_THEMATIC_PLAN;
19
-if (!empty($thematic_simple_list))
20
-foreach($thematic_simple_list as $item) {
20
+if (!empty($thematic_simple_list)) {
21
+    foreach($thematic_simple_list as $item) {
21 22
     if ($item >= ADD_THEMATIC_PLAN) {
22 23
         $new_id = $item + 1;
24
+}
23 25
         $default_thematic_plan_title[$item] = $new_thematic_plan_data[$item]['title'];
24 26
     }
25 27
 }
Please login to merge, or discard this patch.
main/newscorm/lp_impress.php 1 patch
Braces   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -81,7 +81,7 @@
 block discarded – undo
81 81
         //just showing the src in a iframe ...
82 82
         $html .= '<h2>'.$toc['title'].'</h2>';
83 83
         $html .= '<iframe border="0" frameborder="0" style="width:100%;height:600px" src="' . $src . '"></iframe>';
84
-    }else{
84
+    } else{
85 85
         $html .= "<div class='impress-title'>";
86 86
         $html .= '<h1>'.$toc['title'].'</h1>';
87 87
         $html .= "</div>";
Please login to merge, or discard this patch.
main/newscorm/storageapi.php 1 patch
Braces   +6 added lines, -8 removed lines patch added patch discarded remove patch
@@ -45,8 +45,9 @@  discard block
 block discarded – undo
45 45
         }
46 46
         break;
47 47
     case "stackgetall":
48
-        if (storage_can_set($_REQUEST['svuser']))
49
-            print storage_stack_getall($_REQUEST['svuser'], $_REQUEST['svcourse'], $_REQUEST['svsco'], $_REQUEST['svkey']);
48
+        if (storage_can_set($_REQUEST['svuser'])) {
49
+                    print storage_stack_getall($_REQUEST['svuser'], $_REQUEST['svcourse'], $_REQUEST['svsco'], $_REQUEST['svkey']);
50
+        }
50 51
         break;
51 52
     case "getposition":
52 53
         print storage_get_position($_REQUEST['svuser'], $_REQUEST['svcourse'], $_REQUEST['svsco'], $_REQUEST['svkey'], $_REQUEST['svasc']);
@@ -87,8 +88,7 @@  discard block
 block discarded – undo
87 88
         } else {
88 89
             return $row['sv_value'];
89 90
         }
90
-    }
91
-    else {
91
+    } else {
92 92
         return null;
93 93
     }
94 94
 }
@@ -144,8 +144,7 @@  discard block
 block discarded – undo
144 144
     if (Database::num_rows($res) > 0) {
145 145
         $row = Database::fetch_assoc($res);
146 146
         return $row['position'];
147
-    }
148
-    else {
147
+    } else {
149 148
         return null;
150 149
     }
151 150
 }
@@ -198,8 +197,7 @@  discard block
 block discarded – undo
198 197
     if ($resorder && $resinsert) {
199 198
         Database::query("commit");
200 199
         return 1;
201
-    }
202
-    else {
200
+    } else {
203 201
         Database::query("rollback");
204 202
         return 0;
205 203
     }
Please login to merge, or discard this patch.