| Conditions | 13 |
| Paths | 48 |
| Total Lines | 145 |
| Code Lines | 70 |
| Lines | 34 |
| Ratio | 23.45 % |
| Changes | 3 | ||
| Bugs | 1 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 243 | public function save($namespace, $settings) |
||
| 244 | { |
||
| 245 | $schema = $this->schemaRegistry->getSchema($namespace); |
||
| 246 | |||
| 247 | $settingsBuilder = new SettingsBuilder(); |
||
| 248 | $schema->buildSettings($settingsBuilder); |
||
| 249 | |||
| 250 | $parameters = $settingsBuilder->resolve($settings->getParameters()); |
||
| 251 | |||
| 252 | View Code Duplication | foreach ($settingsBuilder->getTransformers() as $parameter => $transformer) { |
|
| 253 | if (array_key_exists($parameter, $parameters)) { |
||
| 254 | $parameters[$parameter] = $transformer->transform($parameters[$parameter]); |
||
| 255 | } |
||
| 256 | } |
||
| 257 | |||
| 258 | if (isset($this->resolvedSettings[$namespace])) { |
||
| 259 | $transformedParameters = $this->transformParameters($settingsBuilder, $parameters); |
||
| 260 | $this->resolvedSettings[$namespace]->setParameters($transformedParameters); |
||
| 261 | } |
||
| 262 | |||
| 263 | $persistedParameters = $this->parameterRepository->findBy(array('category' => $namespace)); |
||
| 264 | $persistedParametersMap = array(); |
||
| 265 | |||
| 266 | foreach ($persistedParameters as $parameter) { |
||
| 267 | $persistedParametersMap[$parameter->getName()] = $parameter; |
||
| 268 | } |
||
| 269 | |||
| 270 | /** @var SettingsEvent $event */ |
||
| 271 | $event = $this->eventDispatcher->dispatch( |
||
| 272 | SettingsEvent::PRE_SAVE, |
||
| 273 | new SettingsEvent($namespace, $settings, $parameters) |
||
| 274 | ); |
||
| 275 | |||
| 276 | var_dump($event); |
||
| 277 | |||
| 278 | /** @var \Chamilo\CoreBundle\Entity\SettingsCurrent $url */ |
||
| 279 | $url = $event->getArgument('url'); |
||
| 280 | |||
| 281 | View Code Duplication | foreach ($parameters as $name => $value) { |
|
| 282 | if (isset($persistedParametersMap[$name])) { |
||
| 283 | $persistedParametersMap[$name]->setValue($value); |
||
| 284 | } else { |
||
| 285 | $parameter = $this->parameterRepository->createNew(); |
||
| 286 | |||
| 287 | $parameter |
||
| 288 | ->setNamespace($namespace) |
||
| 289 | ->setName($name) |
||
| 290 | ->setValue($value) |
||
| 291 | ->setUrl($url) |
||
| 292 | ->setAccessUrlChangeable(1) |
||
| 293 | ->setAccessUrlLocked(1) |
||
| 294 | ; |
||
| 295 | |||
| 296 | /* @var $errors ConstraintViolationListInterface */ |
||
| 297 | $errors = $this->validator->validate($parameter); |
||
| 298 | if (0 < $errors->count()) { |
||
| 299 | throw new ValidatorException($errors->get(0)->getMessage()); |
||
| 300 | } |
||
| 301 | |||
| 302 | $this->parameterManager->persist($parameter); |
||
| 303 | } |
||
| 304 | } |
||
| 305 | |||
| 306 | $this->parameterManager->flush(); |
||
| 307 | |||
| 308 | $this->eventDispatcher->dispatch(SettingsEvent::POST_SAVE, new SettingsEvent($namespace, $settings, $parameters)); |
||
| 309 | |||
| 310 | $this->cache->save($namespace, $parameters); |
||
| 311 | |||
| 312 | |||
| 313 | |||
| 314 | return; |
||
| 315 | |||
| 316 | |||
| 317 | |||
| 318 | |||
| 319 | |||
| 320 | |||
| 321 | |||
| 322 | //// |
||
| 323 | $schemaAlias = $settings->getSchemaAlias(); |
||
| 324 | $schemaAliasChamilo = str_replace('chamilo_core.settings.', '', $schemaAlias); |
||
| 325 | |||
| 326 | $schema = $this->schemaRegistry->get($schemaAlias); |
||
| 327 | |||
| 328 | $settingsBuilder = new SettingsBuilder(); |
||
| 329 | $schema->buildSettings($settingsBuilder); |
||
| 330 | |||
| 331 | $parameters = $settingsBuilder->resolve($settings->getParameters()); |
||
| 332 | |||
| 333 | View Code Duplication | foreach ($settingsBuilder->getTransformers() as $parameter => $transformer) { |
|
| 334 | if (array_key_exists($parameter, $parameters)) { |
||
| 335 | $parameters[$parameter] = $transformer->transform($parameters[$parameter]); |
||
| 336 | } |
||
| 337 | } |
||
| 338 | |||
| 339 | /** @var \Sylius\Bundle\SettingsBundle\Event\SettingsEvent $event */ |
||
| 340 | $event = $this->eventDispatcher->dispatch( |
||
| 341 | SettingsEvent::PRE_SAVE, |
||
| 342 | new SettingsEvent($settings) |
||
| 343 | ); |
||
| 344 | |||
| 345 | /** @var \Chamilo\CoreBundle\Entity\SettingsCurrent $url */ |
||
| 346 | $url = $event->getSettings()->getAccessUrl(); |
||
| 347 | |||
| 348 | foreach ($parameters as $name => $value) { |
||
| 349 | if (isset($persistedParametersMap[$name])) { |
||
| 350 | if ($value instanceof Course) { |
||
| 351 | $value = $value->getId(); |
||
| 352 | } |
||
| 353 | $persistedParametersMap[$name]->setValue($value); |
||
| 354 | } else { |
||
| 355 | /** @var SettingsCurrent $setting */ |
||
| 356 | $setting = $this->settingsFactory->createNew(); |
||
| 357 | $setting->setSchemaAlias($schemaAlias); |
||
| 358 | |||
| 359 | $setting |
||
| 360 | ->setNamespace($schemaAliasChamilo) |
||
| 361 | ->setName($name) |
||
| 362 | ->setValue($value) |
||
| 363 | ->setUrl($url) |
||
| 364 | ->setAccessUrlLocked(0) |
||
| 365 | ->setAccessUrlChangeable(1) |
||
| 366 | ; |
||
| 367 | |||
| 368 | |||
| 369 | /* @var $errors ConstraintViolationListInterface */ |
||
| 370 | /*$errors = $this->->validate($parameter); |
||
| 371 | if (0 < $errors->count()) { |
||
| 372 | throw new ValidatorException($errors->get(0)->getMessage()); |
||
| 373 | }*/ |
||
| 374 | $this->manager->persist($setting); |
||
| 375 | $this->manager->flush(); |
||
| 376 | } |
||
| 377 | } |
||
| 378 | /*$parameters = $settingsBuilder->resolve($settings->getParameters()); |
||
| 379 | $settings->setParameters($parameters); |
||
| 380 | |||
| 381 | $this->eventDispatcher->dispatch(SettingsEvent::PRE_SAVE, new SettingsEvent($settings)); |
||
| 382 | |||
| 383 | $this->manager->persist($settings); |
||
| 384 | $this->manager->flush(); |
||
| 385 | |||
| 386 | $this->eventDispatcher->dispatch(SettingsEvent::POST_SAVE, new SettingsEvent($settings));*/ |
||
| 387 | } |
||
| 388 | |||
| 439 |
Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property.
Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property..