Inspection of "Merge pull request #1589 from jloguercio/1.11.x" - chamilo/chamilo-lms - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 1.11.x ( d78ca9...0f5bcf )

by José

created 2017-01-06 23:30 UTC

Status

Braces +8 added lines, -2 removed lines patch added patch discarded remove patch

@@ -477,7 +477,10 @@  discard block
 block discarded – undo
     <div class="actions">
     	<?php echo $link_add_type_unique ?>&nbsp;|&nbsp;<?php echo $link_add_type_multiple ?>&nbsp;|&nbsp;<?php echo $link_add_group; ?>
     </div>
-    <form name="formulaire" method="post" action="<?php echo api_get_self(); ?>?page=<?php echo $page; ?>&id_session=<?php echo $id_session; ?><?php if(!empty($_GET['add'])) echo '&add=true' ; ?>" style="margin:0px;" <?php if($ajax_search){echo ' onsubmit="valide();"';}?>>
+    <form name="formulaire" method="post" action="<?php echo api_get_self(); ?>?page=<?php echo $page; ?>&id_session=<?php echo $id_session; ?><?php if(!empty($_GET['add'])) {
+    echo '&add=true' ;
+}
+?>" style="margin:0px;" <?php if($ajax_search){echo ' onsubmit="valide();"';}?>>
     <?php echo '<legend>'.$tool_name.' ('.$session_info['name'].') </legend>'; ?>
     <?php
     if ($add_type == 'multiple') {
@@ -545,7 +548,10 @@  discard block
 block discarded – undo
                   <?php
                   foreach ($nosessionUsersList as $uid => $enreg) {
                   ?>
-                      <option value="<?php echo $uid; ?>" <?php if(in_array($uid,$UserList)) echo 'selected="selected"'; ?>><?php echo api_get_person_name($enreg['fn'], $enreg['ln']).' ('.$enreg['un'].')'; ?></option>
+                      <option value="<?php echo $uid; ?>" <?php if(in_array($uid,$UserList)) {
+    echo 'selected="selected"';
+}
+?>><?php echo api_get_person_name($enreg['fn'], $enreg['ln']).' ('.$enreg['un'].')'; ?></option>
                   <?php
                   }
                   ?>

Please login to merge, or discard this patch.

custompages/first_login-dist.php 1 patch

Braces +2 added lines, -1 removed lines patch added patch discarded remove patch

@@ -4,8 +4,9 @@
 block discarded – undo
 require_once dirname(__FILE__).'/../../inc/global.inc.php';
 $url =  api_get_path(WEB_PATH).'main/auth/conditional_login/complete_phone_number.php';
 
-if (! isset($_SESSION['conditional_login']['uid']))
+if (! isset($_SESSION['conditional_login']['uid'])) {
   die("Not Authorised");
+}
 ?>
 <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
 <html lang="fr" xml:lang="fr" xmlns="http://www.w3.org/1999/xhtml">

Please login to merge, or discard this patch.

main/admin/add_courses_to_usergroup.php 1 patch

Braces +4 added lines, -1 removed lines patch added patch discarded remove patch

@@ -144,7 +144,10 @@
 block discarded – undo
 echo '</div>';
 ?>
 
-<form name="formulaire" method="post" action="<?php echo api_get_self(); ?>?id=<?php echo $id; if(!empty($_GET['add'])) echo '&add=true' ; ?>" style="margin:0px;" <?php if($ajax_search){echo ' onsubmit="valide();"';}?>>
+<form name="formulaire" method="post" action="<?php echo api_get_self(); ?>?id=<?php echo $id; if(!empty($_GET['add'])) {
+    echo '&add=true' ;
+}
+?>" style="margin:0px;" <?php if($ajax_search){echo ' onsubmit="valide();"';}?>>
 <?php echo '<legend>'.$tool_name.' '.$promotion_data['name'].'</legend>';
 
 if ($add_type=='multiple') {

Please login to merge, or discard this patch.

main/admin/add_sessions_to_usergroup.php 1 patch

Braces +4 added lines, -1 removed lines patch added patch discarded remove patch

@@ -144,7 +144,10 @@
 block discarded – undo
 echo '</div>';
 ?>
 
-<form name="formulaire" method="post" action="<?php echo api_get_self(); ?>?id=<?php echo $id; if(!empty($_GET['add'])) echo '&add=true' ; ?>" style="margin:0px;" <?php if($ajax_search){echo ' onsubmit="valide();"';}?>>
+<form name="formulaire" method="post" action="<?php echo api_get_self(); ?>?id=<?php echo $id; if(!empty($_GET['add'])) {
+    echo '&add=true' ;
+}
+?>" style="margin:0px;" <?php if($ajax_search){echo ' onsubmit="valide();"';}?>>
 <?php echo '<legend>'.$tool_name.' '.$promotion_data['name'].'</legend>';
 
 if ($add_type=='multiple') {

Please login to merge, or discard this patch.

src/Chamilo/ThemeBundle/Event/SidebarMenuEvent.php 1 patch

Braces +3 added lines, -1 removed lines patch added patch discarded remove patch

@@ -76,7 +76,9 @@
 block discarded – undo
 
         foreach($this->getItems() as $item) {
             /** @var $item MenuItemInterface */
-            if($item->isActive()) return $item;
+            if($item->isActive()) {
+                return $item;
+            }
         }
         return null;
     }

Please login to merge, or discard this patch.

src/Chamilo/ThemeBundle/EventListener/SidebarSetupMenuDemoListener.php 1 patch

Braces +1 added lines, -2 removed lines patch added patch discarded remove patch

@@ -250,8 +250,7 @@
 block discarded – undo
         case RESULT_DISABLE_SHOW_SCORE_ONLY:
             if ($objExercise->feedback_type != EXERCISE_FEEDBACK_TYPE_END) {
                $header_names = array(get_lang('Attempt'), get_lang('StartDate'), get_lang('IP'), get_lang('Score'));
-            }
-            else {
+            } else {
                 $header_names = array(get_lang('Attempt'), get_lang('StartDate'), get_lang('IP'), get_lang('Score'), get_lang('Details'));
             }
             break;

Please login to merge, or discard this patch.

main/admin/user_update_import.php 1 patch

Braces +4 added lines, -1 removed lines patch added patch discarded remove patch

@@ -454,7 +454,10 @@
 block discarded – undo
     <blockquote>
         <pre>
             <b>UserName</b>;LastName;FirstName;Email;NewUserName;Password;AuthSource;OfficialCode;PhoneNumber;Status;ExpiryDate;Active;Language;Courses;ClassId;
-            xxx;xxx;xxx;xxx;xxx;xxx;xxx;xxx;xxx;user/teacher/drh;0000-00-00 00:00:00;0/1;xxx;<span style="color:red;"><?php if (count($list_reponse) > 0) echo implode(';', $list_reponse).';'; ?></span>xxx1|xxx2|xxx3;1;<br />
+            xxx;xxx;xxx;xxx;xxx;xxx;xxx;xxx;xxx;user/teacher/drh;0000-00-00 00:00:00;0/1;xxx;<span style="color:red;"><?php if (count($list_reponse) > 0) {
+    echo implode(';', $list_reponse).';';
+}
+?></span>xxx1|xxx2|xxx3;1;<br />
         </pre>
     </blockquote>
 <p><?php

Please login to merge, or discard this patch.

main/inc/lib/exercise_show_functions.lib.php 1 patch

Braces +1 added lines, -2 removed lines patch added patch discarded remove patch

@@ -434,8 +434,7 @@
 block discarded – undo
             } else {
                 echo $question->options[2];
             }
-        }
-        else {
+        } else {
             echo '-';
         }
         ?>

Please login to merge, or discard this patch.

main/reports/reports.lib.php 1 patch

Braces +10 added lines, -8 removed lines patch added patch discarded remove patch

@@ -15,9 +15,10 @@  discard block
 block discarded – undo
 // load templates
 function reports_loadTemplates() {
 	global $reports_enabled_templates, $reports_template;
-	foreach ($reports_enabled_templates as $t)
-		require_once 'templates/'.$t.'.reports.php';
-}
+	foreach ($reports_enabled_templates as $t) {
+			require_once 'templates/'.$t.'.reports.php';
+	}
+	}
 
 
 // clear all reporting data
@@ -150,11 +151,12 @@  discard block
 block discarded – undo
 // return tools ID (parametre is a constant from main_api
 function reports_getToolId($tool) {
 	$tools = array_flip(api_get_tools_lists());
-	if (array_key_exists($tool, $tools))
-		return $tools[$tool];
-	else
-		return null;
-}
+	if (array_key_exists($tool, $tools)) {
+			return $tools[$tool];
+	} else {
+			return null;
+	}
+	}
 
 // return a sql clause returning triplet of (course, $session, $uid) the
 // current user is authorized to reed

Please login to merge, or discard this patch.

		@@ -477,7 +477,10 @@ discard block
		block discarded – undo
477	477	<div class="actions">
478	478	<?php echo $link_add_type_unique ?> \| <?php echo $link_add_type_multiple ?> \| <?php echo $link_add_group; ?>
479	479	</div>
480		- <form name="formulaire" method="post" action="<?php echo api_get_self(); ?>?page=<?php echo $page; ?>&id_session=<?php echo $id_session; ?><?php if(!empty($_GET['add'])) echo '&add=true' ; ?>" style="margin:0px;" <?php if($ajax_search){echo ' onsubmit="valide();"';}?>>
	480	+ <form name="formulaire" method="post" action="<?php echo api_get_self(); ?>?page=<?php echo $page; ?>&id_session=<?php echo $id_session; ?><?php if(!empty($_GET['add'])) {
	481	+ echo '&add=true' ;
	482	+}
	483	+?>" style="margin:0px;" <?php if($ajax_search){echo ' onsubmit="valide();"';}?>>
481	484	<?php echo '<legend>'.$tool_name.' ('.$session_info['name'].') </legend>'; ?>
482	485	<?php
483	486	if ($add_type == 'multiple') {
		@@ -545,7 +548,10 @@ discard block
		block discarded – undo
545	548	<?php
546	549	foreach ($nosessionUsersList as $uid => $enreg) {
547	550	?>
548		- <option value="<?php echo $uid; ?>" <?php if(in_array($uid,$UserList)) echo 'selected="selected"'; ?>><?php echo api_get_person_name($enreg['fn'], $enreg['ln']).' ('.$enreg['un'].')'; ?></option>
	551	+ <option value="<?php echo $uid; ?>" <?php if(in_array($uid,$UserList)) {
	552	+ echo 'selected="selected"';
	553	+}
	554	+?>><?php echo api_get_person_name($enreg['fn'], $enreg['ln']).' ('.$enreg['un'].')'; ?></option>
549	555	<?php
550	556	}
551	557	?>

		@@ -250,8 +250,7 @@
		block discarded – undo
250	250	case RESULT_DISABLE_SHOW_SCORE_ONLY:
251	251	if ($objExercise->feedback_type != EXERCISE_FEEDBACK_TYPE_END) {
252	252	$header_names = array(get_lang('Attempt'), get_lang('StartDate'), get_lang('IP'), get_lang('Score'));
253		- }
254		- else {
	253	+ } else {
255	254	$header_names = array(get_lang('Attempt'), get_lang('StartDate'), get_lang('IP'), get_lang('Score'), get_lang('Details'));
256	255	}
257	256	break;

		@@ -434,8 +434,7 @@
		block discarded – undo
434	434	} else {
435	435	echo $question->options[2];
436	436	}
437		- }
438		- else {
	437	+ } else {
439	438	echo '-';
440	439	}
441	440	?>

		@@ -4,8 +4,9 @@
		block discarded – undo
4	4	require_once dirname(__FILE__).'/../../inc/global.inc.php';
5	5	$url = api_get_path(WEB_PATH).'main/auth/conditional_login/complete_phone_number.php';
6	6
7		-if (! isset($_SESSION['conditional_login']['uid']))
	7	+if (! isset($_SESSION['conditional_login']['uid'])) {
8	8	die("Not Authorised");
	9	+}
9	10	?>
10	11	<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
11	12	<html lang="fr" xml:lang="fr" xmlns="http://www.w3.org/1999/xhtml">

		@@ -144,7 +144,10 @@
		block discarded – undo
144	144	echo '</div>';
145	145	?>
146	146
147		-<form name="formulaire" method="post" action="<?php echo api_get_self(); ?>?id=<?php echo $id; if(!empty($_GET['add'])) echo '&add=true' ; ?>" style="margin:0px;" <?php if($ajax_search){echo ' onsubmit="valide();"';}?>>
	147	+<form name="formulaire" method="post" action="<?php echo api_get_self(); ?>?id=<?php echo $id; if(!empty($_GET['add'])) {
	148	+ echo '&add=true' ;
	149	+}
	150	+?>" style="margin:0px;" <?php if($ajax_search){echo ' onsubmit="valide();"';}?>>
148	151	<?php echo '<legend>'.$tool_name.' '.$promotion_data['name'].'</legend>';
149	152
150	153	if ($add_type=='multiple') {

		@@ -76,7 +76,9 @@
		block discarded – undo
76	76
77	77	foreach($this->getItems() as $item) {
78	78	/** @var $item MenuItemInterface */
79		- if($item->isActive()) return $item;
	79	+ if($item->isActive()) {
	80	+ return $item;
	81	+ }
80	82	}
81	83	return null;
82	84	}

		@@ -454,7 +454,10 @@
		block discarded – undo
454	454	<blockquote>
455	455	<pre>
456	456	<b>UserName</b>;LastName;FirstName;Email;NewUserName;Password;AuthSource;OfficialCode;PhoneNumber;Status;ExpiryDate;Active;Language;Courses;ClassId;
457		- xxx;xxx;xxx;xxx;xxx;xxx;xxx;xxx;xxx;user/teacher/drh;0000-00-00 00:00:00;0/1;xxx;<span style="color:red;"><?php if (count($list_reponse) > 0) echo implode(';', $list_reponse).';'; ?></span>xxx1\|xxx2\|xxx3;1;<br />
	457	+ xxx;xxx;xxx;xxx;xxx;xxx;xxx;xxx;xxx;user/teacher/drh;0000-00-00 00:00:00;0/1;xxx;<span style="color:red;"><?php if (count($list_reponse) > 0) {
	458	+ echo implode(';', $list_reponse).';';
	459	+}
	460	+?></span>xxx1\|xxx2\|xxx3;1;<br />
458	461	</pre>
459	462	</blockquote>
460	463	<p><?php

		@@ -15,9 +15,10 @@ discard block
		block discarded – undo
15	15	// load templates
16	16	function reports_loadTemplates() {
17	17	global $reports_enabled_templates, $reports_template;
18		- foreach ($reports_enabled_templates as $t)
19		- require_once 'templates/'.$t.'.reports.php';
20		-}
	18	+ foreach ($reports_enabled_templates as $t) {
	19	+ require_once 'templates/'.$t.'.reports.php';
	20	+ }
	21	+ }
21	22
22	23
23	24	// clear all reporting data
		@@ -150,11 +151,12 @@ discard block
		block discarded – undo
150	151	// return tools ID (parametre is a constant from main_api
151	152	function reports_getToolId($tool) {
152	153	$tools = array_flip(api_get_tools_lists());
153		- if (array_key_exists($tool, $tools))
154		- return $tools[$tool];
155		- else
156		- return null;
157		-}
	154	+ if (array_key_exists($tool, $tools)) {
	155	+ return $tools[$tool];
	156	+ } else {
	157	+ return null;
	158	+ }
	159	+ }
158	160
159	161	// return a sql clause returning triplet of (course, $session, $uid) the
160	162	// current user is authorized to reed

chamilo / chamilo-lms

Push — 1.11.x ( d78ca9...0f5bcf )

Status

Category

Braces +8 added lines, -2 removed lines patch added patch discarded remove patch

Braces +2 added lines, -1 removed lines patch added patch discarded remove patch

Braces +4 added lines, -1 removed lines patch added patch discarded remove patch

Braces +4 added lines, -1 removed lines patch added patch discarded remove patch

Braces +3 added lines, -1 removed lines patch added patch discarded remove patch

Braces +1 added lines, -2 removed lines patch added patch discarded remove patch

Braces +4 added lines, -1 removed lines patch added patch discarded remove patch

Braces +1 added lines, -2 removed lines patch added patch discarded remove patch

Braces +10 added lines, -8 removed lines patch added patch discarded remove patch