Conditions | 6 |
Paths | 18 |
Total Lines | 51 |
Code Lines | 28 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
74 | public function save(SettingsInterface $settings): void |
||
75 | { |
||
76 | $namespace = $settings->getSchemaAlias(); |
||
77 | |||
78 | /** @var SchemaInterface $schema */ |
||
79 | $schema = $this->schemaRegistry->get($namespace); |
||
80 | |||
81 | $settingsBuilder = new SettingsBuilder(); |
||
82 | $schema->buildSettings($settingsBuilder); |
||
83 | $parameters = $settingsBuilder->resolve($settings->getParameters()); |
||
84 | |||
85 | // Transform value. Example array to string using transformer. Example: |
||
86 | // 1. Setting "tool_visible_by_default_at_creation" it's a multiple select |
||
87 | // 2. Is defined as an array in class DocumentSettingsSchema |
||
88 | // 3. Add transformer for that variable "ArrayToIdentifierTransformer" |
||
89 | // 4. Here we recover the transformer and convert the array to string |
||
90 | foreach ($settingsBuilder->getTransformers() as $parameter => $transformer) { |
||
91 | if (\array_key_exists($parameter, $parameters)) { |
||
92 | $parameters[$parameter] = $transformer->transform($parameters[$parameter]); |
||
93 | } |
||
94 | } |
||
95 | |||
96 | $repo = $this->manager->getRepository(SettingsCurrent::class); |
||
97 | /** @var CCourseSetting[] $persistedParameters */ |
||
98 | $persistedParameters = $repo->findBy([ |
||
99 | 'category' => $namespace, |
||
100 | ]); |
||
101 | |||
102 | $persistedParametersMap = []; |
||
103 | foreach ($persistedParameters as $parameter) { |
||
104 | $persistedParametersMap[$parameter->getTitle()] = $parameter; |
||
105 | } |
||
106 | |||
107 | $simpleCategoryName = str_replace('chamilo_course.settings.', '', $namespace); |
||
108 | foreach ($parameters as $name => $value) { |
||
109 | if (isset($persistedParametersMap[$name])) { |
||
110 | $persistedParametersMap[$name]->setValue($value); |
||
111 | } else { |
||
112 | $parameter = new CCourseSetting(); |
||
113 | $parameter |
||
114 | ->setTitle($name) |
||
115 | ->setVariable($name) |
||
116 | ->setCategory($simpleCategoryName) |
||
117 | ->setValue($value) |
||
118 | ->setCId($this->getCourse()->getId()) |
||
119 | ; |
||
120 | $this->manager->persist($parameter); |
||
121 | } |
||
122 | } |
||
123 | |||
124 | $this->manager->flush(); |
||
125 | } |
||
154 |