IndexController::toggleStudentViewAction() - Code Metrics - Inspection of "Internal: Fix routes.yaml to use annotations" - chamilo/chamilo-lms - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 7daaad...a8dd9d )

by Julito

created 2020-08-20 08:18 UTC

IndexController::toggleStudentViewAction() A

↳ Parent: IndexController

Complexity

Conditions	4
Paths	3

Size

Total Lines	14
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	4
eloc	9
nc	3
nop	1
dl	0
loc	14
rs	9.9666
c	0
b	0
f	0

<?php

/* For licensing terms, see /license.txt */

namespace Chamilo\CoreBundle\Controller;

use Sensio\Bundle\FrameworkExtraBundle\Configuration\Security;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\Routing\Annotation\Route;

/**
 * Class IndexController.
 */
class IndexController extends BaseController
{
    /**
     * Index home page.
     *
     * @Route("/", name="home", methods={"GET", "POST"}, options={"expose"=true})
     * @Route("/login", name="login", methods={"GET", "POST"}, options={"expose"=true})
     * @Route("/courses", name="courses", methods={"GET", "POST"}, options={"expose"=true})
     * @Route("/sessions", name="sessions", methods={"GET", "POST"}, options={"expose"=true})
     */
    public function indexAction(): Response
    {
        return $this->render('@ChamiloCore/Index/vue.html.twig');
    }

    /**
     * Toggle the student view action.
     *
     * @Route("/toggle_student_view", methods={"GET"})
     *
     * @Security("has_role('ROLE_TEACHER')")
     */
    public function toggleStudentViewAction(Request $request): Response
    {
        if (!api_is_allowed_to_edit(false, false, false, false)) {
            return '';

        }
        $studentView = $request->getSession()->get('studentview');
        if (empty($studentView) || 'studentview' === $studentView) {
            $request->getSession()->set('studentview', 'teacherview');

            return 'teacherview';

        } else {
            $request->getSession()->set('studentview', 'studentview');

            return 'studentview';

        }
    }
}


1			<?php
2
3			/* For licensing terms, see /license.txt */
4
5			namespace Chamilo\CoreBundle\Controller;
6
7			use Sensio\Bundle\FrameworkExtraBundle\Configuration\Security;
8			use Symfony\Component\HttpFoundation\Request;
9			use Symfony\Component\HttpFoundation\Response;
10			use Symfony\Component\Routing\Annotation\Route;
11
12			/**
13			* Class IndexController.
14			*/
15			class IndexController extends BaseController
16			{
17			/**
18			* Index home page.
19			*
20			* @Route("/", name="home", methods={"GET", "POST"}, options={"expose"=true})
21			* @Route("/login", name="login", methods={"GET", "POST"}, options={"expose"=true})
22			* @Route("/courses", name="courses", methods={"GET", "POST"}, options={"expose"=true})
23			* @Route("/sessions", name="sessions", methods={"GET", "POST"}, options={"expose"=true})
24			*/
25			public function indexAction(): Response
26			{
27			return $this->render('@ChamiloCore/Index/vue.html.twig');
28			}
29
30			/**
31			* Toggle the student view action.
32			*
33			* @Route("/toggle_student_view", methods={"GET"})
34			*
35			* @Security("has_role('ROLE_TEACHER')")
36			*/
37			public function toggleStudentViewAction(Request $request): Response
38			{
39			if (!api_is_allowed_to_edit(false, false, false, false)) {
40			return '';
			0 ignored issues – show Bug Best Practice introduced 2018-08-15 09:02 UTC by Report Bug Copy Issue Report The expression `return ''` returns the type `string` which is incompatible with the type-hinted return `Symfony\Component\HttpFoundation\Response`. Loading history...
41			}
42			$studentView = $request->getSession()->get('studentview');
43			if (empty($studentView) \|\| 'studentview' === $studentView) {
44			$request->getSession()->set('studentview', 'teacherview');
45
46			return 'teacherview';
			0 ignored issues – show Bug Best Practice introduced 2018-08-15 09:02 UTC by Report Bug Copy Issue Report The expression `return 'teacherview'` returns the type `string` which is incompatible with the type-hinted return `Symfony\Component\HttpFoundation\Response`. Loading history...
47			} else {
48			$request->getSession()->set('studentview', 'studentview');
49
50			return 'studentview';
			0 ignored issues – show Bug Best Practice introduced 2018-08-15 09:02 UTC by Report Bug Copy Issue Report The expression `return 'studentview'` returns the type `string` which is incompatible with the type-hinted return `Symfony\Component\HttpFoundation\Response`. Loading history...
51			}
52			}
53			}
54

chamilo / chamilo-lms

Push — master ( 7daaad...a8dd9d )

IndexController::toggleStudentViewAction() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like