chamilo / chamilo-lms

main/admin/user_move_stats.php

Braces +99 added lines, -43 removed lines

@@ -108,7 +108,9 @@ 
                 //Check if the user is registered in the session otherwise we will add it
                 $result = SessionManager::get_users_by_session($new_session_id);
                 if (empty($result) || !in_array($user_id, array_keys($result))) {
-                    if ($debug) echo 'User added to the session';
+                    if ($debug) {
+                        echo 'User added to the session';
+                    }
                     //Registering user to the new session
                     SessionManager::subscribe_users_to_session($new_session_id,array($user_id),false);
                 }
@@ -143,10 +145,11 @@ 
                     $list[$row['exe_id']]= $row;
                 }
 
-                if (!empty($list))
-                    foreach ($list as $exe_id =>$data) {
+                if (!empty($list)) {
+                                    foreach ($list as $exe_id =>$data) {
                         if ($update_database) {
                             $sql = "UPDATE $TABLETRACK_EXERCICES SET session_id = '$new_session_id' WHERE exe_id = $exe_id";
+                }
                             $res = Database::query($sql);
                             $result_message[$TABLETRACK_EXERCICES]++;
                         } else {
@@ -170,10 +173,11 @@ 
                         $list[$row['exe_id']]= $row;
                     }
 
-                    if (!empty($list))
-                        foreach ($list as $exe_id =>$data) {
+                    if (!empty($list)) {
+                                            foreach ($list as $exe_id =>$data) {
                             if ($update_database) {
                                 $sql = "UPDATE $TABLETRACK_EXERCICES SET session_id = '$new_session_id' WHERE exe_id = $exe_id";
+                    }
                                 $res = Database::query($sql);
                                 $result_message[$TABLETRACK_EXERCICES]++;
                             } else {
@@ -198,10 +202,11 @@ 
                     $list[$row['course_access_id']] = $row;
                 }
 
-                if (!empty($list))
-                    foreach ($list as $id => $data) {
+                if (!empty($list)) {
+                                    foreach ($list as $id => $data) {
                         if ($update_database) {
                             $sql = "UPDATE $TBL_TRACK_E_COURSE_ACCESS SET session_id = $new_session_id WHERE course_access_id = $id";
+                }
                             if ($debug) {
                                 echo $sql;
                             }
@@ -220,13 +225,18 @@ 
                 while($row = Database::fetch_array($res,'ASSOC')) {
                     $list[] = $row['access_id'];
                 }
-                if (!empty($list))
-                    foreach ($list as $id) {
+                if (!empty($list)) {
+                                    foreach ($list as $id) {
                         if ($update_database) {
                             $sql = "UPDATE $TBL_TRACK_E_LAST_ACCESS SET access_session_id = $new_session_id WHERE access_id = $id";
-                            if ($debug) echo $sql;
+                }
+                            if ($debug) {
+                                echo $sql;
+                            }
                             $res = Database::query($sql);
-                            if ($debug) var_dump($res);
+                            if ($debug) {
+                                var_dump($res);
+                            }
                             $result_message[$TBL_TRACK_E_LAST_ACCESS]++;
                         }
                     }
@@ -250,13 +260,18 @@ 
                     }
                 }
 
-                if (!empty($list))
-                    foreach ($list as $id=>$data) {
+                if (!empty($list)) {
+                                    foreach ($list as $id=>$data) {
                         if ($update_database) {
                             $sql = "UPDATE $TBL_LP_VIEW SET session_id = $new_session_id WHERE c_id = $course_id AND id = $id ";
-                            if ($debug) var_dump($sql);
+                }
+                            if ($debug) {
+                                var_dump($sql);
+                            }
                             $res = Database::query($sql);
-                            if ($debug) var_dump($res);
+                            if ($debug) {
+                                var_dump($res);
+                            }
                             $result_message[$TBL_LP_VIEW]++;
                         } else {
                             //Getting all information of that lp_item_id
@@ -283,10 +298,11 @@ 
                             $list[$row['id']] = $row;
                         }
                     }
-                    if (!empty($list))
-                        foreach ($list as $id=>$data) {
+                    if (!empty($list)) {
+                                            foreach ($list as $id=>$data) {
                             //Getting all information of that lp_item_id
                             $score    = Tracking::get_avg_student_score($user_id, $origin_course_code,        array($data['lp_id']), $new_session_id);
+                    }
                             $progress = Tracking::get_avg_student_progress($user_id, $origin_course_code,     array($data['lp_id']), $new_session_id);
                             $result_message_compare['LP_VIEW'][$data['lp_id']] = array('score' => $score, 'progress' =>$progress);
                         }
@@ -302,9 +318,13 @@ 
                     $id = $row['ref'];
                     if ($update_database) {
                         $sql = "UPDATE $TBL_AGENDA SET session_id = $new_session_id WHERE c_id = $course_id AND id = $id ";
-                        if ($debug) var_dump($sql);
+                        if ($debug) {
+                            var_dump($sql);
+                        }
                         $res_update = Database::query($sql);
-                        if ($debug) var_dump($res_update);
+                        if ($debug) {
+                            var_dump($res_update);
+                        }
                         $result_message['agenda']++;
                     }
                 }
@@ -316,22 +336,30 @@ 
                 //echo '<h1>Student publication</h1>';
 
                 $sql = "SELECT ref FROM $TBL_ITEM_PROPERTY WHERE tool = 'work' AND insert_user_id = $user_id AND c_id = $course_id";
-                if ($debug) echo $sql;
+                if ($debug) {
+                    echo $sql;
+                }
                 $res = Database::query($sql);
                 while($row = Database::fetch_array($res,'ASSOC')) {
                     $id = $row['ref'];
                     $sql = "SELECT * FROM $TBL_STUDENT_PUBLICATION WHERE id = $id AND session_id = $origin_session_id AND c_id = $course_id";
-                    if ($debug) var_dump($sql);
+                    if ($debug) {
+                        var_dump($sql);
+                    }
                     $sub_res = Database::query($sql);
                     if (Database::num_rows($sub_res) > 0 ) {
                         $data = Database::fetch_array($sub_res,'ASSOC');
-                        if ($debug) var_dump($data);
+                        if ($debug) {
+                            var_dump($data);
+                        }
                         $parent_id = $data['parent_id'];
                         if (isset($data['parent_id']) && !empty($data['parent_id'])) {
                             $sql = "SELECT * FROM $TBL_STUDENT_PUBLICATION WHERE id = $parent_id AND c_id = $course_id";
                             $select_res     = Database::query($sql);
                             $parent_data    = Database::fetch_array($select_res,'ASSOC');
-                            if ($debug)     var_dump($parent_data);
+                            if ($debug) {
+                                var_dump($parent_data);
+                            }
 
                             $sys_course_path = api_get_path(SYS_COURSE_PATH);
                             $course_dir = $sys_course_path . $course_info['path'];
@@ -346,7 +374,9 @@ 
                             $sql = "SELECT * FROM $TBL_STUDENT_PUBLICATION
                             		WHERE description like '%$search_this%' AND url LIKE '%$search_this2%' AND session_id = $new_session_id AND c_id = $course_id
                             		ORDER BY id desc  LIMIT 1";
-                            if ($debug) echo $sql;
+                            if ($debug) {
+                                echo $sql;
+                            }
                             $sub_res = Database::query($sql);
                             $num_rows = Database::num_rows($sub_res);
 
@@ -390,7 +420,9 @@ 
 
                             //Creating student_publication_assignment if exists
                             $sql = "SELECT * FROM $TBL_STUDENT_PUBLICATION_ASSIGNMENT WHERE publication_id = $parent_id AND c_id = $course_id";
-                            if ($debug) var_dump($sql);
+                            if ($debug) {
+                                var_dump($sql);
+                            }
                             $rest_select     = Database::query($sql);
                             if (Database::num_rows($rest_select) > 0 ) {
                                 if ($update_database) {
@@ -402,7 +434,9 @@ 
                                        add_to_calendar      = '".$assignment_data['add_to_calendar']."',
                                        enable_qualification = '".$assignment_data['enable_qualification']."',
                                        publication_id       = '".$new_parent_id."'";
-                                    if ($debug) echo $sql_add_publication;
+                                    if ($debug) {
+                                        echo $sql_add_publication;
+                                    }
                                     $rest_select     = Database::query($sql_add_publication);
                                     $id = Database::insert_id();
 
@@ -410,11 +444,15 @@ 
                                         "has_properties         = '".$id."',
                                        view_properties    = '1'
                                        WHERE id   = ".$new_parent_id;
-                                    if ($debug) echo $sql_update;
+                                    if ($debug) {
+                                        echo $sql_update;
+                                    }
                                     $rest_update     = Database::query($sql_update);
 
 
-                                    if ($debug) var_dump($sql_update);
+                                    if ($debug) {
+                                        var_dump($sql_update);
+                                    }
                                     $result_message[$TBL_STUDENT_PUBLICATION_ASSIGNMENT]++;
                                 }
                             }
@@ -455,7 +493,9 @@ 
                                     if ($result) {
                                         unlink($full_file_name);
                                         $sql = "DELETE FROM $TBL_STUDENT_PUBLICATION WHERE id= ".$data['id'];
-                                        if ($debug) var_dump($sql);
+                                        if ($debug) {
+                                            var_dump($sql);
+                                        }
                                         $result_delete     = Database::query($sql);
                                         api_item_property_update($course_info, 'work', $data['id'], 'DocumentDeleted', api_get_user_id());
                                     }
@@ -471,22 +511,30 @@ 
                 //10. Dropbox - not neccesary to move categories (no presence of session_id)
 
                 $sql = "SELECT id FROM $TBL_DROPBOX_FILE WHERE uploader_id = $user_id AND session_id = $origin_session_id AND c_id = $course_id";
-                if ($debug) var_dump($sql);
+                if ($debug) {
+                    var_dump($sql);
+                }
                 $res = Database::query($sql);
                 while($row = Database::fetch_array($res,'ASSOC')) {
                     $id = $row['id'];
                     if ($update_database) {
                         $sql = "UPDATE $TBL_DROPBOX_FILE SET session_id = $new_session_id WHERE c_id = $course_id AND id = $id";
-                        if ($debug) var_dump($sql);
+                        if ($debug) {
+                            var_dump($sql);
+                        }
                         $res = Database::query($sql);
-                        if ($debug) var_dump($res);
+                        if ($debug) {
+                            var_dump($res);
+                        }
 
                         $sql = "UPDATE $TBL_DROPBOX_POST SET session_id = $new_session_id WHERE file_id = $id";
-                        if ($debug)
-                            var_dump($sql);
+                        if ($debug) {
+                                                    var_dump($sql);
+                        }
                         $res = Database::query($sql);
-                        if ($debug)
-                            var_dump($res);
+                        if ($debug) {
+                                                    var_dump($res);
+                        }
                         $result_message[$TBL_DROPBOX_FILE]++;
                     }
                 }
@@ -495,23 +543,30 @@ 
 
                 $sql = "SELECT notebook_id FROM $TBL_NOTEBOOK
                         WHERE user_id = $user_id AND session_id = $origin_session_id AND course = '$origin_course_code' AND c_id = $course_id";
-                if ($debug) var_dump($sql);
+                if ($debug) {
+                    var_dump($sql);
+                }
                 $res = Database::query($sql);
                 while($row = Database::fetch_array($res,'ASSOC')) {
                     $id = $row['notebook_id'];
                     if ($update_database) {
                         $sql = "UPDATE $TBL_NOTEBOOK SET session_id = $new_session_id WHERE c_id = $course_id AND notebook_id = $id";
-                        if ($debug) var_dump($sql);
+                        if ($debug) {
+                            var_dump($sql);
+                        }
                         $res = Database::query($sql);
-                        if ($debug) var_dump($res);
+                        if ($debug) {
+                            var_dump($res);
+                        }
                     }
                 }
 
                 if ($update_database) {
                     echo '<h2>'.get_lang('StatsMoved').'</h2>';
-                    if (is_array($result_message))
-                        foreach ($result_message as $table=>$times) {
+                    if (is_array($result_message)) {
+                                            foreach ($result_message as $table=>$times) {
                             echo 'Table '.$table.' - '.$times.' records updated <br />';
+                    }
                         }
                 } else {
                     echo '<h2>'.get_lang('UserInformationOfThisCourse').'</h2>';
@@ -626,10 +681,11 @@ 
 }
 $navigation .= '&nbsp;';
 $page ++;
-if ($page < $nro_pages)
+if ($page < $nro_pages) {
     $navigation .= '<a href="'.api_get_self().'?page='.$page.'">'.get_lang('Next').'</a>';
-else
+} else {
     $navigation .= get_lang('Next');
+}
 
 echo $navigation;
 $user_list      = UserManager::get_user_list(array(), array(), $begin, $default);

main/inc/lib/course.lib.php

Braces +3 added lines, -3 removed lines

@@ -3416,7 +3416,7 @@ 
             $html .= '<a class="thumbnail" href="'.$params['link'].'">';
             $html .= $params['icon'];
             $html .= '</a>';
-        }else{
+        } else{
             $html .= $params['icon'];
         }
         $html .= '</div>';
@@ -3675,7 +3675,7 @@ 
             if ($showCustomIcon === 'true' && $iconName != 'course.png') {
                 $thumbnails = $course_info['course_image'];
                 $image = $course_info['course_image_large'];
-            }else{
+            } else{
                 $image = Display::return_icon('session_default.png', null, null, null,null, true);
             }
 
@@ -3803,7 +3803,7 @@ 
             if ($showCustomIcon === 'true' && $iconName != 'course.png') {
                 $thumbnails = $course_info['course_image'];
                 $image = $course_info['course_image_large'];
-            }else{
+            } else{
                 $image = Display::return_icon('session_default.png', null, null, null,null, true);
             }
 

main/inc/lib/message.lib.php

Braces +12 added lines, -8 removed lines

@@ -662,8 +662,9 @@ 
      */
     public static function update_message($user_id, $message_id)
     {
-        if ($message_id != strval(intval($message_id)) || $user_id != strval(intval($user_id)))
-            return false;
+        if ($message_id != strval(intval($message_id)) || $user_id != strval(intval($user_id))) {
+                    return false;
+        }
 
         $table_message = Database::get_main_table(TABLE_MESSAGE);
         $sql = "UPDATE $table_message SET msg_status = '0'
@@ -703,8 +704,9 @@ 
      */
     public static function get_message_by_user($user_id, $message_id)
     {
-        if ($message_id != strval(intval($message_id)) || $user_id != strval(intval($user_id)))
-            return false;
+        if ($message_id != strval(intval($message_id)) || $user_id != strval(intval($user_id))) {
+                    return false;
+        }
         $table_message = Database::get_main_table(TABLE_MESSAGE);
         $query = "SELECT * FROM $table_message
                   WHERE user_receiver_id=" . intval($user_id) . " AND id='" . intval($message_id) . "'";
@@ -829,8 +831,9 @@ 
      */
     public static function exist_message($user_id, $id)
     {
-        if ($id != strval(intval($id)) || $user_id != strval(intval($user_id)))
-            return false;
+        if ($id != strval(intval($id)) || $user_id != strval(intval($user_id))) {
+                    return false;
+        }
         $table_message = Database::get_main_table(TABLE_MESSAGE);
         $query = "SELECT id FROM $table_message
                   WHERE
@@ -861,8 +864,9 @@ 
             $direction = 'DESC';
         } else {
             $column = intval($column);
-            if (!in_array($direction, array('ASC', 'DESC')))
-                $direction = 'ASC';
+            if (!in_array($direction, array('ASC', 'DESC'))) {
+                            $direction = 'ASC';
+            }
         }
         $table_message = Database::get_main_table(TABLE_MESSAGE);
         $request = api_is_xml_http_request();

main/gradebook/lib/be/evaluation.class.php

Braces +22 added lines, -10 removed lines

@@ -232,8 +232,11 @@ 
 		}
 
 		if (isset($user_id)) {
-			if ($paramcount != 0) $sql .= ' AND';
-			else $sql .= ' WHERE';
+			if ($paramcount != 0) {
+			    $sql .= ' AND';
+			} else {
+			    $sql .= ' WHERE';
+			}
 			$sql .= ' user_id = '.intval($user_id);
 			$paramcount ++;
 		}
@@ -252,22 +255,31 @@ 
 		}
 
 		if (isset($category_id)) {
-			if ($paramcount != 0) $sql .= ' AND';
-			else $sql .= ' WHERE';
+			if ($paramcount != 0) {
+			    $sql .= ' AND';
+			} else {
+			    $sql .= ' WHERE';
+			}
 			$sql .= ' category_id = '.intval($category_id);
 			$paramcount ++;
 		}
 
 		if (isset($visible)) {
-			if ($paramcount != 0) $sql .= ' AND';
-			else $sql .= ' WHERE';
+			if ($paramcount != 0) {
+			    $sql .= ' AND';
+			} else {
+			    $sql .= ' WHERE';
+			}
 			$sql .= ' visible = '.intval($visible);
 			$paramcount ++;
 		}
 
 		if (isset($locked)) {
-			if ($paramcount != 0) $sql .= ' AND';
-			else $sql .= ' WHERE';
+			if ($paramcount != 0) {
+			    $sql .= ' AND';
+			} else {
+			    $sql .= ' WHERE';
+			}
 			$sql .= ' locked = '.intval($locked);
 		}
 
@@ -407,7 +419,7 @@ 
 			.', description = ';
 		if (isset($this->description)) {
 			$sql .= "'".Database::escape_string($this->get_description())."'";
-		}else {
+		} else {
 			$sql .= 'null';
 		}
 		$sql .= ', user_id = '.intval($this->get_user_id())
@@ -475,7 +487,7 @@ 
 				$sql .= ' AND user_id = '.api_get_user_id();
 			}
 
-		}else {
+		} else {
 			$sql .= ' AND user_id = '.api_get_user_id();
 		}
 

main/reports/reports.php

Braces +43 added lines, -31 removed lines

@@ -37,16 +37,18 @@ 
 	// converting post vars to get uri
 	$params = '';
 	$kv = array();
-	foreach ($_POST as $key => $value)
-		if ($key != 'format')
+	foreach ($_POST as $key => $value) {
+			if ($key != 'format')
 			$kv[] = $key.'='.urlencode($value);
+	}
 	$query_string = join("&", $kv);
 	die('<a href="reports.php?format=directlink&'.$query_string.'">'.get_lang('ReportTypeLink').'</a>');
 }
 
 if ($_REQUEST['format'] == 'directlink') {
-	foreach (array('jquery.dataTables.min.js') as $js)
-		$htmlHeadXtra[] = '<script src="'.api_get_path(WEB_LIBRARY_JS_PATH).$js.'" type="text/javascript" language="javascript"></script>'."\n";
+	foreach (array('jquery.dataTables.min.js') as $js) {
+			$htmlHeadXtra[] = '<script src="'.api_get_path(WEB_LIBRARY_JS_PATH).$js.'" type="text/javascript" language="javascript"></script>'."\n";
+	}
 
 	$htmlCSSXtra[] = 'dataTable.css';
 
@@ -72,9 +74,10 @@ 
 	// converting post vars to get uri
 	$params = '';
 	$kv = array();
-	foreach ($_POST as $key => $value)
-		if ($key != 'format')
+	foreach ($_POST as $key => $value) {
+			if ($key != 'format')
 			$kv[] = $key.'='.urlencode($value);
+	}
 	$query_string = join("&", $kv);
 	die('<a href="reports.php?format=downloadcsv&'.$query_string.'">'.get_lang('DownloadFile').'</a>');
 } else if ($_REQUEST['format'] == 'downloadcsv') {
@@ -82,8 +85,7 @@ 
 		header("Pragma: must-revalidate");
 		header("Cache-Control: must-revalidate");
 		header("Content-type: application/vnd.ms-excel");
-	}
-	else {
+	} else {
 		header("Content-type: text/csv");
 	}
 	$date = date("Y-m-d");
@@ -96,10 +98,12 @@ 
 
 if (is_array($reports_template[$_REQUEST['type']])) {
 	$query = $reports_template[$_REQUEST['type']]['getSQL']();
-	if (! is_array($query))
-		$query = array($query);
-	if ($_REQUEST['format'] == 'sql')
-		die(var_export($query, true));
+	if (! is_array($query)) {
+			$query = array($query);
+	}
+	if ($_REQUEST['format'] == 'sql') {
+			die(var_export($query, true));
+	}
 
 	$result = multiquery_query($query);
 
@@ -155,32 +159,35 @@ 
 		if (substr($columns[$i], -5, 5) != '_link') {
 			$column_islink[$i] = false;
 			echo '<th>'.$columns[$i].'</th>';
-		} else
-			$columns_islink[$i] = true;
+		} else {
+					$columns_islink[$i] = true;
+		}
 	}
 
 	// checking resolving link column id
 	$columns_flip = array_flip($columns);
 	$columns_link = array();
-	for ($i=0; $i < $nfields; $i++)
-		if ($column_islink[$i] == false && array_key_exists($columns[$i].'_link', $columns_flip))
+	for ($i=0; $i < $nfields; $i++) {
+			if ($column_islink[$i] == false && array_key_exists($columns[$i].'_link', $columns_flip))
 			$columns_link[$i] = $columns_flip[$columns[$i].'_link'];
-		else
-			$columns_link[$i] = '';
+	}
+		else {
+					$columns_link[$i] = '';
+		}
 	echo '</tr></thead><tbody>';
 	while ($row = multiquery_fetch_row($result)) {
 		echo '<tr>';
-		for ($i = 0; $i<$nfields; $i++)
-			if (!$columns_islink[$i]){ // ignore links
+		for ($i = 0; $i<$nfields; $i++) {
+					if (!$columns_islink[$i]){ // ignore links
 				if ($columns_link[$i] != '') // link is defined
 					if (substr($columns_link[$i],0,10) == 'javascript') {
 						echo '<td><a href="#" onclick="'.$row[$columns_link[$i]].'">'.$row[$i].'</a></td>';
-					}
-					else {
+		}
+					} else {
 						echo '<td><a href="'.$row[$columns_link[$i]].'">'.$row[$i].'</a></td>';
-					}
-				else
-					echo '<td>'.$row[$i].'</td>';
+					} else {
+									echo '<td>'.$row[$i].'</td>';
+				}
 			}
 		echo "</tr>\n";
 	}
@@ -206,18 +213,23 @@ 
 		if (substr($columns[$i], -5, 5) != '_link') {
 			$column_islink[$i] = false;
 			echo csv_escaping($columns[$i]).',';
-		} else
-			$columns_islink[$i] = true;
+		} else {
+					$columns_islink[$i] = true;
+		}
 	}
 
 	echo "\n";
 	while ($row = multiquery_fetch_row($result)) {
-		for ($i = 0; $i<$nfields; $i++)
-			if (!$columns_islink[$i]) // ignore links
-				echo csv_escaping($row[$i]).',';  // fixme
+		for ($i = 0; $i<$nfields; $i++) {
+					if (!$columns_islink[$i]) // ignore links
+				echo csv_escaping($row[$i]).',';
+		}
+		// fixme
 		echo "\n";
 	}
-} else die(get_lang('UnknownFormat'));
+} else {
+    die(get_lang('UnknownFormat'));
+}
 
 function csv_escaping($value, $csv_separator = ',') {
 	$value = str_replace('"','""',$value);