findResults() - Code Metrics - Inspection of "Plugin: Exercise monitoring and focused - refs BT#..." - chamilo/chamilo-lms - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — 1.11.x (#4900)

by Angel Fernando Quiroz

created 2023-10-30 22:58 UTC

findResults() C

↳ Parent: Project

Complexity

Conditions	10
Paths	192

Size

Total Lines	77
Code Lines	43

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	43
c	1
b	0
f	0
dl	0
loc	77
rs	6.9
cc	10
nc	192
nop	3

How to fix Long Method Complexity

<?php

/* For licensing terms, see /license.txt */

use Chamilo\CoreBundle\Entity\TrackEAttempt;
use Chamilo\CoreBundle\Entity\TrackEExercises;
use Chamilo\CourseBundle\Entity\CQuiz;
use Chamilo\PluginBundle\ExerciseFocused\Entity\Log as FocusedLog;
use Chamilo\PluginBundle\ExerciseMonitoring\Entity\Log as MonitoringLog;
use Chamilo\UserBundle\Entity\User;
use Doctrine\ORM\EntityManagerInterface;
use Doctrine\ORM\Query\Expr\Join;
use Symfony\Component\HttpFoundation\Request as HttpRequest;
.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php

require_once __DIR__.'/../../../main/inc/global.inc.php';

api_protect_course_script(true);

if (!api_is_allowed_to_edit()) {
    api_not_allowed(true);
}

$plugin = ExerciseFocusedPlugin::create();
$monitoringPlugin = ExerciseMonitoringPlugin::create();
$monitoringPluginIsEnabled = $monitoringPlugin->isEnabled(true);
$request = HttpRequest::createFromGlobals();
$em = Database::getManager();
$focusedLogRepository = $em->getRepository(FocusedLog::class);
$attempsRepository = $em->getRepository(TrackEAttempt::class);

if (!$plugin->isEnabled(true)) {
    api_not_allowed(true);
}

$params = $request->query->all();

$results = findResults($params, $em, $plugin);

$data = [];

/** @var array<string, mixed> $result */
foreach ($results as $result) {
    /** @var TrackEExercises $trackExe */
    $trackExe = $result['exe'];
    $user = api_get_user_entity($trackExe->getExeUserId());

    $outfocusedLimitCount = $focusedLogRepository->countByActionInExe($trackExe, FocusedLog::TYPE_OUTFOCUSED_LIMIT);
    $timeLimitCount = $focusedLogRepository->countByActionInExe($trackExe, FocusedLog::TYPE_TIME_LIMIT);

    $exercise = new Exercise($trackExe->getCId());
    $exercise->read($trackExe->getExeExoId());

    $quizType = (int) $exercise->selectType();

    if ($trackExe->getSessionId()) {
        $data[] = [
            get_lang('SessionName'),
            api_get_session_entity($trackExe->getSessionId())->getName(),
        ];
    }
    $data[] = [
        get_lang('Course'),
        api_get_course_entity($trackExe->getCId())->getTitle(),
    ];
    $data[] = [
        get_lang('ExerciseName'),
        $exercise->getUnformattedTitle(),
    ];
    $data[] = [
        get_lang('Student'),
        $user->getUsername(),
        $user->getFirstname(),
        $user->getLastname(),
    ];
    $data[] = [
        $plugin->get_lang('ExerciseStartDateAndTime'),
        api_get_local_time($result['exe']->getStartDate(), null, null, true, true, true),
        $plugin->get_lang('ExerciseEndDateAndTime'),
        api_get_local_time($result['exe']->getExeDate(), null, null, true, true, true),
    ];
    $data[] = [
        $plugin->get_lang('Motive'),
        $plugin->calculateMotive($outfocusedLimitCount, $timeLimitCount),
    ];
    $data[] = [];

    $data[] = [
        $plugin->get_lang('LevelReached'),
        get_lang('DateExo'),
        get_lang('Score'),
        $plugin->get_lang('Outfocused'),
        $plugin->get_lang('Returns'),
        $monitoringPluginIsEnabled ? $monitoringPlugin->get_lang('Snapshots') : '',
    ];

    if (ONE_PER_PAGE === $quizType) {
        $questionList = explode(',', $trackExe->getDataTracking());

        foreach ($questionList as $idx => $questionId) {
            $attempt = $attempsRepository->findOneBy(
                ['exeId' => $trackExe->getExeId(), 'questionId' => $questionId],
                ['tms' => 'DESC']
            );

            if (!$attempt) {
                continue;
            }

            $result = $exercise->manage_answer(
                $trackExe->getExeId(),
                $questionId,
                null,
                'exercise_result',
                false,
                false,
                true,
                false,
                $exercise->selectPropagateNeg()
            );

            $row = [
                get_lang('QuestionNumber').' '.($idx + 1),
                api_get_local_time($attempt->getTms()),
                $result['score'].' / '.$result['weight'],
                $focusedLogRepository->countByActionAndLevel($trackExe, FocusedLog::TYPE_OUTFOCUSED, $questionId),
                $focusedLogRepository->countByActionAndLevel($trackExe, FocusedLog::TYPE_RETURN, $questionId),
                getSnapshotListForLevel($questionId, $trackExe),
            ];

            $data[] = $row;
        }
    } elseif (ALL_ON_ONE_PAGE === $quizType) {
    }

    $data[] = [];
    $data[] = [];
}

//var_dump($data);
Export::arrayToXls($data);

function getSessionIdFromFormValues(array $formValues, array $fieldVariableList): array
{
    $fieldItemIdList = [];
    $objFieldValue = new ExtraFieldValue('session');

    foreach ($fieldVariableList as $fieldVariable) {
        if (!isset($formValues["extra_$fieldVariable"])) {
            continue;
        }

        $itemValue = $objFieldValue->get_item_id_from_field_variable_and_field_value(
            $fieldVariable,
            $formValues["extra_$fieldVariable"]
        );

        if ($itemValue) {
            $fieldItemIdList[] = (int) $itemValue['item_id'];
        }
    }

    return array_unique($fieldItemIdList);
}

function findResults(array $formValues, EntityManagerInterface $em, ExerciseFocusedPlugin $plugin)
{
    $cId = api_get_course_int_id();

    $qb = $em->createQueryBuilder();
    $qb
        ->select('te AS exe, q.title, te.startDate , u.firstname, u.lastname, u.username')
        ->from(TrackEExercises::class, 'te')
        ->innerJoin(CQuiz::class, 'q', Join::WITH, 'te.exeExoId = q.iid')
        ->innerJoin(User::class, 'u', Join::WITH, 'te.exeUserId = u.id');

    $params = [];

    if ($cId) {
        $qb->andWhere($qb->expr()->eq('te.cId', ':cId'));

        $params['cId'] = $cId;
    }

    $sessionItemIdList = getSessionIdFromFormValues(
        $formValues,
        $plugin->getSessionFieldList()
    );

    if ($sessionItemIdList) {

        $qb->andWhere($qb->expr()->in('te.sessionId', ':sessionItemIdList'));

        $params['sessionItemIdList'] = $sessionItemIdList;
    } else {
        $qb->andWhere($qb->expr()->isNull('te.sessionId'));
    }

    if (!empty($formValues['username'])) {
        $qb->andWhere($qb->expr()->eq('u.username', ':username'));

        $params['username'] = $formValues['username'];
    }

    if (!empty($formValues['firstname'])) {
        $qb->andWhere($qb->expr()->eq('u.firstname', ':firstname'));

        $params['firstname'] = $formValues['firstname'];
    }

    if (!empty($formValues['lastname'])) {
        $qb->andWhere($qb->expr()->eq('u.lastname', ':lastname'));

        $params['lastname'] = $formValues['lastname'];
    }

    if (!empty($formValues['start_date'])) {
        $qb->andWhere(
            $qb->expr()->andX(
                $qb->expr()->gte('te.startDate', ':start_date'),
                $qb->expr()->lte('te.exeDate', ':end_date')
            )
        );

        $params['start_date'] = api_get_utc_datetime($formValues['start_date'].' 00:00:00', false, true);
        $params['end_date'] = api_get_utc_datetime($formValues['start_date'].' 23:59:59', false, true);
    }

    if (empty($params)) {
        return [];
    }

    if ($cId && !empty($formValues['id'])) {
        $qb->andWhere($qb->expr()->eq('q.iid', ':q_id'));

        $params['q_id'] = $formValues['id'];
    }

    $qb->setParameters($params);

    $query = $qb->getQuery();

    return $query->getResult();
}

function getSnapshotListForLevel(int $level, TrackEExercises $trackExe): string
{
    $monitoringPluginIsEnabled = ExerciseMonitoringPlugin::create()->isEnabled(true);

    if (!$monitoringPluginIsEnabled) {
        return '';
    }

    $user = api_get_user_entity($trackExe->getExeUserId());
    $monitoringLogRepository = Database::getManager()->getRepository(MonitoringLog::class);

    $monitoringLogsByQuestion = $monitoringLogRepository->findByLevelAndExe($level, $trackExe);
    $snapshotList = [];

    /** @var MonitoringLog $logByQuestion */
    foreach ($monitoringLogsByQuestion as $logByQuestion) {
        $snapshotUrl = ExerciseMonitoringPlugin::generateSnapshotUrl(
            $user->getId(),
            $logByQuestion->getImageFilename()
        );
        $snapshotList[] = api_get_local_time($logByQuestion->getCreatedAt()).' '.$snapshotUrl;
    }

    return implode(PHP_EOL, $snapshotList);
}


1			<?php
2
3			/* For licensing terms, see /license.txt */
4
5			use Chamilo\CoreBundle\Entity\TrackEAttempt;
6			use Chamilo\CoreBundle\Entity\TrackEExercises;
7			use Chamilo\CourseBundle\Entity\CQuiz;
8			use Chamilo\PluginBundle\ExerciseFocused\Entity\Log as FocusedLog;
9			use Chamilo\PluginBundle\ExerciseMonitoring\Entity\Log as MonitoringLog;
10			use Chamilo\UserBundle\Entity\User;
11			use Doctrine\ORM\EntityManagerInterface;
12			use Doctrine\ORM\Query\Expr\Join;
13			use Symfony\Component\HttpFoundation\Request as HttpRequest;
			0 ignored issues – show Bug introduced 2023-10-06 16:55 UTC by Report Bug Copy Issue Report This use statement conflicts with another class in this namespace, `HttpRequest`. Consider defining an alias. Let?s assume that you have a directory layout like this: . \|-- OtherDir \| \|-- Bar.php \| `-- Foo.php `-- SomeDir `-- Foo.php and let?s assume the following content of `Bar.php`: // Bar.php namespace OtherDir; use SomeDir\Foo; // This now conflicts the class OtherDir\Foo If both files `OtherDir/Foo.php` and `SomeDir/Foo.php` are loaded in the same runtime, you will see a PHP error such as the following: PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php However, as `OtherDir/Foo.php` does not necessarily have to be loaded and the error is only triggered if it is loaded before `OtherDir/Bar.php`, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: // Bar.php namespace OtherDir; use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore. Loading history...
14
15			require_once __DIR__.'/../../../main/inc/global.inc.php';
16
17			api_protect_course_script(true);
18
19			if (!api_is_allowed_to_edit()) {
20			api_not_allowed(true);
21			}
22
23			$plugin = ExerciseFocusedPlugin::create();
24			$monitoringPlugin = ExerciseMonitoringPlugin::create();
25			$monitoringPluginIsEnabled = $monitoringPlugin->isEnabled(true);
26			$request = HttpRequest::createFromGlobals();
27			$em = Database::getManager();
28			$focusedLogRepository = $em->getRepository(FocusedLog::class);
29			$attempsRepository = $em->getRepository(TrackEAttempt::class);
30
31			if (!$plugin->isEnabled(true)) {
32			api_not_allowed(true);
33			}
34
35			$params = $request->query->all();
36
37			$results = findResults($params, $em, $plugin);
38
39			$data = [];
40
41			/** @var array<string, mixed> $result */
42			foreach ($results as $result) {
43			/** @var TrackEExercises $trackExe */
44			$trackExe = $result['exe'];
45			$user = api_get_user_entity($trackExe->getExeUserId());
46
47			$outfocusedLimitCount = $focusedLogRepository->countByActionInExe($trackExe, FocusedLog::TYPE_OUTFOCUSED_LIMIT);
48			$timeLimitCount = $focusedLogRepository->countByActionInExe($trackExe, FocusedLog::TYPE_TIME_LIMIT);
49
50			$exercise = new Exercise($trackExe->getCId());
51			$exercise->read($trackExe->getExeExoId());
52
53			$quizType = (int) $exercise->selectType();
54
55			if ($trackExe->getSessionId()) {
56			$data[] = [
57			get_lang('SessionName'),
58			api_get_session_entity($trackExe->getSessionId())->getName(),
59			];
60			}
61			$data[] = [
62			get_lang('Course'),
63			api_get_course_entity($trackExe->getCId())->getTitle(),
64			];
65			$data[] = [
66			get_lang('ExerciseName'),
67			$exercise->getUnformattedTitle(),
68			];
69			$data[] = [
70			get_lang('Student'),
71			$user->getUsername(),
72			$user->getFirstname(),
73			$user->getLastname(),
74			];
75			$data[] = [
76			$plugin->get_lang('ExerciseStartDateAndTime'),
77			api_get_local_time($result['exe']->getStartDate(), null, null, true, true, true),
78			$plugin->get_lang('ExerciseEndDateAndTime'),
79			api_get_local_time($result['exe']->getExeDate(), null, null, true, true, true),
80			];
81			$data[] = [
82			$plugin->get_lang('Motive'),
83			$plugin->calculateMotive($outfocusedLimitCount, $timeLimitCount),
84			];
85			$data[] = [];
86
87			$data[] = [
88			$plugin->get_lang('LevelReached'),
89			get_lang('DateExo'),
90			get_lang('Score'),
91			$plugin->get_lang('Outfocused'),
92			$plugin->get_lang('Returns'),
93			$monitoringPluginIsEnabled ? $monitoringPlugin->get_lang('Snapshots') : '',
94			];
95
96			if (ONE_PER_PAGE === $quizType) {
97			$questionList = explode(',', $trackExe->getDataTracking());
98
99			foreach ($questionList as $idx => $questionId) {
100			$attempt = $attempsRepository->findOneBy(
101			['exeId' => $trackExe->getExeId(), 'questionId' => $questionId],
102			['tms' => 'DESC']
103			);
104
105			if (!$attempt) {
106			continue;
107			}
108
109			$result = $exercise->manage_answer(
110			$trackExe->getExeId(),
111			$questionId,
112			null,
113			'exercise_result',
114			false,
115			false,
116			true,
117			false,
118			$exercise->selectPropagateNeg()
119			);
120
121			$row = [
122			get_lang('QuestionNumber').' '.($idx + 1),
123			api_get_local_time($attempt->getTms()),
124			$result['score'].' / '.$result['weight'],
125			$focusedLogRepository->countByActionAndLevel($trackExe, FocusedLog::TYPE_OUTFOCUSED, $questionId),
126			$focusedLogRepository->countByActionAndLevel($trackExe, FocusedLog::TYPE_RETURN, $questionId),
127			getSnapshotListForLevel($questionId, $trackExe),
128			];
129
130			$data[] = $row;
131			}
132			} elseif (ALL_ON_ONE_PAGE === $quizType) {
133			}
134
135			$data[] = [];
136			$data[] = [];
137			}
138
139			//var_dump($data);
140			Export::arrayToXls($data);
141
142			function getSessionIdFromFormValues(array $formValues, array $fieldVariableList): array
143			{
144			$fieldItemIdList = [];
145			$objFieldValue = new ExtraFieldValue('session');
146
147			foreach ($fieldVariableList as $fieldVariable) {
148			if (!isset($formValues["extra_$fieldVariable"])) {
149			continue;
150			}
151
152			$itemValue = $objFieldValue->get_item_id_from_field_variable_and_field_value(
153			$fieldVariable,
154			$formValues["extra_$fieldVariable"]
155			);
156
157			if ($itemValue) {
158			$fieldItemIdList[] = (int) $itemValue['item_id'];
159			}
160			}
161
162			return array_unique($fieldItemIdList);
163			}
164
165			function findResults(array $formValues, EntityManagerInterface $em, ExerciseFocusedPlugin $plugin)
166			{
167			$cId = api_get_course_int_id();
168
169			$qb = $em->createQueryBuilder();
170			$qb
171			->select('te AS exe, q.title, te.startDate , u.firstname, u.lastname, u.username')
172			->from(TrackEExercises::class, 'te')
173			->innerJoin(CQuiz::class, 'q', Join::WITH, 'te.exeExoId = q.iid')
174			->innerJoin(User::class, 'u', Join::WITH, 'te.exeUserId = u.id');
175
176			$params = [];
177
178			if ($cId) {
179			$qb->andWhere($qb->expr()->eq('te.cId', ':cId'));
180
181			$params['cId'] = $cId;
182			}
183
184			$sessionItemIdList = getSessionIdFromFormValues(
185			$formValues,
186			$plugin->getSessionFieldList()
187			);
188
189			if ($sessionItemIdList) {
			0 ignored issues – show Bug Best Practice introduced 2023-10-18 16:23 UTC by Report Bug Copy Issue Report The expression `$sessionItemIdList` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `! empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
190			$qb->andWhere($qb->expr()->in('te.sessionId', ':sessionItemIdList'));
191
192			$params['sessionItemIdList'] = $sessionItemIdList;
193			} else {
194			$qb->andWhere($qb->expr()->isNull('te.sessionId'));
195			}
196
197			if (!empty($formValues['username'])) {
198			$qb->andWhere($qb->expr()->eq('u.username', ':username'));
199
200			$params['username'] = $formValues['username'];
201			}
202
203			if (!empty($formValues['firstname'])) {
204			$qb->andWhere($qb->expr()->eq('u.firstname', ':firstname'));
205
206			$params['firstname'] = $formValues['firstname'];
207			}
208
209			if (!empty($formValues['lastname'])) {
210			$qb->andWhere($qb->expr()->eq('u.lastname', ':lastname'));
211
212			$params['lastname'] = $formValues['lastname'];
213			}
214
215			if (!empty($formValues['start_date'])) {
216			$qb->andWhere(
217			$qb->expr()->andX(
218			$qb->expr()->gte('te.startDate', ':start_date'),
219			$qb->expr()->lte('te.exeDate', ':end_date')
220			)
221			);
222
223			$params['start_date'] = api_get_utc_datetime($formValues['start_date'].' 00:00:00', false, true);
224			$params['end_date'] = api_get_utc_datetime($formValues['start_date'].' 23:59:59', false, true);
225			}
226
227			if (empty($params)) {
228			return [];
229			}
230
231			if ($cId && !empty($formValues['id'])) {
232			$qb->andWhere($qb->expr()->eq('q.iid', ':q_id'));
233
234			$params['q_id'] = $formValues['id'];
235			}
236
237			$qb->setParameters($params);
238
239			$query = $qb->getQuery();
240
241			return $query->getResult();
242			}
243
244			function getSnapshotListForLevel(int $level, TrackEExercises $trackExe): string
245			{
246			$monitoringPluginIsEnabled = ExerciseMonitoringPlugin::create()->isEnabled(true);
247
248			if (!$monitoringPluginIsEnabled) {
249			return '';
250			}
251
252			$user = api_get_user_entity($trackExe->getExeUserId());
253			$monitoringLogRepository = Database::getManager()->getRepository(MonitoringLog::class);
254
255			$monitoringLogsByQuestion = $monitoringLogRepository->findByLevelAndExe($level, $trackExe);
256			$snapshotList = [];
257
258			/** @var MonitoringLog $logByQuestion */
259			foreach ($monitoringLogsByQuestion as $logByQuestion) {
260			$snapshotUrl = ExerciseMonitoringPlugin::generateSnapshotUrl(
261			$user->getId(),
262			$logByQuestion->getImageFilename()
263			);
264			$snapshotList[] = api_get_local_time($logByQuestion->getCreatedAt()).' '.$snapshotUrl;
265			}
266
267			return implode(PHP_EOL, $snapshotList);
268			}
269

chamilo / chamilo-lms

Pull Request — 1.11.x (#4900)

findResults() C

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like