CcAssesmentQuestionFib::onGenerateAnswers() - Code Metrics - Inspection of "Maintenance: CommonCartridge: Partial implementati..." - chamilo/chamilo-lms - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — 1.11.x ( ef1e71...906f76 )

by Yannick

created 2024-06-28 00:14 UTC

CcAssesmentQuestionFib::onGenerateAnswers() A

↳ Parent: CcAssesmentQuestionFib

Complexity

Conditions	3
Paths	3

Size

Total Lines	57
Code Lines	38

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	38
c	1
b	0
f	0
dl	0
loc	57
rs	9.312
cc	3
nc	3
nop	0

How to fix Long Method

<?php
/* Source: https://github.com/moodle/moodle/blob/MOODLE_310_STABLE/backup/cc/cc_lib/cc_asssesment.php under GNU/GPL license */

class CcAssesmentQuestionFib extends CcAssesmentQuestionProcBase
{
    public function __construct($quiz, $questions, $manifest, $section, $questionNode, $rootpath, $contextid, $outdir)
    {
        parent::__construct($quiz, $questions, $manifest, $section, $questionNode, $rootpath, $contextid, $outdir);
        $this->qtype = CcQtiProfiletype::FIELD_ENTRY;
        $correctAnswerNodes = [];
        $questionScore = 0;
        foreach ($questionNode->answers as $index => $answer) {
            $answerScore = 0;
            $answerText = $answer['answer'];
            $pos = strrpos($answerText, '::');
            list($answerText, $answerRules) = explode('::', $answerText);
            $matches = [];
            list($weights, $sizes, $others) = explode(':', $answerRules);
            $weights = explode(',', $weights);
            $i = 0;
            // Todo: improve to tolerate all separators
            if (preg_match_all('/\[(.*?)\]/', $answerText, $matches)) {
                foreach ($matches[1] as $match) {
                    $correctAnswerNodes[] = $match;
                    $questionScore += $weights[$i];
                    $answerScore += $weights[$i];
                    $i++;
                }
            }
            $questionNode->answers[$index] = [
                'answer' => $answerText,
                'ponderation' => $answerScore,
                'comment' => $answer['comment'],
            ];
            $questionScore ++;
        }
        if (count($correctAnswerNodes) == 0) {
            throw new RuntimeException('No correct answer!');
        }
        $this->correctAnswers = $correctAnswerNodes;
        $this->totalGradeValue = $questionScore;
    }

    public function onGenerateAnswers()
    {
        //add responses holder
        $qresponseLid = new CcResponseLidtype();
        $this->qresponseLid = $qresponseLid;
        $this->qpresentation->setResponseLid($qresponseLid);
        $qresponseChoice = new CcAssesmentRenderFibtype();
        $qresponseLid->setRenderFib($qresponseChoice);

        //Mark that question has more than one correct answer
        $qresponseLid->setRcardinality(CcQtiValues::MULTIPLE);

        //are we to shuffle the responses?
        $shuffleAnswers = $this->quiz['random_answers'] > 0;

        $qresponseChoice->enableShuffle($shuffleAnswers);
        $answerlist = [];

        $qaResponses = $this->questionNode->answers;

        foreach ($qaResponses as $node) {
            $answerContent = $node['answer'];
            $answerGradeFraction = $node['ponderation'];

            $result = CcHelpers::processLinkedFiles($answerContent,
                $this->manifest,
                $this->rootpath,
                $this->contextid,
                $this->outdir);

            $qresponseLabel = CcAssesmentHelper::addAnswer($qresponseChoice,
                $result[0],
                CcQtiValues::HTMLTYPE);

            PkgResourceDependencies::instance()->add($result[1]);

            $answerIdent = $qresponseLabel->getIdent();
            $feedbackIdent = $answerIdent.'_fb';
            //add answer specific feedbacks if not empty
            $content = $node['comment'];
            if (!empty($content)) {
                $result = CcHelpers::processLinkedFiles($content,
                    $this->manifest,
                    $this->rootpath,
                    $this->contextid,
                    $this->outdir);

                CcAssesmentHelper::addFeedback($this->qitem,
                    $result[0],
                    CcQtiValues::HTMLTYPE,
                    $feedbackIdent);

                PkgResourceDependencies::instance()->add($result[1]);
            }
            $answerlist[$answerIdent] = [$feedbackIdent, ($answerGradeFraction > 0)];
        }
        $this->answerlist = $answerlist;
    }

    public function onGenerateFeedbacks()
    {
        parent::onGenerateFeedbacks();
    }

    public function onGenerateResponseProcessing()
    {
        parent::onGenerateResponseProcessing();

        /**
         * General unconditional feedback must be added as a first respcondition
         * without any condition and just displayfeedback (if exists).
         */
        $qrespcondition = new CcAssesmentRespconditiontype();
        $qrespcondition->setTitle('General feedback');
        $this->qresprocessing->addRespcondition($qrespcondition);
        $qrespcondition->enableContinue();
    }
}


1			<?php
2			/* Source: https://github.com/moodle/moodle/blob/MOODLE_310_STABLE/backup/cc/cc_lib/cc_asssesment.php under GNU/GPL license */
3
4			class CcAssesmentQuestionFib extends CcAssesmentQuestionProcBase
5			{
6			public function __construct($quiz, $questions, $manifest, $section, $questionNode, $rootpath, $contextid, $outdir)
7			{
8			parent::__construct($quiz, $questions, $manifest, $section, $questionNode, $rootpath, $contextid, $outdir);
9			$this->qtype = CcQtiProfiletype::FIELD_ENTRY;
10			$correctAnswerNodes = [];
11			$questionScore = 0;
12			foreach ($questionNode->answers as $index => $answer) {
13			$answerScore = 0;
14			$answerText = $answer['answer'];
15			$pos = strrpos($answerText, '::');
16			list($answerText, $answerRules) = explode('::', $answerText);
17			$matches = [];
18			list($weights, $sizes, $others) = explode(':', $answerRules);
19			$weights = explode(',', $weights);
20			$i = 0;
21			// Todo: improve to tolerate all separators
22			if (preg_match_all('/\[(.*?)\]/', $answerText, $matches)) {
23			foreach ($matches[1] as $match) {
24			$correctAnswerNodes[] = $match;
25			$questionScore += $weights[$i];
26			$answerScore += $weights[$i];
27			$i++;
28			}
29			}
30			$questionNode->answers[$index] = [
31			'answer' => $answerText,
32			'ponderation' => $answerScore,
33			'comment' => $answer['comment'],
34			];
35			$questionScore ++;
36			}
37			if (count($correctAnswerNodes) == 0) {
38			throw new RuntimeException('No correct answer!');
39			}
40			$this->correctAnswers = $correctAnswerNodes;
41			$this->totalGradeValue = $questionScore;
42			}
43
44			public function onGenerateAnswers()
45			{
46			//add responses holder
47			$qresponseLid = new CcResponseLidtype();
48			$this->qresponseLid = $qresponseLid;
49			$this->qpresentation->setResponseLid($qresponseLid);
50			$qresponseChoice = new CcAssesmentRenderFibtype();
51			$qresponseLid->setRenderFib($qresponseChoice);
52
53			//Mark that question has more than one correct answer
54			$qresponseLid->setRcardinality(CcQtiValues::MULTIPLE);
55
56			//are we to shuffle the responses?
57			$shuffleAnswers = $this->quiz['random_answers'] > 0;
58
59			$qresponseChoice->enableShuffle($shuffleAnswers);
60			$answerlist = [];
61
62			$qaResponses = $this->questionNode->answers;
63
64			foreach ($qaResponses as $node) {
65			$answerContent = $node['answer'];
66			$answerGradeFraction = $node['ponderation'];
67
68			$result = CcHelpers::processLinkedFiles($answerContent,
69			$this->manifest,
70			$this->rootpath,
71			$this->contextid,
72			$this->outdir);
73
74			$qresponseLabel = CcAssesmentHelper::addAnswer($qresponseChoice,
75			$result[0],
76			CcQtiValues::HTMLTYPE);
77
78			PkgResourceDependencies::instance()->add($result[1]);
79
80			$answerIdent = $qresponseLabel->getIdent();
81			$feedbackIdent = $answerIdent.'_fb';
82			//add answer specific feedbacks if not empty
83			$content = $node['comment'];
84			if (!empty($content)) {
85			$result = CcHelpers::processLinkedFiles($content,
86			$this->manifest,
87			$this->rootpath,
88			$this->contextid,
89			$this->outdir);
90
91			CcAssesmentHelper::addFeedback($this->qitem,
92			$result[0],
93			CcQtiValues::HTMLTYPE,
94			$feedbackIdent);
95
96			PkgResourceDependencies::instance()->add($result[1]);
97			}
98			$answerlist[$answerIdent] = [$feedbackIdent, ($answerGradeFraction > 0)];
99			}
100			$this->answerlist = $answerlist;
101			}
102
103			public function onGenerateFeedbacks()
104			{
105			parent::onGenerateFeedbacks();
106			}
107
108			public function onGenerateResponseProcessing()
109			{
110			parent::onGenerateResponseProcessing();
111
112			/**
113			* General unconditional feedback must be added as a first respcondition
114			* without any condition and just displayfeedback (if exists).
115			*/
116			$qrespcondition = new CcAssesmentRespconditiontype();
117			$qrespcondition->setTitle('General feedback');
118			$this->qresprocessing->addRespcondition($qrespcondition);
119			$qrespcondition->enableContinue();
120			}
121			}
122

chamilo / chamilo-lms

Push — 1.11.x ( ef1e71...906f76 )

CcAssesmentQuestionFib::onGenerateAnswers() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like