CToolIntroExtension::addWhere() - Code Metrics - Inspection of "Merge" - chamilo/chamilo-lms - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( da60ad...b1f801 )

by Yannick

created 2021-10-02 21:30 UTC

CToolIntroExtension::addWhere() B

↳ Parent: CToolIntroExtension

Complexity

Conditions	7
Paths	18

Size

Total Lines	65
Code Lines	37

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
cc	7
eloc	37
nc	18
nop	2
dl	0
loc	65
rs	8.3946
c	1
b	0
f	1

How to fix Long Method

<?php

/* For licensing terms, see /license.txt */

declare(strict_types=1);

namespace Chamilo\CoreBundle\DataProvider\Extension;

use ApiPlatform\Core\Bridge\Doctrine\Orm\Extension\QueryCollectionExtensionInterface;
//use ApiPlatform\Core\Bridge\Doctrine\Orm\Extension\QueryItemExtensionInterface;
use ApiPlatform\Core\Bridge\Doctrine\Orm\Util\QueryNameGeneratorInterface;
use Chamilo\CoreBundle\Entity\ResourceLink;
use Chamilo\CourseBundle\Entity\CToolIntro;
use Doctrine\ORM\QueryBuilder;
use Symfony\Component\HttpFoundation\RequestStack;
use Symfony\Component\Security\Core\Exception\AccessDeniedException;
use Symfony\Component\Security\Core\Security;

final class CToolIntroExtension implements QueryCollectionExtensionInterface
{
    private Security $security;
    private RequestStack $requestStack;

    public function __construct(Security $security, RequestStack $request)
    {
        $this->security = $security;
        $this->requestStack = $request;
    }

    public function applyToCollection(QueryBuilder $queryBuilder, QueryNameGeneratorInterface $queryNameGenerator, string $resourceClass, string $operationName = null): void
    {
        $this->addWhere($queryBuilder, $resourceClass);
    }

    private function addWhere(QueryBuilder $queryBuilder, string $resourceClass): void
    {
        if (CToolIntro::class !== $resourceClass) {
            return;
        }

        /*if ($this->security->isGranted('ROLE_ADMIN')) {
            return;
        }*/

        if (null === $user = $this->security->getUser()) {
            throw new AccessDeniedException('Access Denied.');
        }

        $request = $this->requestStack->getCurrentRequest();

        $courseId = $request->query->get('cid');
        $sessionId = $request->query->get('sid');
        $groupId = $request->query->get('gid');

        $rootAlias = $queryBuilder->getRootAliases()[0];

        $queryBuilder
            ->innerJoin("$rootAlias.resourceNode", 'node')
            ->innerJoin('node.resourceLinks', 'links')
        ;

        // Do not show deleted resources.
        $queryBuilder
            ->andWhere('links.visibility != :visibilityDeleted')
            ->setParameter('visibilityDeleted', ResourceLink::VISIBILITY_DELETED)
        ;

        $allowDraft =
            $this->security->isGranted('ROLE_ADMIN') ||
            $this->security->isGranted('ROLE_CURRENT_COURSE_TEACHER')
        ;

        if (!$allowDraft) {
            $queryBuilder
                ->andWhere('links.visibility != :visibilityDraft')
                ->setParameter('visibilityDraft', ResourceLink::VISIBILITY_DRAFT)
            ;
        }

        $queryBuilder
            ->andWhere('links.course = :course')
            ->setParameter('course', $courseId)
        ;

        if (empty($sessionId)) {
            $queryBuilder->andWhere('links.session IS NULL');
        } else {
            $queryBuilder
                ->andWhere('links.session = :session')
                ->setParameter('session', $sessionId)
            ;
        }

        if (empty($groupId)) {
            $queryBuilder->andWhere('links.group IS NULL');
        } else {
            $queryBuilder
                ->andWhere('links.group = :group')
                ->setParameter('group', $groupId)
            ;
        }
    }
}


1			<?php
2
3			/* For licensing terms, see /license.txt */
4
5			declare(strict_types=1);
6
7			namespace Chamilo\CoreBundle\DataProvider\Extension;
8
9			use ApiPlatform\Core\Bridge\Doctrine\Orm\Extension\QueryCollectionExtensionInterface;
10			//use ApiPlatform\Core\Bridge\Doctrine\Orm\Extension\QueryItemExtensionInterface;
11			use ApiPlatform\Core\Bridge\Doctrine\Orm\Util\QueryNameGeneratorInterface;
12			use Chamilo\CoreBundle\Entity\ResourceLink;
13			use Chamilo\CourseBundle\Entity\CToolIntro;
14			use Doctrine\ORM\QueryBuilder;
15			use Symfony\Component\HttpFoundation\RequestStack;
16			use Symfony\Component\Security\Core\Exception\AccessDeniedException;
17			use Symfony\Component\Security\Core\Security;
18
19			final class CToolIntroExtension implements QueryCollectionExtensionInterface
20			{
21			private Security $security;
22			private RequestStack $requestStack;
23
24			public function __construct(Security $security, RequestStack $request)
25			{
26			$this->security = $security;
27			$this->requestStack = $request;
28			}
29
30			public function applyToCollection(QueryBuilder $queryBuilder, QueryNameGeneratorInterface $queryNameGenerator, string $resourceClass, string $operationName = null): void
31			{
32			$this->addWhere($queryBuilder, $resourceClass);
33			}
34
35			private function addWhere(QueryBuilder $queryBuilder, string $resourceClass): void
36			{
37			if (CToolIntro::class !== $resourceClass) {
38			return;
39			}
40
41			/*if ($this->security->isGranted('ROLE_ADMIN')) {
42			return;
43			}*/
44
45			if (null === $user = $this->security->getUser()) {
46			throw new AccessDeniedException('Access Denied.');
47			}
48
49			$request = $this->requestStack->getCurrentRequest();
50
51			$courseId = $request->query->get('cid');
52			$sessionId = $request->query->get('sid');
53			$groupId = $request->query->get('gid');
54
55			$rootAlias = $queryBuilder->getRootAliases()[0];
56
57			$queryBuilder
58			->innerJoin("$rootAlias.resourceNode", 'node')
59			->innerJoin('node.resourceLinks', 'links')
60			;
61
62			// Do not show deleted resources.
63			$queryBuilder
64			->andWhere('links.visibility != :visibilityDeleted')
65			->setParameter('visibilityDeleted', ResourceLink::VISIBILITY_DELETED)
66			;
67
68			$allowDraft =
69			$this->security->isGranted('ROLE_ADMIN') \|\|
70			$this->security->isGranted('ROLE_CURRENT_COURSE_TEACHER')
71			;
72
73			if (!$allowDraft) {
74			$queryBuilder
75			->andWhere('links.visibility != :visibilityDraft')
76			->setParameter('visibilityDraft', ResourceLink::VISIBILITY_DRAFT)
77			;
78			}
79
80			$queryBuilder
81			->andWhere('links.course = :course')
82			->setParameter('course', $courseId)
83			;
84
85			if (empty($sessionId)) {
86			$queryBuilder->andWhere('links.session IS NULL');
87			} else {
88			$queryBuilder
89			->andWhere('links.session = :session')
90			->setParameter('session', $sessionId)
91			;
92			}
93
94			if (empty($groupId)) {
95			$queryBuilder->andWhere('links.group IS NULL');
96			} else {
97			$queryBuilder
98			->andWhere('links.group = :group')
99			->setParameter('group', $groupId)
100			;
101			}
102			}
103			}
104

chamilo / chamilo-lms

Push — master ( da60ad...b1f801 )

CToolIntroExtension::addWhere() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like