View GitHub Repository chamilo-lms

Schedule Inspection
Subscribe

Code Duplication    Length = 6-6 lines in 2 locations

main/admin/add_users_to_group.php 2 locations

@@ 59-64 (lines=6) @@
56 
                AND relation_type IN (".GROUP_USER_PERMISSION_ADMIN.",".GROUP_USER_PERMISSION_READER.",".GROUP_USER_PERMISSION_PENDING_INVITATION.",".GROUP_USER_PERMISSION_MODERATOR.", ".GROUP_USER_PERMISSION_HRM.") ";
57 
        $res = Database::query($sql);
58 
        $user_ids = array();
59 
        if (Database::num_rows($res) > 0) {
60 
            while ($row = Database::fetch_row($res)) {
61 
                $user_ids[] = $row[0];
62 
            }
63 
            $without_user_id = " AND user.user_id NOT IN(".implode(',', $user_ids).") ";
64 
        }
65 

                                

                                                            

                                    66
                                    
                                    
        $condition_relation = " AND groups.relation_type = '$relation_type' ";

                                

                                                            

                                    67
                                    
                                    

                                

                                                                                

                                
                                
                                    @@ 304-309 (lines=6) @@
                                
                            


                                                            

                                    301
                                    
                                    
                AND relation_type IN (".GROUP_USER_PERMISSION_ADMIN.", ".GROUP_USER_PERMISSION_READER.",".GROUP_USER_PERMISSION_PENDING_INVITATION.",".GROUP_USER_PERMISSION_MODERATOR.", ".GROUP_USER_PERMISSION_HRM.") ";

                                

                                                            

                                    302
                                    
                                    
        $res = Database::query($sql);

                                

                                                            

                                    303
                                    
                                    
        $user_ids = array();

                                

                                                            

                                    304
                                    
                                    
        if (Database::num_rows($res) > 0) {

                                

                                                            

                                    305
                                    
                                    
            while ($row = Database::fetch_row($res)) {

                                

                                                            

                                    306
                                    
                                    
                $user_ids[] = $row[0];

                                

                                                            

                                    307
                                    
                                    
            }

                                

                                                            

                                    308
                                    
                                    
            $without_user_id = " AND user.user_id NOT IN(".implode(',', $user_ids).") ";

                                

                                                            

                                    309
                                    
                                    
        }

                                

                                                            

                                    310
                                    
                                    

                                

                                                            

                                    311
                                    
                                    
        $sql = "SELECT user_id, username, lastname, firstname FROM $tbl_user user

                                

                                                            

                                    312
                                    
                                    
                WHERE ".(api_sort_by_first_name() ? 'firstname' : 'lastname')." LIKE '$needle%' AND user_id<>'$user_anonymous' $without_user_id $order_clause ";