SurveyManager::save_question_options()

Complexity

Conditions	23
Paths	128

Size

Total Lines	116
Code Lines	80

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public static function save_question_options($form_content, $survey_data, $dataFromDatabase = [])
    {
        $course_id = api_get_course_int_id();
        $type = $form_content['type'];

        // A percentage question type has options 1 -> 100
        if ('percentage' === $type) {
            for ($i = 1; $i < 101; $i++) {
                $form_content['answers'][] = $i;
            }
        }

        if (is_numeric($survey_data['survey_share']) && 0 != $survey_data['survey_share']) {
            self::save_shared_question_options($form_content, $survey_data);

The method SurveyManager::save_shared_question_options() is not static, but was called statically.

        }

        // Table definition
        $table = Database::get_course_table(TABLE_SURVEY_QUESTION_OPTION);

        // We are editing a question so we first have to remove all the existing options from the database
        $optionsToDelete = [];
        if (isset($dataFromDatabase['answer_data'])) {
            foreach ($dataFromDatabase['answer_data'] as $data) {
                if ('other' === $data['data'] && 'multiplechoiceother' === $type) {
                    continue;
                }

                if (!in_array($data['iid'], $form_content['answersid'])) {
                    $optionsToDelete[] = $data['iid'];
                }
            }
        }

        if (!empty($optionsToDelete)) {
            foreach ($optionsToDelete as $iid) {
                $iid = (int) $iid;
                $sql = "DELETE FROM $table
			            WHERE
			                iid = $iid AND
			                c_id = $course_id AND
                            question_id = '".intval($form_content['question_id'])."'
                            ";
                Database::query($sql);
            }
        }

        $counter = 1;
        if (isset($form_content['answers']) && is_array($form_content['answers'])) {
            for ($i = 0; $i < count($form_content['answers']); $i++) {

It seems like you are calling the size function count() as part of the test condition. You might want to compute the size beforehand, and not on each iteration.

                $values = isset($form_content['values']) ? $form_content['values'][$i] : '';
                $answerId = 0;
                if (isset($form_content['answersid']) && isset($form_content['answersid'][$i])) {
                    $answerId = $form_content['answersid'][$i];
                }
                if (empty($answerId)) {
                    $params = [
                        'c_id' => $course_id,
                        'question_id' => $form_content['question_id'],
                        'survey_id' => $form_content['survey_id'],
                        'option_text' => $form_content['answers'][$i],
                        'value' => $values,
                        'sort' => $counter,
                    ];
                    $insertId = Database::insert($table, $params);
                    if ($insertId) {

The expression $insertId of type false|integer is loosely compared to true; this is ambiguous if the integer can be 0. You might want to explicitly use !== false instead.

                        $sql = "UPDATE $table
                                SET question_option_id = $insertId
                                WHERE iid = $insertId";
                        Database::query($sql);
                        $counter++;
                    }
                } else {
                    $params = [
                        'option_text' => $form_content['answers'][$i],
                        'value' => $values,
                        'sort' => $counter,
                    ];
                    Database::update($table, $params, ['iid = ?' => [$answerId]]);
                    $counter++;
                }
            }
        }

        if ('multiplechoiceother' === $type) {
            // First time creation
            if (empty($dataFromDatabase['answer_data'])) {
                $params = [
                    'c_id' => $course_id,
                    'question_id' => $form_content['question_id'],
                    'survey_id' => $form_content['survey_id'],
                    'option_text' => 'other',
                    'value' => 0,
                    'sort' => $counter,
                ];
                $insertId = Database::insert($table, $params);
                if ($insertId) {

The expression $insertId of type false|integer is loosely compared to true; this is ambiguous if the integer can be 0. You might want to explicitly use !== false instead.

                    $sql = "UPDATE $table
                            SET question_option_id = $insertId
                            WHERE iid = $insertId";
                    Database::query($sql);
                }
            } else {
                $params = [
                    'option_text' => 'other',
                    'value' => 0,
                    'sort' => $counter,
                ];
                Database::update(
                    $table,
                    $params,
                    [
                        'c_id = ? AND question_id = ? AND survey_id = ? AND option_text = ?' => [
                            $course_id,
                            $form_content['question_id'],
                            $form_content['survey_id'],
                            'other',
                        ],