chamilo /
chamilo-lms
| Conditions | 32 |
| Paths | 57 |
| Total Lines | 221 |
| Code Lines | 124 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 133 | function search_language_term( |
||
| 134 | $term, |
||
| 135 | $search_in_variable = true, |
||
| 136 | $search_in_english = true, |
||
| 137 | $search_in_parent = true, |
||
| 138 | $search_in_sub_language = true |
||
| 139 | ) { |
||
| 140 | //These the $_REQUEST['id'] and the $_REQUEST['sub_language_id'] variables are process in global.inc.php (LOAD LANGUAGE FILES SECTION) |
||
| 141 | /* |
||
| 142 | These 4 arrays are set in global.inc.php with the condition that will be load from sub_language.php or sub_language_ajax.inc.php |
||
| 143 | $english_language_array |
||
| 144 | $parent_language_array |
||
| 145 | $sub_language_array |
||
| 146 | $language_files_to_load |
||
| 147 | */ |
||
| 148 | global $language_files_to_load, $sub_language_array, $english_language_array, $parent_language_array; |
||
| 149 | $language_files_to_load_keys = array_flip($language_files_to_load); |
||
| 150 | $array_to_search = $parent_language_array; |
||
| 151 | $list_info = []; |
||
| 152 | $term = '/'.Security::remove_XSS(trim($_REQUEST['txt_search_word'])).'/i'; |
||
| 153 | //@todo optimize this foreach |
||
| 154 | foreach ($language_files_to_load as $lang_file) { |
||
| 155 | //searching in parent language of the sub language |
||
| 156 | if ($search_in_parent) { |
||
| 157 | $variables = $parent_language_array[$lang_file]; |
||
| 158 | foreach ($variables as $parent_name_variable => $parent_variable_value) { |
||
| 159 | //arrays are avoided |
||
| 160 | if (is_array($parent_variable_value)) { |
||
| 161 | continue; |
||
| 162 | } |
||
| 163 | $founded = false; |
||
| 164 | // searching the item in the parent tool |
||
| 165 | if (preg_match($term, $parent_variable_value) !== 0) { |
||
| 166 | $founded = true; |
||
| 167 | } |
||
| 168 | if ($founded) { |
||
| 169 | //loading variable from the english array |
||
| 170 | $sub_language_name_variable = isset($sub_language_array[$lang_file][$parent_name_variable]) |
||
| 171 | ? $sub_language_array[$lang_file][$parent_name_variable] |
||
| 172 | : ''; |
||
| 173 | //loading variable from the english array |
||
| 174 | $english_name_variable = $english_language_array[$lang_file][$parent_name_variable]; |
||
| 175 | |||
| 176 | //config buttons |
||
| 177 | /*if (strlen($english_name_variable)>1500) { |
||
| 178 | $size =20; |
||
| 179 | } else { |
||
| 180 | $size =4; |
||
| 181 | }*/ |
||
| 182 | |||
| 183 | $obj_text = Display::tag( |
||
| 184 | 'textarea', |
||
| 185 | $sub_language_name_variable, |
||
| 186 | [ |
||
| 187 | 'rows' => 10, |
||
| 188 | 'cols' => 40, |
||
| 189 | 'name' => 'txt|'.$parent_name_variable.'|'.$language_files_to_load_keys[$lang_file], |
||
| 190 | 'id' => 'txtid_'.$language_files_to_load_keys[$lang_file].'_'.$parent_name_variable, |
||
| 191 | ] |
||
| 192 | ); |
||
| 193 | $obj_button = Display::button( |
||
| 194 | 'btn|'.$parent_name_variable.'|'.$language_files_to_load_keys[$lang_file], |
||
| 195 | get_lang('Save'), |
||
| 196 | [ |
||
| 197 | 'class' => 'save btn btn-default btn-sm', |
||
| 198 | 'type' => 'button', |
||
| 199 | 'id' => 'btnid_'.$parent_name_variable, |
||
| 200 | ] |
||
| 201 | ); |
||
| 202 | |||
| 203 | $list_info[$parent_name_variable] = [ |
||
| 204 | $lang_file.'.inc.php', |
||
| 205 | $parent_name_variable, |
||
| 206 | htmlentities($english_name_variable), |
||
| 207 | htmlentities($parent_variable_value), |
||
| 208 | $obj_text, |
||
| 209 | $obj_button, |
||
| 210 | ]; |
||
| 211 | } |
||
| 212 | } |
||
| 213 | } |
||
| 214 | |||
| 215 | //search in english |
||
| 216 | if ($search_in_english || $search_in_variable) { |
||
| 217 | $variables = $english_language_array[$lang_file]; |
||
| 218 | foreach ($variables as $name_variable => $variable_value) { |
||
| 219 | if (isset($list_info[$name_variable])) { |
||
| 220 | continue; |
||
| 221 | } |
||
| 222 | |||
| 223 | if (is_array($variable_value)) { |
||
| 224 | continue; |
||
| 225 | } |
||
| 226 | |||
| 227 | if (is_array($variable_value)) { |
||
| 228 | echo $lang_file; |
||
| 229 | } |
||
| 230 | $founded = false; |
||
| 231 | if ($search_in_english && $search_in_variable) { |
||
| 232 | // searching the item in the parent tool |
||
| 233 | if (preg_match($term, $variable_value) !== 0 || preg_match($term, $name_variable) !== 0) { |
||
| 234 | $founded = true; |
||
| 235 | } |
||
| 236 | } else { |
||
| 237 | if ($search_in_english) { |
||
| 238 | if (preg_match($term, $variable_value) !== 0) { |
||
| 239 | $founded = true; |
||
| 240 | } |
||
| 241 | } else { |
||
| 242 | if (preg_match($term, $name_variable) !== 0) { |
||
| 243 | $founded = true; |
||
| 244 | } |
||
| 245 | } |
||
| 246 | } |
||
| 247 | |||
| 248 | if ($founded) { |
||
| 249 | //loading variable from the english array |
||
| 250 | $sub_language_name_variable = null; |
||
| 251 | if (isset($sub_language_array[$lang_file][$name_variable])) { |
||
| 252 | $sub_language_name_variable = $sub_language_array[$lang_file][$name_variable]; |
||
| 253 | } |
||
| 254 | $parent_variable_value = null; |
||
| 255 | if (isset($parent_language_array[$lang_file][$name_variable])) { |
||
| 256 | $parent_variable_value = $parent_language_array[$lang_file][$name_variable]; |
||
| 257 | } |
||
| 258 | //config buttons |
||
| 259 | $obj_text = Display::tag( |
||
| 260 | 'textarea', |
||
| 261 | $sub_language_name_variable, |
||
| 262 | [ |
||
| 263 | 'rows' => 10, |
||
| 264 | 'cols' => 40, |
||
| 265 | 'name' => 'txt|'.$name_variable.'|'.$language_files_to_load_keys[$lang_file], |
||
| 266 | 'id' => 'txtid_'.$language_files_to_load_keys[$lang_file].'_'.$name_variable, |
||
| 267 | ] |
||
| 268 | ); |
||
| 269 | $obj_button = Display::button( |
||
| 270 | 'btn|'.$name_variable.'|'.$language_files_to_load_keys[$lang_file], |
||
| 271 | get_lang('Save'), |
||
| 272 | [ |
||
| 273 | 'class' => 'save btn btn-default btn-sm', |
||
| 274 | 'type' => 'button', |
||
| 275 | 'id' => 'btnid_'.$name_variable, |
||
| 276 | ] |
||
| 277 | ); |
||
| 278 | |||
| 279 | //loading variable from the english array |
||
| 280 | $english_name_variable = $english_language_array[$lang_file][$name_variable]; |
||
| 281 | |||
| 282 | $list_info[] = [ |
||
| 283 | $lang_file.'.inc.php', |
||
| 284 | $name_variable, |
||
| 285 | htmlentities($english_name_variable), |
||
| 286 | htmlentities($parent_variable_value), |
||
| 287 | $obj_text, |
||
| 288 | $obj_button, |
||
| 289 | ]; |
||
| 290 | } |
||
| 291 | } |
||
| 292 | } |
||
| 293 | |||
| 294 | // Search in sub language |
||
| 295 | if ($search_in_sub_language) { |
||
| 296 | $variables = $sub_language_array[$lang_file]; |
||
| 297 | foreach ($variables as $name_variable => $variable_value) { |
||
| 298 | if (is_array($parent_variable_value)) { |
||
|
Comprehensibility
Best Practice
introduced
by
|
|||
| 299 | continue; |
||
| 300 | } |
||
| 301 | |||
| 302 | if (is_array($variable_value)) { |
||
| 303 | continue; |
||
| 304 | } |
||
| 305 | |||
| 306 | $founded = false; |
||
| 307 | // searching the item in the parent tool |
||
| 308 | if (preg_match($term, $variable_value) !== 0) { |
||
| 309 | $founded = true; |
||
| 310 | } |
||
| 311 | if ($founded) { |
||
| 312 | //loading variable from the english array |
||
| 313 | $sub_language_name_variable = isset($sub_language_array[$lang_file][$name_variable]) |
||
| 314 | ? $sub_language_array[$lang_file][$name_variable] |
||
| 315 | : ''; |
||
| 316 | $parent_variable_value = isset($parent_language_array[$lang_file][$name_variable]) |
||
| 317 | ? $parent_language_array[$lang_file][$name_variable] |
||
| 318 | : ''; |
||
| 319 | //config buttons |
||
| 320 | $obj_text = Display::tag( |
||
| 321 | 'textarea', |
||
| 322 | $sub_language_name_variable, |
||
| 323 | [ |
||
| 324 | 'rows' => 10, |
||
| 325 | 'cols' => 40, |
||
| 326 | 'name' => 'txt|'.$name_variable.'|'.$language_files_to_load_keys[$lang_file], |
||
| 327 | 'id' => 'txtid_'.$language_files_to_load_keys[$lang_file].'_'.$name_variable, |
||
| 328 | ] |
||
| 329 | ); |
||
| 330 | $obj_button = Display::button( |
||
| 331 | 'btn|'.$name_variable.'|'.$language_files_to_load_keys[$lang_file], |
||
| 332 | get_lang('Save'), |
||
| 333 | [ |
||
| 334 | 'class' => 'save btn btn-default btn-sm', |
||
| 335 | 'type' => 'button', |
||
| 336 | 'id' => 'btnid_'.$name_variable, |
||
| 337 | ] |
||
| 338 | ); |
||
| 339 | |||
| 340 | //loading variable from the english array |
||
| 341 | $english_name_variable = $english_language_array[$lang_file][$name_variable]; |
||
| 342 | $list_info[] = [$lang_file.'.inc.php', |
||
| 343 | $name_variable, |
||
| 344 | $english_name_variable, |
||
| 345 | $parent_variable_value, $obj_text, $obj_button, ]; |
||
| 346 | } |
||
| 347 | } |
||
| 348 | } |
||
| 349 | } |
||
| 350 | |||
| 351 | $list_info = array_unique_dimensional($list_info); |
||
| 352 | |||
| 353 | return $list_info; |
||
| 354 | } |
||
| 388 |
Loading history...