| Conditions | 23 |
| Paths | > 20000 |
| Total Lines | 375 |
| Code Lines | 307 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 283 | public function get_php_data() |
||
| 284 | { |
||
| 285 | $array = []; |
||
| 286 | |||
| 287 | // General Functions |
||
| 288 | |||
| 289 | $version = phpversion(); |
||
| 290 | $status = $version > REQUIRED_PHP_VERSION ? self::STATUS_OK : self::STATUS_ERROR; |
||
| 291 | $array[] = $this->build_setting( |
||
| 292 | $status, |
||
| 293 | '[PHP]', |
||
| 294 | 'phpversion()', |
||
| 295 | 'https://php.net/manual/en/function.phpversion.php', |
||
| 296 | phpversion(), |
||
| 297 | '>= '.REQUIRED_PHP_VERSION, |
||
| 298 | null, |
||
| 299 | get_lang('PHPVersionInfo') |
||
| 300 | ); |
||
| 301 | |||
| 302 | $setting = ini_get('output_buffering'); |
||
| 303 | $req_setting = 1; |
||
| 304 | $status = $setting >= $req_setting ? self::STATUS_OK : self::STATUS_ERROR; |
||
| 305 | $array[] = $this->build_setting( |
||
| 306 | $status, |
||
| 307 | '[INI]', |
||
| 308 | 'output_buffering', |
||
| 309 | 'https://php.net/manual/en/outcontrol.configuration.php#ini.output-buffering', |
||
| 310 | $setting, |
||
| 311 | $req_setting, |
||
| 312 | 'on_off', |
||
| 313 | get_lang('OutputBufferingInfo') |
||
| 314 | ); |
||
| 315 | |||
| 316 | $setting = ini_get('file_uploads'); |
||
| 317 | $req_setting = 1; |
||
| 318 | $status = $setting == $req_setting ? self::STATUS_OK : self::STATUS_ERROR; |
||
| 319 | $array[] = $this->build_setting( |
||
| 320 | $status, |
||
| 321 | '[INI]', |
||
| 322 | 'file_uploads', |
||
| 323 | 'https://php.net/manual/en/ini.core.php#ini.file-uploads', |
||
| 324 | $setting, |
||
| 325 | $req_setting, |
||
| 326 | 'on_off', |
||
| 327 | get_lang('FileUploadsInfo') |
||
| 328 | ); |
||
| 329 | |||
| 330 | $setting = ini_get('magic_quotes_runtime'); |
||
| 331 | $req_setting = 0; |
||
| 332 | $status = $setting == $req_setting ? self::STATUS_OK : self::STATUS_ERROR; |
||
| 333 | $array[] = $this->build_setting( |
||
| 334 | $status, |
||
| 335 | '[INI]', |
||
| 336 | 'magic_quotes_runtime', |
||
| 337 | 'https://php.net/manual/en/ini.core.php#ini.magic-quotes-runtime', |
||
| 338 | $setting, |
||
| 339 | $req_setting, |
||
| 340 | 'on_off', |
||
| 341 | get_lang('MagicQuotesRuntimeInfo') |
||
| 342 | ); |
||
| 343 | |||
| 344 | $setting = ini_get('safe_mode'); |
||
| 345 | $req_setting = 0; |
||
| 346 | $status = $setting == $req_setting ? self::STATUS_OK : self::STATUS_WARNING; |
||
| 347 | $array[] = $this->build_setting( |
||
| 348 | $status, |
||
| 349 | '[INI]', |
||
| 350 | 'safe_mode', |
||
| 351 | 'https://php.net/manual/en/ini.core.php#ini.safe-mode', |
||
| 352 | $setting, |
||
| 353 | $req_setting, |
||
| 354 | 'on_off', |
||
| 355 | get_lang('SafeModeInfo') |
||
| 356 | ); |
||
| 357 | |||
| 358 | $setting = ini_get('register_globals'); |
||
| 359 | $req_setting = 0; |
||
| 360 | $status = $setting == $req_setting ? self::STATUS_OK : self::STATUS_ERROR; |
||
| 361 | $array[] = $this->build_setting( |
||
| 362 | $status, |
||
| 363 | '[INI]', |
||
| 364 | 'register_globals', |
||
| 365 | 'https://php.net/manual/en/ini.core.php#ini.register-globals', |
||
| 366 | $setting, |
||
| 367 | $req_setting, |
||
| 368 | 'on_off', |
||
| 369 | get_lang('RegisterGlobalsInfo') |
||
| 370 | ); |
||
| 371 | |||
| 372 | $setting = ini_get('short_open_tag'); |
||
| 373 | $req_setting = 0; |
||
| 374 | $status = $setting == $req_setting ? self::STATUS_OK : self::STATUS_WARNING; |
||
| 375 | $array[] = $this->build_setting( |
||
| 376 | $status, |
||
| 377 | '[INI]', |
||
| 378 | 'short_open_tag', |
||
| 379 | 'https://php.net/manual/en/ini.core.php#ini.short-open-tag', |
||
| 380 | $setting, |
||
| 381 | $req_setting, |
||
| 382 | 'on_off', |
||
| 383 | get_lang('ShortOpenTagInfo') |
||
| 384 | ); |
||
| 385 | |||
| 386 | $setting = ini_get('magic_quotes_gpc'); |
||
| 387 | $req_setting = 0; |
||
| 388 | $status = $setting == $req_setting ? self::STATUS_OK : self::STATUS_ERROR; |
||
| 389 | $array[] = $this->build_setting( |
||
| 390 | $status, |
||
| 391 | '[INI]', |
||
| 392 | 'magic_quotes_gpc', |
||
| 393 | 'https://php.net/manual/en/ini.core.php#ini.magic_quotes_gpc', |
||
| 394 | $setting, |
||
| 395 | $req_setting, |
||
| 396 | 'on_off', |
||
| 397 | get_lang('MagicQuotesGpcInfo') |
||
| 398 | ); |
||
| 399 | |||
| 400 | $setting = ini_get('display_errors'); |
||
| 401 | $req_setting = 0; |
||
| 402 | $status = $setting == $req_setting ? self::STATUS_OK : self::STATUS_WARNING; |
||
| 403 | $array[] = $this->build_setting( |
||
| 404 | $status, |
||
| 405 | '[INI]', |
||
| 406 | 'display_errors', |
||
| 407 | 'https://php.net/manual/en/ini.core.php#ini.display_errors', |
||
| 408 | $setting, |
||
| 409 | $req_setting, |
||
| 410 | 'on_off', |
||
| 411 | get_lang('DisplayErrorsInfo') |
||
| 412 | ); |
||
| 413 | |||
| 414 | $setting = ini_get('default_charset'); |
||
| 415 | if ($setting == '') { |
||
| 416 | $setting = null; |
||
| 417 | } |
||
| 418 | $req_setting = 'UTF-8'; |
||
| 419 | $status = $setting == $req_setting ? self::STATUS_OK : self::STATUS_ERROR; |
||
| 420 | $array[] = $this->build_setting( |
||
| 421 | $status, |
||
| 422 | '[INI]', |
||
| 423 | 'default_charset', |
||
| 424 | 'https://php.net/manual/en/ini.core.php#ini.default-charset', |
||
| 425 | $setting, |
||
| 426 | $req_setting, |
||
| 427 | null, |
||
| 428 | get_lang('DefaultCharsetInfo') |
||
| 429 | ); |
||
| 430 | |||
| 431 | $setting = ini_get('max_execution_time'); |
||
| 432 | $req_setting = '300 ('.get_lang('Minimum').')'; |
||
| 433 | $status = $setting >= 300 ? self::STATUS_OK : self::STATUS_WARNING; |
||
| 434 | $array[] = $this->build_setting( |
||
| 435 | $status, |
||
| 436 | '[INI]', |
||
| 437 | 'max_execution_time', |
||
| 438 | 'https://php.net/manual/en/ini.core.php#ini.max-execution-time', |
||
| 439 | $setting, |
||
| 440 | $req_setting, |
||
| 441 | null, |
||
| 442 | get_lang('MaxExecutionTimeInfo') |
||
| 443 | ); |
||
| 444 | |||
| 445 | $setting = ini_get('max_input_time'); |
||
| 446 | $req_setting = '300 ('.get_lang('Minimum').')'; |
||
| 447 | $status = $setting >= 300 ? self::STATUS_OK : self::STATUS_WARNING; |
||
| 448 | $array[] = $this->build_setting( |
||
| 449 | $status, |
||
| 450 | '[INI]', |
||
| 451 | 'max_input_time', |
||
| 452 | 'https://php.net/manual/en/ini.core.php#ini.max-input-time', |
||
| 453 | $setting, |
||
| 454 | $req_setting, |
||
| 455 | null, |
||
| 456 | get_lang('MaxInputTimeInfo') |
||
| 457 | ); |
||
| 458 | |||
| 459 | $setting = ini_get('memory_limit'); |
||
| 460 | $req_setting = '>= '.REQUIRED_MIN_MEMORY_LIMIT.'M'; |
||
| 461 | $status = self::STATUS_ERROR; |
||
| 462 | if ((float) $setting >= REQUIRED_MIN_MEMORY_LIMIT) { |
||
| 463 | $status = self::STATUS_OK; |
||
| 464 | } |
||
| 465 | $array[] = $this->build_setting( |
||
| 466 | $status, |
||
| 467 | '[INI]', |
||
| 468 | 'memory_limit', |
||
| 469 | 'https://php.net/manual/en/ini.core.php#ini.memory-limit', |
||
| 470 | $setting, |
||
| 471 | $req_setting, |
||
| 472 | null, |
||
| 473 | get_lang('MemoryLimitInfo') |
||
| 474 | ); |
||
| 475 | |||
| 476 | $setting = ini_get('post_max_size'); |
||
| 477 | $req_setting = '>= '.REQUIRED_MIN_POST_MAX_SIZE.'M'; |
||
| 478 | $status = self::STATUS_ERROR; |
||
| 479 | if ((float) $setting >= REQUIRED_MIN_POST_MAX_SIZE) { |
||
| 480 | $status = self::STATUS_OK; |
||
| 481 | } |
||
| 482 | $array[] = $this->build_setting( |
||
| 483 | $status, |
||
| 484 | '[INI]', |
||
| 485 | 'post_max_size', |
||
| 486 | 'https://php.net/manual/en/ini.core.php#ini.post-max-size', |
||
| 487 | $setting, |
||
| 488 | $req_setting, |
||
| 489 | null, |
||
| 490 | get_lang('PostMaxSizeInfo') |
||
| 491 | ); |
||
| 492 | |||
| 493 | $setting = ini_get('upload_max_filesize'); |
||
| 494 | $req_setting = '>= '.REQUIRED_MIN_UPLOAD_MAX_FILESIZE.'M'; |
||
| 495 | $status = self::STATUS_ERROR; |
||
| 496 | if ((float) $setting >= REQUIRED_MIN_UPLOAD_MAX_FILESIZE) { |
||
| 497 | $status = self::STATUS_OK; |
||
| 498 | } |
||
| 499 | $array[] = $this->build_setting( |
||
| 500 | $status, |
||
| 501 | '[INI]', |
||
| 502 | 'upload_max_filesize', |
||
| 503 | 'https://php.net/manual/en/ini.core.php#ini.upload_max_filesize', |
||
| 504 | $setting, |
||
| 505 | $req_setting, |
||
| 506 | null, |
||
| 507 | get_lang('UploadMaxFilesizeInfo') |
||
| 508 | ); |
||
| 509 | |||
| 510 | $setting = ini_get('upload_tmp_dir'); |
||
| 511 | $status = self::STATUS_OK; |
||
| 512 | $array[] = $this->build_setting( |
||
| 513 | $status, |
||
| 514 | '[INI]', |
||
| 515 | 'upload_tmp_dir', |
||
| 516 | 'https://php.net/manual/en/ini.core.php#ini.upload_tmp_dir', |
||
| 517 | $setting, |
||
| 518 | '', |
||
| 519 | null, |
||
| 520 | get_lang('UploadTmpDirInfo') |
||
| 521 | ); |
||
| 522 | |||
| 523 | $setting = ini_get('variables_order'); |
||
| 524 | $req_setting = 'GPCS'; |
||
| 525 | $status = $setting == $req_setting ? self::STATUS_OK : self::STATUS_ERROR; |
||
| 526 | $array[] = $this->build_setting( |
||
| 527 | $status, |
||
| 528 | '[INI]', |
||
| 529 | 'variables_order', |
||
| 530 | 'https://php.net/manual/en/ini.core.php#ini.variables-order', |
||
| 531 | $setting, |
||
| 532 | $req_setting, |
||
| 533 | null, |
||
| 534 | get_lang('VariablesOrderInfo') |
||
| 535 | ); |
||
| 536 | |||
| 537 | $setting = ini_get('session.gc_maxlifetime'); |
||
| 538 | $req_setting = '4320'; |
||
| 539 | $status = $setting == $req_setting ? self::STATUS_OK : self::STATUS_WARNING; |
||
| 540 | $array[] = $this->build_setting( |
||
| 541 | $status, |
||
| 542 | '[SESSION]', |
||
| 543 | 'session.gc_maxlifetime', |
||
| 544 | 'https://php.net/manual/en/ini.core.php#session.gc-maxlifetime', |
||
| 545 | $setting, |
||
| 546 | $req_setting, |
||
| 547 | null, |
||
| 548 | get_lang('SessionGCMaxLifetimeInfo') |
||
| 549 | ); |
||
| 550 | |||
| 551 | if (api_check_browscap()) { |
||
| 552 | $setting = true; |
||
| 553 | } else { |
||
| 554 | $setting = false; |
||
| 555 | } |
||
| 556 | $req_setting = true; |
||
| 557 | $status = $setting == $req_setting ? self::STATUS_OK : self::STATUS_WARNING; |
||
| 558 | $array[] = $this->build_setting( |
||
| 559 | $status, |
||
| 560 | '[INI]', |
||
| 561 | 'browscap', |
||
| 562 | 'https://php.net/manual/en/misc.configuration.php#ini.browscap', |
||
| 563 | $setting, |
||
| 564 | $req_setting, |
||
| 565 | 'on_off', |
||
| 566 | get_lang('BrowscapInfo') |
||
| 567 | ); |
||
| 568 | |||
| 569 | // Extensions |
||
| 570 | $extensions = [ |
||
| 571 | 'gd' => [ |
||
| 572 | 'link' => 'https://php.net/gd', |
||
| 573 | 'expected' => 1, |
||
| 574 | 'comment' => get_lang('ExtensionMustBeLoaded'), |
||
| 575 | ], |
||
| 576 | 'pdo_mysql' => [ |
||
| 577 | 'link' => 'https://php.net/manual/en/ref.pdo-mysql.php', |
||
| 578 | 'expected' => 1, |
||
| 579 | 'comment' => get_lang('ExtensionMustBeLoaded'), |
||
| 580 | ], |
||
| 581 | 'pcre' => [ |
||
| 582 | 'link' => 'https://php.net/pcre', |
||
| 583 | 'expected' => 1, |
||
| 584 | 'comment' => get_lang('ExtensionMustBeLoaded'), |
||
| 585 | ], |
||
| 586 | 'session' => [ |
||
| 587 | 'link' => 'https://php.net/session', |
||
| 588 | 'expected' => 1, |
||
| 589 | 'comment' => get_lang('ExtensionMustBeLoaded'), |
||
| 590 | ], |
||
| 591 | 'standard' => [ |
||
| 592 | 'link' => 'https://php.net/spl', |
||
| 593 | 'expected' => 1, |
||
| 594 | 'comment' => get_lang('ExtensionMustBeLoaded'), |
||
| 595 | ], |
||
| 596 | 'zlib' => [ |
||
| 597 | 'link' => 'https://php.net/zlib', |
||
| 598 | 'expected' => 1, |
||
| 599 | 'comment' => get_lang('ExtensionMustBeLoaded'), |
||
| 600 | ], |
||
| 601 | 'curl' => [ |
||
| 602 | 'link' => 'https://php.net/curl', |
||
| 603 | 'expected' => 1, |
||
| 604 | 'comment' => get_lang('ExtensionMustBeLoaded'), |
||
| 605 | ], |
||
| 606 | 'fileinfo' => [ |
||
| 607 | 'link' => 'https://php.net/fileinfo', |
||
| 608 | 'expected' => 1, |
||
| 609 | 'comment' => get_lang('ExtensionMustBeLoaded'), |
||
| 610 | ], |
||
| 611 | 'xsl' => [ |
||
| 612 | 'link' => 'https://php.net/xsl', |
||
| 613 | 'expected' => 2, |
||
| 614 | 'comment' => get_lang('ExtensionShouldBeLoaded'), |
||
| 615 | ], |
||
| 616 | 'Zend OPcache' => [ |
||
| 617 | 'link' => 'https://php.net/opcache', |
||
| 618 | 'expected' => 2, |
||
| 619 | 'comment' => get_lang('ExtensionShouldBeLoaded'), |
||
| 620 | ], |
||
| 621 | 'apcu' => [ |
||
| 622 | 'link' => 'https://php.net/apcu', |
||
| 623 | 'expected' => 2, |
||
| 624 | 'comment' => get_lang('ExtensionShouldBeLoaded'), |
||
| 625 | ], |
||
| 626 | 'openssl' => [ //required only for DKIM e-mail signatures |
||
| 627 | 'link' => 'https://php.net/openssl', |
||
| 628 | 'expected' => 2, |
||
| 629 | 'comment' => get_lang('ExtensionShouldBeLoaded'), |
||
| 630 | ], |
||
| 631 | 'bcmath' => [ |
||
| 632 | 'link' => 'https://php.net/bcmath', |
||
| 633 | 'expected' => 2, |
||
| 634 | 'comment' => get_lang('ExtensionShouldBeLoaded'), |
||
| 635 | ], |
||
| 636 | ]; |
||
| 637 | |||
| 638 | foreach ($extensions as $extension => $data) { |
||
| 639 | $url = $data['link']; |
||
| 640 | $expected_value = $data['expected']; |
||
| 641 | $comment = $data['comment']; |
||
| 642 | |||
| 643 | $loaded = extension_loaded($extension); |
||
| 644 | $status = $loaded ? self::STATUS_OK : self::STATUS_ERROR; |
||
| 645 | $array[] = $this->build_setting( |
||
| 646 | $status, |
||
| 647 | '[EXTENSION]', |
||
| 648 | get_lang('LoadedExtension').': '.$extension, |
||
| 649 | $url, |
||
| 650 | $loaded, |
||
| 651 | $expected_value, |
||
| 652 | 'yes_no_optional', |
||
| 653 | $comment |
||
| 654 | ); |
||
| 655 | } |
||
| 656 | |||
| 657 | return $array; |
||
| 658 | } |
||
| 1020 |