Revoke - Code Metrics - Inspection of "Add /revoke route as per RFC 7009" - chadicus/slim-oauth2-routes - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Pull Request — master (#17)

by Earl Von

created 2016-04-26 08:29 UTC

Revoke A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	57
Duplicated Lines	100 %

Coupling/Cohesion

Components	0
Dependencies	2

Importance

Changes	2
Bugs	0	Features	1

Metric	Value
wmc	3
c	2
b	0
f	1
lcom	0
cbo	2
dl	57
loc	57
rs	10

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	5	5	1
A	__invoke()	8	8	1
A	register()	4	4	1

How to fix Duplicated Code

<?php


namespace Chadicus\Slim\OAuth2\Routes;

use Chadicus\Slim\OAuth2\Http\MessageBridge;
use OAuth2;
use Slim\Slim;

/**
 * The revoke class.
 * 
 */
class Revoke

{
    const ROUTE = '/revoke';

    /**
     * The slim framework application instance.
     *
     * @var Slim
     */
    private $slim;

    /**
     * The oauth2 server instance.
     *
     * @var OAuth2\Server
     */
    private $server;

    /**
     * Construct a new instance of Authorize.
     *
     * @param Slim          $slim   The slim framework application instance.
     * @param OAuth2\Server $server The oauth2 server imstance.
     */
    public function __construct(Slim $slim, OAuth2\Server $server)
    {
        $this->slim = $slim;
        $this->server = $server;
    }

    /**
     * Call this class as a function.
     *
     * @return void
     */
    public function __invoke()
    {
        $request = MessageBridge::newOAuth2Request($this->slim->request());
        MessageBridge::mapResponse(
            $this->server->handleRevokeRequest($request),
            $this->slim->response()
        );
    }

    /**
     * Register this route with the given Slim application and OAuth2 server
     *
     * @param Slim          $slim   The slim framework application instance.
     * @param OAuth2\Server $server The oauth2 server instance.
     *
     * @return void
     */
    public static function register(Slim $slim, OAuth2\Server $server)
    {
        $slim->post(self::ROUTE, new static($slim, $server))->name('revoke');
    }
}


1		<?php
		0 ignored issues – show Coding Style introduced 2016-04-26 08:04 UTC by Report Bug Copy Issue Report End of line character is invalid; expected "\n" but found "\r\n" Loading history...
2
3		namespace Chadicus\Slim\OAuth2\Routes;
4
5		use Chadicus\Slim\OAuth2\Http\MessageBridge;
6		use OAuth2;
7		use Slim\Slim;
8
9		/**
10		* The revoke class.
11		*
12		*/
13	View Code Duplication	class Revoke
		0 ignored issues – show Duplication introduced 2016-04-26 08:04 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
14		{
15		const ROUTE = '/revoke';
16
17		/**
18		* The slim framework application instance.
19		*
20		* @var Slim
21		*/
22		private $slim;
23
24		/**
25		* The oauth2 server instance.
26		*
27		* @var OAuth2\Server
28		*/
29		private $server;
30
31		/**
32		* Construct a new instance of Authorize.
33		*
34		* @param Slim $slim The slim framework application instance.
35		* @param OAuth2\Server $server The oauth2 server imstance.
36		*/
37		public function __construct(Slim $slim, OAuth2\Server $server)
38		{
39		$this->slim = $slim;
40		$this->server = $server;
41		}
42
43		/**
44		* Call this class as a function.
45		*
46		* @return void
47		*/
48		public function __invoke()
49		{
50		$request = MessageBridge::newOAuth2Request($this->slim->request());
51		MessageBridge::mapResponse(
52		$this->server->handleRevokeRequest($request),
53		$this->slim->response()
54		);
55		}
56
57		/**
58		* Register this route with the given Slim application and OAuth2 server
59		*
60		* @param Slim $slim The slim framework application instance.
61		* @param OAuth2\Server $server The oauth2 server instance.
62		*
63		* @return void
64		*/
65		public static function register(Slim $slim, OAuth2\Server $server)
66		{
67		$slim->post(self::ROUTE, new static($slim, $server))->name('revoke');
68		}
69		}
70

chadicus / slim-oauth2-routes

Pull Request — master (#17)

Revoke A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like