Issues (4)

Security Analysis    no request data  

This project does not seem to handle request data directly as such no vulnerable execution paths were found.

  Cross-Site Scripting
Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.
  File Exposure
File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.
  File Manipulation
File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.
  Object Injection
Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.
  Code Injection
Code Injection enables an attacker to execute arbitrary code on the server.
  Response Splitting
Response Splitting can be used to send arbitrary responses.
  File Inclusion
File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.
  Command Injection
Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.
  SQL Injection
SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.
  XPath Injection
XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.
  LDAP Injection
LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.
  Header Injection
  Other Vulnerability
This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.
  Regex Injection
Regex Injection enables an attacker to execute arbitrary code in your PHP process.
  XML Injection
XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.
  Variable Injection
Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.
Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Cache/ArrayCache.php (1 issue)

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

1
<?php
2
3
namespace Chadicus\Marvel\Api\Cache;
4
5
use Chadicus\Psr\SimpleCache;
6
use DateInterval;
7
use DateTime;
8
use DominionEnterprises\Util\Arrays;
9
use Psr\SimpleCache\CacheInterface;
10
11
/**
12
 * A PSR-16 implementation which stores data in an array.
13
 */
14
final class ArrayCache implements CacheInterface
15
{
16
    use SimpleCache\KeyValidatorTrait;
17
    use SimpleCache\TTLValidatorTrait;
18
19
    /**
20
     * @var array
21
     */
22
    private $cache = [];
23
24
    /**
25
     * Fetches a value from the cache.
26
     *
27
     * @param string $key     The unique key of this item in the cache.
28
     * @param mixed  $default Default value to return if the key does not exist.
29
     *
30
     * @return mixed The value of the item from the cache, or $default in case of cache miss.
31
     *
32
     * @throws InvalidArgumentException Thrown if the $key string is not a legal value.
33
     */
34
    public function get($key, $default = null)//@codingStandardsIgnoreLine Interface does not define type-hints or return
35
    {
36
        $this->validateKey($key);
37
        $cache = Arrays::get($this->cache, $key);
38
        if ($cache === null) {
39
            return $default;
40
        }
41
42
        if ($cache['expires'] >= time()) {
43
            return $cache['data'];
44
        }
45
46
        unset($this->cache[$key]);
47
        return $default;
48
    }
49
50
    /**
51
     * Obtains multiple cache items by their unique keys.
52
     *
53
     * @param iterable $keys    A list of keys that can obtained in a single operation.
54
     * @param mixed    $default Default value to return for keys that do not exist.
55
     *
56
     * @return array List of key => value pairs. Cache keys that do not exist or are stale will have $default as value.
57
     *
58
     * @throws InvalidArgumentException Thrown if the $key string is not a legal value.
59
     */
60
    public function getMultiple($keys, $default = null)//@codingStandardsIgnoreLine Interface does not define type-hints or return
61
    {
62
        $result = [];
63
        foreach ($keys as $key) {
64
            $result[$key] = $this->get($key, $default);
65
        }
66
67
        return $result;
0 ignored issues
show
Bug Best Practice introduced by
The return type of return $result; (array) is incompatible with the return type declared by the interface Psr\SimpleCache\CacheInterface::getMultiple of type Psr\SimpleCache\iterable.

If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design.

Let’s take a look at an example:

class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}

Our function my_function expects a Post object, and outputs the author of the post. The base class Post returns a simple string and outputting a simple string will work just fine. However, the child class BlogPost which is a sub-type of Post instead decided to return an object, and is therefore violating the SOLID principles. If a BlogPost were passed to my_function, PHP would not complain, but ultimately fail when executing the strtoupper call in its body.

Loading history...
68
    }
69
70
    /**
71
     * Persists data in the cache, uniquely referenced by a key with an optional expiration TTL time.
72
     *
73
     * @param string                    $key   The key of the item to store.
74
     * @param mixed                     $value The value of the item to store, must be serializable.
75
     * @param null|integer|DateInterval $ttl   Optional. The TTL value of this item. If no value is sent and
76
     *                                         the driver supports TTL then the library may set a default value
77
     *                                         for it or let the driver take care of that.
78
     *
79
     * @return boolean True on success and false on failure.
80
     *
81
     * @throws InvalidArgumentException Thrown if the $key string is not a legal value.
82
     */
83
    public function set($key, $value, $ttl = null)//@codingStandardsIgnoreLine Interface does not define type-hints or return
84
    {
85
        $this->validateKey($key);
86
        $this->validateTTL($ttl);
87
        $this->cache[$key] = ['data' => $value, 'expires' => $this->getExpiration($ttl)];
88
        return true;
89
    }
90
91
    /**
92
     * Persists a set of key => value pairs in the cache, with an optional TTL.
93
     *
94
     * @param iterable                  $values A list of key => value pairs for a multiple-set operation.
95
     * @param null|integer|DateInterval $ttl    Optional. The TTL value of this item. If no value is sent and
96
     *                                          the driver supports TTL then the library may set a default value
97
     *                                          for it or let the driver take care of that.
98
     *
99
     * @return boolean True on success and false on failure.
100
     *
101
     * @throws InvalidArgumentException Thrown if $values is neither an array nor a Traversable,
102
     *                                  or if any of the $values are not a legal value.
103
     */
104
    public function setMultiple($values, $ttl = null)//@codingStandardsIgnoreLine Interface does not define type-hints or return
105
    {
106
        $keys = array_keys($values);
107
        $this->validateKeys($keys);
108
        $this->getExpiration($ttl);
109
110
        foreach ($values as $key => $value) {
111
            $this->set($key, $value, $ttl);
112
        }
113
114
        return true;
115
    }
116
117
    /**
118
     * Delete an item from the cache by its unique key.
119
     *
120
     * @param string $key The unique cache key of the item to delete.
121
     *
122
     * @return boolean True if the item was successfully removed. False if there was an error.
123
     *
124
     * @throws InvalidArgumentException Thrown if the $key string is not a legal value.
125
     */
126
    public function delete($key)//@codingStandardsIgnoreLine Interface does not define type-hints or return
127
    {
128
        $this->validateKey($key);
129
        unset($this->cache[$key]);
130
        return true;
131
    }
132
133
    /**
134
     * Deletes multiple cache items in a single operation.
135
     *
136
     * @param iterable $keys A list of string-based keys to be deleted.
137
     *
138
     * @return boolean True if the items were successfully removed. False if there was an error.
139
     *
140
     * @throws InvalidArgumentException Thrown if $keys is neither an array nor a Traversable,
141
     *                                  or if any of the $keys are not a legal value.
142
     */
143
    public function deleteMultiple($keys)//@codingStandardsIgnoreLine Interface does not define type-hints
144
    {
145
        $this->validateKeys($keys);
146
        return Arrays::unsetAll($this->cache, $keys);
147
    }
148
149
    /**
150
     * Wipes clean the entire cache's keys.
151
     *
152
     * @return boolean True on success and false on failure.
153
     */
154
    public function clear()//@codingStandardsIgnoreLine Interface does not define type-hints or return
155
    {
156
        $this->cache = [];
157
        return true;
158
    }
159
160
    /**
161
     * Determines whether an item is present in the cache.
162
     *
163
     * NOTE: It is recommended that has() is only to be used for cache warming type purposes
164
     * and not to be used within your live applications operations for get/set, as this method
165
     * is subject to a race condition where your has() will return true and immediately after,
166
     * another script can remove it making the state of your app out of date.
167
     *
168
     * @param string $key The cache item key.
169
     *
170
     * @return boolean
171
     *
172
     * @throws InvalidArgumentException Thrown if the $key string is not a legal value.
173
     */
174
    public function has($key) //@codingStandardsIgnoreLine  Interface does not define type-hints
175
    {
176
        $this->validateKey($key);
177
        return $this->get($key, false) !== false;
178
    }
179
180
    /**
181
     * Converts the given time to live value to a DataTime instance;
182
     *
183
     * @param mixed $ttl The time-to-live value to validate.
184
     *
185
     * @return integer
186
     */
187
    private function getExpiration($ttl) : int
188
    {
189
        if ($ttl === null) {
190
            return PHP_INT_MAX;
191
        }
192
193
        if (is_int($ttl)) {
194
            return time() + $ttl;
195
        }
196
197
        return (new DateTime())->add($ttl)->getTimestamp();
198
    }
199
}
200