ErrorAdapter::send() - Code Metrics - Inspection of "Switch to Chadicus coding standard" - chadicus/marvel-api-client - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Pull Request — master (#25)

by Chad

created 2016-10-08 22:22 UTC

ErrorAdapter::send() A

↳ Parent: ErrorAdapter

Complexity

Conditions	1
Paths	1

Size

Total Lines	17
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	17
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	9
nc	1
nop	1

<?php
namespace Chadicus\Marvel\Api\Assets;

use Chadicus\Marvel\Api\Adapter\AdapterInterface;
use Chadicus\Marvel\Api\RequestInterface;
use Chadicus\Marvel\Api\Response;

/**
 * Adapter implementation that only returns empty responses.
 */
final class ErrorAdapter implements AdapterInterface
{
    /**
     * The last request given to this adapter.
     *
     * @var Request
     */
    private $request = null;

    /**
     * Returns an empty Response.
     *
     * @param RequestInterface $request The request to send.
     *
     * @return ResponseInterface
     */
    public function send(RequestInterface $request)
    {
        $this->request = $request;


        return new Response(
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
            404,
            [
                'code' => 'ResourceNotFound',
                'message' => "{$request->getUrl()} was not found",
            ],
            [
                'Response Code' => 404,
                'Response Status' => 'Not Found',
                'Content-Type' => 'application/json',
            ]
        );
    }

    /**
     * Return the last request given to this Adapter.
     *
     * @return RequestInterface
     */
    public function getRequest()
    {
        return $this->request;
    }
}


1			<?php
2			namespace Chadicus\Marvel\Api\Assets;
3
4			use Chadicus\Marvel\Api\Adapter\AdapterInterface;
5			use Chadicus\Marvel\Api\RequestInterface;
6			use Chadicus\Marvel\Api\Response;
7
8			/**
9			* Adapter implementation that only returns empty responses.
10			*/
11			final class ErrorAdapter implements AdapterInterface
12			{
13			/**
14			* The last request given to this adapter.
15			*
16			* @var Request
17			*/
18			private $request = null;
19
20			/**
21			* Returns an empty Response.
22			*
23			* @param RequestInterface $request The request to send.
24			*
25			* @return ResponseInterface
26			*/
27			public function send(RequestInterface $request)
28			{
29			$this->request = $request;
			0 ignored issues – show Documentation Bug introduced 2016-10-08 22:25 UTC by Report Bug Copy Issue Report It seems like `$request` of type `object<Chadicus\Marvel\Api\RequestInterface>` is incompatible with the declared type `object<Chadicus\Marvel\Api\Assets\Request>` of property `$request`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
30
31			return new Response(
			0 ignored issues – show Bug Best Practice introduced 2016-10-08 22:25 UTC by Report Bug Copy Issue Report The return type of `return new \Chadicus\Mar...> 'application/json'));` (`Chadicus\Marvel\Api\Response`) is incompatible with the return type declared by the interface `Chadicus\Marvel\Api\Adapter\AdapterInterface::send` of type `Chadicus\Marvel\Api\Adapter\ResponseInterface`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
32			404,
33			[
34			'code' => 'ResourceNotFound',
35			'message' => "{$request->getUrl()} was not found",
36			],
37			[
38			'Response Code' => 404,
39			'Response Status' => 'Not Found',
40			'Content-Type' => 'application/json',
41			]
42			);
43			}
44
45			/**
46			* Return the last request given to this Adapter.
47			*
48			* @return RequestInterface
49			*/
50			public function getRequest()
51			{
52			return $this->request;
53			}
54			}
55

chadicus / marvel-api-client

Pull Request — master (#25)

ErrorAdapter::send() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like