Issues in Middleware.php (master) - Issues in master - chadicus/hmac-middleware-php - Measure and Improve Code Quality continuously with Scrutinizer

Issues (6)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Middleware.php (2 issues)

Labels

Severity

Major 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Chadicus\Psr\Http\ServerMiddleware;

use ArrayAccess;
use Psr\Http\Message\ServerRequestInterface;
use Psr\Http\Message\ResponseInterface;

/**
 * PSR-7 Middleware for extracting and validating request via hmac cryptography.
 */
final class Middleware
{
    /**
     * Obtains private keys.
     *
     * @var KeyProviderInterface
     */
    private $keyProvider;

    /**
     * Extracts the token information from the incoming request.
     *
     * @var TokenExtractorInterface
     */
    private $tokenExtractor;

    /**
     * Validates the extracted token.
     *
     * @var TokenValidatorInterface
     */
    private $tokenValidator;

    /**
     * Container in which to store the private key.
     *
     * @var ArrayAccess
     */
    private $container;

    /**
     * Construct a new instance of this middleware.
     *
     * @param KeyProviderInterface    $provider  Obtains private keys.
     * @param TokenExtractorInterface $extractor Extracts the token information from the incoming request.
     * @param TokenValidatorInterface $validator Validates the extracted token.
     * @param ArrayAccess             $container Container in which to store the private key.
     */
    public function __construct(
        KeyProviderInterface $provider,
        TokenExtractorInterface $extractor,
        TokenValidatorInterface $validator,
        ArrayAccess $container
    ) {
        $this->keyProvider = $provider;
        $this->tokenExtractor = $extractor;
        $this->tokenValidator = $validator;
        $this->tokenContainer = $container;

    }

    /**
     * Execute this middleware.
     *
     * @param  ServerRequestInterface $request  The incoming PSR7 request.
     * @param  ResponseInterface      $response The outgoing PSR7 response.
     * @param  callable               $next     The next middleware.
     *
     * @return ResponseInterface
     */
    public function __invoke(ServerRequestInterface $request, ResponseInterface $response, callable $next)
    {
        try {
            $token = $this->tokenExtractor->extract($request);
            $privateKey = $this->keyProvider->findPrivateKey($token->getPublicKey());
            $this->tokenValidator->validate($privateKey, $token, $request);

            //Authenticated! Set the private key and call the next middleware
            $this->tokenContainer['privateKey'] = $privateKey;


            return $next($request, $response);
        } catch (AuthenticationException $e) {
            return $response->withStatus($e->getStatusCode(), $e->getReasonPhrase());
        }
    }
}


1			<?php
2
3			namespace Chadicus\Psr\Http\ServerMiddleware;
4
5			use ArrayAccess;
6			use Psr\Http\Message\ServerRequestInterface;
7			use Psr\Http\Message\ResponseInterface;
8
9			/**
10			* PSR-7 Middleware for extracting and validating request via hmac cryptography.
11			*/
12			final class Middleware
13			{
14			/**
15			* Obtains private keys.
16			*
17			* @var KeyProviderInterface
18			*/
19			private $keyProvider;
20
21			/**
22			* Extracts the token information from the incoming request.
23			*
24			* @var TokenExtractorInterface
25			*/
26			private $tokenExtractor;
27
28			/**
29			* Validates the extracted token.
30			*
31			* @var TokenValidatorInterface
32			*/
33			private $tokenValidator;
34
35			/**
36			* Container in which to store the private key.
37			*
38			* @var ArrayAccess
39			*/
40			private $container;
41
42			/**
43			* Construct a new instance of this middleware.
44			*
45			* @param KeyProviderInterface $provider Obtains private keys.
46			* @param TokenExtractorInterface $extractor Extracts the token information from the incoming request.
47			* @param TokenValidatorInterface $validator Validates the extracted token.
48			* @param ArrayAccess $container Container in which to store the private key.
49			*/
50			public function __construct(
51			KeyProviderInterface $provider,
52			TokenExtractorInterface $extractor,
53			TokenValidatorInterface $validator,
54			ArrayAccess $container
55			) {
56			$this->keyProvider = $provider;
57			$this->tokenExtractor = $extractor;
58			$this->tokenValidator = $validator;
59			$this->tokenContainer = $container;
			0 ignored issues – show Bug introduced 2017-09-20 00:28 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `tokenContainer` does not seem to exist. Did you mean `container`? An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
60			}
61
62			/**
63			* Execute this middleware.
64			*
65			* @param ServerRequestInterface $request The incoming PSR7 request.
66			* @param ResponseInterface $response The outgoing PSR7 response.
67			* @param callable $next The next middleware.
68			*
69			* @return ResponseInterface
70			*/
71			public function __invoke(ServerRequestInterface $request, ResponseInterface $response, callable $next)
72			{
73			try {
74			$token = $this->tokenExtractor->extract($request);
75			$privateKey = $this->keyProvider->findPrivateKey($token->getPublicKey());
76			$this->tokenValidator->validate($privateKey, $token, $request);
77
78			//Authenticated! Set the private key and call the next middleware
79			$this->tokenContainer['privateKey'] = $privateKey;
			0 ignored issues – show Bug introduced 2017-09-20 00:28 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `tokenContainer` does not seem to exist. Did you mean `container`? An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
80
81			return $next($request, $response);
82			} catch (AuthenticationException $e) {
83			return $response->withStatus($e->getStatusCode(), $e->getReasonPhrase());
84			}
85			}
86			}
87

chadicus / hmac-middleware-php

Issues (6)

Security Analysis no request data

src/Middleware.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like